Few more comments...
+/// If an address comes from an existing module, then it will be resolved
+/// into an offset from its containing section in that module. That way it
+/// can refer to the same logical location as the module that holds it even
Probably my error, but "location as the module"
jingham added a comment.
Oh, yeah, and note the other branch of the if holds the thread list mutex the
whole time. So you'll need to change that to get the list of threads, then
drop the mutex & iterate over them or you'll get into the same problem if
somebody does:
(lldb) thread backtrace 1
jingham added a comment.
Another even safer way to do this is to take the thread list, turn it into a
vector of TID's, then iterate over the TID's looking them up one at a time as
you go. That way you don't have to worry about your ThreadSP going stale. You
could even change HandleOneThread t
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Yeah, I'm beginning to wonder whether we're doing ourselves a favor by putting
off computing the ObjC runtime symbols till some time that's bound to be more
inconvenient than right
Author: jingham
Date: Thu Mar 10 19:57:45 2016
New Revision: 263183
URL: http://llvm.org/viewvc/llvm-project?rev=263183&view=rev
Log:
Fix SBDebugger.GetOutputFileHandle() on OS X.
The swig typemaps had some magic for output File *'s on OS X that made:
SBDebugger.GetOutputFileHandle()
actually
fjricci updated this revision to Diff 50387.
fjricci added a comment.
Remove duplication of index variable
http://reviews.llvm.org/D18075
Files:
source/Commands/CommandObjectThread.cpp
Index: source/Commands/CommandObjectThread.cpp
fjricci created this revision.
fjricci added reviewers: jingham, clayborg, andrew.w.kaylor.
fjricci added subscribers: lldb-commits, sas.
The gdb-remote async thread cannot modify thread state while the main thread
holds a lock on the state. Don't use locking thread iteration for bt all.
Specific
jingham added a comment.
More precisely, the "Public running lock..." part of the comment.
http://reviews.llvm.org/D17635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I marked a comment left over from a previous draft of the patch that isn't
needed. Other than that, this looks fine.
Comment at: source/Target/Process.cpp:3561-3562
@@ +35
Honsik updated this revision to Diff 50373.
Honsik added a comment.
Sorry for the delay, I have been on holiday.
I have modified the patch as jingham requested. The public run lock is reset
back on error in both Resume and ResumeSynchronous methods.
http://reviews.llvm.org/D17635
Files:
pa
Author: eugenezelenko
Date: Thu Mar 10 17:57:12 2016
New Revision: 263174
URL: http://llvm.org/viewvc/llvm-project?rev=263174&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core;
other minor fixes.
Modified:
lldb/trunk/source/Core/ConstString.cpp
lldb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263166: Fixed ValueObject::GetExpressionPath() for paths
including anonymous… (authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D18005?vs=50192&id=50353#toc
Repository:
rL LLVM
h
Author: mamai
Date: Thu Mar 10 16:10:59 2016
New Revision: 263166
URL: http://llvm.org/viewvc/llvm-project?rev=263166&view=rev
Log:
Fixed ValueObject::GetExpressionPath() for paths including anonymous
struct/union
When the parent of an expression is anonymous, skip adding '.' or '->' before
the
clayborg closed this revision.
clayborg added a comment.
Submitted with SVN revision 263161.
http://reviews.llvm.org/D18057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Thu Mar 10 14:49:32 2016
New Revision: 263161
URL: http://llvm.org/viewvc/llvm-project?rev=263161&view=rev
Log:
Fixed the python interpreter so that it correctly inherits the top IOHandler's
files instead of always using stdin/out/err.
Removed lldb_private::File::Duplicate
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good, and it doesn't break anything on Windows. Glad we got rid of
copying and duplication, that always seemed like unnecessary complexity.
http://reviews.llvm.org/D18057
Hello everyone,
Below are some buildbot numbers for the last week of 2/28/2016 - 3/05/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Hello everyone,
Below are some buildbot numbers for the week of 2/21/2016 - 2/27/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername |
clayborg created this revision.
clayborg added a reviewer: zturner.
clayborg added a subscriber: lldb-commits.
After the Python 3 fixes the interactive python interpreter stopped working in
Xcode. The issue was the python interpreter tried to adopt the top IOHandler
file handles, but it failed d
Thanks for your patience and feedback! Attached is the updated file.
John
On Wed, Mar 9, 2016 at 3:10 PM, Jim Ingham wrote:
> The relation between section offsets and files is stronger than you are
> stating here. You say:
>
> +/// Represents an address. An address may refer to code or data
mamai added a comment.
Could someone commit it for me please? I don't have commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D18050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mamai created this revision.
mamai added a reviewer: clayborg.
mamai added a subscriber: lldb-commits.
mamai set the repository for this revision to rL LLVM.
Use the same method to find the cache line as in Read().
Repository:
rL LLVM
http://reviews.llvm.org/D18050
Files:
packages/Python/ll
Author: aidandodds
Date: Thu Mar 10 11:50:01 2016
New Revision: 263134
URL: http://llvm.org/viewvc/llvm-project?rev=263134&view=rev
Log:
[Renderscript] Add stack argument reading code for Mipsel 3
Fix a problem raised with the previous patches being applied in the wrong order.
Committed on behal
Author: aidandodds
Date: Thu Mar 10 11:37:02 2016
New Revision: 263131
URL: http://llvm.org/viewvc/llvm-project?rev=263131&view=rev
Log:
[Renderscript] Add stack argument reading code for Mipsel 2
This commit implements the reading of stack spilled function arguments for
little endian MIPS targe
Author: aidandodds
Date: Thu Mar 10 11:27:41 2016
New Revision: 263130
URL: http://llvm.org/viewvc/llvm-project?rev=263130&view=rev
Log:
[Renderscript] Add stack argument reading code for Mipsel
This commit implements the reading of stack spilled function arguments for
little endian MIPS targets
Author: aidandodds
Date: Thu Mar 10 11:23:33 2016
New Revision: 263129
URL: http://llvm.org/viewvc/llvm-project?rev=263129&view=rev
Log:
[Renderscript] Explicitly set the language to evaluate allocations
Currently it is not specified, and since allocations are usually
requested once we hit a rend
tfiala added a comment.
Can this close?
http://reviews.llvm.org/D16615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This happened, right? Can we close?
http://reviews.llvm.org/D16872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: amccarth
Date: Thu Mar 10 09:41:11 2016
New Revision: 263122
URL: http://llvm.org/viewvc/llvm-project?rev=263122&view=rev
Log:
Eliminate the TestStarted-XXX and TestFinished-XXX files from check-lldb runs.
Nobody seems to know what purpose these files serve, yet they were accumulating
by
labath added a comment.
Comment at: unittests/Host/FileSpecTest.cpp:57
@@ +56,3 @@
+// We get "F:/bar" instead.
+// EXPECT_STREQ("F:\\bar",
fs_windows_trailing_slash.GetDirectory().GetCString());
+EXPECT_STREQ(".", fs_windows_trailing_slash.GetFilename().GetCString
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
This fixes a couple of corner cases in FileSpec, related to AppendPathComponent
and
handling of root directory (/) file spec. I add a bunch of unit tests for the
new behavior.
Summa
Author: ewancrawford
Date: Thu Mar 10 06:38:55 2016
New Revision: 263107
URL: http://llvm.org/viewvc/llvm-project?rev=263107&view=rev
Log:
Revert "Track expression language from one place in ClangExpressionParser"
r263099 seems to have broken some OSX tests
Modified:
lldb/trunk/source/Plugin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263099: Track expression language from one place in
ClangExpressionParser (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D17719?vs=49531&id=50253#toc
Repository:
rL LLVM
Author: ewancrawford
Date: Thu Mar 10 04:31:08 2016
New Revision: 263099
URL: http://llvm.org/viewvc/llvm-project?rev=263099&view=rev
Log:
Track expression language from one place in ClangExpressionParser
The current expression language is currently tracked in a few places within the
ClangExpres
labath accepted this revision.
labath added a comment.
In http://reviews.llvm.org/D18017#371362, @zturner wrote:
> lgtm, Pavel does Android build infrastructure need these files for some
> reason?
Nope, let's get rid of them.
http://reviews.llvm.org/D18017
37 matches
Mail list logo