Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

> On Mar 3, 2016, at 12:33 PM, Jim Ingham wrote: > > >> On Mar 2, 2016, at 10:18 AM, Greg Clayton wrote: >> >> So this is nice that you cleaned up this one place where we can use LLVM's >> option parsing stuff, but it now makes the driver inconsistent with the rest >> of LLDB. It also make

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

> On Mar 2, 2016, at 10:18 AM, Greg Clayton wrote: > > So this is nice that you cleaned up this one place where we can use LLVM's > option parsing stuff, but it now makes the driver inconsistent with the rest > of LLDB. It also makes it so you have to link some LLVM .a files into the > lldb c

Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

jingham added a comment. At some point we should deal with the loss of information when we resolve re-mapped paths. For instance, here I set a breakpoint by the moved source location's full path, and that gets remapped to the build location. That's lovely since it makes the breakpoint take, b

Re: [Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

jingham added a subscriber: jingham. jingham added a comment. This looks fine to me. http://reviews.llvm.org/D17848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

clayborg added a comment. Feel free to check this in a branch if you want to keep it around for when you later work on this so you don't lose the changes? http://reviews.llvm.org/D17724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

ted created this revision. ted added reviewers: spyffe, zturner, amccarth. ted added a subscriber: lldb-commits. From Adrian McCarthy: "Running ninja check-lldb now has one crash in a Python process, due to deferencing a null pointer in IRExecutionUnit.cpp: candidate_sc.symbol is null, which l

[Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath created this revision. labath added a reviewer: spyffe. labath added subscribers: lldb-commits, paulherman, sivachandra. referencing a user-defined operator new was triggering an assert in clang because we were registering the function name as string "operator new", instead of using the s

[Lldb-commits] [lldb] r262622 - Revert "Fetch remote log files from LLGS tests"

Author: labath Date: Thu Mar 3 09:19:14 2016 New Revision: 262622 URL: http://llvm.org/viewvc/llvm-project?rev=262622&view=rev Log: Revert "Fetch remote log files from LLGS tests" Even after the last fixup, there still seems to be one failure left. Revert until I figure out what is going on. M

[Lldb-commits] [PATCH] D17848: Add reverse file remapping for breakpoint set

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Add reverse file remapping for breakpoint set LLDB can remap a source file to a new directory based on the "target.sorce-map" to handle the usecase when the source code

[Lldb-commits] [PATCH] D17847: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

labath created this revision. labath added a reviewer: nlewycky. labath added subscribers: cfe-commits, lldb-commits. While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which expect to be called with a valid source location. This causes an assertion failure if the locatio

[Lldb-commits] [lldb] r262602 - Fix OSX breakage caused by r262597

Author: labath Date: Thu Mar 3 04:39:24 2016 New Revision: 262602 URL: http://llvm.org/viewvc/llvm-project?rev=262602&view=rev Log: Fix OSX breakage caused by r262597 Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Modified: lldb/trunk/packages/

Re: [Lldb-commits] [PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

labath added a subscriber: lldb-commits. labath added a comment. I noticed this while debugging an importing issue in LLDB. I am not sure if I have selected the right reviewer, and also how/if to test this... http://reviews.llvm.org/D17845 ___ lld

Re: [Lldb-commits] [PATCH] D17798: Fetch remote log files from LLGS tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL262597: Fetch remote log files from LLGS tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D17798?vs=49593&id=49720#toc Repository: rL LLVM http://reviews.llvm.org/D17798

[Lldb-commits] [lldb] r262597 - Fetch remote log files from LLGS tests

Author: labath Date: Thu Mar 3 03:02:52 2016 New Revision: 262597 URL: http://llvm.org/viewvc/llvm-project?rev=262597&view=rev Log: Fetch remote log files from LLGS tests Summary: this enables download of remote log files for llgs and debugserver tests (previously we were just passing the host

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

labath abandoned this revision. labath added a comment. Ok, fair enough. I'll see if I can do something like that in the future, but I'm going to abandon this for the moment. http://reviews.llvm.org/D17724 ___ lldb-commits mailing list lldb-commits