bhushan closed this revision.
bhushan added a comment.
This was committed on 6th Oct 15 by http://reviews.llvm.org/rL249381 ,closing
it now.
Repository:
rL LLVM
http://reviews.llvm.org/D13282
___
lldb-commits mailing list
lldb-commits@lists.llvm
tfiala added a comment.
Sorry, late to the party. All the same, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256331: [LLDB] Fix Read/Write memory to be compatible with
both endians (authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D15738?vs=43520&id=43522#toc
Repository:
rL LLVM
Author: mohit.bhakkad
Date: Wed Dec 23 06:34:58 2015
New Revision: 256331
URL: http://llvm.org/viewvc/llvm-project?rev=256331&view=rev
Log:
[LLDB] Fix Read/Write memory to be compatible with both endians
Reviewers: tberghammer.
Subscribers: jaydeep, bhushan, sagar, nitesh.jain,lldb-commits.
Diff
tberghammer added a comment.
LGTM
I can't accept it on the UI because of some bug, but you can commit it without
waiting for Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D15738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
mohit.bhakkad updated this revision to Diff 43520.
mohit.bhakkad added a comment.
Addressed comment.
Repository:
rL LLVM
http://reviews.llvm.org/D15738
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp
===
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2549-2550
@@ -2548,6 +2548,4 @@
