Re: [Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

Yea that's probably what I was thinking of. Can make a similar variable for lldb_test_root as you've done. Feel free to put other suite-wide globals in there in the future as needed, it's a useful way to allow everything in the package access to a common set of stuff. On Sun, Dec 6, 2015 at 10:2

Re: [Lldb-commits] [PATCH] D14937: swig_bot remote path preliminary implementation

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D14937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Basic idea looks fine. (I saw you put this in not long after, but I'm finally getting to look at the actual review). I'm not sure if you're intending to cover all the use cases of the generat

Re: [Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

I do see the lldbsuite.lldb_root var but didn't see an lldbsuite.lldb_test_root var. I added one and switched over to it here: r254894 Let me know if that covers what you were thinking. I'm happy to have a place to stick the var :-) I'm thinking I may have other places that construct that, I'l

[Lldb-commits] [lldb] r254894 - Added lldbsuite.lldb_test_root, switched formatter to use it.

Author: tfiala Date: Mon Dec 7 00:19:48 2015 New Revision: 254894 URL: http://llvm.org/viewvc/llvm-project?rev=254894&view=rev Log: Added lldbsuite.lldb_test_root, switched formatter to use it. Modified: lldb/trunk/packages/Python/lldbsuite/__init__.py lldb/trunk/packages/Python/lldbsuit

Re: [Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

Oh I'll have a look, thanks. On Sun, Dec 6, 2015 at 7:51 PM, Zachary Turner wrote: > > > On Sun, Dec 6, 2015 at 7:13 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfiala >> Date: Sun Dec 6 21:10:02 2015 >> New Revision: 254890 >> >> URL: http://llvm.org/vie

[Lldb-commits] [lldb] r254892 - [LLDB][MIPS] Marking some expected failures

Author: mohit.bhakkad Date: Sun Dec 6 23:47:35 2015 New Revision: 254892 URL: http://llvm.org/viewvc/llvm-project?rev=254892&view=rev Log: [LLDB][MIPS] Marking some expected failures Reviewers: clayborg, zturner. Subscribers: jaydeep, bhushan, sagar, nitesh.jain, tberghammer,lldb-commits. Differ

Re: [Lldb-commits] [PATCH] D14944: [LLDB][MIPS] Marking some expected failures

This revision was automatically updated to reflect the committed changes. Closed by commit rL254892: [LLDB][MIPS] Marking some expected failures (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D14944?vs=41843&id=42027#toc Repository: rL LLVM http://reviews.llvm

[Lldb-commits] [lldb] r254891 - Moved total test count and rerun count into summary counts.

Author: tfiala Date: Sun Dec 6 22:55:07 2015 New Revision: 254891 URL: http://llvm.org/viewvc/llvm-project?rev=254891&view=rev Log: Moved total test count and rerun count into summary counts. Modified: lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py Modified: lldb/trunk

Re: [Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

On Sun, Dec 6, 2015 at 7:13 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Sun Dec 6 21:10:02 2015 > New Revision: 254890 > > URL: http://llvm.org/viewvc/llvm-project?rev=254890&view=rev > Log: > Move test summary counts to end; simplify issue detail

[Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

Author: tfiala Date: Sun Dec 6 21:10:02 2015 New Revision: 254890 URL: http://llvm.org/viewvc/llvm-project?rev=254890&view=rev Log: Move test summary counts to end; simplify issue detail line Test summary counts now show at the end, with issue details above. Issue details now print "ISSUE_TYPE:

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

krytarowski updated this revision to Diff 42014. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py === --- packages/Python/lld

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

joerg added a comment. Two small cleanups, otherwise LGTM. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1328 @@ -1313,3 +1327,3 @@ cls.platformContext = _PlatformContext('DYLD_LIBRARY_PATH', 'lib', 'dylib') -elif getPlatform() == "linux" or getPla

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

krytarowski updated the summary for this revision. krytarowski updated this revision to Diff 42013. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

emaste added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:832-834 @@ -828,2 +831,5 @@ +def expectedFlakeyNetBSD(bugnumber=None, compilers=None): +return expectedFlakeyOS(['netbsd'], bugnumber, compilers) + def expectedFlakeyLinux(bugnumber=None, c

Re: [Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. We could probably replace these freebsd/linux/netbsd cases with a routine that strips trailing digits. Repository: rL LLVM http://reviews.llvm.org/D15263 ___