Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. Kamil, the situation is a little complicated, please read the following threads for some context: http://lists.llvm.org/pipermail/lldb-dev/2015-November/008802.html http://lists.llvm.org/pipermail/lldb-dev/2015-November/008829.html http://lists.llvm.org/pipermail/lldb-de

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. I would reject this patch. http://reviews.llvm.org/D14790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. Sure, I'm just giving general feedback. From a user perspective I want to get yes/no information whether I need swig or not, if so what version. If we allow Python, I don't see any reason to not allowing swig. if some version gives you problems (license, bad code g

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. > For now please leave an option that end user to disable Python. Otherwise > erasing it will be done downstream without benefit for the project. Nobody is talking about removing the option to disable python. The static binding binding option is ignored (i.e. irrelevant

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. I dislike delegating jobs (or hiding problems) of CMake (assuming that autoconf/gmake is already dead) to external scripts like Python ones. In the goal, I plan to add LLDB in the NetBSD base (next to LLVM and Clang) where there is no Python at all. In FreeBSD there

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. In http://reviews.llvm.org/D14790#292493, @krytarowski wrote: > Not long ago we rejected dynamic dependency on `curses`(3), as a fall-back > for NetBSD (without `libpanel`(3) in the 7.0 release). Why doing the similar > thing with swig is fine? > > Why are we abstractin

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a subscriber: krytarowski. krytarowski added a comment. Not long ago we rejected dynamic dependency on `curses`(3), as a fall-back for NetBSD (without `libpanel`(3) in the 7.0 release). Why doing the similar thing with swig is fine? Why are we abstracting swig when there is no

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. So, this is the last thing I'm going to say on this thread. What I'm fighting for here is consistency. We seem to have the same goal (making LLDB easier to build for the casual developer) but a different understanding of how to go about accomplishing this. From your p

[Lldb-commits] [lldb] r253538 - I like how PlatformAndroid/PlatformLinux log when their platforms

Author: jmolenda Date: Wed Nov 18 21:15:37 2015 New Revision: 253538 URL: http://llvm.org/viewvc/llvm-project?rev=253538&view=rev Log: I like how PlatformAndroid/PlatformLinux log when their platforms try to CreateInstance, and log the results. I copied that for the Mac platforms. Modified:

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

zturner added inline comments. Comment at: source/API/SBProcess.cpp:1433-1437 @@ +1432,7 @@ +{ +ProcessSP process_sp(GetSP()); +lldb::SBFileSpec core_file(file_name); +lldb::SBError error; +error.SetError(PluginManager::SaveCore(process_sp, core_file.get())); +

[Lldb-commits] [lldb] r253537 - Pass the ExecutionContext as well, since it is actually useful

Author: enrico Date: Wed Nov 18 20:50:27 2015 New Revision: 253537 URL: http://llvm.org/viewvc/llvm-project?rev=253537&view=rev Log: Pass the ExecutionContext as well, since it is actually useful Modified: lldb/trunk/include/lldb/Target/Language.h lldb/trunk/source/Core/FormatEntity.cpp

Re: [Lldb-commits] [PATCH] D14530: Plug-in PlatformNetBSD initializer and terminator

krytarowski added a comment. Are we ready to land it? Without this patch I cannot launch lldb. Repository: rL LLVM http://reviews.llvm.org/D14530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [lldb] r253531 - Allow the language plugins a say in how the function name is rendered as part of frame formatting

That depends - some of the language plugin stuff is being used in C/C++/ObjC, and then there either are new test cases, or existing test cases cover the fact that refactoring has not broken functionality Some of the new functionality is not (yet) used, and is just infrastructural plumbing - in

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

zturner added a subscriber: zturner. zturner added a comment. Fair enough. I figured it was worth asking about, but the rationale makes sense. http://reviews.llvm.org/D14793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

Fair enough. I figured it was worth asking about, but the rationale makes sense. On Wed, Nov 18, 2015 at 5:18 PM Jim Ingham wrote: > > > On Nov 18, 2015, at 4:31 PM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > zturner added a reviewer: clayborg. > > zturner a

Re: [Lldb-commits] [lldb] r253531 - Allow the language plugins a say in how the function name is rendered as part of frame formatting

Hi Enrico, have there been any tests exercising any of the language plugin stuff yet? Hard to follow every CL that goes in, so just trying to catch up. On Wed, Nov 18, 2015 at 5:14 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Wed Nov 18 19:11:

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

> On Nov 18, 2015, at 4:31 PM, Zachary Turner via lldb-commits > wrote: > > zturner added a reviewer: clayborg. > zturner added a comment. > > +greg since this touches some SB stuff and the ObjectFile plugins. > > > > Comment at: include/lldb/API/SBProcess.h:345-346 > @@ +34

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. In http://reviews.llvm.org/D14790#292255, @zturner wrote: > > What is worth arguing about, however, is that changes need to have some kind > of reasonable justification. I strongly disagree with this statement from a procedural point of view. It is just an invalid

[Lldb-commits] [lldb] r253531 - Allow the language plugins a say in how the function name is rendered as part of frame formatting

Author: enrico Date: Wed Nov 18 19:11:53 2015 New Revision: 253531 URL: http://llvm.org/viewvc/llvm-project?rev=253531&view=rev Log: Allow the language plugins a say in how the function name is rendered as part of frame formatting Modified: lldb/trunk/include/lldb/Target/Language.h lldb/

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

clayborg added a comment. Code correction and added that we should make sure the process is alive and stopped. Comment at: source/API/SBProcess.cpp:1433-1437 @@ +1432,7 @@ +{ +ProcessSP process_sp(GetSP()); +lldb::SBFileSpec core_file(file_name); +lldb::SBError erro

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: include/lldb/API/SBProcess.h:344-346 @@ -343,1 +343,5 @@ +// Save the state of the process in a core file (or mini dump o

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

zturner added a reviewer: clayborg. zturner added a comment. +greg since this touches some SB stuff and the ObjectFile plugins. Comment at: include/lldb/API/SBProcess.h:345-346 @@ +344,4 @@ +// Save the state of the process in a core file (or mini dump on Windows). +lldb

[Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Enable the saving of a mini dump (on Windows) using the existing lldb save-core command. Also plumbs a new method into SBProcess, and adds a very basic test to make sure it produces a

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Anyway, just check it in. The content of this patch is not worth arguing about. What is worth arguing about, however, is that changes need to have some kind of reasonable justification. "

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. It's not that I don't like it. I mean, it used to be, but it's a minor change. At this point it's about that I've repeatedly asked for some kind of reasonable explanation about why swig is a contentious dependency, and the most I've gotten is "things are about to chan

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. In http://reviews.llvm.org/D14790#292226, @zturner wrote: > So you can't install swig on your Linux machines either? > > I really can't wrap my head around why we need this. What is the problem > with installing swig, given that we need to install other software already?

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. Keep in mind this is an opt-in flag. No developers get the behavior unless they specifically ask for it. I'm adding it because I specifically need it. http://reviews.llvm.org/D14790 ___ lldb-commits mailing list lldb-commi

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. (And I also work on cmake-based OS X lldb when there are issues that break there). http://reviews.llvm.org/D14790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. So you can't install swig on your Linux machines either? I really can't wrap my head around why we need this. What is the problem with installing swig, given that we need to install other software already? The build instructions here [http://lldb.llvm.org/build.html#B

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. In http://reviews.llvm.org/D14790#292220, @zturner wrote: > If nobody on the Apple side is using CMake, then I'm still not clear why we > need this. Everyone using CMake already will continue to work fine using > dynamically generated bindings, right? I'm at Apple. I

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

zturner added a comment. If nobody on the Apple side is using CMake, then I'm still not clear why we need this. Everyone using CMake already will continue to work fine using dynamically generated bindings, right? I still don't agree with the need for the static bindings in any configuration,

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala added a comment. BTW I've tested this with the static bindings we use on OS X on Ubuntu 14.04 with a clang 3.6 build. http://reviews.llvm.org/D14790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

tfiala created this revision. tfiala added reviewers: labath, zturner, spyffe. tfiala added a subscriber: lldb-commits. This change does the following: * Adds a cached LLDB_ALLOW_STATIC_BINDINGS variable, defaults to off/false * If specified, flips on the --allow-static-binding flag to prepare_bin

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala closed this revision. tfiala added a comment. Committed here: r253513. http://reviews.llvm.org/D14783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

zturner added a comment. sounds good http://reviews.llvm.org/D14783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253513 - Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

Author: tfiala Date: Wed Nov 18 16:21:47 2015 New Revision: 253513 URL: http://llvm.org/viewvc/llvm-project?rev=253513&view=rev Log: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes This closes: http://reviews.llvm.org/D14783 Removed: lldb/trunk/scripts/Python/buil

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala added a comment. Aside from that one fix in the second patch, a grep for those two scripts came back clean on the source tree. http://reviews.llvm.org/D14783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala updated this revision to Diff 40560. tfiala added a comment. Missed one reference in a cmake custom command dependency. Fixed in latest diff. http://reviews.llvm.org/D14783 Files: scripts/CMakeLists.txt scripts/Python/buildSwigPython.py scripts/buildSwigWrapperClasses.py Index:

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala added a comment. Okay, thanks. I'll grep the source base first to make sure I'm not missing anything else. http://reviews.llvm.org/D14783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. As long as with your new script these are no longer being called anywhere, should be safe to remove. http://reviews.llvm.org/D14783 ___ lldb-c

Re: [Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala added a comment. Looks like with your change in r253501, we are okay to delete these? http://reviews.llvm.org/D14783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14718: Insert the SWIG version into LLDB's __init__.py

tfiala added a comment. We can close this one out too, right? http://reviews.llvm.org/D14718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14726: Add the ability to skip or xfail based on Python and/or SWIG version

tfiala added a comment. Is this one ready to close out? http://reviews.llvm.org/D14726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253505 - [TestExitDuringStep] Adjust after a recent type map change.

Author: sivachandra Date: Wed Nov 18 15:22:29 2015 New Revision: 253505 URL: http://llvm.org/viewvc/llvm-project?rev=253505&view=rev Log: [TestExitDuringStep] Adjust after a recent type map change. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D1478

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Sure thing. I'll get the finish-bindings script taken care of in another pass after T-day week. On Wed, Nov 18, 2015 at 1:13 PM, Zachary Turner wrote: > Tested this on Windows, seems to work fine. r253501 has a minor fix that > was causing a CMake warning, but overall everything works great.

Re: [Lldb-commits] [lldb] r253501 - Fix CMake dependency on lldb.py

(good catch :-) ) On Wed, Nov 18, 2015 at 1:20 PM, Todd Fiala wrote: > Nope, I'm wrong. Sorry! > > On Wed, Nov 18, 2015 at 1:15 PM, Todd Fiala wrote: > >> I don't *think* that's right? (At least, not for Linux). >> >> It's not coming from the source dir. It gets generated into the binary >>

Re: [Lldb-commits] [lldb] r253501 - Fix CMake dependency on lldb.py

Nope, I'm wrong. Sorry! On Wed, Nov 18, 2015 at 1:15 PM, Todd Fiala wrote: > I don't *think* that's right? (At least, not for Linux). > > It's not coming from the source dir. It gets generated into the binary > directory. Or - maybe the Windows ones write the output into the source > tree?

Re: [Lldb-commits] [lldb] r253501 - Fix CMake dependency on lldb.py

I don't *think* that's right? (At least, not for Linux). It's not coming from the source dir. It gets generated into the binary directory. Or - maybe the Windows ones write the output into the source tree? Do we need to conditionalize the location of lldb.py based on the build? -Todd On Wed,

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Tested this on Windows, seems to work fine. r253501 has a minor fix that was causing a CMake warning, but overall everything works great. Happy to see progress on this front. On Wed, Nov 18, 2015 at 12:47 PM Todd Fiala wrote: > BTW if you cook up something on the swig-as-a-service end that end

[Lldb-commits] [lldb] r253501 - Fix CMake dependency on lldb.py

Author: zturner Date: Wed Nov 18 15:09:55 2015 New Revision: 253501 URL: http://llvm.org/viewvc/llvm-project?rev=253501&view=rev Log: Fix CMake dependency on lldb.py Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/C

Re: [Lldb-commits] [PATCH] D14784: [TestExitDuringStep] Adjust after a recent type map change.

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. lgtm, probably don't need to ask for review on this kind of patch :) http://reviews.llvm.org/D14784 ___ lldb-commits mailing list lldb-commits@

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 12:51 PM, Zachary Turner wrote: > (This is originally from a thread on lldb-commits, but it seems more > appropriate here, so I'm responding here. > > On Wed, Nov 18, 2015 at 12:47 PM Todd Fiala wrote: > >> BTW if you cook up something on the swig-as-a-service end that en

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 12:53 PM, Todd Fiala wrote: > > > On Wed, Nov 18, 2015 at 12:45 PM, Zachary Turner > wrote: > >> >> >> On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote: >> >>> On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner >>> wrote: >>> Because even if it isn't perfect for e

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 12:45 PM, Zachary Turner wrote: > > > On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote: > >> On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner >> wrote: >> >>> Because even if it isn't perfect for everyone, it works for everyone. >>> >> >> Unless you can't get swig on

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

(This is originally from a thread on lldb-commits, but it seems more appropriate here, so I'm responding here. On Wed, Nov 18, 2015 at 12:47 PM Todd Fiala wrote: > BTW if you cook up something on the swig-as-a-service end that ends up > working to eliminate the need for swig, I'll be happy to re

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

BTW if you cook up something on the swig-as-a-service end that ends up working to eliminate the need for swig, I'll be happy to remove the static binding support at that point. -Todd On Wed, Nov 18, 2015 at 12:45 PM, Todd Fiala wrote: > > On Wed, Nov 18, 2015 at 11:55 AM, Zachary Turner > wrot

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote: > On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner > wrote: > >> Because even if it isn't perfect for everyone, it works for everyone. >> > > Unless you can't get swig on your system in a way that doesn't break other > items. And then it does

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

On Wed, Nov 18, 2015 at 11:55 AM, Zachary Turner wrote: > By the way, it would be great if we could kill this modify-lldb-python.py. > I'm totally up for that. > It seems like a total hackjob, and there's nothing it does that can't be > done better by wrapping the lldb module instead of modi

[Lldb-commits] [PATCH] D14784: [TestExitDuringStep] Adjust after a recent type map change.

sivachandra created this revision. sivachandra added a reviewer: zturner. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D14784 Files: packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py Index: packages/Python/lldbsuite/test/fun

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

By the way, it would be great if we could kill this modify-lldb-python.py. It seems like a total hackjob, and there's nothing it does that can't be done better by wrapping the lldb module instead of modifying it. For example, it goes through and injects a bunch of methods to classes in the lldb mo

[Lldb-commits] [PATCH] D14783: Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes

tfiala created this revision. tfiala added a reviewer: zturner. tfiala added a subscriber: lldb-commits. These classes have been cleaned up in scripts/prepare_bindings.py and scripts/Python/prepare_binding_Python.py. Both Xcode and cmake builds have been converted over. Waiting to make sure thi

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Yea, VS 2015 only. On Wed, Nov 18, 2015 at 11:42 AM Todd Fiala wrote: > And that works with VS 2015, and VS 2015 only, right? > > On Wed, Nov 18, 2015 at 11:41 AM, Todd Fiala wrote: > >> That's great, Zachary! >> >> Cool. Makes it easier to make sure I'm not breaking stuff. >> >> On Wed, Nov 1

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote: > > My intent here is to only provide the --allow-static-binding option on > cmake if it is explicitly turned on. And it will be off by default. > I know, but I don't really like adding options that nobody is going to use, because it makes maint

[Lldb-commits] [lldb] r253493 - Reapply r253423 and r253424 (which cleanup the data formatters iteration model, as well as the type X list commands), along with a change by Zachary Turner to bypass a

Author: enrico Date: Wed Nov 18 13:42:44 2015 New Revision: 253493 URL: http://llvm.org/viewvc/llvm-project?rev=253493&view=rev Log: Reapply r253423 and r253424 (which cleanup the data formatters iteration model, as well as the type X list commands), along with a change by Zachary Turner to bypa

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

And that works with VS 2015, and VS 2015 only, right? On Wed, Nov 18, 2015 at 11:41 AM, Todd Fiala wrote: > That's great, Zachary! > > Cool. Makes it easier to make sure I'm not breaking stuff. > > On Wed, Nov 18, 2015 at 11:07 AM, Zachary Turner > wrote: > >> yea. Pass -DPYTHON_HOME=C:\Pytho

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

That's great, Zachary! Cool. Makes it easier to make sure I'm not breaking stuff. On Wed, Nov 18, 2015 at 11:07 AM, Zachary Turner wrote: > yea. Pass -DPYTHON_HOME=C:\Python35 to CMake and you're good to go. > > I've still got about 20-30 tests failing and/or timing out, but I'm > getting clo

[Lldb-commits] [lldb] r253491 - Remove the scripts/Python/build-swig-Python.sh script.

Author: tfiala Date: Wed Nov 18 13:37:51 2015 New Revision: 253491 URL: http://llvm.org/viewvc/llvm-project?rev=253491&view=rev Log: Remove the scripts/Python/build-swig-Python.sh script. This logically goes with my previous commit. Removed: lldb/trunk/scripts/Python/build-swig-Python.sh Re

[Lldb-commits] [lldb] r253490 - remove defunct scripts/build-swig-wrapper-classes.sh; switch autoconf build to prepare_bindings.py.

Author: tfiala Date: Wed Nov 18 13:34:03 2015 New Revision: 253490 URL: http://llvm.org/viewvc/llvm-project?rev=253490&view=rev Log: remove defunct scripts/build-swig-wrapper-classes.sh; switch autoconf build to prepare_bindings.py. Xcode moved off of build-swig-wrapper-classes.sh earlier this w

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

yea. Pass -DPYTHON_HOME=C:\Python35 to CMake and you're good to go. I've still got about 20-30 tests failing and/or timing out, but I'm getting close. On Wed, Nov 18, 2015 at 10:58 AM Todd Fiala wrote: > Ah okay. > > Hey is the "use the python 3.5 from python.org" path on Windows > (including

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner wrote: > > > On Wed, Nov 18, 2015 at 10:00 AM Todd Fiala wrote: > >> Checking in the static bindings is no different than projects checking in >> autoconf config baked scripts so that the vast majority of people don't >> need to run autoconf just

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

> On Nov 18, 2015, at 10:34 AM, Zachary Turner via lldb-dev > wrote: > > > > On Wed, Nov 18, 2015 at 10:00 AM Todd Fiala > wrote: > Checking in the static bindings is no different than projects checking in > autoconf config baked scripts so that the vast majorit

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

This revision was automatically updated to reflect the committed changes. Closed by commit rL253488: Support unix-abstract-connect scheme as platform url in lldb testsuite (authored by chying). Changed prior to commit: http://reviews.llvm.org/D14765?vs=40469&id=40535#toc Repository: rL LLVM

[Lldb-commits] [lldb] r253488 - Support unix-abstract-connect scheme as platform url in lldb testsuite

Author: chying Date: Wed Nov 18 13:03:20 2015 New Revision: 253488 URL: http://llvm.org/viewvc/llvm-project?rev=253488&view=rev Log: Support unix-abstract-connect scheme as platform url in lldb testsuite Reviewers: ovyalov Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

chying marked an inline comment as done. chying added a comment. http://reviews.llvm.org/D14765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

On Wed, Nov 18, 2015 at 10:58 AM, Todd Fiala wrote: > Ah okay. > (I thought that was too easy ;-) ) > > Hey is the "use the python 3.5 from python.org" path on Windows > (including tests) try-able at this time? > > -Todd > > On Wed, Nov 18, 2015 at 10:37 AM, Zachary Turner > wrote: > >> Yea,

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Ah okay. Hey is the "use the python 3.5 from python.org" path on Windows (including tests) try-able at this time? -Todd On Wed, Nov 18, 2015 at 10:37 AM, Zachary Turner wrote: > Yea, this is the right one. Thanks! I haven't tested this yet, but I > will later. (Our buildbot currently builds

[Lldb-commits] [lldb] r253487 - Fix some issues with swig & string conversion.

Author: zturner Date: Wed Nov 18 12:40:16 2015 New Revision: 253487 URL: http://llvm.org/viewvc/llvm-project?rev=253487&view=rev Log: Fix some issues with swig & string conversion. This patch fixes two issues: 1) Popen needs to be used with universal_newlines=True by default. This elicits aut

[Lldb-commits] Some buildbot statistics for the last week

Hello everyone, Here are some buildbot statistics you may found interesting. I will be adding more statistics. My goal is to publish metrics to help with keeping the buildbot infrastructure healthy and improving it. All the numbers are for the week of 11/8/2015 - 11/14/2015. Thanks Galina Nu

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Yea, this is the right one. Thanks! I haven't tested this yet, but I will later. (Our buildbot currently builds with LLDB_DISABLE_PYTHON=1, so if there is a problem with this, the Windows buildbot wouldn't pick it up, although the others probably would) On Wed, Nov 18, 2015 at 10:14 AM Todd Fia

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Wed, Nov 18, 2015 at 10:00 AM Todd Fiala wrote: > Checking in the static bindings is no different than projects checking in > autoconf config baked scripts so that the vast majority of people don't > need to run autoconf just to get a setup that rarely changes. There is > precedent for this g

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM Comment at: packages/Python/lldbsuite/test/lldbtest.py:464 @@ -463,3 +463,3 @@ parsed_url = urlparse.urlparse(lldb.platform_url) -if parsed_url.scheme

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

If I have that right, we're fine. The prepare_bindings.py still calls modify-python-lldb.py. scripts/prepare_bindings.py is meant to be the same as createSwigBindings.py, and scripts/python/prepare_binding_Python.py is meant to be the same as buildSwigPython.py. Once I make sure that I haven't b

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

You're talking about this change, right? (I'm looking at it now...) commit cc353bbc992ab324aef395c54a2a46fcaaa3855b Author: Zachary Turner Date: Mon Nov 16 22:40:20 2015 + Insert the SWIG version into LLDB's __init__.py The goal here is to allow us to add skip / xfail decorators

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Double checking now, if it happens in that lldb-modify script, we're covered. Otherwise I need to adjust... (the bulk of the rewrite happened on Friday/Sunday). On Wed, Nov 18, 2015 at 9:47 AM, Zachary Turner wrote: > Just to be sure, did you catch the change I made to the old scripts in the >

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

> On OS X, it is a pain to get unless you install homebrew/macports/fink. On Linux, you'll need to do an apt-get or yum install. And I should add that installing home-brew (the most common way of picking up extra goodies, as I know I do it on home machines) is also one of the most common ways to p

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

Checking in the static bindings is no different than projects checking in autoconf config baked scripts so that the vast majority of people don't need to run autoconf just to get a setup that rarely changes. There is precedent for this going back a long way on open source projects. I'm backing of

Re: [Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Just to be sure, did you catch the change I made to the old scripts in the past few days to embed the swig version in the generated lldb.py? Maybe you did, I just want to make sure that change is in your new version. On Wed, Nov 18, 2015 at 9:38 AM Todd Fiala via lldb-commits < lldb-commits@lists

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

clayborg added a comment. I would prefix the first fix: > Add a new function to llvm::APInt what returns the pointer to the actual data > in case of both endian (possibly the best option) Using llvm::APInt gets us unlimited integer size abilities (support 128 bit ints and higher) along with a

[Lldb-commits] [lldb] r253478 - Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version.

Author: tfiala Date: Wed Nov 18 11:36:15 2015 New Revision: 253478 URL: http://llvm.org/viewvc/llvm-project?rev=253478&view=rev Log: Switched cmake build from using buildSwigWrapperClases.py to the cleaned up version. This change does not introduce static bindings. It is simply using the pylint

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

evgeny777 updated this revision to Diff 40508. evgeny777 added a comment. Minor code cleanups http://reviews.llvm.org/D13350 Files: packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py packages/Python/lldbsuite/test/lang/cpp/namespace/main.cpp packages/Python/lldbsuite/test/

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

tberghammer added a comment. Hi, I checked out the implementation of RegisterValue and this is my understanding what is happening: - When we call RegisterValue::SetUInt it will be creating a 32bit unsigned llvm::APInt - The llvm::APInt will store the data in a uint64_t - Calling RegisterValue:

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

evgeny777 updated this revision to Diff 40497. evgeny777 added a comment. Hi folks! The clang patch has been landed. I've added test cases, so please look at the new patch. Thanks http://reviews.llvm.org/D13350 Files: packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py pack

[Lldb-commits] [lldb] r253455 - Revert 2 commits breaking the MSVC build

Author: tberghammer Date: Wed Nov 18 06:11:34 2015 New Revision: 253455 URL: http://llvm.org/viewvc/llvm-project?rev=253455&view=rev Log: Revert 2 commits breaking the MSVC build Revert "Remove a few vestigial typedefs from the old world" This reverts commit 05872cda2a00fbd988c4fc761b1f87fe9edce2

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

sagar added a comment. Hi, @tberghammer : For both mips32 and mips64 big endian 'T' packet response contains the register values in target byte order only. But for mips32 big endian when we set the value of the register in RegisterValue using RegisterValue::SetUInt() the upper half of the cont

Re: [Lldb-commits] [lldb-dev] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On 18 November 2015 at 09:02, Zachary Turner via lldb-dev wrote: > On Tue, Nov 17, 2015 at 8:03 PM Todd Fiala wrote: >> >> Nothing concrete at the moment; however, it could be interesting to look >> at the clang community and see what could be done for llvm-based language >> implementations. The

Re: [Lldb-commits] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

On Tue, Nov 17, 2015 at 8:03 PM Todd Fiala wrote: > Nothing concrete at the moment; however, it could be interesting to look > at the clang community and see what could be done for llvm-based language > implementations. The angle that I think would be interesting would be if > we can generate bi

Re: [Lldb-commits] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

Usage of static bindings for the prepare_bindings.py script went in here: r253448. Only Xcode provides the flag to use it. The commit description indicates how it works in this incarnation. Essentially it only uses the static Python binding if and only if a swig isn't specified or cannot be foun

[Lldb-commits] [lldb] r253448 - prepare_bindings.py: enable static bindings

Author: tfiala Date: Wed Nov 18 02:52:33 2015 New Revision: 253448 URL: http://llvm.org/viewvc/llvm-project?rev=253448&view=rev Log: prepare_bindings.py: enable static bindings Added a new flag, --allow-static-binding. When specified, if (and only if) the swig binary cannot be found, then the LL

Re: [Lldb-commits] [PATCH] D14634: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

sagar added a comment. Committed in r253445 on behalf of @nitesh.jain Repository: rL LLVM http://reviews.llvm.org/D14634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253445 - [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

Author: slthakur Date: Wed Nov 18 02:18:03 2015 New Revision: 253445 URL: http://llvm.org/viewvc/llvm-project?rev=253445&view=rev Log: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS Patch by Nitesh Jain Summary: The break is opcode for breakpoint instruction. Subscribers: lldb-commits,

  1   2   >