brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this resu
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
pla
Author: enrico
Date: Thu Nov 5 21:04:56 2015
New Revision: 252272
URL: http://llvm.org/viewvc/llvm-project?rev=252272&view=rev
Log:
Change the way we read data from the ObjC runtime
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp
Mod
Author: enrico
Date: Thu Nov 5 20:43:32 2015
New Revision: 252269
URL: http://llvm.org/viewvc/llvm-project?rev=252269&view=rev
Log:
Add data formatters for NSError and NSException
Added:
lldb/trunk/source/Plugins/Language/ObjC/NSError.cpp
lldb/trunk/source/Plugins/Language/ObjC/NSExcept
labath added a comment.
(The upstream unittest does not seem to have the bugnumber feature. I am
assuming the intention here is to make this upstream compatible, in hope of
moving over there at some point.)
http://reviews.llvm.org/D14406
___
lldb-
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:605
@@ -611,2 +604,3 @@
if expected_fn(self):
-raise case._UnexpectedSuccess(sys.exc_info(), bugnumber)
+xfail_func = unittest2.expectedFailure(fu
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
From what I can tell, it should just work. I assume you've done the obvious
checks, like deliberately failing a test and seeing it registers as failed,
etc. I think we should just commit it, a
Author: jmolenda
Date: Thu Nov 5 19:43:36 2015
New Revision: 252264
URL: http://llvm.org/viewvc/llvm-project?rev=252264&view=rev
Log:
A little more careful handling of platforms and unspecified unknown
vendors & oses, especially on Apple, to handle the new environment
where we have more than maco
Author: jmolenda
Date: Thu Nov 5 18:55:17 2015
New Revision: 252254
URL: http://llvm.org/viewvc/llvm-project?rev=252254&view=rev
Log:
Jim thinks we shouldn't bother to pollute the svn repo with these
internal details, so I'll pull it back to just our own branch
of the sources.
Modified:
lldb
Author: jmolenda
Date: Thu Nov 5 18:43:31 2015
New Revision: 252252
URL: http://llvm.org/viewvc/llvm-project?rev=252252&view=rev
Log:
Upstream a change to MemoryHistoryASan from Sean:
Author: Sean Callanan
Date: Tue Jun 23 13:52:24 2015 -0700
Memory history should not crash if it can't i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252250: Reuse native curses(8) library on NetBSD (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14037?vs=39440&id=39444#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1403
Author: brucem
Date: Thu Nov 5 18:21:18 2015
New Revision: 252250
URL: http://llvm.org/viewvc/llvm-project?rev=252250&view=rev
Log:
Reuse native curses(8) library on NetBSD
Summary:
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with and linkage fr
krytarowski updated this revision to Diff 39440.
krytarowski added a comment.
Rebase to master
Repository:
rL LLVM
http://reviews.llvm.org/D14037
Files:
source/Core/IOHandler.cpp
Index: source/Core/IOHandler.cpp
===
--- sourc
zturner created this revision.
zturner added reviewers: tfiala, tberghammer, labath.
zturner added a subscriber: lldb-commits.
The specific exception types that are thrown internally by unittest2 are
considered implementation details and even documented as such in the source
code of the library.
Author: jmolenda
Date: Thu Nov 5 17:59:30 2015
New Revision: 252245
URL: http://llvm.org/viewvc/llvm-project?rev=252245&view=rev
Log:
Add a warning to TargetList::CreateTargetInternal
so when it is run on a kext (which won't activate
any platform plugins), you'll get a warning message
which may b
Author: jmolenda
Date: Thu Nov 5 17:54:29 2015
New Revision: 252242
URL: http://llvm.org/viewvc/llvm-project?rev=252242&view=rev
Log:
Use Process::IsAlive instead of just checking for eStateExited.
Two minor tweaks to GetLoadedDynamicLibrariesInfos.
Modified:
lldb/trunk/source/Plugins/Proces
Author: jingham
Date: Thu Nov 5 17:52:05 2015
New Revision: 252240
URL: http://llvm.org/viewvc/llvm-project?rev=252240&view=rev
Log:
Add a generic API to return the Concrete type for a given abstract type
name and the execution context in which it is realized.
Modified:
lldb/trunk/include/ll
Author: jmolenda
Date: Thu Nov 5 17:51:05 2015
New Revision: 252239
URL: http://llvm.org/viewvc/llvm-project?rev=252239&view=rev
Log:
GDBRemoteCommunicationClient::SendEnvironmentPacket should use the hex-encoded
env packet if the '*' character used for run length encoding is present.
Modified:
Author: brucem
Date: Thu Nov 5 17:48:41 2015
New Revision: 252238
URL: http://llvm.org/viewvc/llvm-project?rev=252238&view=rev
Log:
Fix cmake build on Mac OS X.
PlatformDarwin uses Host/XML.h which needs to find libxml2, and
so it needs to be told how to find the headers.
Modified:
lldb/tru
Author: jmolenda
Date: Thu Nov 5 17:44:08 2015
New Revision: 252235
URL: http://llvm.org/viewvc/llvm-project?rev=252235&view=rev
Log:
Update the invocation to dsymForUUID (a script plugin used
at Apple, called by the DebugSymbols private framework to
find a dSYM for a UUID on mac) to include the
Author: jmolenda
Date: Thu Nov 5 17:42:18 2015
New Revision: 252234
URL: http://llvm.org/viewvc/llvm-project?rev=252234&view=rev
Log:
Update for tvos or watchos builds.
Modified:
lldb/trunk/scripts/package-clang-headers.py
Modified: lldb/trunk/scripts/package-clang-headers.py
URL:
http://l
Author: jmolenda
Date: Thu Nov 5 17:41:49 2015
New Revision: 252233
URL: http://llvm.org/viewvc/llvm-project?rev=252233&view=rev
Log:
One more debug-build assert that addr_size is
a realistic value.
Modified:
lldb/trunk/include/lldb/Core/DataExtractor.h
Modified: lldb/trunk/include/lldb/Cor
Author: jmolenda
Date: Thu Nov 5 17:41:08 2015
New Revision: 252232
URL: http://llvm.org/viewvc/llvm-project?rev=252232&view=rev
Log:
Initialize addr_size to match the size of lldb itself
as an initial seed value, instead of 4.
Add some asserts when lldb is built for development to
check that ad
Author: chaoren
Date: Thu Nov 5 17:19:27 2015
New Revision: 252230
URL: http://llvm.org/viewvc/llvm-project?rev=252230&view=rev
Log:
Another import fix for OS X.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL:
Author: jmolenda
Date: Thu Nov 5 17:04:57 2015
New Revision: 252228
URL: http://llvm.org/viewvc/llvm-project?rev=252228&view=rev
Log:
Add support for one API used to detect if a process
is running under System Integrity Protection on
Mac OS X 10.11. The rootless_allows_task_for_pid() spi
(see d
Author: jmolenda
Date: Thu Nov 5 17:03:44 2015
New Revision: 252227
URL: http://llvm.org/viewvc/llvm-project?rev=252227&view=rev
Log:
Add support for the new (added last week) llvm::Triple::WatchOS and ::TvOS
in places where we check for Triple::IOS. They're mostly the same as far
as lldb is con
Author: jmolenda
Date: Thu Nov 5 16:51:29 2015
New Revision: 252225
URL: http://llvm.org/viewvc/llvm-project?rev=252225&view=rev
Log:
Add support for the armv7k ABI which has some small
changes from the normal armv7 ABI used on darwin.
Modified:
lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMa
Author: jingham
Date: Thu Nov 5 16:33:17 2015
New Revision: 252224
URL: http://llvm.org/viewvc/llvm-project?rev=252224&view=rev
Log:
Let the process help figure out the Host OS if nobody else
can figure it out.
Modified:
lldb/trunk/include/lldb/Target/Platform.h
lldb/trunk/include/lldb/T
Thanks, yea that looks like the right fix.
On Thu, Nov 5, 2015 at 2:10 PM Chaoren Lin wrote:
> rL252218 should hopefully fix it.
>
> On Thu, Nov 5, 2015 at 1:53 PM, Chaoren Lin wrote:
>
>> Hi, I think this changed caused all of the OS X tests to fail:
>>
>>
>> http://lab.llvm.org:8011/builders/
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
TBH I'm honestly not sure what the problem was before, or why this fixes
it. But what I can tell from debugging is that under Py3,
`sortMethodsUsing` is treated as a class attrib
rL252218 should hopefully fix it.
On Thu, Nov 5, 2015 at 1:53 PM, Chaoren Lin wrote:
> Hi, I think this changed caused all of the OS X tests to fail:
>
>
> http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio
>
> with this error:
>
> Traceback (most recent
Author: chaoren
Date: Thu Nov 5 16:00:47 2015
New Revision: 252218
URL: http://llvm.org/viewvc/llvm-project?rev=252218&view=rev
Log:
Fix OS X tests.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL:
http://llvm.
Hi, I think this changed caused all of the OS X tests to fail:
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio
with this error:
Traceback (most recent call last):
File "/Users/lldb_build/lldbSlave/buildDir/scripts/../lldb/test/dotest.py",
line 7, in
zturner added a comment.
Ahh makes sense, I didn't know about that. I think a cleaner way to do this is
to just add everything to `PLUGIN_PLATFORM_MACOSX_SOURCES` in the very first
`list(APPEND)`. Then just do this:
if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
set(LLVM_OPTIONAL_SOURCES
Author: chaoren
Date: Thu Nov 5 14:45:29 2015
New Revision: 252205
URL: http://llvm.org/viewvc/llvm-project?rev=252205&view=rev
Log:
Completely avoid building Apple simulator on non-Darwin platforms.
Summary:
This is a resubmission of r252179, but correctly ignores the source
files for other pla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252205: Completely avoid building Apple simulator on
non-Darwin platforms. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14389?vs=39394&id=39402#toc
Repository:
rL LLVM
ht
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I find the code to be a fair bit harder to understand as a result, but I guess
it's not the end of the world.
Searching the source of LLVM's CMake infrastructure, this variable exists
solel
chaoren added a comment.
I haven't seen anything else that uses LLVM_OPTIONAL_SOURCES, but it's
conceivable that there might be items in the list already, and I would like to
avoid doing anything to it besides just appending.
http://reviews.llvm.org/D14389
__
chaoren added a comment.
It's not actually CMake complaining but the LLVM cmake scripts.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chaoren added a comment.
LLVM_OPTIONAL_SOURCES should avoid that.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Isn't this going to have the same problem as before? If CMake finds a source
file in the directory that is not added to one of the targets, it will give you
an error. With this patch, on Linux or Windows `PlatformAppleSimulator.cpp`
will be on disk, but not part of th
chaoren created this revision.
chaoren added reviewers: granata.enrico, tberghammer, zturner, jingham.
chaoren added a subscriber: lldb-commits.
This is a resubmission of r252179, but correctly ignores the source
files for other platforms.
http://reviews.llvm.org/D14389
Files:
source/Initializ
.mm means compile with the ObjectiveC++ compiler, not the ObjectiveC compiler.
Probably wouldn't effect these files but it seems a really bogus way to tell
the build system not to build files...
Jim
> On Nov 5, 2015, at 10:58 AM, Zachary Turner via lldb-commits
> wrote:
>
> Renaming it to .
Author: spyffe
Date: Thu Nov 5 13:46:12 2015
New Revision: 252198
URL: http://llvm.org/viewvc/llvm-project?rev=252198&view=rev
Log:
Better validation when we think a directory might be Xcode.app.
LLDB could otherwise get confused if it is (for example) in a
root that is meant to install into an
Author: zturner
Date: Thu Nov 5 13:22:28 2015
New Revision: 252191
URL: http://llvm.org/viewvc/llvm-project?rev=252191&view=rev
Log:
Python 3 - Turn on absolute imports, and fix existing imports.
Absolute imports were introduced in Python 2.5 as a feature
(e.g. from __future__ import absolute_im
Author: zturner
Date: Thu Nov 5 13:22:06 2015
New Revision: 252190
URL: http://llvm.org/viewvc/llvm-project?rev=252190&view=rev
Log:
Fix build on platforms that don't have dlfcn.h
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
Modified: lldb/trunk/source/Plug
Author: zturner
Date: Thu Nov 5 13:21:56 2015
New Revision: 252189
URL: http://llvm.org/viewvc/llvm-project?rev=252189&view=rev
Log:
Python 3 - Fix usage of `unicode` in unittest2.
Modified:
lldb/trunk/third_party/Python/module/unittest2/unittest2/case.py
Modified: lldb/trunk/third_party/Py
Author: jingham
Date: Thu Nov 5 13:20:39 2015
New Revision: 252188
URL: http://llvm.org/viewvc/llvm-project?rev=252188&view=rev
Log:
Add a comment explaining TypeImpl.
Modified:
lldb/trunk/include/lldb/Symbol/Type.h
Modified: lldb/trunk/include/lldb/Symbol/Type.h
URL:
http://llvm.org/viewv
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Okay, looks good then. Thanks, Zachary!
http://reviews.llvm.org/D14342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
Renaming it to .mm would fix it, but I don't know if that extension has
special implications on OSX platforms.
Another fix would be moving the platform-specific files into a subfolder
and then adding them dfrom the subfolder. That way CMake won't see them in
the current directory.
On Thu, Nov 5,
Author: jingham
Date: Thu Nov 5 12:51:48 2015
New Revision: 252184
URL: http://llvm.org/viewvc/llvm-project?rev=252184&view=rev
Log:
Remove Copy and Paste error in a comment.
Modified:
lldb/trunk/include/lldb/Symbol/CompileUnit.h
Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h
URL:
Author: chaoren
Date: Thu Nov 5 12:49:02 2015
New Revision: 252182
URL: http://llvm.org/viewvc/llvm-project?rev=252182&view=rev
Log:
Revert "Do not build any of the simulator material on non-Darwin"
This breaks the cmake build on all non-darwin platforms.
This reverts commit ff6cc332dd6654620e3
Author: chaoren
Date: Thu Nov 5 12:49:03 2015
New Revision: 252183
URL: http://llvm.org/viewvc/llvm-project?rev=252183&view=rev
Log:
Use lldb::pid_t instead of pid_t.
Reviewers: granata.enrico
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14388
Modified:
lldb/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252183: Use lldb::pid_t instead of pid_t. (authored by
chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14388?vs=39384&id=39387#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14388
Fil
Author: zturner
Date: Thu Nov 5 12:38:02 2015
New Revision: 252181
URL: http://llvm.org/viewvc/llvm-project?rev=252181&view=rev
Log:
Python 3 - Apply 2to3 `filter` fixer to unittest2.
Modified:
lldb/trunk/third_party/Python/module/unittest2/unittest2/loader.py
Modified: lldb/trunk/third_par
chaoren created this revision.
chaoren added a reviewer: granata.enrico.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D14388
Files:
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSu
Hi Enrico,
Skipping files this way isn't working because of the way the LLVM build
system works (see:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8151/steps/cmake%20local/logs/stdio
)
Do you have any suggestion for a quick fix better then surrounding the
affected files
Author: enrico
Date: Thu Nov 5 12:23:10 2015
New Revision: 252179
URL: http://llvm.org/viewvc/llvm-project?rev=252179&view=rev
Log:
Do not build any of the simulator material on non-Darwin
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
Modified: lldb/trunk/source/Plugins
brucem added inline comments.
Comment at: scripts/Python/buildSwigPython.py:293
@@ +292,3 @@
+# LLDBWrapPython.cpp file.
+# Args:vDictArg - (R) Program input parameters.
+# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file.
I shouldn't hav
zturner added a comment.
Seems ok I suppose, I can't find any functional changes from eyeballing it
aside from the import changes. I'm still confused why `utilsDebug.py` even
worked before
Comment at: scripts/utilsDebug.py:14
@@ -16,2 +13,3 @@
# Python modules:
+import sys
brucem added a comment.
Even if it were, in some of the files, almost every line would change anyway
due to semicolons and then due to incorrect whitespace.
http://reviews.llvm.org/D14375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Would it be possible for you to break this up into patches that only run 1
fixer at a time? When I look at the diff, basically every line has a
change, so it's hard for me to verify that no actual substance changed, and
that this is all just style issues.
On Wed, Nov 4, 2015 at 11:42 PM Bruce Mit
zturner added a comment.
In http://reviews.llvm.org/D14342#282346, @tfiala wrote:
> Does this mean that if we import third party modules, and since you have
> embedded them into our package, that we would have to change third party code
> to adhere to our packaging structure? If not, fine. If
tfiala added a comment.
Does this mean that if we import third party modules, and since you have
embedded them into our package, that we would have to change third party code
to adhere to our packaging structure? If not, fine. If so, this was one of
the areas I mentioned that I was concerned
brucem added a reviewer: emaste.
brucem added a comment.
emaste, are you okay with this and willing to approve it?
It looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a reviewer: clayborg.
brucem added a comment.
I'd like to land this given approval.
Repository:
rL LLVM
http://reviews.llvm.org/D14037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
66 matches
Mail list logo
