Author: chaoren
Date: Wed Nov 4 21:30:45 2015
New Revision: 252143
URL: http://llvm.org/viewvc/llvm-project?rev=252143&view=rev
Log:
Fix build for platforms without ObjC++.
Reviewers: jingham, jasonmolenda
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14365
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252143: Fix build for platforms without ObjC++. (authored by
chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14365?vs=39305&id=39309#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1436
chaoren created this revision.
chaoren added reviewers: jingham, jasonmolenda.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D14365
Files:
source/Plugins/Platform/MacOSX/CMakeLists.txt
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Index:
sour
Yeah, it fails to build if we don't have objc too. I'll upload an update.
On Wed, Nov 4, 2015 at 6:12 PM, Jim Ingham wrote:
> Yeah, sure. But I bet you could figure out something to put in
> PlatformiOSSimulatorCoreSimulatorSupport.h that would cause this to fail to
> link except on OS X. Not
Author: chaoren
Date: Wed Nov 4 20:17:21 2015
New Revision: 252133
URL: http://llvm.org/viewvc/llvm-project?rev=252133&view=rev
Log:
Fix TestGoFormatters.py.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py
Modified:
lldb/trunk/packages/Python/lld
Yeah, sure. But I bet you could figure out something to put in
PlatformiOSSimulatorCoreSimulatorSupport.h that would cause this to fail to
link except on OS X. Not that that's likely, but as a general strategy it
seems wrong.
Jim
> On Nov 4, 2015, at 6:09 PM, Chaoren Lin wrote:
>
> There's
There's no simulator support outside of Darwin, so none of it should get
used anyway.
On Wed, Nov 4, 2015 at 6:08 PM, Jim Ingham wrote:
> In this case it's even a little weirder, 'cause we compile a source file
> that contains a class declaration (since the #if defined is after the
> #include),
In this case it's even a little weirder, 'cause we compile a source file that
contains a class declaration (since the #if defined is after the #include), but
not the methods that aren't inlined. Then presumably link in the .o file
containing whatever was the result of that compilation. That se
Yeah, I just looked at PlatformDarwinKernel.cpp as example for a quick fix.
I agree that kind of logic probably belongs in the CMakeLists.txt.
On Wed, Nov 4, 2015 at 6:02 PM, Jason Molenda wrote:
> You're making a valid point. I was only noting that this is not the first
> instance where've con
You're making a valid point. I was only noting that this is not the first
instance where've conditionally compiled mac platform files.
J
> On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote:
>
> Why?
>
> Jim
>
>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote:
>>
>> We do the same thing in oth
chaoren added a comment.
Yeah, it seems like it's been passing for gcc-4.9 for a while now. Thanks
for checking!
Repository:
rL LLVM
http://reviews.llvm.org/D12115
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
Yeah, it seems like it's been passing for gcc-4.9 for a while now. Thanks
for checking!
On Wed, Nov 4, 2015 at 5:15 PM, Dawn Perchik wrote:
> dawn marked an inline comment as done.
> dawn added a comment.
>
> In http://reviews.llvm.org/D12115#248069, @chaoren wrote:
>
> > Could you please take a
Why?
Jim
> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote:
>
> We do the same thing in other MacOSX platform files where they depend on
> Apple specific libraries.
>
>
>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits
>> wrote:
>>
>> Why are we trying to build this at all on Lin
Author: jingham
Date: Wed Nov 4 19:50:42 2015
New Revision: 252129
URL: http://llvm.org/viewvc/llvm-project?rev=252129&view=rev
Log:
Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in
place.
Modified:
lldb/trunk/include/lldb/lldb-forward.h
lldb/trunk/source/Plug
We do the same thing in other MacOSX platform files where they depend on Apple
specific libraries.
> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits
> wrote:
>
> Why are we trying to build this at all on Linux? Seems odd to build an empty
> file rather than just not build it.
>
> J
Why are we trying to build this at all on Linux? Seems odd to build an empty
file rather than just not build it.
Jim
> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits
> wrote:
>
> Author: chaoren
> Date: Wed Nov 4 19:23:19 2015
> New Revision: 252124
>
> URL: http://llvm.org/viewv
Author: zturner
Date: Wed Nov 4 19:33:54 2015
New Revision: 252127
URL: http://llvm.org/viewvc/llvm-project?rev=252127&view=rev
Log:
Python 3 - Don't use `os.path.walk`, it's removed in Py3.
It was deprecated even in 2.7, but not removed until 3.x. os.walk
provides all of the same functionality
Author: zturner
Date: Wed Nov 4 19:33:44 2015
New Revision: 252126
URL: http://llvm.org/viewvc/llvm-project?rev=252126&view=rev
Log:
Python 3 - Use universal_newlines=True in subprocess.Popen.
This follows the spirit of a previous patch which did essentially
the same thing. In Python 3, when yo
Author: chaoren
Date: Wed Nov 4 19:23:19 2015
New Revision: 252124
URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev
Log:
Fix build on Linux.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Modified:
lldb/trunk/source/Plugins/Plat
Author: jingham
Date: Wed Nov 4 19:18:07 2015
New Revision: 252122
URL: http://llvm.org/viewvc/llvm-project?rev=252122&view=rev
Log:
CommandObjectProxy needs to proxy GenerateHelpText as well as
everything else.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
lld
dawn marked an inline comment as done.
dawn added a comment.
In http://reviews.llvm.org/D12115#248069, @chaoren wrote:
> Could you please take a look at these issues?
>
> TestMiSymbol started to fail on Linux with gcc-4.9:
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds
Author: enrico
Date: Wed Nov 4 18:46:25 2015
New Revision: 252112
URL: http://llvm.org/viewvc/llvm-project?rev=252112&view=rev
Log:
Teach LLDB how to directly launch processes on the iOS simulator
This allows for command-line debugging of iOS simulator binaries (as long as UI
is not required, o
Author: jingham
Date: Wed Nov 4 18:38:39 2015
New Revision: 252111
URL: http://llvm.org/viewvc/llvm-project?rev=252111&view=rev
Log:
LLDB needs a mutex around getopt_long_only() function calls to avoid
multi-threading option parsing issues.
Modified:
lldb/trunk/include/lldb/Host/OptionPar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252109: Add go data formatters. (authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D13878?vs=37900&id=39288#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
lldb/t
Author: ribrdb
Date: Wed Nov 4 18:24:36 2015
New Revision: 252109
URL: http://llvm.org/viewvc/llvm-project?rev=252109&view=rev
Log:
Add go data formatters.
Differential Revision: http://reviews.llvm.org/D13878
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/
lldb/tr
Author: jingham
Date: Wed Nov 4 18:24:18 2015
New Revision: 252108
URL: http://llvm.org/viewvc/llvm-project?rev=252108&view=rev
Log:
AddInitialArguments -> AddArguments, and we pass in the struct_address and push
it too. All the
callers had to do this by hand and we ended up never actually addi
Author: jingham
Date: Wed Nov 4 18:22:19 2015
New Revision: 252106
URL: http://llvm.org/viewvc/llvm-project?rev=252106&view=rev
Log:
One of the File constructors was missing initializers. Didn't seem
to cause any problems, but still...
Modified:
lldb/trunk/include/lldb/Host/File.h
Modified
Author: amccarth
Date: Wed Nov 4 17:47:55 2015
New Revision: 252100
URL: http://llvm.org/viewvc/llvm-project?rev=252100&view=rev
Log:
Fix x64 build on Windows, which was broken by my refactor from last week.
No build bots build x64 on Windows yet, but this was spotted by another
developer who e
Author: davide
Date: Wed Nov 4 17:12:17 2015
New Revision: 252094
URL: http://llvm.org/viewvc/llvm-project?rev=252094&view=rev
Log:
[FreeBSD] Add missing overrides.
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBS
Author: zturner
Date: Wed Nov 4 17:03:10 2015
New Revision: 252091
URL: http://llvm.org/viewvc/llvm-project?rev=252091&view=rev
Log:
Don't access class members inside of `__del__`.
Apparently this doesn't work as the attribute doesn't exist anymore.
Modified:
lldb/trunk/scripts/utilsDebug.p
Author: zturner
Date: Wed Nov 4 17:03:21 2015
New Revision: 252092
URL: http://llvm.org/viewvc/llvm-project?rev=252092&view=rev
Log:
Handle keyword args on our patched Popen methods.
Python 3 introduces the `timeout` keyword argument on Popen.wait().
If our patched version doesn't support keywor
Author: davide
Date: Wed Nov 4 15:31:16 2015
New Revision: 252079
URL: http://llvm.org/viewvc/llvm-project?rev=252079&view=rev
Log:
[Core] Avoid default in switch() that covers all the cases.
Unbreak the build for FreeBSD + -Werror.
Modified:
lldb/trunk/source/Core/ValueObject.cpp
Modified
Author: jingham
Date: Wed Nov 4 14:32:27 2015
New Revision: 252072
URL: http://llvm.org/viewvc/llvm-project?rev=252072&view=rev
Log:
Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero
out
the Expression ResultVariable so it's in a known initial state.
Modified:
Author: tberghammer
Date: Wed Nov 4 13:39:32 2015
New Revision: 252067
URL: http://llvm.org/viewvc/llvm-project?rev=252067&view=rev
Log:
Revert r252001 as it brake TestCppIncompleteTypes on all platforms
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified:
Author: tberghammer
Date: Wed Nov 4 13:32:01 2015
New Revision: 252065
URL: http://llvm.org/viewvc/llvm-project?rev=252065&view=rev
Log:
Fix TestMemoryRead after r252035
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.cpp
Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
Enable absolute imports in lldbsuite.
Absolute imports were introduced in Python 2.5 as a feature
(e.g. from __future__ import absolute_import), and made default
in Python 3.
artagnon added a comment.
Okay, so run this on the current HEAD:
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- C
Author: tfiala
Date: Wed Nov 4 12:10:31 2015
New Revision: 252059
URL: http://llvm.org/viewvc/llvm-project?rev=252059&view=rev
Log:
OS X: fix the Xcode debugserver lookup code when LLDB.framework does not
contain a debugserver
LLDB recently started supporting LLDB.framework without a
debugserve
tfiala added a comment.
I think this got checked in, right?
http://reviews.llvm.org/D14157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I think this went in, right?
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I'll have a look. How do I test it, @artagnon?
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Nov 4 11:10:40 2015
New Revision: 252058
URL: http://llvm.org/viewvc/llvm-project?rev=252058&view=rev
Log:
Fix test infrastructure when using xunit output.
Our test reporting infrastructure needed module names to change based on the
python package layout.
Modified:
42 matches
Mail list logo
