Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

2015-10-27 Thread Mateusz Kocielski via lldb-commits
akat1 added a subscriber: akat1. akat1 added a comment. I've compiled it successfully on: Distributor ID: Ubuntu Description:Ubuntu 14.04.3 LTS Release:14.04 Codename: trusty Linux AAH 3.13.0-46-generic #75-Ubuntu SMP Tue Feb 10 15:24:04 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD

2015-10-27 Thread Mateusz Kocielski via lldb-commits
akat1 added a subscriber: akat1. akat1 added a comment. I've compiled it successfully on: Distributor ID: Ubuntu Description:Ubuntu 14.04.3 LTS Release:14.04 Codename: trusty Linux AAH 3.13.0-46-generic #75-Ubuntu SMP Tue Feb 10 15:24:04 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

[Lldb-commits] [lldb] r251470 - Fix Clang-tidy modernize-use-nullptr warnings in some files in include/lldb/Core; other minor fixes.

2015-10-27 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Tue Oct 27 19:18:41 2015 New Revision: 251470 URL: http://llvm.org/viewvc/llvm-project?rev=251470&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in include/lldb/Core; other minor fixes. Modified: lldb/trunk/include/lldb/Core/Address.h

[Lldb-commits] [lldb] r251462 - Fix line endings to be LF instead of CRLF.

2015-10-27 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Oct 27 17:54:46 2015 New Revision: 251462 URL: http://llvm.org/viewvc/llvm-project?rev=251462&view=rev Log: Fix line endings to be LF instead of CRLF. Modified: lldb/trunk/packages/Python/lldbsuite/__init__.py lldb/trunk/packages/Python/lldbsuite/test/__init__.py

Re: [Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

2015-10-27 Thread Zachary Turner via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251460: Preparation for turning lldbsuite into a Python package. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D14131?vs=38600&id=38606#toc Repository: rL LLVM http://revie

[Lldb-commits] [lldb] r251460 - Preparation for turning lldbsuite into a Python package.

2015-10-27 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Oct 27 17:33:47 2015 New Revision: 251460 URL: http://llvm.org/viewvc/llvm-project?rev=251460&view=rev Log: Preparation for turning lldbsuite into a Python package. The idea behind this patch is to expose the meat of LLDB's Python infrastructure (test suite, scripts, etc

[Lldb-commits] LLVM buildmaster will be restarted tonight

2015-10-27 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

2015-10-27 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D14131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

2015-10-27 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 38600. zturner added a comment. Fixed `lldbsuite` module initialization. I'm having to do this all by eye / memory since this code isn't actually exercised yet until the move actually happens. http://reviews.llvm.org/D14131 Files: packages/Python/lldbs

[Lldb-commits] [lldb] r251457 - Fix editline unindentation code for more recent libedits.

2015-10-27 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Oct 27 16:53:39 2015 New Revision: 251457 URL: http://llvm.org/viewvc/llvm-project?rev=251457&view=rev Log: Fix editline unindentation code for more recent libedits. This code was modifying the cursor and then expecting the editline API call to see the effect for the next

Re: [Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

2015-10-27 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 38595. zturner added a comment. Moved `progress.py` from `lldb/test` to `lldb/third_party`. This seems to be a third party module that had also snuck into the test folder. It's used by both `unittest2` and `dosep.py` so it has to be in `third_party` to be

[Lldb-commits] [PATCH] D14131: Preparation for making a Python package out of lldb's Python code

2015-10-27 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, tfiala. zturner added a subscriber: lldb-commits. See the thread in lldb-dev for context. After this patch, the remaining piece of work is to literally move `lldb/test` to `lldb/packages/Python/lldbsuite/test` and apply 1 or 2 fix

Re: [Lldb-commits] [PATCH] D14126: Make lldb-gdbserver to take explicit socket scheme as command line argument

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov updated this revision to Diff 38588. ovyalov added a comment. Addressed review comments - please take another look. http://reviews.llvm.org/D14126 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicati

Re: [Lldb-commits] [PATCH] D14126: Make lldb-gdbserver to take explicit socket scheme as command line argument

2015-10-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Need to make a copy of socket_scheme in GDBRemoteCommunicationServerPlatform (save it to a std::string). Comment at: source/Plugins/Process/gdb-remote/GDBRemot

Re: [Lldb-commits] [PATCH] D14127: Use accept4 workaround for MIPS Android build.

2015-10-27 Thread Chaoren Lin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251439: Use accept4 workaround for MIPS Android build. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D14127?vs=38581&id=38582#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [lldb] r251439 - Use accept4 workaround for MIPS Android build.

2015-10-27 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Tue Oct 27 14:17:35 2015 New Revision: 251439 URL: http://llvm.org/viewvc/llvm-project?rev=251439&view=rev Log: Use accept4 workaround for MIPS Android build. Summary: Similar to http://reviews.llvm.org/rL242319, which was for ARM. Reviewers: chying, ovyalov Subscribers: a

[Lldb-commits] [PATCH] D14127: Use accept4 workaround for MIPS Android build.

2015-10-27 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added reviewers: chying, ovyalov. chaoren added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Similar to http://reviews.llvm.org/rL242319, which was for ARM. http://reviews.llvm.org/D14127 Files: cmake/pl

[Lldb-commits] [PATCH] D14126: Make lldb-gdbserver to take explicit socket scheme as command line argument

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added a reviewer: clayborg. ovyalov added a subscriber: lldb-commits. Make lldb-gdbserver to take explicit socket scheme as command line argument - so lldb gdb-server uses the same socket type as platform does. http://reviews.llvm.org/D14126 Files: sourc

[Lldb-commits] [lldb] r251426 - Include to fix build errors.

2015-10-27 Thread Hafiz Abid Qadeer via lldb-commits
Author: abidh Date: Tue Oct 27 12:56:23 2015 New Revision: 251426 URL: http://llvm.org/viewvc/llvm-project?rev=251426&view=rev Log: Include to fix build errors. This file uses things like fprintf and stderr and is the right header to include. I was getting build errors without it. Modified:

Re: [Lldb-commits] [PATCH] D14101: Treat hostname in android URL as device id unless it matches "localhost"

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov closed this revision. ovyalov added a comment. Submitted as http://reviews.llvm.org/rL251422 http://reviews.llvm.org/D14101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r251422 - Treat hostname in android URL as device id unless it matches "localhost".

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Tue Oct 27 12:41:34 2015 New Revision: 251422 URL: http://llvm.org/viewvc/llvm-project?rev=251422&view=rev Log: Treat hostname in android URL as device id unless it matches "localhost". http://reviews.llvm.org/D14101 Modified: lldb/trunk/source/Plugins/Platform/Android

[Lldb-commits] [lldb] r251421 - Add a file in Makefile build which is present in CMake build.

2015-10-27 Thread Hafiz Abid Qadeer via lldb-commits
Author: abidh Date: Tue Oct 27 12:39:22 2015 New Revision: 251421 URL: http://llvm.org/viewvc/llvm-project?rev=251421&view=rev Log: Add a file in Makefile build which is present in CMake build. Since 219143, this file is missing from Makefile build. Committed as obvious. Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket protocol to find an appropriate implementation class.

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/include/lldb/Host/Socket.h /lldb/trunk/include/lldb/Host/common/UDPSocket.h /lldb/trunk/source/Host/common/Socket.cpp /lldb/trunk/tools/lldb-server/Acceptor.cpp /lldb/trunk/tools/lldb-server/Acceptor.h Users:

[Lldb-commits] [lldb] r251417 - Add Socket::Create factory method which uses socket protocol to find an appropriate implementation class.

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Tue Oct 27 12:32:01 2015 New Revision: 251417 URL: http://llvm.org/viewvc/llvm-project?rev=251417&view=rev Log: Add Socket::Create factory method which uses socket protocol to find an appropriate implementation class. http://reviews.llvm.org/D14085 Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D14101: Treat hostname in android URL as device id unless it matches "localhost"

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. In http://reviews.llvm.org/D14101#275946, @labath wrote: > I like this. (I assume it will work with the tcp-connected devices which have > an ID like `???:port`) Yes - definitely. http://reviews.llvm.org/D14101 ___ lldb-

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-10-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. Looks good - minor comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:513 @@ +512,3 @@ +{ +FileSpec file_spec; +file_spec.SetFile("[vdso]", false); ---

[Lldb-commits] [lldb] r251416 - Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/DataFormatters, Breakpoint and Utility; other minor fixes.

2015-10-27 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Tue Oct 27 12:20:33 2015 New Revision: 251416 URL: http://llvm.org/viewvc/llvm-project?rev=251416&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/DataFormatters, Breakpoint and Utility; other minor fixes. Modified: lldb/trunk/include/ll

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-10-27 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I don't know anything about shared library loading on Linux. http://reviews.llvm.org/D14118 ___ lldb-commits mailing list lldb-commits@lists.llvm.

Re: [Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2015-10-27 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg edited reviewers, added: spyffe, jingham; removed: clayborg. clayborg added a comment. Lets let Sean Callanan and Jim Ingham make sure this is good as they are the expression parser masters. Repository: rL LLVM http://reviews.llvm.org/D14111

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-10-27 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with a few minor suggestions inline Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:578-579 @@ +577,4 @@ +} + +ret

[Lldb-commits] [lldb] r251403 - Fix MSVC build after r251402

2015-10-27 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Oct 27 05:56:35 2015 New Revision: 251403 URL: http://llvm.org/viewvc/llvm-project?rev=251403&view=rev Log: Fix MSVC build after r251402 Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp Modified: lldb/trunk/source/Plugins/Language/CPl

Re: [Lldb-commits] [PATCH] D14088: Some minor improvements on the symtab parsing code

2015-10-27 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251402: Some minor improvements on the symtab parsing code (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D14088?vs=38445&id=38520#toc Repository: rL LLVM http://reviews

[Lldb-commits] [lldb] r251402 - Some minor improvements on the symtab parsing code

2015-10-27 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Oct 27 05:43:27 2015 New Revision: 251402 URL: http://llvm.org/viewvc/llvm-project?rev=251402&view=rev Log: Some minor improvements on the symtab parsing code * Remove an unneccessary re-computaion on arch spec from the ELF file * Use a local cache to optimize name b

[Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2015-10-27 Thread Bhushan Attarde via lldb-commits
bhushan created this revision. bhushan added a reviewer: clayborg. bhushan added subscribers: nitesh.jain, sagar, mohit.bhakkad, jaydeep, lldb-commits. bhushan set the repository for this revision to rL LLVM. There is a issue (llvm assertion) in evaluating expressions for MIPS on Linux. (lldb) p

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-27 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251400: Deprecate -m/+m dotest options in favor of test categories (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14060?vs=38389&id=38516#toc Repository: rL LLVM http://revi

[Lldb-commits] [lldb] r251400 - Deprecate -m/+m dotest options in favor of test categories

2015-10-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 27 04:34:34 2015 New Revision: 251400 URL: http://llvm.org/viewvc/llvm-project?rev=251400&view=rev Log: Deprecate -m/+m dotest options in favor of test categories Summary: This change deprecates -m/+m dotest options (the options are still recognized but they print an

Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

2015-10-27 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251399: Fix race condition in process resume (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14083?vs=38429&id=38515#toc Repository: rL LLVM http://reviews.llvm.org/D14083 F

[Lldb-commits] [lldb] r251399 - Fix race condition in process resume

2015-10-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 27 04:23:55 2015 New Revision: 251399 URL: http://llvm.org/viewvc/llvm-project?rev=251399&view=rev Log: Fix race condition in process resume Summary: Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message *before* actually sending out the continue

Re: [Lldb-commits] [PATCH] D14101: Treat hostname in android URL as device id unless it matches "localhost"

2015-10-27 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like this. (I assume it will work with the tcp-connected devices which have an ID like `???:port`) http://reviews.llvm.org/D14101 ___ lldb-com