This revision was automatically updated to reflect the committed changes.
Closed by commit rL250494: Fix build with python disabled after r249597
(authored by kfischer).
Changed prior to commit:
http://reviews.llvm.org/D13577?vs=36918&id=37557#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: kfischer
Date: Fri Oct 16 00:21:23 2015
New Revision: 250494
URL: http://llvm.org/viewvc/llvm-project?rev=250494&view=rev
Log:
Fix build with python disabled after r249597
Summary: r249597 introduced a usage of GetTypeSummary in lldb-mi.
That function used to only be available when python
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250493: Add a missing Mutex Locker in
ResetCurrentInlinedDepth (authored by kfischer).
Changed prior to commit:
http://reviews.llvm.org/D13638?vs=37050&id=37556#toc
Repository:
rL LLVM
http://review
Author: kfischer
Date: Fri Oct 16 00:17:25 2015
New Revision: 250493
URL: http://llvm.org/viewvc/llvm-project?rev=250493&view=rev
Log:
Add a missing Mutex Locker in ResetCurrentInlinedDepth
Summary: This function reads m_frames, so it needs to lock the
mutex like all other function that access m_
Author: jmolenda
Date: Thu Oct 15 20:27:21 2015
New Revision: 250487
URL: http://llvm.org/viewvc/llvm-project?rev=250487&view=rev
Log:
I've been seeing a problem with xcodebuilds on macosx for
a few days now where compiler-rt gets an error when trying
to run its install step (related to not being
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250485: [LLDB] Fix Clang-tidy misc-use-override warnings in
remaining files in… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13681?vs=37195&id=37551#toc
Repository:
Author: eugenezelenko
Date: Thu Oct 15 20:11:37 2015
New Revision: 250485
URL: http://llvm.org/viewvc/llvm-project?rev=250485&view=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in remaining files in include;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13681
Mo
zturner updated this revision to Diff 37546.
zturner added a comment.
Fixed indentation
http://reviews.llvm.org/D13794
Files:
scripts/Python/python-typemaps.swig
source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
Inde
zturner created this revision.
zturner added reviewers: clayborg, granata.enrico.
zturner added a subscriber: lldb-commits.
Handling of Python files is different in Python 3, to the point that it is
unwieldy to try to write native C API calls in places that need to use files.
A new type of pyth
Author: gclayton
Date: Thu Oct 15 19:34:18 2015
New Revision: 250478
URL: http://llvm.org/viewvc/llvm-project?rev=250478&view=rev
Log:
More general fixes to the tree view and BoxedPanel.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
http://llvm.org/vi
Author: eugenezelenko
Date: Thu Oct 15 19:17:35 2015
New Revision: 250476
URL: http://llvm.org/viewvc/llvm-project?rev=250476&view=rev
Log:
Test commit. Part of:
[LLDB] Fix Clang-tidy misc-use-override warnings in remaining files in include;
other minor fixes.
Differential Revision: http://revi
Author: ovyalov
Date: Thu Oct 15 18:54:09 2015
New Revision: 250474
URL: http://llvm.org/viewvc/llvm-project?rev=250474&view=rev
Log:
Split Socket class into Tcp/Udp/DomainSocket subclasses.
http://reviews.llvm.org/D13754
Added:
lldb/trunk/include/lldb/Host/common/TCPSocket.h
lldb/trunk
clayborg added a comment.
For the public API you will need both and not have a default arg.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL250467: Factor the execution of the test method into a
separate function to ensure… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D1
amccarth added a comment.
Nice catch on the comment.
Repository:
rL LLVM
http://reviews.llvm.org/D13788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: amccarth
Date: Thu Oct 15 17:39:55 2015
New Revision: 250467
URL: http://llvm.org/viewvc/llvm-project?rev=250467&view=rev
Log:
Factor the execution of the test method into a separate function to ensure that
any exceptions that are thrown go out of scope and no longer hold references to
S
zturner added a subscriber: zturner.
zturner accepted this revision.
zturner added a reviewer: zturner.
Comment at: test/lldbtest.py:2548-2550
@@ -2546,1 +2547,5 @@
+# Ensure all the references to SB objects have gone away so that we can
+# be sure that all the m
sivachandra added a comment.
I did this experiment before setting off:
class A
{
public:
int method();
int method(int a = 10);
};
int
A::method()
{
return 10;
}
int
A::method(int a)
{
return a + 10;
}
int
main()
{
A a;
return a.method
Author: sas
Date: Thu Oct 15 17:24:17 2015
New Revision: 250465
URL: http://llvm.org/viewvc/llvm-project?rev=250465&view=rev
Log:
Minor indentation fix in StackFrameList.cpp.
Modified:
lldb/trunk/source/Target/StackFrameList.cpp
Modified: lldb/trunk/source/Target/StackFrameList.cpp
URL:
htt
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Adrian. Thanks!
http://reviews.llvm.org/D13788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r234610
http://reviews.llvm.org/D8977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner accepted this revision.
zturner added a comment.
Looks good.
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added inline comments.
Comment at: source/Host/common/Socket.cpp:356
@@ -740,3 +355,3 @@
-uint16_t Socket::GetLocalPortNumber(const NativeSocket& socket)
+size_t Socket::Send(const void *buf, const size_t num_bytes)
{
Good point - done.
===
ovyalov updated this revision to Diff 37525.
ovyalov marked 3 inline comments as done.
ovyalov added a comment.
Addressed review suggestions.
Please take another look.
http://reviews.llvm.org/D13754
Files:
include/lldb/Host/Socket.h
include/lldb/Host/common/TCPSocket.h
include/lldb/Host/c
sivachandra added a comment.
Ah, I did not notice PyCallable::GetNumArguments before you drew my attention
to it. It seems to be using internals of PyCodeObject. When I said "no
easy/clean way", I was talking about avoiding such a usage. If that is
acceptable, I am fine with it. I will modify t
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
This solves problems in tearDown of individual test cases, which were
especially noticeable on Windows.
When a test throws an exception, the exception retains references to the
function
granata.enrico added a comment.
One alternative would be to have the num_children method on the synthetic
provider itself be able to take an optional argument that is the max_count.
That is, instead of defining
def num_children(self):
..
You would instead define
def num_children(self,
clayborg added a comment.
Stopping the threads is fine as it seems to be desired from most others.
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added a comment.
I did consider the option of adding a new method GetNumChildren (uint32_t max =
UINT32_MAX). This if fine from SBValue point of view. But from a the scripted
synthetic provider point of view, I am not sure there is an easy/clean way of
checking whether the num_child
tberghammer added a comment.
In http://reviews.llvm.org/D13727#268233, @zturner wrote:
> In http://reviews.llvm.org/D13727#268086, @clayborg wrote:
>
> > > Yes. But an implementation of std::async is either going to use a global
> > > thread pool or it's not. If it does there's no problem, and
sivachandra abandoned this revision.
sivachandra added a comment.
This was from the time when I did not have commit access. sbest committed this
for me separately.
http://reviews.llvm.org/D6122
___
lldb-commits mailing list
lldb-commits@lists.llvm.
clayborg added a comment.
If you still care about this, please resubmit against current sources.
http://reviews.llvm.org/D6122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In http://reviews.llvm.org/D13727#268086, @clayborg wrote:
> > Yes. But an implementation of std::async is either going to use a global
> > thread pool or it's not. If it does there's no problem, and if it doesn't,
> > it's going to create one thread for each call, an
tfiala added a comment.
In http://reviews.llvm.org/D13727#268096, @clayborg wrote:
> In http://reviews.llvm.org/D13727#268091, @tberghammer wrote:
>
> > I agree that parking the threads in the kernel should be very cheap (I am
> > not sure about Windows) but on high end multi core machines havin
Author: tfiala
Date: Thu Oct 15 15:32:25 2015
New Revision: 250454
URL: http://llvm.org/viewvc/llvm-project?rev=250454&view=rev
Log:
Fixup previous commit.
Looks like I blasted something into my editor...
Modified:
lldb/trunk/test/lldb_pylint_helper.py
Modified: lldb/trunk/test/lldb_pylint_
Author: tfiala
Date: Thu Oct 15 15:27:23 2015
New Revision: 250453
URL: http://llvm.org/viewvc/llvm-project?rev=250453&view=rev
Log:
Modify pylint/flake8 path helper to add lldb python module to path.
It was adding all the test infrastructure paths properly, but it
was not adding the lldb module.
clayborg added a comment.
I would almost rather change the GetNumChildren() to take a "max" param:
class SBValue
{
uint32_t
GetNumChildren ();
uint32_t
GetNumChildren (uint32_t max = UINT32_MAX);
};
We need to keep the other one so that our public API still has
Author: zturner
Date: Thu Oct 15 14:35:48 2015
New Revision: 250444
URL: http://llvm.org/viewvc/llvm-project?rev=250444&view=rev
Log:
Introduce a `PythonFile` object, and use it everywhere.
Python file handling got an overhaul in Python 3, and it affects
the way we have to interact with files. N
On Thu, Oct 15, 2015 at 11:59 AM, Enrico Granata
wrote:
> granata.enrico added a comment.
>
> So, if I understand this correctly, this HasChildAtIndex() API returns a
> three-state int:
>
> 1 == yes I do
> 0 == no I do not
> -1 == maybe, can't tell
>
> When would you ever run into the -1 case? It
granata.enrico added a comment.
So, if I understand this correctly, this HasChildAtIndex() API returns a
three-state int:
1 == yes I do
0 == no I do not
-1 == maybe, can't tell
When would you ever run into the -1 case? It seems you're mostly using it as an
invalid marker. Would 0 not be a bett
sivachandra added a comment.
Ah, we want this exposed in the SBValue API. What I mean't in the earlier
message was that no other part of LLDB will functionally depend/lookup/expect
this "feature".
http://reviews.llvm.org/D13778
___
lldb-commits ma
granata.enrico requested changes to this revision.
granata.enrico added a comment.
This revision now requires changes to proceed.
If so, why do you need this to be exposed as a call that LLDB knows about?
You are free to provide any methods you want in your synthetic child providers.
Adding them
sivachandra added a comment.
Yes, we would like to use this is specific synthetic providers. It will not be
used by any part of LLDB internally.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
granata.enrico added a comment.
Is it possible to ask for concrete examples?
As in, for example, do you plan to change ValueObjectPrinter to use this API in
some way?
Or do you have any specific synthetic providers that you would like to use this
API in?
http://reviews.llvm.org/D13778
sivachandra added a comment.
As I mentioned in the first post, this is the use case:
Synthetic child providers currently have a method "has_children" and
"get_num_children". While the former is good enough to know if there are
children, it does not give any insight into how many children there ar
granata.enrico added a comment.
What do you plan to use this has_child_at_index call for?
My concern is that it adds complication to the synthetic child provider
interface. Yes, I understand it is optional, but it seems like yet another
thing in the "any children?" realm that I would rather muc
sivachandra added a comment.
If the general idea in this patch is OK, I will update it with tests.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra created this revision.
sivachandra added reviewers: clayborg, granata.enrico.
sivachandra added a subscriber: lldb-commits.
Along with this, support for an optional Python synthetic child provider
method "has_child_at_index" has also been added. These have been added
with the following
This may or may not be relevant, but the stack size for std::thread on
OS X is a fixed size of 512KB (DEFAULT_STACK_SIZE in pthread.c).
There's no way to specify a stack size with std::thread and no
per-process override like I think you can do with rlimit on Linux.
It's an issue I ran into when imp
tberghammer added a comment.
I agree that parking the threads in the kernel should be very cheap (I am not
sure about Windows) but on high end multi core machines having 40+ threads
around just to wait for work is a bit strange for me too and it definitely
makes debugging of LLDB more difficult
clayborg added a comment.
In http://reviews.llvm.org/D13727#268091, @tberghammer wrote:
> I agree that parking the threads in the kernel should be very cheap (I am not
> sure about Windows) but on high end multi core machines having 40+ threads
> around just to wait for work is a bit strange fo
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Fine to get it in
http://reviews.llvm.org/D13657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
granata.enrico accepted this revision.
granata.enrico added a comment.
Looks fine to me
Repository:
rL LLVM
http://reviews.llvm.org/D13577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
clayborg added a comment.
In http://reviews.llvm.org/D13727#268084, @tberghammer wrote:
> Addressing comments from the discussion with destroying the treads not in use
> while keeping a global thread pool with at most hardware_concurrency threads.
We should perf test this, but I would be OK wi
tberghammer updated this revision to Diff 37498.
tberghammer added a comment.
Addressing comments from the discussion with destroying the treads not in use
while keeping a global thread pool with at most hardware_concurrency threads.
IMO this update also simplifies the implementation of the Thre
clayborg added a comment.
> Yes. But an implementation of std::async is either going to use a global
> thread pool or it's not. If it does there's no problem, and if it doesn't,
> it's going to create one thread for each call, and when the work in that
> thread is done, the thread will exit.
zturner added a comment.
In http://reviews.llvm.org/D13727#268066, @clayborg wrote:
> In http://reviews.llvm.org/D13727#268053, @zturner wrote:
>
> > The main thought I had was just that it would make the code simpler and
> > delegate more of the synchronization stuff to the library. But if we
clayborg added a comment.
In http://reviews.llvm.org/D13727#268053, @zturner wrote:
> The main thought I had was just that it would make the code simpler and
> delegate more of the synchronization stuff to the library. But if we don't
> get any of that benefit then I guess there's no point in
tfiala added a subscriber: tfiala.
tfiala added a comment.
In http://reviews.llvm.org/D13727#268053, @zturner wrote:
> The main thought I had was just that it would make the code simpler and
> delegate more of the synchronization stuff to the library. But if we don't
> get any of that benefit
clayborg accepted this revision.
clayborg added a comment.
Very nice! I look forward to seeing this patch and the associated DWARF patches
make it in!
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
zturner added a comment.
The main thought I had was just that it would make the code simpler and
delegate more of the synchronization stuff to the library. But if we don't get
any of that benefit then I guess there's no point in doing that.
That said, I really dont' want to see 48 threads runn
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: include/lldb/Target/UnixSignals.h:101-102
@@ -100,1 +100,4 @@
+ConstString
+GetShortName(ConstString name) const;
+
-
Author: tfiala
Date: Thu Oct 15 11:35:59 2015
New Revision: 250426
URL: http://llvm.org/viewvc/llvm-project?rev=250426&view=rev
Log:
Fix broken assert in DWARFDIE.cpp on OS X
See:
http://reviews.llvm.org/D13777
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Modified: lldb
tfiala closed this revision.
tfiala added a comment.
Closed by commit:
$ svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Transmitting file data .
Committed revision 250426.
http://reviews.llvm.org/D13777
___
lldb-comm
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D13777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer added a comment.
Zach: I thought about your idea and I think it won't make the code any simpler
because your suggestion would only implement the functionality what is
currently implemented by TaskPool and TaskPoolImpl what is using only a single
condition variable and a single queue
tberghammer updated this revision to Diff 37492.
tberghammer marked 7 inline comments as done.
tberghammer added a comment.
- Address review comments
- Add some more documentation
- Add some unit tests
http://reviews.llvm.org/D13727
Files:
include/lldb/Utility/TaskPool.h
source/Utility/CMak
tfiala created this revision.
tfiala added a reviewer: tberghammer.
tfiala added a subscriber: lldb-commits.
This addresses an assert that has started firing recently on the OS X test
suite.
The change was proposed by the assert's author, Tamas Berghammer. (Thanks for
the fix, Tamas!)
http://
evgeny777 updated this revision to Diff 37487.
evgeny777 added a comment.
Updated: callback is checked for null + explicit construction
http://reviews.llvm.org/D13657
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
Index: source/API/SBTypeSummary.cpp
==
labath added a comment.
This looks much better, I just have a couple of small remarks.
Comment at: include/lldb/Target/UnixSignals.h:116
@@ -114,1 +115,3 @@
+ const char *description,
+ const char *alias = NULL);
nullptr
==
labath created this revision.
labath added reviewers: clayborg, tberghammer.
labath added subscribers: emaste, lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
On linux, the environment variables for temp directories that lldb checks for
are generally not
defined, and the
Author: labath
Date: Thu Oct 15 09:46:46 2015
New Revision: 250412
URL: http://llvm.org/viewvc/llvm-project?rev=250412&view=rev
Log:
Revert "Fix temporary directory computation on linux (pr25147)"
I actually did not want to commit this without review, but I mistyped. :/
Modified:
lldb/trunk/
Author: labath
Date: Thu Oct 15 09:44:29 2015
New Revision: 250409
URL: http://llvm.org/viewvc/llvm-project?rev=250409&view=rev
Log:
Fix temporary directory computation on linux (pr25147)
On linux, the environment variables for temp directories that lldb checks for
are generally not
defined, and
Author: aidandodds
Date: Thu Oct 15 06:42:20 2015
New Revision: 250391
URL: http://llvm.org/viewvc/llvm-project?rev=250391&view=rev
Log:
Superficial fix for the windows build when building with LLDB_DISABLE_PYTHON.
The definition of lldb::SBTypeSummary and some methods of lldb::SBValue are
hidd
mohit.bhakkad updated this revision to Diff 37469.
mohit.bhakkad added a comment.
Herald added a subscriber: dsanders.
Changes in this revision:
- Added alias as new argument for AddSignal.
- removed shortname as hardcoded argument, as for alias we would need another
shortname. Now generating sh
EwanCrawford added a comment.
Unfortunately there isn't a user-visible variable for the allocation.
Information regarding the allocation as a whole is maintained by the runtime.
Within a RS kernel invocation the user only has access to the raw data at a
specific cell in the allocation, which is
labath accepted this revision.
labath added a comment.
Looks good, with some random comments you can ignore.
Comment at: include/lldb/Host/Socket.h:55
@@ -55,1 +54,3 @@
+virtual Error Connect(llvm::StringRef host_and_port);
+virtual Error Listen(llvm::StringRef host_an
Author: abidh
Date: Thu Oct 15 03:27:01 2015
New Revision: 250380
URL: http://llvm.org/viewvc/llvm-project?rev=250380&view=rev
Log:
Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
Summary:
I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc
4.9 on Linux.
"warning: ca
78 matches
Mail list logo
