evgeny777 accepted this revision.
evgeny777 added a comment.
This revision is now accepted and ready to land.
Lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D13577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
Author: mohit.bhakkad
Date: Fri Oct 9 01:34:52 2015
New Revision: 249809
URL: http://llvm.org/viewvc/llvm-project?rev=249809&view=rev
Log:
Addressing warning due to rL249651
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp
Modified: lldb/trunk/source/Plugins/I
brucem added a subscriber: brucem.
brucem added a comment.
Getting rid of a lot of the `#ifndef LLDB_DISABLE_PYTHON` checks had been on my
list of things I wanted to clean up. Since you regularly build with this
configuration (and I never do), I suspect that a lot more of those checks could
go
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249806: Fix handling of LLDB_VERS_GENERATED_FILE. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13552?vs=36851&id=36923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D135
Author: brucem
Date: Thu Oct 8 22:40:55 2015
New Revision: 249806
URL: http://llvm.org/viewvc/llvm-project?rev=249806&view=rev
Log:
Fix handling of LLDB_VERS_GENERATED_FILE.
Summary:
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything t
jasonmolenda created this revision.
jasonmolenda added a reviewer: tberghammer.
jasonmolenda added subscribers: lldb-commits, clayborg.
jasonmolenda set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
This patch is to address a few issues I came up with w
loladiro created this revision.
loladiro added reviewers: evgeny777, ki.stfu, granata.enrico, clayborg.
loladiro added a subscriber: lldb-commits.
loladiro set the repository for this revision to rL LLVM.
r249597 introduced a usage of GetTypeSummary in lldb-mi. That function used to
only be avail
dawn accepted this commit.
dawn added a comment.
This test is no longer failing.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
dawn accepted this commit.
dawn added a comment.
The filing test was removed by Greg in r249613.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
This breaks 2 tests on linux:
Failing Tests (2)
FAIL: LLDB (suite) :: TestMiBreak.py
FAIL: LLDB (suite) :: TestSettings.py
On Thu, Oct 8, 2015 at 4:07 PM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Thu Oct 8 18:07:53 2015
> New Revision: 249769
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Works great! Please commit. (Sorry for delay - I ran into problems with clang
crashing on me for unknown reasons - finally got the build working again so I
could test).
http://reviews.llvm.org
Eugene.Zelenko added a comment.
I make whitespaces more consistent.
Space between function names and round bracket is consistent with Clang-format
settings for LLDB.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
___
lldb-commits mailing li
brucem added a comment.
I'd like to hear from @clayborg about the whitespace changes here.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: spyffe
Date: Thu Oct 8 18:07:53 2015
New Revision: 249769
URL: http://llvm.org/viewvc/llvm-project?rev=249769&view=rev
Log:
Added support for enumerating the languages that actually support TypeSystems
and expressions. Also wired that into the OptionValue infrastructure, although
it isn'
Author: jmolenda
Date: Thu Oct 8 16:48:35 2015
New Revision: 249755
URL: http://llvm.org/viewvc/llvm-project?rev=249755&view=rev
Log:
Re-commit the (fixed) changes from r248985 which were reverted by Pavel
when they introduced android testsuite regressions. Pavel has run the
testsuite against th
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
Author: gclayton
Date: Thu Oct 8 16:04:34 2015
New Revision: 249747
URL: http://llvm.org/viewvc/llvm-project?rev=249747&view=rev
Log:
Moved the target specific ClangASTContext initialization over into
ClangASTContext::CreateInstance.
This involved changing the TypeSystem::CreateInstance to take
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 02.10.2015 12:15, Kamil Rytarowski via lldb-commits wrote:
> On 02.10.2015 10:07, Ed Maste wrote:
>> On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
>> wrote:
>>>
>>> Yes, please! Better incomplete support in the source trees
>>>
dawn added a comment.
Hi Bruce, thanks for this patch! I'll give it a try now...
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Thu Oct 8 12:43:02 2015
New Revision: 249705
URL: http://llvm.org/viewvc/llvm-project?rev=249705&view=rev
Log:
syncsource.py: a specific dir's source_excludes may now include the special
entry "".
The special entry will prevent that specific directory's excludes
from
rece
clayborg accepted this revision.
clayborg added a comment.
Add space in between if and opening ( and this is good to go.
Repository:
rL LLVM
http://reviews.llvm.org/D13548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
clayborg accepted this revision.
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
I'll defer to Dawn, I'm not too familiar with how the CMake Darwin stuff works.
If the people interested say it works, that's fine with me.
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.ll
zturner accepted this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision is now accepted and ready to land.
In the future, u sually the reviewer (you in this case) does this by hitting
Accept in Phabricator. I can do it this time though, no worries
http://revie
brucem added a comment.
Both builds from clean and incremental have now succeeded for me with this
patch.
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
amccarth added a comment.
Hold off. I just got a failure even at only 32 subprocesses.
http://reviews.llvm.org/D13555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
Python uses stdio from the C runtime for file descriptors and pipes. On
Windows, by default, the CRT has a limit of 512 open file descriptors.
https://msdn.microsoft.com/en-us/library/
brucem added a comment.
I have a full build from clean going with this. I'm pretty sure that it will be
fine.
I'll check this into SVN after I wake up if someone agrees that it looks good.
http://reviews.llvm.org/D13552
___
lldb-commits mailing li
brucem added a comment.
I did NOT test this with a full rebuild as it is nearly my bedtime. I did test
it with an incremental build as well as rm'ing the generated file and touching
the (new) dependencies to make sure that the vers file got regenerated.
http://reviews.llvm.org/D13552
__
brucem created this revision.
brucem added reviewers: dawn, sas, clayborg, zturner.
brucem added a subscriber: lldb-commits.
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have th
dawn accepted this commit.
dawn added a comment.
Build fixed in svn r249684.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
dawn added a comment.
FYI - our Jenkins master build just picked up the change and is finally
building again - yay!! :)
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
dawn added a comment.
In http://reviews.llvm.org/D13535#262672, @brucem wrote:
> I don't know what's broken for you. My build hasn't had any issues on Mac OS
> X using cmake.
In a clean workspace, cmake would fail because LLDB_vers.c hadn't been created
yet. You get the error:
CMake Error
enlight added a comment.
Hi Zach,
Can you close this issue please?
http://reviews.llvm.org/D13404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a comment.
In http://reviews.llvm.org/D13535#262670, @brucem wrote:
> The way to do this correctly is something like
> ...
Can you open a new patch which shows your suggested changes please? Or at
least clarify how the add_custom_command should look in this case and where it
shou
brucem added a comment.
I don't know what's broken for you. My build hasn't had any issues on Mac OS X
using cmake.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
dawn added a comment.
I went ahead and committed this since the build was completely broken - I'd be
happy to apply any suggestions folks make here in subsequent commits.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailin
brucem added a comment.
The way to do this correctly is something like
ADD_CUSTOM_COMMAND(
OUTPUT whatever.output.file.c
COMMAND ... whatever ...
DEPENDS ... whatever ...
)
ADD_CUSTOM_TARGET(whatever-target-name
ALL
DEPENDS whatever.output
brucem added a comment.
I think what needs to happen is that you take the `add_custom_command` and then
create a target that will execute the command and only do it once ... I'll
provide an example from something else shortly.
(I was about to request changes here when you committed it and close
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249684: [cmake] Fix cmake build on OSX after r249434.
(authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13535?vs=36798&id=36846#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: dperchik
Date: Thu Oct 8 07:35:21 2015
New Revision: 249684
URL: http://llvm.org/viewvc/llvm-project?rev=249684&view=rev
Log:
[cmake] Fix cmake build on OSX after r249434.
Reviewed by: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13535
Modified:
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
dawn wrote:
> brucem wrote:
> > Why is this needed?
> You get undefined symbol other
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
brucem wrote:
> Why is this needed?
You get undefined symbol otherwise (if you build
Author: sylvestre
Date: Thu Oct 8 06:17:01 2015
New Revision: 249681
URL: http://llvm.org/viewvc/llvm-project?rev=249681&view=rev
Log:
Fix the undefined symbol issue with go linking with autotools: build the
LanguageRuntime for Go + link against it
Modified:
lldb/trunk/lib/Makefile
lldb
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2108
@@ -2107,1 +2107,3 @@
mohit.bhakkad created this revision.
mohit.bhakkad added reviewers: clayborg, jingham.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
On MIPS architecture, it is possible to use same hardware regi
mohit.bhakkad updated this revision to Diff 36837.
mohit.bhakkad added a comment.
Changing as suggested
Repository:
rL LLVM
http://reviews.llvm.org/D13202
Files:
functionalities/watchpoint/watchpoint_on_vectors/Makefile
functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVa
Author: ravitheja
Date: Thu Oct 8 04:45:41 2015
New Revision: 249673
URL: http://llvm.org/viewvc/llvm-project?rev=249673&view=rev
Log:
Testcase and fix for bug 24074
Summary:
In bug 24074, the type information is not shown
correctly. This commit includes the following -
-> Changes for displaying
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Same issue here with whitespace and needing to be rebased forward.
Repository:
rL LLVM
http://reviews.llvm.org/D12257
___
lldb-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249671: Make CMake display more readable paths to Python
binaries on Windows (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13520?vs=36764&id=36832#toc
Repository:
rL LLVM
h
Author: brucem
Date: Thu Oct 8 03:50:20 2015
New Revision: 249671
URL: http://llvm.org/viewvc/llvm-project?rev=249671&view=rev
Log:
Make CMake display more readable paths to Python binaries on Windows
Summary:
Previously CMake would display messages like these:
```
-- LLDB Found PythonExecutabl
51 matches
Mail list logo
