Yea. It's definitely hard to write a normal test case for this. It's also
a common problem when dealing with remote debugging scenarios. It's both
hard and resource demanding (needing to have just the right Host -> Target
configuration available) to test that by going through the full debugging
Thanks for the idea Zachary, I haven't been following that. I'll look at this
tomorrow. I was trying to imagine how to write a normal test case for this and
it'd involve running a binary, deleting the binary off disk, then lldb attach
to the process, letting it find a dSYM via spotlight which
This is a good example of where unit tests are useful. There's already a
small suite of unit tests but I'm going to start being proactive about
growing it (in part by evangelizing it in response to people's commits
;-). It's not integrated into the Xcode build, but it would certainly be
easy to d
Author: jmolenda
Date: Thu Oct 1 00:37:22 2015
New Revision: 248985
URL: http://llvm.org/viewvc/llvm-project?rev=248985&view=rev
Log:
Fixing a subtle issue on Mac OS X systems with dSYMs (possibly
introduced by r235737 but I didn't look into it too closely).
A dSYM can have a per-UUID plist in i
ki.stfu accepted this revision.
ki.stfu added a comment.
lgtm
Comment at: test/tools/lldb-mi/control/TestMiExec.py:16
@@ +15,3 @@
+@skipIfFreeBSD # Failure presumably due to StopAtEntry most likely not
implemented
+@expectedFailureAll("llvm.org/pr25000", oslist=["linux"
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Use %HOME%/.lldb/module_cache as a default module cache directory.
http://reviews.llvm.org/D13323
Files:
source/Target/Platform.cpp
Index: source/Target/Platform.cpp
==
Hi Sean, would it be possible to add a test for this?
On Wed, Sep 30, 2015 at 5:40 PM Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Sep 30 19:39:03 2015
> New Revision: 248971
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248971&view=rev
> Lo
Author: spyffe
Date: Wed Sep 30 19:39:03 2015
New Revision: 248971
URL: http://llvm.org/viewvc/llvm-project?rev=248971&view=rev
Log:
Use the preferred display language when making a persistent variable from a
ValueObject.
Modified:
lldb/trunk/source/Core/ValueObject.cpp
Modified: lldb/trunk/
Author: spyffe
Date: Wed Sep 30 19:38:06 2015
New Revision: 248970
URL: http://llvm.org/viewvc/llvm-project?rev=248970&view=rev
Log:
Changed PersistentExpressionState to allow symbol lookups. Clang doesn't
report any (yet).
Modified:
lldb/trunk/include/lldb/Expression/ExpressionVariable.h
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov added a comment.
I tried Nexus 5 and 6P with Android M. Thanks for the new patch - it's fixing
the problem.
Repository:
rL LLVM
http://reviews.llvm.org/D13162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
Author: enrico
Date: Wed Sep 30 18:12:22 2015
New Revision: 248960
URL: http://llvm.org/viewvc/llvm-project?rev=248960&view=rev
Log:
Introudce a IsTopLevelFunction() API on Language and Function
This is meant to support languages that have a scripting mode with top-level
code that acts as global
amccarth abandoned this revision.
amccarth added a comment.
Same fix was already committed to fix the Linux build.
http://reviews.llvm.org/D13312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
emaste added a subscriber: emaste.
emaste added a comment.
> I'm not sure why it didn't break other platforms.
It did - perhaps it worked only on OS X due to xcode path differences? It was
fixed by http://reviews.llvm.org/rL248956.
http://reviews.llvm.org/D13312
___
amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.
This fixes the Windows build break introduced by r248934. I'm not sure why it
didn't break other platforms.
http://reviews.llvm.org/D13312
Files:
include/lldb/Symbol/ClangAST
Author: ovyalov
Date: Wed Sep 30 17:27:55 2015
New Revision: 248956
URL: http://llvm.org/viewvc/llvm-project?rev=248956&view=rev
Log:
Fix Linux build.
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h
URL:
http://llvm.org/
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Sep 30 15:13:58 2015
New Revision: 248936
URL: http://llvm.org/viewvc/llvm-project?rev=248936&view=rev
Log:
Fixes a potential hang in test runner timeout logic.
Part of https://llvm.org/bugs/show_bug.cgi?id=25002
In writing the new process_control test included here,
I d
Author: spyffe
Date: Wed Sep 30 14:57:57 2015
New Revision: 248934
URL: http://llvm.org/viewvc/llvm-project?rev=248934&view=rev
Log:
Now persistent expression data no longer lives with the Target, but rather with
the corresponding TypeSystem. This makes sense because what kind of data there
is --
tberghammer created this revision.
tberghammer added reviewers: clayborg, tfiala, zturner, emaste, labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Run tests with dwo symbol file
dwo symbol files are generated when code compiled with
KLapshin added inline comments.
Comment at: test/tools/lldb-mi/control/TestMiExec.py:16
@@ +15,3 @@
+@skipIfFreeBSD # Failure presumably due to StopAtEntry most likely not
implemented
+@expectedFailureAll("llvm.org/pr25000", oslist=["linux"])
+def test_lldbmi_exec_run
KLapshin added a comment.
In http://reviews.llvm.org/D12968#256563, @labath wrote:
> This is definitely not a proper fix for this problem, it merely sweeps the
> problem under the carpet. If something like this makes a difference then it
> means something has gone horribly wrong a long time ago
KLapshin marked an inline comment as done.
KLapshin added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
KLapshin updated this revision to Diff 36128.
KLapshin added a comment.
Test has been marked as XFAILed for Linux (x86_64) case.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
Files:
test/tools/lldb-mi/control/TestMiExec.py
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb-mi/MICmdCmdExec.
KLapshin added inline comments.
Comment at: test/tools/lldb-mi/control/TestMiExec.py:16
@@ +15,3 @@
+@skipIfFreeBSD # Failure presumably due to StopAtEntry most likely not
implemented
+def test_lldbmi_exec_run(self):
+"""Test that 'lldb-mi --interpreter' can stop
mohit.bhakkad created this revision.
mohit.bhakkad added reviewers: clayborg, jingham.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
For archs like MIPS, where watchpoints are triggered before as
Ahh, so the test was already failing and you're just fixing it? That's
fine then, thanks.
On Tue, Sep 29, 2015 at 11:24 PM Jason Molenda wrote:
> jasonmolenda added a comment.
>
> I see, this seems reasonable to me.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13241
>
>
>
>
__
zturner added a comment.
Ahh, so the test was already failing and you're just fixing it? That's
fine then, thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
Ok, looks good
On Wed, Sep 30, 2015 at 12:27 AM Vadim Macagon
wrote:
> enlight updated this revision to Diff 36072.
> enlight added a comment.
> This revision is now accepted and ready to land.
>
> Added an explanation of the generator expression used in this patch.
>
>
> Repository:
> rL LLVM
labath added a comment.
This is definitely not a proper fix for this problem, it merely sweeps the
problem under the carpet. If something like this makes a difference then it
means something has gone horribly wrong a long time ago. I haven't been able to
reproduce this locally, but I'd recommen
I haven't managed to reproduce the issue you reported (what OS and Android
version do you use?), but based on the description this change (not
committed in yet) might fix the issue: http://reviews.llvm.org/D13293. Can
you take a look?
Thanks,
Tamas
On Wed, Sep 30, 2015 at 12:49 AM Oleksiy Vyalov
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile
http://reviews.llvm.org/D13293
Files:
source/Plugins/Platfor
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:683
@@ +682,3 @@
+
+if (m_use_alt_disaasm == true)
+decode_status = m_alt_dis
Author: tberghammer
Date: Wed Sep 30 10:17:06 2015
New Revision: 248910
URL: http://llvm.org/viewvc/llvm-project?rev=248910&view=rev
Log:
Make the ArmUnwindInfo parsing code endian independent
Differential revision: http://reviews.llvm.org/D13291
Modified:
lldb/trunk/include/lldb/Symbol/ArmU
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL248910: Make the ArmUnwindInfo parsing code endian
independent (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13291?vs=36103&i
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, after fixing some typos.
Comment at: include/lldb/Symbol/ArmUnwindInfo.h:55
@@ -46,1 +54,3 @@
+
+const ObjectFile& m_objfile;
lldb::SectionSP m_arm_exidx_
Author: amccarth
Date: Wed Sep 30 09:57:21 2015
New Revision: 248909
URL: http://llvm.org/viewvc/llvm-project?rev=248909&view=rev
Log:
Removed an unused member variable. Affects Windows only.
Modified:
lldb/trunk/source/Plugins/Process/Windows/Live/TargetThreadWindows.h
Modified: lldb/trunk
Author: tberghammer
Date: Wed Sep 30 09:55:08 2015
New Revision: 248908
URL: http://llvm.org/viewvc/llvm-project?rev=248908&view=rev
Log:
Fix xcode build after rL248903
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.o
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Make the ArmUnwindInfo parsing code endian independent
http://reviews.llvm.org/D13291
Files:
include/lldb/Symbol/ArmUnwindInfo.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248903: Add support for .ARM.exidx unwind information
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13245?vs=35970&id=36101#toc
Repository:
rL LLVM
http://reviews.llvm
Author: tberghammer
Date: Wed Sep 30 08:50:14 2015
New Revision: 248903
URL: http://llvm.org/viewvc/llvm-project?rev=248903&view=rev
Log:
Add support for .ARM.exidx unwind information
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an excepti
tberghammer marked an inline comment as done.
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
labath wrote:
> Is there a reason DataExtractor::GetULEB128 could
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:421
@@ +420,3 @@
+uint32_t os_major = 0, os_minor = 0, os_update = 0;
+if (arch.GetTr
Author: tberghammer
Date: Wed Sep 30 08:42:06 2015
New Revision: 248901
URL: http://llvm.org/viewvc/llvm-project?rev=248901&view=rev
Log:
XFAIL 2 test in TestTargetCommands on android-aarch64
The 2 test just get enabled with the recemt test system refactor.
Modified:
lldb/trunk/test/function
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Restrict the scope of a hack in DYLDRendezvous
The hack is there to work around an incorrect load address reported
by t
Author: labath
Date: Wed Sep 30 05:59:39 2015
New Revision: 248889
URL: http://llvm.org/viewvc/llvm-project?rev=248889&view=rev
Log:
Fix TestAttachDenied on linux
This test was timing out because the test inferior was forking a child, which
was not terminated
correctly. The test contained provis
bhushan closed this revision.
bhushan added a comment.
Closed by commit http://reviews.llvm.org/rL246015
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
bhushan created this revision.
bhushan added reviewers: clayborg, tberghammer.
bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, sagar,
jaydeep.
bhushan set the repository for this revision to rL LLVM.
This patch includes:
1. Emulation of prologue/epilogue and branch instructi
labath added a subscriber: labath.
Comment at: scripts/Python/modules/readline/readline.cpp:17
@@ -15,3 +16,3 @@
moduleDocumentation,
"Stub module meant to effectively disable readline support.");
Given the code you are adding, this comment seems out o
enlight updated this revision to Diff 36072.
enlight added a comment.
This revision is now accepted and ready to land.
Added an explanation of the generator expression used in this patch.
Repository:
rL LLVM
http://reviews.llvm.org/D13234
Files:
cmake/modules/LLDBConfig.cmake
Index: cmake
50 matches
Mail list logo
