brucem added a comment.
Yes. With a change that I'm going to submit for review:
batavia:build-llvm bruce$ bin/lldb bin/clang
(lldb) target create "bin/clang"
Current executable set to 'bin/clang' (x86_64).
(lldb) b main
Breakpoint 1: where = clang`main, address = 0x00012890
(l
evgeny777 added a comment.
Also in MI empty value and NULL value almost always mean "no output". Checking
for NULL everywhere is just not convenient
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
evgeny777 added a comment.
Without this change I have to use temporary const char* variable each time I
call GetData() GetSummary(), GetValue() and so on
It would be nice to be able to do something like this
CMIUtilString s = v.GetSummary();
if (!s.empty()) {
CMIUtilString v = v.GetValue();
tfiala added a subscriber: tfiala.
tfiala added a comment.
Are you all still seeing this now? I am heading to sleep but can have a
look early in the morning...
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
Are you all still seeing this now? I am heading to sleep but can have a
look early in the morning...
On Wed, Sep 23, 2015 at 10:09 PM, Bruce Mitchener via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> brucem added a subscriber: brucem.
> brucem added a comment.
>
> I ran into this myself
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Your fix in assign operator looks good. Others go out of scope of this CL, so
please revert them.
Comment at: tools/lldb-mi/MIUtilString.cpp:41
@@ -40,3 +40,3 @@
tfiala added inline comments.
Comment at: test/curses_results.py:223
@@ -223,1 +222,3 @@
+# Greg - not sure why this is here. It locks up on
exit.
+# self.main_window.key_event_loop()
lldbcurses.terminate_c
tfiala created this revision.
tfiala added reviewers: zturner, clayborg, labath.
tfiala added a subscriber: lldb-commits.
For all the parallel test runners, provide a pure-Python mechanism for timing
out dotest inferior processes that run for too long.
Stock OS X and Windows do not have a built-
tfiala accepted this revision.
tfiala added a comment.
This review is mighty stale, but going through my differentials I saw it was
still around. It looked good for the time.
http://reviews.llvm.org/D5503
___
lldb-commits mailing list
lldb-commits
brucem added a subscriber: brucem.
brucem added a comment.
I ran into this myself and looked into it.
What is happening is that it is looking for `argdumper` and not finding it.
This happens because it is looking in the `lib` directory within the build
directory, but `argdumper` is in the `bin`
jaydeep added a comment.
Hi Dawn,
Let me check and get back to you.
Regards,
Jaydeep
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248457: execinfo.h isn't needed on Mac OS X for Host.mm.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13049?vs=35354&id=35581#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: brucem
Date: Wed Sep 23 20:37:32 2015
New Revision: 248457
URL: http://llvm.org/viewvc/llvm-project?rev=248457&view=rev
Log:
execinfo.h isn't needed on Mac OS X for Host.mm.
Summary: This is no longer needed as this file no longer calls backtrace().
Reviewers: clayborg
Subscribers: lldb
sivachandra added inline comments.
Comment at: test/lang/cpp/incomplete-types/Makefile:8
@@ +7,3 @@
+
+ifneq (,$(findstring clang,$(CC)))
+ CFLAGS_LIMIT += -flimit-debug-info
dblaikie wrote:
> In case it's interesting, you can get similarly problematic DWARF by u
Author: gclayton
Date: Wed Sep 23 19:19:42 2015
New Revision: 248450
URL: http://llvm.org/viewvc/llvm-project?rev=248450&view=rev
Log:
Added the ability to register key callbacks for much easier key handling. Also
added the elapsed time display to the status bar.
Modified:
lldb/trunk/test/c
dawn added a subscriber: dawn.
dawn added a comment.
These tests have been failing on OSX ever since this commit:
./dotest.py -f
LldbGdbServerTestCase.test_qRegisterInfo_returns_all_valid_results_debugserver_dsym
./dotest.py -f
LldbGdbServerTestCase.test_qRegisterInfo_returns_one_valid_resu
ribrdb added a comment.
I suppose JIT might make more sense if we want to implement more complicated
expressions like looping and calling in to go code.
There's lots of issues to solve before we can call into go code however. In
addition to the stack I'm not sure what to do about the GC. Also I
dblaikie added a subscriber: dblaikie.
Comment at: test/lang/cpp/incomplete-types/Makefile:8
@@ +7,3 @@
+
+ifneq (,$(findstring clang,$(CC)))
+ CFLAGS_LIMIT += -flimit-debug-info
In case it's interesting, you can get similarly problematic DWARF by using a
dynami
ribrdb added a comment.
Hmm. I assumed you're using clang to generate llvm IR, is that not the case?
I don't really want to write a whole go compiler.
Right now I'm interpreting the AST using the ValueObject API. This also lets me
reuse the error checking and things implemented in the type system
dawn added a subscriber: lldb-commits.
http://reviews.llvm.org/rL247741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
I see you moved the JIT code over into ClangUserExpression. I was wondering if
all languages might not want to generate llvm IR and then let the JIT make code
from the llvm IR? This is the reason were originally left the IR in the
UserExpression. IR is very generic and
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Jay,
This test has been failing on OSX ever since this commit:
./dotest.py -f ConnectRemoteTestCase.test_connect_remote
Failure-TestConnectRemote.ConnectRemoteTestCase.test_connect_remote-x86_64-
dawn added a subscriber: lldb-commits.
Users:
jaydeep (Author)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248434: Check existence of SIGHUP before using it (authored
by chying).
Changed prior to commit:
http://reviews.llvm.org/D13114?vs=35543&id=35557#toc
Repository:
rL LLVM
http://reviews.llvm.org/D131
Author: chying
Date: Wed Sep 23 16:53:18 2015
New Revision: 248434
URL: http://llvm.org/viewvc/llvm-project?rev=248434&view=rev
Log:
Check existence of SIGHUP before using it
Summary: -SIGHUP doesn't exist on Windows
Reviewers: tfiala
Subscribers: lldb-commits
Differential Revision: http://rev
> On Sep 23, 2015, at 2:31 PM, Zachary Turner wrote:
>
> If you change "enum" to "enum class" I think it will work
Yes that would also work
> (IANALL but I think it's even more correct).
IANALL either, but I beg to differ on that
The way I usually heard it explained is that C has different “
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Jay,
This test has been failing on OSX ever since this commit:
./dotest.py -f TestCppNsImport.test_with_dwarf_and_run_command
Failure-TestCppNsImport.TestCppNsImport.test_with_dwarf_and_run_comma
If you change "enum" to "enum class" I think it will work (IANALL but I
think it's even more correct). But if what you've done works, then that
should be fine.
On Wed, Sep 23, 2015 at 1:50 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Wed Sep 2
clayborg added a subscriber: clayborg.
clayborg added a comment.
Even though clang isn't done this way for historical reason, I would like to
see the Go expression parser files (.cpp and .h) over into
"source/Plugins/ExpressionParser/Go". The following files should be moved:
include/lldb/Expr
dawn raised a concern with this commit.
Users:
spyffe (Author)
dawn (Auditor)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn added a comment.
Hi Sean,
These 3 tests have been failing on OSX ever since this commit:
Failure-TestLaunchWithShellExpand.LaunchWithShellExpandTestCase.test_with_dsym-x86_64-clang.log
Failure-TestLaunchWithShellExpand.LaunchWithShellExpandTestCase.test_
dawn added a subscriber: lldb-commits.
Users:
spyffe (Author)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
We need to get Sean Callanan as a reviewer on this. Jim is out for a few weeks,
so Sean will need to OK this.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
_
Author: enrico
Date: Wed Sep 23 15:49:15 2015
New Revision: 248429
URL: http://llvm.org/viewvc/llvm-project?rev=248429&view=rev
Log:
The Visual Studio compiler does not like this C-ism when 'enum class'es are
involved
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntim
Author: enrico
Date: Wed Sep 23 15:12:19 2015
New Revision: 248427
URL: http://llvm.org/viewvc/llvm-project?rev=248427&view=rev
Log:
Make the ObjCLanguageRuntimes comply with llvm-style RTTI
Modified:
lldb/trunk/include/lldb/Target/ObjCLanguageRuntime.h
lldb/trunk/include/lldb/lldb-priva
chying created this revision.
chying added a reviewer: tfiala.
chying added a subscriber: lldb-commits.
-SIGHUP doesn't exist on Windows
http://reviews.llvm.org/D13114
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.
> On Sep 23, 2015, at 12:42 PM, Dawn Perchik via lldb-commits
> wrote:
>
> dawn added a subscriber: dawn.
> dawn raised a concern with this commit.
> dawn added a comment.
>
> Hi Enrico,
>
> This commit has caused catasrophic test failures on OSX. The failure count
> went
> up by 512.
>
>
sivachandra added a comment.
Friendly periodic ping. Let me know if once in 2 days is too frequent.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Enrico,
This commit has caused catasrophic test failures on OSX. The failure count went
up by 512.
lldb is built with cmake/ninja, and tests are run in the test dir as follows:
cd ~/llvm
mkdir
dawn added a subscriber: lldb-commits.
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> On Sep 23, 2015, at 12:09 PM, Ed Maste wrote:
>
> I'd suggest we revert for now and bring it back after testing on all
> platforms. There were a couple of nits and changes in the committed
> version relative to the version in the review as well so I think it's
> better to bring it back with th
Author: enrico
Date: Wed Sep 23 14:32:56 2015
New Revision: 248421
URL: http://llvm.org/viewvc/llvm-project?rev=248421&view=rev
Log:
Revert 248366 "Testcase and fix for bug 24074"
This commit introduced regressions in several test cases on FreeBSD and Mac OS X
Removed:
lldb/trunk/include/ll
dawn added a subscriber: lldb-commits.
Users:
jaydeep (Author)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Jim,
This test has been failing on OSX ever since this commit:
./dotest.py -f RegisterCommandsTestCase.test_register_expressions
Failure-TestRegisters.RegisterCommandsTestCase.test_register_expre
I'd suggest we revert for now and bring it back after testing on all
platforms. There were a couple of nits and changes in the committed
version relative to the version in the review as well so I think it's
better to bring it back with those fixed up.
On 23 September 2015 at 14:52, Enrico Granata
dawn added a subscriber: lldb-commits.
Users:
jingham (Author)
http://reviews.llvm.org/rL247709
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I am seeing the same issue on OS X
Ravitheja, can you investigate this?
Or should we just revert?
> On Sep 23, 2015, at 9:54 AM, Ed Maste via lldb-commits
> wrote:
>
> On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits
> wrote:
>> Author: ravitheja
>> Date: Wed Sep 23 02:19:0
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248416: [TestCppIncompleteTypes] Fix Makefile to handle
different archs. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13111?vs=35535&id=35539#toc
Repository:
rL LLVM
sivachandra created this revision.
sivachandra added a reviewer: chying.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13111
Files:
test/lang/cpp/incomplete-types/Makefile
Index: test/lang/cpp/incomplete-types/Makefile
==
Author: sivachandra
Date: Wed Sep 23 13:36:39 2015
New Revision: 248416
URL: http://llvm.org/viewvc/llvm-project?rev=248416&view=rev
Log:
[TestCppIncompleteTypes] Fix Makefile to handle different archs.
Reviewers: chying
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248414: Handle new types in ClangASTContext::GetEncoding
(authored by emaste).
Changed prior to commit:
http://reviews.llvm.org/D13096?vs=35532&id=35537#toc
Repository:
rL LLVM
http://reviews.llvm.o
emaste added a comment.
http://reviews.llvm.org/rL248414
http://reviews.llvm.org/D13096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: emaste
Date: Wed Sep 23 13:32:34 2015
New Revision: 248414
URL: http://llvm.org/viewvc/llvm-project?rev=248414&view=rev
Log:
Handle new types in ClangASTContext::GetEncoding
And remove the switch default, so that the -Wcovered-switch-default
warning will catch new types next time they're
Author: emaste
Date: Wed Sep 23 13:23:38 2015
New Revision: 248411
URL: http://llvm.org/viewvc/llvm-project?rev=248411&view=rev
Log:
Remove expectedFailureFreeBSD from passing test
ClassTypesTestCase::test_with_dwarf_and_constructor_name
llvm.org/pr14540
Modified:
lldb/trunk/test/lang/cpp/c
Author: emaste
Date: Wed Sep 23 13:20:51 2015
New Revision: 248410
URL: http://llvm.org/viewvc/llvm-project?rev=248410&view=rev
Log:
Remove expectedFailureFreeBSD from passing TestChangeValueAPI test
This test used fail intermittently, but now passes consistently on
FreeBSD in local runs. We'll i
emaste retitled this revision from "Handle OMPArraySection in
ClangASTContext::GetEncoding" to "Handle new types in
ClangASTContext::GetEncoding".
emaste updated this revision to Diff 35532.
emaste added a comment.
More new types added after my initial patch.
http://reviews.llvm.org/D13096
Fi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If you are going to hijack you do need to do it before you call Halt().
Repository:
rL LLVM
http://reviews.llvm.org/D12968
___
l
KLapshin added a comment.
As little summary what should be added to existing lldb-mi in context of this
review:
- list-features MI command (for getting supported features in future, currently
only one "exec-run-start-option" feature will be reported)
- add --start option to -exec-run, set StopA
Author: sivachandra
Date: Wed Sep 23 12:47:08 2015
New Revision: 248401
URL: http://llvm.org/viewvc/llvm-project?rev=248401&view=rev
Log:
DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child
Summary:
With this change DWARFASTParserClang::CompleteTypeFromDWARF returns f
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
You need to add more diffs to take care of the extra enums or does this patch
include those already?
http://reviews.llvm.org/D13096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as the test suite if happy.
http://reviews.llvm.org/D13066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
Author: tfiala
Date: Wed Sep 23 12:20:09 2015
New Revision: 248397
URL: http://llvm.org/viewvc/llvm-project?rev=248397&view=rev
Log:
test framework: fixed issue when using results formatter with no formatter
options
I broke the formatter options-passing parsing when no formatter
options are prov
% ./dotest.py lang/cpp/dynamic-value
LLDB library dir: /Volumes/work/gclayton/Documents/src/lldb/tot/build/Debug
LLDB import library dir:
/Volumes/work/gclayton/Documents/src/lldb/tot/build/Debug
lldb-350.99.0
lldb.pre_flight: None
lldb.post_flight: None
Session logs for test failures/errors/unex
On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits
wrote:
> Author: ravitheja
> Date: Wed Sep 23 02:19:02 2015
> New Revision: 248366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev
> Log:
> Testcase and fix for bug 24074
This change introduced a segfault in 10 o
brucem added a comment.
Ping? This should be safe and almost risk-free.
http://reviews.llvm.org/D13049
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a comment.
This doesn't cover files with Clang in their name. But it should cover just
about everything else.
http://reviews.llvm.org/D13102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: tfiala
Date: Wed Sep 23 10:21:28 2015
New Revision: 248384
URL: http://llvm.org/viewvc/llvm-project?rev=248384&view=rev
Log:
Cleaned up results formatter options hand-off.
* --results-formatter-options renamed to --results-formatter-option,
with short version of -O
* Multiple --results
emaste added a comment.
Oh, it seems there are more new types added after I first made this change:
../tools/lldb/source/Symbol/ClangASTContext.cpp:4445:21: warning: 10
enumeration values not handled in switch: 'OCLImage2dDepth',
'OCLImage2dArrayDepth', 'OCLImage2dMSAA'... [-Wswitch]
http:/
The doc comment for SortTypeList() is wrong.
On Sep 23, 2015 12:20 AM, "Ravitheja Addepally via lldb-commits" <
lldb-commits@lists.llvm.org> wrote:
> Author: ravitheja
> Date: Wed Sep 23 02:19:02 2015
> New Revision: 248366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev
> Log:
>
KLapshin added a comment.
In http://reviews.llvm.org/D12968#251719, @labath wrote:
> In http://reviews.llvm.org/D12968#251696, @KLapshin wrote:
>
> > Regarding matter of this patch - I just tried to make process stop
> > synchronous, see Process::ResumeSynchronous() - same technique was applied
labath added a comment.
In http://reviews.llvm.org/D12968#251696, @KLapshin wrote:
> Regarding matter of this patch - I just tried to make process stop
> synchronous, see Process::ResumeSynchronous() - same technique was applied
> months ago (@ki.stfu).
>
> Agreed what crash may be related to f
KLapshin marked an inline comment as done.
KLapshin added a comment.
Done.
Repository:
rL LLVM
http://reviews.llvm.org/D12968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
KLapshin added a comment.
@labath,
I updated patch against actual source in SVN - i.e. with taking into account
your change (Halt*->Stop*).
Regarding matter of this patch - I just tried to make process stop synchronous,
see Process::ResumeSynchronous() - same technique was applied month ago.
KLapshin removed rL LLVM as the repository for this revision.
KLapshin updated this revision to Diff 35491.
http://reviews.llvm.org/D12968
Files:
source/Target/Process.cpp
Index: source/Target/Process.cpp
===
--- source/Target/Pro
emaste created this revision.
emaste added reviewers: granata.enrico, clayborg, brucem.
emaste added a subscriber: lldb-commits.
And remove the switch default, so that the -Wcovered-switch-default warning
will catch new types in the future.
http://reviews.llvm.org/D13096
Files:
source/Symbol/
Author: tberghammer
Date: Wed Sep 23 06:00:35 2015
New Revision: 248373
URL: http://llvm.org/viewvc/llvm-project?rev=248373&view=rev
Log:
Fix xcode build after r248366
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.or
labath added inline comments.
Comment at: source/Target/Process.cpp:3934
@@ +3933,3 @@
+
+ListenerSP listener_sp (new
Listener("lldb.Process.HaltForDestroyOrDetach.hijack"));
+HijackProcessEvents(listener_sp.get());
ki.stfu wrote:
> btw: p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248371: Fix race condition during process detach (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D13056?vs=35372&id=35476#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1305
Author: labath
Date: Wed Sep 23 05:16:57 2015
New Revision: 248371
URL: http://llvm.org/viewvc/llvm-project?rev=248371&view=rev
Log:
Fix race condition during process detach
Summary:
The following situation occured in TestAttachResume:
The inferior was stoped at a breakpoint and we did a continu
ki.stfu requested changes to this revision.
ki.stfu added a comment.
Please, next time make a patch with full context:
svn diff --diff-cmd diff -x "-U" > mypatch.txt
This will help us to reduce the review time.
Comment at: test/tools/lldb-mi/variable/TestMiGdbSetShowPrin
Author: ravitheja
Date: Wed Sep 23 02:19:02 2015
New Revision: 248366
URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev
Log:
Testcase and fix for bug 24074
Summary:
In bug 24074, the type information is not shown
correctly. This commit includes the following -
-> Changes for displayin
83 matches
Mail list logo
