Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

sagar updated this revision to Diff 33668. sagar marked 4 inline comments as done. sagar added a comment. Corrected code indent and initialized wr_val correctly. Repository: rL LLVM http://reviews.llvm.org/D12356 Files: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp sourc

[Lldb-commits] [PATCH] D12519: [debugserver] Fix sign comparison warning.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. Comparing m_page_size against kInvalidPageSize was resulting in a warning about comparing integers with different signs. Since kInvalidPageSize isn't used anywhere outside of MachVMMemory.cpp,

[Lldb-commits] [lldb] r246530 - A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" -> "stabs".

Author: jmolenda Date: Tue Sep 1 00:17:01 2015 New Revision: 246530 URL: http://llvm.org/viewvc/llvm-project?rev=246530&view=rev Log: A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" -> "stabs". Just noticed these while reading through some code. Modified: lldb/trunk/s

Re: [Lldb-commits] [PATCH] D12518: Simplify find_first_of & find_last_of on single char.

brucem added a comment. This touches random files across the tree, including lldb-mi. I wasn't sure how best this should be reviewed or by who (despite it being pretty mechanical). http://reviews.llvm.org/D12518 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D12518: Simplify find_first_of & find_last_of on single char.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. When calling find_first_of and find_last_of on a single character, we can instead just call find / rfind and make our intent more clear. http://reviews.llvm.org/D12518 Files: source/Core/F

Re: [Lldb-commits] [PATCH] D12517: [lldb-mi] Use find, not find_first_of, for "--".

This revision was automatically updated to reflect the committed changes. Closed by commit rL246529: [lldb-mi] Use find, not find_first_of, for "--". (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12517?vs=33662&id=33663#toc Repository: rL LLVM http://reviews.llvm.o

[Lldb-commits] [lldb] r246529 - [lldb-mi] Use find, not find_first_of, for "--".

Author: brucem Date: Mon Aug 31 23:36:54 2015 New Revision: 246529 URL: http://llvm.org/viewvc/llvm-project?rev=246529&view=rev Log: [lldb-mi] Use find, not find_first_of, for "--". Summary: find_first_of will look for any of the characters, not the full string passed in. When looking for "--" th

[Lldb-commits] [PATCH] D12517: [lldb-mi] Use find, not find_first_of, for "--".

brucem created this revision. brucem added reviewers: ki.stfu, abidh. brucem added a subscriber: lldb-commits. find_first_of will look for any of the characters, not the full string passed in. When looking for "--" then, we must use find and not find_first_of. http://reviews.llvm.org/D12517 File

[Lldb-commits] [PATCH] D12515: Use -Wno-vla-extension globally.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. This was previously only established within debugserver, but there is a use of the VLA extension in source/Host/macosx/Symbols.cpp, so ignore this warning globally. http://reviews.llvm.org/D1

Re: [Lldb-commits] [lldb] r246518 - Attempt at fixing the CMake build

> On Aug 31, 2015, at 6:23 PM, Enrico Granata via lldb-commits > wrote: > > Author: enrico > Date: Mon Aug 31 20:23:02 2015 > New Revision: 246518 > > URL: http://llvm.org/viewvc/llvm-project?rev=246518&view=rev > Log: > Attempt at fixing the CMake build > > Modified: >lldb/trunk/cmake/LL

[Lldb-commits] [lldb] r246518 - Attempt at fixing the CMake build

Author: enrico Date: Mon Aug 31 20:23:02 2015 New Revision: 246518 URL: http://llvm.org/viewvc/llvm-project?rev=246518&view=rev Log: Attempt at fixing the CMake build Modified: lldb/trunk/cmake/LLDBDependencies.cmake lldb/trunk/source/Plugins/Language/CMakeLists.txt Modified: lldb/trunk/

[Lldb-commits] [lldb] r246519 - And of course, typos

Author: enrico Date: Mon Aug 31 20:23:22 2015 New Revision: 246519 URL: http://llvm.org/viewvc/llvm-project?rev=246519&view=rev Log: And of course, typos Modified: lldb/trunk/source/Plugins/Language/CMakeLists.txt Modified: lldb/trunk/source/Plugins/Language/CMakeLists.txt URL: http://llvm.

[Lldb-commits] [lldb] r246515 - Add support for language plugins to provide data formatters

Author: enrico Date: Mon Aug 31 20:01:48 2015 New Revision: 246515 URL: http://llvm.org/viewvc/llvm-project?rev=246515&view=rev Log: Add support for language plugins to provide data formatters Historically, data formatters all exist in a global repository (the category map) On top of that, some

[Lldb-commits] [lldb] r246512 - Make FormatEntity be a little bit smarter when printing function arguments

Author: enrico Date: Mon Aug 31 19:19:35 2015 New Revision: 246512 URL: http://llvm.org/viewvc/llvm-project?rev=246512&view=rev Log: Make FormatEntity be a little bit smarter when printing function arguments Modified: lldb/trunk/source/Core/FormatEntity.cpp Modified: lldb/trunk/source/Core/

[Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly different methods for capturing ranges of memory, so I abstracted away the search for a range from the ac

[Lldb-commits] [lldb] r246490 - Remove expectedFailureFreeBSD for passing pexpect tests

Author: emaste Date: Mon Aug 31 16:37:15 2015 New Revision: 246490 URL: http://llvm.org/viewvc/llvm-project?rev=246490&view=rev Log: Remove expectedFailureFreeBSD for passing pexpect tests These tests work when run locally. They had been occasionally failing on the FreeBSD buildbot due to pexpect

[Lldb-commits] [lldb] r246488 - Stop objects from keeping a strong reference to the process when they should have a weak reference.

Author: gclayton Date: Mon Aug 31 16:25:45 2015 New Revision: 246488 URL: http://llvm.org/viewvc/llvm-project?rev=246488&view=rev Log: Stop objects from keeping a strong reference to the process when they should have a weak reference. Modified: lldb/trunk/source/Plugins/InstrumentationRunt

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

chaoren added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2910 @@ +2909,3 @@ +{ +Process::SetUnixSignals(std::make_shared(signals_sp)); +} Here's the copy. http://reviews.llvm.org/D12420

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

emaste added a subscriber: emaste. emaste added a comment. In http://reviews.llvm.org/D12485#236538, @sas wrote: > Looks like accept4(2) is linux-only. And FreeBSD -- from the man page `The accept4() system call appeared in FreeBSD 10.0.` Repository: rL LLVM http://reviews.llvm.org/D12485

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

sas added a subscriber: sas. sas accepted this revision. sas added a reviewer: sas. sas added a comment. This revision is now accepted and ready to land. Looks like accept4(2) is linux-only. Repository: rL LLVM http://reviews.llvm.org/D12485 ___

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

clayborg added a comment. We do want processes to have individual copies that are copied from the platform. Does this actually make a copy? I don't see the copy. http://reviews.llvm.org/D12420 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

It doesn't necessarily have to be through fancy pipes, I guess the point is just that right now we use stdio as a way to print stuff that a person will read, so naturally it's formatted differently than if we were trying to produce something that would be consumed by a machine. But you're probably

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

> On Aug 28, 2015, at 9:36 AM, Zachary Turner wrote: > > > > On Fri, Aug 28, 2015 at 8:41 AM Todd Fiala wrote: > tfiala added a comment. > > In http://reviews.llvm.org/D12416#235112, @labath wrote: > > > Same question as Zachary. This sounds like a very useful feature and it > > would be n

[Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. accept4(2) and paccept(2) are nonstandard extensions. Repository: rL LLVM http://reviews.llvm.org/D12485 Files:

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

sagar marked 7 inline comments as done. Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3160 @@ +3159,3 @@ +if((*ptr == 0 && bnz) || (*ptr != 0 && !bnz) ) +branch_hit = false; +break; T

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

sagar updated this revision to Diff 33567. sagar added a comment. Addressed review commenst Repository: rL LLVM http://reviews.llvm.org/D12356 Files: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h Index: source