bhushan created this revision.
bhushan added a reviewer: clayborg.
bhushan added subscribers: lldb-commits, jaydeep, sagar, nitesh.jain,
mohit.bhakkad.
bhushan set the repository for this revision to rL LLVM.
In MIPS, when a breakpoint is hit in a delay slot then the PC points to the
previous br
Author: jmolenda
Date: Wed Aug 19 23:29:46 2015
New Revision: 245537
URL: http://llvm.org/viewvc/llvm-project?rev=245537&view=rev
Log:
If the filename specified by plugin.process.gdb-remote.target-definition-file,
doesn't exist, see if it needs tilde expansion before we ignore it completely.
Modi
ovyalov retitled this revision from "Make LLDB URLs to support hex encoding for
special symbols" to "Make UriParser to support [$HOSTNAME] notation.".
ovyalov updated the summary for this revision.
ovyalov updated this revision to Diff 32655.
ovyalov added a comment.
Herald added subscribers: srhi
Author: jmolenda
Date: Wed Aug 19 22:05:09 2015
New Revision: 245536
URL: http://llvm.org/viewvc/llvm-project?rev=245536&view=rev
Log:
When the target definition is unparseable, print an error message
to the user. e.g. specified via the
plugin.process.gdb-remote.target-definition-file
setting.
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3051
@@ +3050,3 @@
+return step_result;
+}
+default:
Let's go ahead wit
Author: chaoren
Date: Wed Aug 19 20:26:57 2015
New Revision: 245532
URL: http://llvm.org/viewvc/llvm-project?rev=245532&view=rev
Log:
XTIMEOUT TestIntegerTypesExpr for Darwin.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lldb
Author: paulherman
Date: Wed Aug 19 17:44:48 2015
New Revision: 245515
URL: http://llvm.org/viewvc/llvm-project?rev=245515&view=rev
Log:
Fix tests to work on remote targets.
Modified:
lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py
lldb/trunk/test/lang/cpp/global_operators/T
chaoren requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/lang/cpp/nsimport/TestCppNsImport.py:37
@@ -36,3 +36,3 @@
# Get the path of the executable
-cwd = os.getcwd()
+cwd = self.get_process_working_direct
Author: paulherman
Date: Wed Aug 19 16:44:56 2015
New Revision: 245508
URL: http://llvm.org/viewvc/llvm-project?rev=245508&view=rev
Log:
Fix evaluation of global operators in C++
Added:
lldb/trunk/test/lang/cpp/global_operators/
lldb/trunk/test/lang/cpp/global_operators/Makefile
lldb/
Author: paulherman
Date: Wed Aug 19 16:23:01 2015
New Revision: 245505
URL: http://llvm.org/viewvc/llvm-project?rev=245505&view=rev
Log:
Improve tests regarding imported namespaces and chained calls in C++
Modified:
lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py
lldb/trunk/
sivachandra accepted this revision.
sivachandra added a comment.
LGTM
http://reviews.llvm.org/D12165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245495: Read exception records from Windows mini dump
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12126?vs=32476&id=32606#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: amccarth
Date: Wed Aug 19 15:43:22 2015
New Revision: 245495
URL: http://llvm.org/viewvc/llvm-project?rev=245495&view=rev
Log:
Read exception records from Windows mini dump
Differential Revision: http://reviews.llvm.org/D12126
Modified:
lldb/trunk/source/Plugins/Process/Windows/Excep
Seems reasonable to move that to lldb-dev.
On Wed, Aug 19, 2015 at 12:56 PM Dawn Perchik wrote:
> dawn planned changes to this revision.
> dawn added a comment.
>
> In http://reviews.llvm.org/D12115#227613, @abidh wrote:
>
> > This command uses "target modules lookup" [...]
>
>
> Good point. Ye
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245488: [lldb-mi] Add (gdb) prompt after
=breakpoint-modified and =breakpoint-created. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D12113?vs=32443&id=32601#toc
Repository:
Author: dperchik
Date: Wed Aug 19 15:04:03 2015
New Revision: 245488
URL: http://llvm.org/viewvc/llvm-project?rev=245488&view=rev
Log:
[lldb-mi] Add (gdb) prompt after =breakpoint-modified and =breakpoint-created.
Reviewed by: abidh, ki.stfu
Subscribers: lldb-commits
Differential Revision: http:/
dawn planned changes to this revision.
dawn added a comment.
In http://reviews.llvm.org/D12115#227613, @abidh wrote:
> This command uses "target modules lookup" [...]
Good point. Yes, it would be good to encapsulate this. I'll rework this patch
accordingly when I can find the time (busy with
paulherman updated this revision to Diff 32593.
paulherman added a comment.
Improve tests regarding imported namespaces and chained calls in C++
http://reviews.llvm.org/D12165
Files:
test/lang/cpp/chained-calls/TestCppChainedCalls.py
test/lang/cpp/chained-calls/main.cpp
test/lang/cpp/nsim
chaoren added a subscriber: chaoren.
chaoren requested changes to this revision.
chaoren added a reviewer: chaoren.
This revision now requires changes to proceed.
Comment at: test/lang/cpp/chained-calls/TestCppChainedCalls.py:45
@@ -45,3 +44,3 @@
env = None
proce
paulherman created this revision.
paulherman added a reviewer: sivachandra.
paulherman added a subscriber: lldb-commits.
http://reviews.llvm.org/D12165
Files:
test/lang/cpp/chained-calls/TestCppChainedCalls.py
test/lang/cpp/chained-calls/main.cpp
test/lang/cpp/nsimport/TestCppNsImport.py
Author: chaoren
Date: Wed Aug 19 13:39:25 2015
New Revision: 245477
URL: http://llvm.org/viewvc/llvm-project?rev=245477&view=rev
Log:
XTIMEOUT TestChangeProcessGroup for Linux.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lld
labath updated this revision to Diff 32571.
labath marked an inline comment as done.
labath added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
Address review comments
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Pl
Author: chaoren
Date: Wed Aug 19 12:22:12 2015
New Revision: 245464
URL: http://llvm.org/viewvc/llvm-project?rev=245464&view=rev
Log:
XTIMEOUT TestEvents and TestThreadStates for Windows to Android.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/v
Author: chaoren
Date: Wed Aug 19 12:13:02 2015
New Revision: 245460
URL: http://llvm.org/viewvc/llvm-project?rev=245460&view=rev
Log:
XTIMEOUT TestExitDuringStep for Darwin.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
ybelkadi created this revision.
ybelkadi added a reviewer: jingham.
ybelkadi added a subscriber: lldb-commits.
http://reviews.llvm.org/D12158
Files:
tools/driver/Driver.cpp
Index: tools/driver/Driver.cpp
===
--- tools/driver/Drive
ybelkadi added a comment.
Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D12138
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This looks great to me. Thank you!
http://reviews.llvm.org/D11543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
ovyalov added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1049-1051
@@ -1047,5 +1048,5 @@
-NativeThreadProtocolSP new_thread_sp = GetThreadByID(tid);
+NativeThreadLinuxSP new_thread_sp =
std::static_pointer_cast(GetThreadByID(tid
Author: labath
Date: Wed Aug 19 10:24:02 2015
New Revision: 245448
URL: http://llvm.org/viewvc/llvm-project?rev=245448&view=rev
Log:
Increase timeout in TestCallThatRestarts
the test was failing on android because processing 30 signals involved a lot of
round-trips,
which was not possible in the
Author: labath
Date: Wed Aug 19 09:15:45 2015
New Revision: 245440
URL: http://llvm.org/viewvc/llvm-project?rev=245440&view=rev
Log:
Add TestCrashDuringStep
this tests that a crash that happens during instruction step is reported
correctly.
Added:
lldb/trunk/test/functionalities/thread/cras
Author: labath
Date: Wed Aug 19 08:47:57 2015
New Revision: 245436
URL: http://llvm.org/viewvc/llvm-project?rev=245436&view=rev
Log:
On Linux, clear the signal mask of the launched inferior
Summary:
Due to fork()/execve(), the launched inferior inherits the signal mask of its
parent (lldb-server
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245436: On Linux, clear the signal mask of the launched
inferior (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12138?vs=32529&id=32546#toc
Repository:
rL LLVM
http://review
labath added a comment.
Ok, I see what you mean. I will commit it with the test enabled, and I will
keep an eye out on the buildbots.
http://reviews.llvm.org/D12138
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
labath updated this revision to Diff 32545.
labath added a comment.
Fix test on android arm - skip single-stepping over some functions
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
source/Plugins
Author: omjavaid
Date: Wed Aug 19 05:44:16 2015
New Revision: 245428
URL: http://llvm.org/viewvc/llvm-project?rev=245428&view=rev
Log:
Fix lldb-server arm-linux-g++ build
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
Modified: lldb/trunk/source/Plugins/Process/Lin
ybelkadi updated this revision to Diff 32529.
ybelkadi added a comment.
Yes, the test passes, but as PR19246 reported intermittent failures, I thought
I'd wait for the results of the tests run by the bots.
Here is an updated patch also enabling the test. Could you please commit it if
it's accep
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457
@@ -1453,3 +1456,3 @@
-thread_sp = AddThread(pid);
+thread_sp =
std::static_pointer_cast(AddThread(pid));
assert (thread_sp.get() && "failed to create the
labath updated this revision to Diff 32526.
labath marked 4 inline comments as done.
labath added a comment.
- Address review comments
http://reviews.llvm.org/D12104
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
source/Plugins
abidh added a comment.
This command uses "target modules lookup" to obtain the information while
-symbol-list-lines uses "target modules dump line-table". Although there is
difference in the format of the output of these 2 commands, the format for path
and line is same. I think we should have o
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for catching this.
Does the test you mentioned pass after this, or does it still fail
intermittently as the original bug indicates? If it seems to pass, you should
also ena
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
sagar added inline comments.
Comment at: include/lldb/Core/RegisterValue.h:185
@@ -190,1 +184,3 @@
+llvm::APInt
+GetAsUInt128 (llvm::APInt& fail_value, bool *success_ptr = NULL) const;
ovyalov wrote:
> Could you pass fail_value as a const referen
43 matches
Mail list logo
