Re: [PATCH] powerpc/kexec: Fix the return of uninitialized variable

2024-10-08 Thread zhangzekun (A)
在 2024/9/30 17:01, Madhavan Srinivasan 写道: On 9/30/24 1:57 PM, Christophe Leroy wrote: Le 30/09/2024 à 09:56, Zhang Zekun a écrit : [Vous ne recevez pas souvent de courriers de zhangzeku...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]

Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced()

2025-02-09 Thread zhangzekun (A)
Hi, Laurent, I think we all agree that of_find_node_by_name() is miused, and that it shows the API isn't optimal. What we have different opinions on is how to make the API less error-prone. I think adding a new of_find_node_by_name_balanced() function works around the issue and doesn't improve t

Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced()

2025-02-07 Thread zhangzekun (A)
在 2025/2/7 16:24, Oleksij Rempel 写道: On Fri, Feb 07, 2025 at 09:31:09AM +0800, Zhang Zekun wrote: There are many drivers use of_find_node_by_name() with a not-NULL device_node pointer, and a number of callers would require a call to of_node_get() before using it. There are also some drivers w

Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced()

2025-02-11 Thread zhangzekun (A)
在 2025/2/10 18:03, Laurent Pinchart 写道: Hi Zekun, On Mon, Feb 10, 2025 at 02:47:28PM +0800, zhangzekun (A) wrote: I think we all agree that of_find_node_by_name() is miused, and that it shows the API isn't optimal. What we have different opinions on is how to make the API less error-

Re: [PATCH 2/9] net: bcmasp: Add missing of_node_get() before of_find_node_by_name()

2025-02-11 Thread zhangzekun (A)
在 2025/2/12 13:52, Krzysztof Kozlowski 写道: On 07/02/2025 02:31, Zhang Zekun wrote: of_find_node_by_name() will decrease the refcount of the device_node. So, get the device_node before passing to it. Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller") Signed-off-by