Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting

2019-07-19 Thread shuah
c3. This isn't part of this series anyway and I would like to get this in right away. thanks, -- Shuah

Re: [PATCH] sefltest/ima: support appended signatures (modsig)

2019-08-28 Thread shuah
1 ] && [ $ima_signed -eq 0 ]; then + if [ $ima_sig_required -eq 1 ] && [ $ima_signed -eq 0 ] \ +&& [ $ima_modsig -eq 0 ]; then log_fail "$succeed_msg (missing IMA sig)" fi @@ -204,5 +231,8 @@ pe_signed=$? check_for_imasig ima_signed=$? +check_for_modsig +ima_modsig=$? + # Test loading the kernel image via kexec_file_load syscall kexec_file_load_test thanks, -- Shuah

Re: [PATCH v1] sefltest/ima: support appended signatures (modsig)

2019-08-28 Thread shuah
an appended signature and updates the existing test messages appropriately. Reviewed-by: Petr Vorel Signed-off-by: Mimi Zohar --- Thanks Mimi. This commit log looks good. My Ack for the patch to go through the IMA tree. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH -next 5/5] USB: usbip: Remove an unnecessary NULL value

2023-08-04 Thread shuah
going to out. if (!udc_dev) goto out; thanks, -- Shuah

Re: [PATCH v5 1/3] powerpc: Fix vDSO clock_getres()

2019-05-30 Thread shuah
") Cc: sta...@vger.kernel.org Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Signed-off-by: Vincenzo Frascino Reviewed-by: Christophe Leroy --- Note: This patch is independent from the others in this series, hence it can be merged singularly by the powerpc maintainers.

Re: [PATCH v5 2/3] s390: Fix vDSO clock_getres()

2019-05-30 Thread shuah
--- Note: This patch is independent from the others in this series, hence it can be merged singularly by the s390 maintainers. Acked-by: Shuah Khan thanks, -- Shuah

Re: [V5 7/7] selftests, powerpc: Add test case for TM related ptrace interface

2014-11-25 Thread Shuah Khan
e > Could you please add .gitignore for the binaries in this directory to avoid git status including the binaries it in its output. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 __

Re: [PATCH V6 9/9] selftests: Make GIT ignore all binaries in powerpc test suite

2014-12-02 Thread Shuah Khan
pler without having to add one .gitignore for each directory underneath. Thanks for taking on the task to add .gitignore for all powerpc binaries. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 __

Re: [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default

2015-01-13 Thread Shuah Khan
he DSCR default */ > + for (i = 0; i < COUNT; i++) { > + double ret = uniform_deviate(rand()); > + > + if (ret < 0.0001) { > + sequence++; > + wmb(); > + > + dscr++; > +

[PATCH] powerpc: fix wii_memory_fixups() compile error on 3.0.y tree

2012-12-07 Thread Shuah Khan
type ‘phys_addr_t’ [-Werror=format] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/platforms/embedded6xx/wii.o] Error 1 make[1]: *** [arch/powerpc/platforms/embedded6xx] Error 2 make: *** [arch/powerpc/platforms] Error 2 Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.0

Re: [PATCH] powerpc: fix wii_memory_fixups() compile error on 3.0.y tree

2012-12-08 Thread Shuah Khan
On Sat, Dec 8, 2012 at 10:22 AM, Ben Hutchings wrote: > On Fri, 2012-12-07 at 19:07 -0700, Shuah Khan wrote: >> Fix wii_memory_fixups() the following compile error on 3.0.y tree with >> wii_defconfig on 3.0.y tree. >> >> CC arch/powerpc/platforms/embedded6xx/wii.

[PATCH v2] powerpc: fix wii_memory_fixups() compile error on 3.0.y tree

2012-12-10 Thread Shuah Khan
type ‘phys_addr_t’ [-Werror=format] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/platforms/embedded6xx/wii.o] Error 1 make[1]: *** [arch/powerpc/platforms/embedded6xx] Error 2 make: *** [arch/powerpc/platforms] Error 2 Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.0

Re: [PATCH v2] powerpc: fix wii_memory_fixups() compile error on 3.0.y tree

2012-12-11 Thread Shuah Khan
On Mon, 2012-12-10 at 18:55 +, Ben Hutchings wrote: > On Mon, Dec 10, 2012 at 10:23:16AM -0700, Shuah Khan wrote: > > Fix wii_memory_fixups() the following compile error on 3.0.y tree with > > wii_defconfig on 3.0.y tree. > > > > CC arch/powerpc/platforms

[PATCH v3] powerpc: fix wii_memory_fixups() compile error on 3.0.y tree

2012-12-12 Thread Shuah Khan
‘phys_addr_t’ [-Werror=format] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/platforms/embedded6xx/wii.o] Error 1 make[1]: *** [arch/powerpc/platforms/embedded6xx] Error 2 make: *** [arch/powerpc/platforms] Error 2 Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.0.y

[RFT][PATCH 04/12] drivers/macintosh/adb: change platform power management to use dev_pm_ops

2014-02-10 Thread Shuah Khan
Change adb platform driver to register pm ops using dev_pm_ops instead of legacy pm_ops. .pm hooks call existing legacy suspend and resume interfaces by passing in the right pm state. Signed-off-by: Shuah Khan --- drivers/macintosh/adb.c | 41 - 1 file

[RFT][PATCH 00/12] change drivers power management to use dev_pm_ops

2014-02-10 Thread Shuah Khan
Change drivers to register pm ops using dev_pm_ops instead of legacy pm_ops. .pm hooks call existing legacy suspend and resume interfaces by passing in the right pm state. Bus drivers suspend and resume routines call .pm driver hooks if found. Shuah Khan (12): arm: change locomo platform and

Re: [PATCH V2 07/12] selftests, powerpc: Add test for explicitly changing DSCR value

2015-01-13 Thread Shuah Khan
return 1; > + } > + } > + return 0; > +} > + > +int main(int argc, char *argv[]) > +{ > + return test_harness(test_body, "dscr_explicit_test"); > +} > Could you please add a .gitignore for powerpc targets as we discu

Re: [PATCH V2 08/12] selftests, powerpc: Add test for DSCR SPR numbers

2015-01-13 Thread Shuah Khan
gt; + if (check_dscr("user")) > + return 1; > + } > + return 0; > +} > + > +int main(int argc, char *argv[]) > +{ > + return test_harness(test_body, "dscr_user_test"); > +} > Could you please add a .g

Re: [PATCH V2 09/12] selftests, powerpc: Add test for DSCR value inheritence across fork

2015-01-13 Thread Shuah Khan
> + "but is %ld\n", dscr, cur_dscr_usr); > + exit(1); > + } > + exit(0); > + } > + } > + return 0; > +} > + > +int main(int argc, cha

Re: [PATCH V2 10/12] selftests, powerpc: Add test for DSCR inheritence across fork & exec

2015-01-13 Thread Shuah Khan
p; !strcmp(argv[1], "exec")) { > + unsigned long parent_dscr; > + > + parent_dscr = atoi(argv[2]); > + do_exec(parent_dscr); > + } else if (argc != 1) { > + fprintf(stderr, "Usage: %s\n", argv[0]); > +

Re: [PATCH V2 11/12] selftests, powerpc: Add test for all DSCR sysfs interfaces

2015-01-13 Thread Shuah Khan
r_defaults(j)) > + return 1; > + } > + } > + return 0; > +} > + > +int main(int argc, char *argv[]) > +{ > + return test_harness(test_body, "dscr_sysfs_test"); > +}

Re: [PATCH V2 12/12] selftests, powerpc: Add thread based stress test for DSCR sysfs interfaces

2015-01-13 Thread Shuah Khan
result = malloc(sizeof(unsigned long) * sysconf(_SC_NPROCESSORS_ONLN)); > + pthread_mutex_init(&lock, NULL); > + target = 0; > + for (i = 0; i < COUNT; i++) { > + for (j = 0; j < DSCR_MAX; j++) { > + set_default_dscr(j); > +

Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests

2015-01-13 Thread Shuah Khan
44 tools/testing/selftests/powerpc/primitives/.gitignore > create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore Please create a single .gitignore for all targets right under tools/testing/selftests/powerpc instead of multiple .gitignore files. thanks, -- Shuah -- Shuah Khan Sr. Lin

Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests

2015-01-14 Thread Shuah Khan
On 01/13/2015 07:15 PM, Michael Ellerman wrote: > On Tue, 2015-01-13 at 17:16 -0700, Shuah Khan wrote: >> Please add a commit log. > > What does it need to say? Explain the change the patch is making. Please see Documentation/SubmittingPatches for details. Looks like this pat

Re: [PATCH] selftest/lkdtm: Use local .gitignore

2020-02-27 Thread Shuah Khan
d the problem in the previous version. It slipped by me. :( thanks, -- Shuah

Re: [PATCH 0/2] selftests: vm: Build fixes for powerpc64

2020-03-31 Thread Shuah Khan
deletions(-) Michael, I see your tested-by on these two patches. I will take these through kselftest fixes. Sorry for the delay. I assumed these will go through ppc64 or vm. thanks, -- Shuah

Re: [PATCH 1/2] selftests: vm: Do not override definition of ARCH

2020-04-10 Thread Shuah Khan
tests: vm: Build/Run 64bit tests only on 64bit arch") overrides the value of ARCH with the machine name from uname. This does not always match the architecture names used for tasks like header installation. Please make sure to run checkpatch with --strict to catch these kinds of errors in the future. thanks, -- Shuah

Re: [PATCH v6] selftests: add headers_install to lib.mk

2018-09-28 Thread Shuah Khan
> Why did it go in at rc5? > This patch has been in linux-next for a sometime before I decided to send this. My original intent was to send this for rc2, and my schedule was messed up with traveling. Since I didn't hear any issues from linux-next soaking, I made a call on sending this in for rc5. On second thought I should have waited until 4.20. Sorry about that. thanks, -- Shuah

Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'

2020-02-20 Thread Shuah Khan
Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets") Signed-off-by: Christophe Leroy Without this, 'git status' now reports the following crap and real problems are drowned in the middle, that's annoying. I will pull this in. Please cc linux-kselftest mailing list in the future. thanks, -- Shuah

[PATCH RFT] powerpc: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan --- arch/powerpc/include/asm/dma

[PATCH RFT RESEND linux-next] powerpc: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan --- arch/powerpc/include/asm/dma

Re: [PATCH RFT RESEND linux-next] powerpc: dma-mapping: support debug_dma_mapping_error

2012-11-15 Thread Shuah Khan
On Fri, 2012-10-26 at 10:08 -0600, Shuah Khan wrote: > Add support for debug_dma_mapping_error() call to avoid warning from > debug_dma_unmap() interface when it checks for mapping error checked > status. Without this patch, device driver failed to check map error > warning

[PATCH 1/9] ARM64: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan Acked-by: Catalin Marinas --- arch/arm64/include/asm/dma-mapping.h |1 + 1 file

[PATCH 2/9] c6x: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan Acked-by: Mark Salter --- arch/c6x/include/asm/dma-mapping.h |1 + 1 file changed, 1

[PATCH 0/9] dma_debug: add debug_dma_mapping_error support to architectures that support DMA_DEBUG_API

2012-11-23 Thread Shuah Khan
pport Thanks, -- Shuah ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 8/9] sparc: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan Acked-by: David S. Miller --- arch/sparc/include/asm/dma-mapping.h |1 + 1 file

[PATCH 9/9] tile: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan --- arch/tile/include/asm/dma-mapping.h |1 + 1 file changed, 1 insertion(+) diff

[PATCH 5/9] mips: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan --- arch/mips/include/asm/dma-mapping.h |2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 6/9] powerpc: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan --- arch/powerpc/include/asm/dma-mapping.h |1 + 1 file changed, 1 insertion(+) diff

[PATCH 4/9] microblaze: dma-mapping: support debug_dma_mapping_error

2012-11-23 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan Acked-by: Michal Simek --- This patch is

[PATCH 3/9] ia64: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan --- arch/ia64/include/asm/dma-mapping.h |1 + 1 file changed, 1 insertion(+) diff

[PATCH 7/9] sh: dma_debug: add debug_dma_mapping_error support

2012-11-23 Thread Shuah Khan
Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page() interfaces. Signed-off-by: Shuah Khan --- arch/sh/include/asm/dma-mapping.h |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 0/9] dma_debug: add debug_dma_mapping_error support to architectures that support DMA_DEBUG_API

2012-11-26 Thread Shuah Khan
On Mon, 2012-11-26 at 12:22 +0100, Joerg Roedel wrote: > Hi Shuah, > > On Fri, Nov 23, 2012 at 02:29:02PM -0700, Shuah Khan wrote: > > x86 - done in the first patch that added the feature. > > > > ARM64: dma_debug: add debug_dma_mapping_error supp

Re: [PATCH 21/34] selftests: powerpc: Fix incorrect kernel headers search path

2023-01-30 Thread Shuah Khan
Cc: Shuah Khan Cc: linux-kselft...@vger.kernel.org Cc: Ingo Molnar Cc: [5.18+] --- tools/testing/selftests/powerpc/ptrace/Makefile | 2 +- tools/testing/selftests/powerpc/security/Makefile | 2 +- tools/testing/selftests/powerpc/syscalls/Makefile | 2 +- tools/testing/selftests/powerpc

Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

2023-01-30 Thread Shuah Khan
ers search path # 02/34 selftests: net: Fix incorrect kernel headers search path # 17/34 selftests: powerpc: Fix incorrect kernel headers search path # 21/34 selftests: bpf docs: Use installed kernel headers search path # 30/34 thanks, -- Shuah

Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

2023-01-30 Thread Shuah Khan
On 1/30/23 16:45, Alexei Starovoitov wrote: On Mon, Jan 30, 2023 at 2:46 PM Shuah Khan wrote: On 1/27/23 06:57, Mathieu Desnoyers wrote: Hi, This series fixes incorrect kernel header search path in kernel selftests. Near the end of the series, a few changes are not tagged as "

Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

2023-02-01 Thread Shuah Khan
Hi Mathieu, On 1/30/23 15:29, Shuah Khan wrote: On 1/27/23 06:57, Mathieu Desnoyers wrote: Hi, This series fixes incorrect kernel header search path in kernel selftests. Near the end of the series, a few changes are not tagged as "Fixes" because the current behavior is to rely on

Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

2023-02-03 Thread Shuah Khan
On 2/1/23 19:07, Shuah Khan wrote: Hi Mathieu, On 1/30/23 15:29, Shuah Khan wrote: On 1/27/23 06:57, Mathieu Desnoyers wrote: Hi, This series fixes incorrect kernel header search path in kernel selftests. Near the end of the series, a few changes are not tagged as "Fixes" b

Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

2023-02-10 Thread Shuah Khan
On 2/3/23 18:06, Shuah Khan wrote: On 2/1/23 19:07, Shuah Khan wrote: Hi Mathieu, On 1/30/23 15:29, Shuah Khan wrote: On 1/27/23 06:57, Mathieu Desnoyers wrote: Hi, This series fixes incorrect kernel header search path in kernel selftests. Near the end of the series, a few changes are not

Re: [PATCH v13 25/35] KVM: selftests: Convert lib's mem regions to KVM_SET_USER_MEMORY_REGION2

2024-04-25 Thread Shuah Khan
xample. thanks, -- Shuah

Re: [PATCH v13 25/35] KVM: selftests: Convert lib's mem regions to KVM_SET_USER_MEMORY_REGION2

2024-04-25 Thread Shuah Khan
On 4/25/24 09:09, Sean Christopherson wrote: On Thu, Apr 25, 2024, Shuah Khan wrote: On 4/25/24 08:12, Dan Carpenter wrote: On Fri, Oct 27, 2023 at 11:22:07AM -0700, Sean Christopherson wrote: Use KVM_SET_USER_MEMORY_REGION2 throughout KVM's selftests library so that support for guest pr

Re: [PATCH v2] selftests/seccomp: fix ptrace tests on powerpc

2020-09-11 Thread Shuah Khan
variant->use_ptrace); ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); ASSERT_EQ(0, ret); Hi Kees, If you want to take this through your tree: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] testing/selftests/mqueue: Fix mq_perf_tests to free the allocated cpu set

2022-04-06 Thread Shuah Khan
e problem. Review the other exit paths where CPU_FREE is needed. thanks, -- Shuah

Re: [PATCH V2] testing/selftests/mqueue: Fix mq_perf_tests to free the allocated cpu set

2022-04-07 Thread Shuah Khan
g: From v1 -> v2: Addressed review comment from Shuah Khan to add CPU_FREE in other exit paths where it is needed Thank you. I have a couple of comments on making the error paths simpler. Please see below. tools/testing/selftests/mqueue/mq_perf_tests.c | 10 +- 1 file cha

Re: [PATCH V3] testing/selftests/mqueue: Fix mq_perf_tests to free the allocated cpu set

2022-04-08 Thread Shuah Khan
) Signed-off-by: Athira Rajeev --- Changelog: From v2 -> v3: Addressed review comment from Shuah Khan to add common "goto" error path with CPU_FREE for few exit cases. From v1 -> v2: Addressed review comment from Shuah Khan to add CPU_FREE in other exit paths wher

Re: [PATCH 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2020-07-07 Thread Shuah Khan
$LOG +NUM_CPUS=$(nproc --all) +NUM_STATES=$(ls -1 /sys/devices/system/cpu/cpu0/cpuidle/ | wc -l) + +# Insert the module +ins_mod $MODULE + +printf "Started IPI latency tests\n" +run_ipi_tests + +printf "Started Timer latency tests\n" +run_timeout_tests + +printf "Removing $MODULE module\n" +printf "Output logged at: $LOG\n" +rmmod $MODULE diff --git a/tools/testing/selftests/cpuidle/settings b/tools/testing/selftests/cpuidle/settings new file mode 100644 index ..e7b9417537fb --- /dev/null +++ b/tools/testing/selftests/cpuidle/settings @@ -0,0 +1 @@ +timeout=0 thanks, -- Shuah

Re: [PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

2021-08-24 Thread Shuah Khan
tm-poison.c @@ -20,7 +20,6 @@ #include #include #include -#include #include "tm.h" We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah

Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

2021-08-24 Thread Shuah Khan
/tm/tm-poison.c @@ -20,7 +20,6 @@ #include #include #include -#include #include "tm.h" We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah

Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

2021-08-24 Thread Shuah Khan
On 8/24/21 10:35 AM, Christophe Leroy wrote: Le 24/08/2021 à 16:41, Shuah Khan a écrit : On 8/23/21 9:05 PM, CGEL wrote: From: Changcheng Deng Clean up the following includecheck warning: ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included more than once. No

Re: [PATCH v3 1/8] PCI/AER: Remove ID from aer_agent_string[]

2021-10-04 Thread Shuah Khan
char *level; if (!info->status) { - pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent ID)\n", + pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent)\n", aer_error_severity_string[info->severity]); goto out; } thanks, -- Shuah

Re: [PATCH v1 2/6] mm/memory_hotplug: remove CONFIG_MEMORY_HOTPLUG_SPARSE

2021-10-05 Thread Shuah Khan
CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m CONFIG_MEMORY_HOTREMOVE=y For Kselftest change: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 2/2] KVM: selftests: Add support for ppc64le

2022-02-02 Thread Shuah Khan
Same line. asm ("mfpvr %0" : "=r"(pvr)); + return pvr; +} + +#endif thanks, -- Shuah

Re: [PATCH] selftest/vm: Use correct PAGE_SHIFT value for ppc64

2022-02-09 Thread Shuah Khan
(pagemap_fd, ent, sizeof(ent), (uintptr_t)ptr >> (PAGE_SHIFT - 3)) != sizeof(ent)) err(2, "read pagemap"); Cc: Shuah Khan Signed-off-by: Aneesh Kumar K.V --- tools/testing/selftests/vm/ksm_tests.c| 8 tools/testing/selftests/vm/tr

Re: [PATCH] selftest/vm: Use correct PAGE_SHIFT value for ppc64

2022-02-10 Thread Shuah Khan
On 2/9/22 9:12 PM, Aneesh Kumar K.V wrote: Shuah Khan writes: On 2/9/22 8:43 AM, Aneesh Kumar K.V wrote: Keep it simple by using a #define and limiting hugepage size to 2M. This keeps the test simpler instead of dynamically finding the page size and huge page size. Without this tests are

Re: [PATCH] selftest/vm: Use correct PAGE_SHIFT value for ppc64

2022-02-10 Thread Shuah Khan
On 2/10/22 8:03 AM, Aneesh Kumar K V wrote: On 2/10/22 20:09, Shuah Khan wrote: On 2/9/22 9:12 PM, Aneesh Kumar K.V wrote: Shuah Khan writes: On 2/9/22 8:43 AM, Aneesh Kumar K.V wrote: Keep it simple by using a #define and limiting hugepage size to 2M. This keeps the test simpler instead

[PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:44: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/x86/Makefile | 3

[PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

2017-04-21 Thread Shuah Khan
Define CLEAN macro to allow Makefiles to override common clean target in lib.mk. This will help fix the following failures: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/test

[PATCH 7/8] selftests: sync: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:24: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/sync/Make

[PATCH 0/8] Fix clean target warnings

2017-04-21 Thread Shuah Khan
This patch series consists of changes to lib.mk to allow overriding common clean target from Makefiles. This fixes warnings when clean overriding and ignoring warnings. Also fixes splice clean target removing a script that runs the test from its clean target. Shuah Khan (8): selftests: splice

[PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:36: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/futex/Make

[PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:11: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/gpio/Make

[PATCH 1/8] selftests: splice: fix clean target to not remove default_file_splice_read.sh

2017-04-21 Thread Shuah Khan
splice clean target removes the shell script default_file_splice_read.sh that runs the splice test. Fix it to not remove this file. Signed-off-by: Shuah Khan --- tools/testing/selftests/splice/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests

[PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:8: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/splice/Make

[PATCH 5/8] selftests: powerpc: override clean in lib.mk to fix warnings

2017-04-21 Thread Shuah Khan
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:63: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- tools/testing/selftests/powerpc/Make

Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

2017-04-24 Thread Shuah Khan
On 04/24/2017 09:45 AM, David Laight wrote: > From: Shuah Khan >> Sent: 22 April 2017 00:15 >> Define CLEAN macro to allow Makefiles to override common clean target >> in lib.mk. This will help fix the following failures: >> >> warning: overriding recipe for target

Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings

2017-04-24 Thread Shuah Khan
On 04/24/2017 09:57 AM, David Laight wrote: > From: Linuxppc-dev Michael Ellerman >> Shuah Khan writes: >> >>> Add override for lib.mk clean to fix the following warnings from clean >>> target run. >>> >>> Makefile:44: warning: overriding

Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

2017-04-25 Thread Shuah Khan
On 04/21/2017 11:38 PM, Michael Ellerman wrote: > Shuah Khan writes: > >> Define CLEAN macro to allow Makefiles to override common clean target >> in lib.mk. This will help fix the following failures: >> >> warning: overriding recipe for target 'clean'

Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
On 04/21/2017 11:40 PM, Michael Ellerman wrote: > Shuah Khan writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:11: warning: overriding recipe for target 'clean' >> ../lib.mk:55:

Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
On 04/21/2017 11:40 PM, Michael Ellerman wrote: > Shuah Khan writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:8: warning: overriding recipe for target 'clean' >> ../lib.mk:55:

Re: [PATCH 7/8] selftests: sync: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
On 04/21/2017 11:41 PM, Michael Ellerman wrote: > Shuah Khan writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:24: warning: overriding recipe for target 'clean' >> ../lib.mk:55:

Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
On 04/21/2017 11:41 PM, Michael Ellerman wrote: > Shuah Khan writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:44: warning: overriding recipe for target 'clean' >> ../lib.mk:55:

[PATCH v2] selftests: x86: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
Add override with EXTRA_CLEAN for lib.mk clean to fix the following warnings from clean target run. Makefile:44: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- Changes since v1:

[PATCH v2] selftests: sync: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
Add override with EXTRA_CLEAN for lib.mk clean to fix the following warnings from clean target run. Makefile:24: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- Changes since v1:

[PATCH v2] selftests: splice: override clean in lib.mk to fix warnings

2017-04-25 Thread Shuah Khan
Add override with EXTRA_CLEAN for lib.mk clean to fix the following warnings from clean target run. Makefile:8: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan --- Changes since v1:

Re: [PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings

2017-04-27 Thread Shuah Khan
On 04/27/2017 03:54 PM, Darren Hart wrote: > On Fri, Apr 21, 2017 at 05:14:45PM -0600, Shuah Khan wrote: >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:36: warning: overriding recipe for target 'clean' &

Re: [PATCH 0/8] Fix clean target warnings

2017-04-27 Thread Shuah Khan
On 04/21/2017 05:14 PM, Shuah Khan wrote: > This patch series consists of changes to lib.mk to allow overriding > common clean target from Makefiles. This fixes warnings when clean > overriding and ignoring warnings. Also fixes splice clean target > removing a script that runs the t

Re: [PATCH kernel] vfio/spapr: Add trace points for map/unmap

2017-11-29 Thread Shuah Khan
racing/events/vfio/vfio_iommu_spapr_tce/map will. > > But iommu/map does work, it's just not called by the vfio spapr tce > backend, which is absolutely correct. In fact, that's part of my > reservation about this approach is that it could be interpreted as > implying a call path that doesn't exist on this arch. These tracepoints are intended to be called after a iommo/map/unmap calls from IOMMU API. It doesn't make any sense to call them from random places. It is totally useless to do so and makes it difficult to debug problems. As an author of these tracepoints - that is my opinion. thanks, -- Shuah

Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

2017-02-14 Thread Shuah Khan
he start of lib.mk, making it the >> default target. >> >> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target") >> Signed-off-by: Michael Ellerman > > Hi Shuah, > > Can you please merge this series into linux-next? > > Th

Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

2017-03-01 Thread Shuah Khan
he start of lib.mk, making it the >> default target. >> >> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target") >> Signed-off-by: Michael Ellerman > > Hi Shuah, > > Can you please merge this series into linux-next? > > The s

Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

2017-03-02 Thread Shuah Khan
Hi Michael and Bamovar, On 03/01/2017 11:43 PM, Michael Ellerman wrote: > Shuah Khan writes: >> Hi Bamovar, >> >> Your original series badly broke the selftest build. I can no longer >> build individual tests. For example: >> >> cd breakpoints/ >> s

Re: [PATCH v2 1/1] rtc: rtctest: Improve support detection

2017-08-16 Thread Shuah Khan
TC_AIE_ON, 0); > if (retval == -1) { > - if (errno == EINVAL) { > + if (errno == EINVAL || errno == EIO) { > fprintf(stderr, > "\n...Alarm IRQs not supported.\n"); > goto test_PIE; > Applied to linux-kselftest next for 4.14-rc1 thanks, -- Shuah

Re: [PATCH] selftests/overlayfs: Fix build error on ppc64

2024-05-29 Thread Shuah Khan
+#define __SANE_USERSPACE_TYPES__ // Use ll64 #include #include Applied to linux-kselftest fixes for the next rc. Michael, If you want to take this through, let me know, I can drop this. thanks, -- Shuah

Re: [PATCH] selftests: cachestat: Fix build warnings on ppc64

2024-05-29 Thread Shuah Khan
#include Applied to linux-kselftest fixes for the next rc. Michael, If you want to take this through, let me know, I can drop this. thanks, -- Shuah

Re: [PATCH] selftests/openat2: Fix build warnings on ppc64

2024-05-29 Thread Shuah Khan
fixes for the next rc. Michael, If you want to take this through, let me know, I can drop this. thanks, -- Shuah

Re: [PATCH v4 28/29] kselftest/arm64: Add test case for POR_EL0 signal frame records

2024-07-05 Thread Shuah Khan
On 5/29/24 09:51, Mark Brown wrote: On Fri, May 03, 2024 at 02:01:46PM +0100, Joey Gouly wrote: Ensure that we get signal context for POR_EL0 if and only if POE is present on the system. Reviewed-by: Mark Brown For kselftest: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/5] selftests: vdso: Fix vDSO name for powerpc

2024-08-30 Thread Shuah Khan
On 8/30/24 06:41, Jason A. Donenfeld wrote: Hi Shuah, No 0/5 patch, so replying to the first one. These are fixes to the vDSO selftests that Christophe is ostensibly providing as a preamble to his work porting vgetrandom to PPC. Do you mind if I take these via my random tree so his PPC

Re: [PATCH v2] selftests/ftrace: adjust offset for kprobe syntax error test

2024-12-05 Thread Shuah Khan
On 12/3/24 18:20, Steven Rostedt wrote: On Tue, 3 Dec 2024 18:01:06 -0700 Shuah Khan wrote: On 12/2/24 12:41, Steven Rostedt wrote: On Sat, 30 Nov 2024 01:56:21 +0530 Hari Bathini wrote: In 'NOFENTRY_ARGS' test case for syntax check, any offset X of `vfs_read+X` except func

Re: [PATCH v2] selftests/ftrace: adjust offset for kprobe syntax error test

2024-12-03 Thread Shuah Khan
on build configuration (see arch_kprobe_on_func_entry() for implementation details). So, use `vfs_read+20` to accommodate that scenario too. Suggested-by: Masami Hiramatsu Signed-off-by: Hari Bathini Acked-by: Steven Rostedt (Google) Shuah, Can you take this through your tree? Yes I can take it. I do have

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-04-05 Thread Shuah Khan
l put them into mm.git, to advance things a bit. I haven't heard from kunit maintainers yet. This thread got lost in inbox due to travel. David/Brendan/Rae, Okay to take this series? Andrew, Okay to take this through your tree - this needs merging. thanks, -- Shuah