Re: [PATCH v1 2/4] powerpc/mm: print warning in arch_remove_linear_mapping()

2020-11-04 Thread osalvador
On Thu, Oct 29, 2020 at 05:27:16PM +0100, David Hildenbrand wrote: > Let's print a warning similar to in arch_add_linear_mapping() instead of > WARN_ON_ONCE() and eventually crashing the kernel. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Rashmica Gupta > C

Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()

2020-11-04 Thread osalvador
On Thu, Oct 29, 2020 at 05:27:17PM +0100, David Hildenbrand wrote: > Let's revert what we did in case seomthing goes wrong and we return an > error. Dumb question, but should not we do this for other arches as well? -- Oscar Salvador SUSE L3

Re: [PATCH v2 5/8] mm/memory_hotplug: Drop MHP_MEMBLOCK_API

2019-05-08 Thread osalvador
On Wed, 2019-05-08 at 09:39 +0200, David Hildenbrand wrote: > However I haven't really thought it through yet, smalles like that > could > as well just be handled by the caller of > arch_add_memory()/arch_remove_memory() eventually, passing it via > something like the altmap parameter. > > Let's l