Re: [PATCH v6] dmaengine: Driver support for FSL RaidEngine device.

2015-04-02 Thread Vinod Koul
On Tue, Mar 03, 2015 at 02:26:22PM +0800, xuelin@freescale.com wrote: > From: Xuelin Shi > > The RaidEngine is a new FSL hardware used for Raid5/6 acceration. > This patch enables the RaidEngine functionality and provides > hardware offloading capability for memcpy, xor and pq computation. >

[PATCH 0/6] dmaengine: remove FSLDMA_EXTERNAL_START

2014-10-11 Thread Vinod Koul
to new dependency. Vinod Koul (6): dmaengine: add dmaengine_prep_dma_sg() helper dmaengine: freescale: add and export fsl_dma_external_start() carma-fpga: use dmaengine_xxx() API carma-fpga: move to fsl_dma_external_start() dmaengine: freescale: remove FSLDMA_EXTERNAL_START control

[PATCH 1/6] dmaengine: add dmaengine_prep_dma_sg() helper

2014-10-11 Thread Vinod Koul
This was only prep API which didnt have an helper Signed-off-by: Vinod Koul --- include/linux/dmaengine.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 3d291f5..ce8a08e 100644 --- a/include/linux

[PATCH 2/6] dmaengine: freescale: add and export fsl_dma_external_start()

2014-10-11 Thread Vinod Koul
The freescale driver uses custom device control FSLDMA_EXTERNAL_START to put the controller in external start mode. Since we are planning to deprecate the device control, move this to exported API. Subsequent patches will remove the FSLDMA_EXTERNAL_START Signed-off-by: Vinod Koul --- drivers

[PATCH 3/6] carma-fpga: use dmaengine_xxx() API

2014-10-11 Thread Vinod Koul
The drivers should use dmaengine_slave_config() and dmaengine_prep_dma_sg() API instead of accessing the device_control which will be deprecated soon Signed-off-by: Vinod Koul --- drivers/misc/carma/carma-fpga-program.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 5/6] dmaengine: freescale: remove FSLDMA_EXTERNAL_START control method

2014-10-11 Thread Vinod Koul
since users have been move to fsl_dma_external_start() API, so remove this now Signed-off-by: Vinod Koul --- drivers/dma/fsldma.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 0cded86..994bcb2 100644 --- a

[PATCH 4/6] carma-fpga: move to fsl_dma_external_start()

2014-10-11 Thread Vinod Koul
carma-fpga driver uses device control with custom FSLDMA_EXTERNAL_START command. Since we wnat to deprecate the device control, move this driver to use new fsl_dma_external_start() API Signed-off-by: Vinod Koul --- drivers/misc/carma/carma-fpga-program.c |3 ++- 1 files changed, 2

[PATCH 6/6] dmaengine: remove FSLDMA_EXTERNAL_START

2014-10-11 Thread Vinod Koul
as users have been converted, so no need of this custom method Signed-off-by: Vinod Koul --- include/linux/dmaengine.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index ce8a08e..3254a03 100644 --- a/include

Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.

2014-10-17 Thread Vinod Koul
On Fri, Oct 17, 2014 at 02:13:20AM +, Xuelin Shi wrote: > Hi Dan & Vinod, > > I have sent out the v4 of this patch and not received any further feedback > yet. > > This patch looks ruled out from the patchwork. > https://patchwork.kernel.org/project/linux-dmaengine/list/?page=2 > > So do y

Re: [RESEND PATCH v4] dmaengine: Driver support for FSL RaidEngine device.

2014-12-05 Thread Vinod Koul
On Fri, Oct 17, 2014 at 03:28:20PM +0800, xuelin@freescale.com wrote: > +/* > + * drivers/dma/fsl_raid.c > + * > + * Freescale RAID Engine device driver > + * > + * Author: > + * Harninder Rai > + * Naveen Burmi > + * > + * Rewrite: > + * Xuelin Shi > + * > + * Copyright (c) 2010-2014

Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-05-02 Thread Vinod Koul
On Wed, May 01, 2013 at 03:28:09PM +0400, Alexander Popov wrote: > The initial version of this driver supports only memory to memory > data transfers. > > Data transfers between memory and i/o memory require more delicate TCD > (Transfer Control Descriptor) configuration and DMA channel service re

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

2013-05-30 Thread Vinod Koul
On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote: > Here is a set of small independent patches that clean up or fix minor things > across DMA slave drivers. The series looks fine. I am going to wait a day more and apply, pls speak up if you disagree and ack if you agree -- ~Vinod >

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

2013-07-15 Thread Vinod Koul
On Fri, May 31, 2013 at 05:09:51PM -0700, Dan Williams wrote: > On Thu, May 30, 2013 at 10:47 AM, Vinod Koul wrote: > > On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote: > >> Here is a set of small independent patches that clean up or fix minor > >> t

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

2013-07-15 Thread Vinod Koul
On Thu, May 30, 2013 at 09:32:19PM +0300, Andy Shevchenko wrote: > >> Here is a set of small independent patches that clean up or fix minor > >> things > >> across DMA slave drivers. Applied thanks -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@l

Re: [PATCH 00/12] dma: various minor clean ups for slave drivers

2013-07-15 Thread Vinod Koul
On Mon, Jul 15, 2013 at 01:21:17PM +0300, Andy Shevchenko wrote: > On Mon, 2013-07-15 at 15:07 +0530, Vinod Koul wrote: > > On Thu, May 30, 2013 at 09:32:19PM +0300, Andy Shevchenko wrote: > > > >> Here is a set of small independent patches that clean up or fi

Re: [PATCH v6 3/3] DMA: Freescale: update driver to support 8-channel DMA engine

2013-07-28 Thread Vinod Koul
On Fri, Jul 26, 2013 at 06:27:16PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > This patch adds support to 8-channel DMA engine, thus the driver works for > both > the new 8-channel and the legacy 4-channel DMA engines. > > Signed-off-by: Hongbo Zhang This looks fine. I ne

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-07-29 Thread Vinod Koul
On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Hi Vinod, Dan, Scott and Leo, please have a look at these V7 patches. The dma relates changes look okay to me. I need someone to review and ACK the DT bindings. ~Vinod > > Freescale QorIQ T4 an

Re: [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-08-20 Thread Vinod Koul
On Tue, Aug 20, 2013 at 04:33:46PM +0800, Hongbo Zhang wrote: > On 07/29/2013 06:59 PM, Vinod Koul wrote: > >On Mon, Jul 29, 2013 at 06:49:01PM +0800, hongbo.zh...@freescale.com wrote: > >>From: Hongbo Zhang > >> > >>Hi Vinod, Dan, Scott and Leo, please have a

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. > > Signed-off-by: Russell King Acked-by: Vino

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Vinod Koul
this driver. > > Signed-off-by: Russell King Acked-by: Vinod Koul This also brings me question that should we force the driver to use the dma_set_mask_and_coherent() API or they have below flexiblity too? ~Vinod > --- > drivers/dma/edma.c |6 ++ > 1 files changed, 2

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
() > > > functions before doing any DMA mapping. Add this required call to > > > the AMBA PL08x driver. > > ^--- copy and paste error - should of course be PL330 > > Fixed, thanks. with f

Re: [PATCH] powerpc: add explicit OF includes for ppc4xx

2013-11-11 Thread Vinod Koul
so add the necessary includes > to fix ppc4xx builds. > > Signed-off-by: Rob Herring > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Tejun Heo > Cc: Matt Mackall > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Vinod Koul > Cc

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-11 Thread Vinod Koul
On Mon, Oct 28, 2013 at 05:58:42AM +, Xiubo Li-B47053 wrote: > Hi Dan, Vinod, > > > > > +static int fsl_sai_probe(struct platform_device *pdev) { > > [...] > > > + > > > + sai->dma_params_rx.addr = res->start + SAI_RDR; > > > + sai->dma_params_rx.maxburst = 6; > > > + index = of_property_matc

Re: [PATCH v11 0/3] DMA: Freescale: Add support for 8-channel DMA engine

2013-11-13 Thread Vinod Koul
On Thu, Sep 26, 2013 at 05:33:40PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Hi DMA and DT maintainers, please have a look at these V11 patches. > > Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch set > adds support this DMA engine. > Applied al

Re: [PATCH v4 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:44PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Some codes are calling chan_dbg with FSL_DMA_LD_DEBUG surrounded, it is really > unnecessary to use such a macro because chan_dbg is a wrapper of dev_dbg, we > do > have corresponding DEBUG macro

Re: [PATCH v4 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:46PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Delete attribute DMA_INTERRUPT because fsldma doesn't support this function, > exception will be thrown if talitos is used to offload xor at the same time. > Applied, thanks -- ~Vinod _

Re: [PATCH v4 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:47PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > There are several places where descriptors are freed using identical code. > This patch puts this code into a function to reduce code duplication. > Applied, thanks -- ~Vinod __

Re: [PATCH v4 2/8] DMA: Freescale: unify register access methods

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:45PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Methods of accessing DMA controller registers are inconsistent, some registers > are accessed by DMA_IN/OUT directly, while others are accessed by functions > get/set_* which are wrappers of DMA_I

Re: [PATCH v4 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:49PM +0800, hongbo.zh...@freescale.com wrote: This need review from Dan ... -- ~Vinod > From: Hongbo Zhang > > Fix the potential risk when enable config NET_DMA and ASYNC_TX. Async_tx is > lack of support in current release process of dma descriptor, all descripto

Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > The usage of spin_lock_irqsave() is a stronger locking mechanism than is > required throughout the driver. The minimum locking required should be used > instead. Interrupts will be turned off and

Re: [PATCH v4 5/8] DMA: Freescale: move functions to avoid forward declarations

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:48PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > These functions will be modified in the next patch in the series. By moving > the > function in a patch separate from the changes, it will make review easier. > Applied, thanks -- ~Vinod __

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-05-02 Thread Vinod Koul
On Fri, Apr 18, 2014 at 04:17:51PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > This patch adds suspend resume functions for Freescale DMA driver. > .prepare callback is used to stop further descriptors from being added into > the > pending queue, and also issue pending queu

Re: [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

2014-05-02 Thread Vinod Koul
On Wed, Apr 23, 2014 at 05:53:25PM +0400, Alexander Popov wrote: > Introduce support for slave s/g transfer preparation and the associated > device control callback in the MPC512x DMA controller driver, which adds > support for data transfers between memory and peripheral I/O to the > previously su

Re: [PATCH RFC v12 5/7] dma: of: add common xlate function for matching by channel id

2014-05-02 Thread Vinod Koul
On Wed, Apr 23, 2014 at 05:53:27PM +0400, Alexander Popov wrote: > This patch adds a new common OF dma xlate callback function which will match a > channel by it's id. The binding expects one integer argument which it will > use to > lookup the channel by the id. > > Unlike of_dma_simple_xlate th

Re: [PATCH RFC v12 1/7] dma: mpc512x: reorder mpc8308 specific instructions

2014-05-02 Thread Vinod Koul
On Wed, Apr 23, 2014 at 05:53:23PM +0400, Alexander Popov wrote: > Concentrate the specific code for MPC8308 in the 'if' branch > and handle MPC512x in the 'else' branch. > This modification only reorders instructions but doesn't change behaviour. > > Signed-off-by: Alexander Popov > Acked-by: An

Re: [PATCH RFC v12 2/7] dma: mpc512x: separate 'compatible' values for MPC512x and MPC8308

2014-05-02 Thread Vinod Koul
On Wed, Apr 23, 2014 at 05:53:24PM +0400, Alexander Popov wrote: > MPC512x and MPC8308 have similar DMA controllers, but are independent SoCs. > DMA controller driver should have separate 'compatible' values for these SoCs. > > Signed-off-by: Alexander Popov Applied, thanks -- ~Vinod __

Re: [PATCH RFC v12 4/7] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()

2014-05-02 Thread Vinod Koul
On Wed, Apr 23, 2014 at 05:53:26PM +0400, Alexander Popov wrote: > Fix mpc_dma_probe() error path and mpc_dma_remove(): manually free IRQs and > dispose IRQ mappings before devm_* takes care of other resources. > Moreover replace devm_request_irq() with request_irq() since there is no need > to use

Re: [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

2014-05-20 Thread Vinod Koul
On Thu, May 08, 2014 at 01:49:20PM +0400, Alexander Popov wrote: > >> + case DMA_SLAVE_CONFIG: > >> + /* > >> + * Constraints: > >> + * - only transfers between a peripheral device and > >> + * memory are supported; > >> + *

Re: [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-05-20 Thread Vinod Koul
On Thu, May 08, 2014 at 05:52:37PM +0800, Hongbo Zhang wrote: > > On 05/07/2014 04:31 PM, Shevchenko, Andriy wrote: > >On Sun, 2014-05-04 at 18:22 +0800, Hongbo Zhang wrote: > >>On 05/03/2014 12:46 AM, Vinod Koul wrote: > >>>On Fri, Apr 18, 2014 at 04:17:51PM

Re: [PATCH RFC v13 1/5] dmaengine: fix comment typo

2014-05-21 Thread Vinod Koul
On Thu, May 15, 2014 at 06:15:31PM +0400, Alexander Popov wrote: > Fix comment typo. Applied, thanks -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RFC v13 2/5] dma: mpc512x: add support for peripheral transfers

2014-05-21 Thread Vinod Koul
On Thu, May 15, 2014 at 06:15:32PM +0400, Alexander Popov wrote: > Introduce support for slave s/g transfer preparation and the associated > device control callback in the MPC512x DMA controller driver, which adds > support for data transfers between memory and peripheral I/O to the > previously su

Re: [PATCH RFC v13 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2014-05-21 Thread Vinod Koul
> A new patch (part 2/7) is added to this series. > Part 6/7: > - change the description of 'compatible' property according part 2/7; > - improve the document according Gerhard's feedback; > > Parts 1/7, 2/7 and 4/7 have been applied by Vinod Koul and > are excl

Re: [PATCH v5 0/3] DMA: Freescale: driver cleanups and enhancements

2014-07-14 Thread Vinod Koul
On Wed, May 21, 2014 at 04:03:00PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Hi Dan, > Please have a look at this 3/3 as Vinod mentioned. > > Hi Vinod Koul, > Please have a look at the v5 patch set. I dont see any objection, so applying all 3 wi

Re: [PATCH v3 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-07-25 Thread Vinod Koul
On Wed, Jun 25, 2014 at 02:52:57PM +0400, Alexander Popov wrote: > This patch series introduces a device tree binding document for > the MPC512x DMA controller and adds device tree based DMA channel lookup > for it. > > This version contains the improved device tree binding document: > #dma-cells

Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-28 Thread Vinod Koul
On Wed, Nov 13, 2013 at 10:55:23PM +0800, Nicolin Chen wrote: > * ! This series of patches has a direct dependency between them. When > * ! applying them, we need to apply to one single branch. Otherwise, > * ! it would break currect branches. Applied, thanks -- ~Vinod > > Changelog > v7: > *

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2014-01-09 Thread Vinod Koul
On Wed, Jan 08, 2014 at 05:47:19PM +0100, Gerhard Sittig wrote: > [ dropping devicetree from the Cc: list ] > > [ what is the semantics of DMA_PRIVATE capability flag? > is documentation available beyond the initial commit message? > need individual channels be handled instead of controllers?

Re: [PATCH] DMA: Freescale: change BWC from 256 bytes to 1024 bytes

2014-01-20 Thread Vinod Koul
On Thu, Jan 16, 2014 at 02:10:53PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Freescale DMA has a feature of BandWidth Control (ab. BWC), which is currently > 256 bytes and should be changed to 1024 bytes for best DMA throughput. > Changing BWC from 256 to 1024 will improve

Re: [PATCH 3/7] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-03-11 Thread Vinod Koul
On Thu, Jan 16, 2014 at 01:47:22PM +0800, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > There are several places where descriptors are freed using identical code. > This patch puts this code into a function to reduce code duplication. > > Signed-off-by: Hongbo Zhang > Signed-off-by

Re: [PATCH RFC v9 2/6] dma: mpc512x: add support for peripheral transfers

2014-03-19 Thread Vinod Koul
On Wed, Mar 19, 2014 at 05:26:47PM +0400, Alexander Popov wrote: > Hello Andy > > 2014-03-14 13:47 GMT+04:00 Andy Shevchenko > : > > On Wed, 2014-03-12 at 15:47 +0400, Alexander Popov wrote: > >> + case DMA_SLAVE_CONFIG: > >> + /* Constraints: > >> + * - only transfe

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-03-26 Thread Vinod Koul
ock, flags); > + spin_lock_bh(&chan->desc_lock); okay here is the problem :( You moved to _bh variant. So if you grab the lock in rest of the code and irq gets triggered then here we will be spinning to grab the lock. So effectively you made right locking solution into deadlock situation! > >

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-03-29 Thread Vinod Koul
On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote: > > On 03/26/2014 03:01 PM, Vinod Koul wrote: > >On Thu, 2014-01-16 at 13:47 +0800, hongbo.zh...@freescale.com wrote: > >>From: Hongbo Zhang > >> > >>The usage of spin_lock_irqsave()

Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

2014-04-02 Thread Vinod Koul
On Mon, Mar 31, 2014 at 12:08:55PM +0800, Hongbo Zhang wrote: > > On 03/29/2014 09:45 PM, Vinod Koul wrote: > >On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote: > >>On 03/26/2014 03:01 PM, Vinod Koul wrote: > >>>On Thu, 2014-01-16 at 13:47 +0800,

Re: [PATCH v5] dmaengine: Driver support for FSL RaidEngine device.

2015-02-10 Thread Vinod Koul
On Mon, Dec 15, 2014 at 10:32:28AM +0800, xuelin@freescale.com wrote: > +/* Copy descriptor from per chan software queue into hardware job ring */ > +static void fsl_re_issue_pending(struct dma_chan *chan) > +{ > + struct fsl_re_chan *re_chan; > + int avail; > + struct fsl_re_desc

Re: [PATCH] dmaengine:fsldma: fix memory leak

2016-03-09 Thread Vinod Koul
On Tue, Mar 08, 2016 at 02:02:01PM +0800, xuelin@nxp.com wrote: > From: Xuelin Shi > > adding unmap of sources and destinations while doing dequeue. Applied, thanks -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lis

Re: [PATCH 06/14] dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/

2016-04-25 Thread Vinod Koul
On Wed, Apr 20, 2016 at 05:32:11PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +- This change does not apply for me, can you please split it up and send the sound ones thru sound tree -- ~Vinod > d

Re: [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall()

2015-10-07 Thread Vinod Koul
On Thu, Sep 24, 2015 at 08:28:57PM +0300, Alexander Popov wrote: > Initialize Freescale MPC512x DMA driver with subsys_initcall() > to allow the depending drivers to call dma_request_slave_channel() > during their probe. Why can't we use defered probe ? I have been asking people to not move init l

Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-26 Thread Vinod Koul
peripheral devices on LocalPlus Bus. > > > Changes in v4: > > - the race condition is fixed; > > - plenty of style fixes are made; > > - devm_* functions and EPROBE_DEFER are used in probe(). > > Hello, > > I've done my best to fix the issues pointed by Tim

Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-27 Thread Vinod Koul
On Tue, Oct 27, 2015 at 11:42:57PM +0300, Alexander Popov wrote: > >> Hello, > >> > >> I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. > >> Could I have a feedback please? > > > > I dont see to have v4 in my list :( Ca

Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-24 Thread Vinod Koul
On 23-11-18, 15:24, Anshuman Khandual wrote: > --- a/drivers/dma/dmaengine.c > +++ b/drivers/dma/dmaengine.c > @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all); > static bool dma_chan_is_local(struct dma_chan *chan, int cpu) > { > int node = dev_to_node(chan->device->dev); > -

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-27 Thread Vinod Koul
global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like > 'invalid node' from various places redirecting them to a common definition. > > drivers/dma/dmaengine.c | 4 +++- Acked-by: Vinod Koul -- ~Vinod

Re: [v11 1/7] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT

2018-12-05 Thread Vinod Koul
On 30-10-18, 10:35, Peng Ma wrote: > From: Wen He > > This patch implement a standard macro call functions is > used to NXP dma drivers. Applied all except DTS patches, thanks -- ~Vinod

Re: [PATCH] dmaengine: fsldma: Mark expected switch fall-through

2019-08-12 Thread Vinod Koul
On 11-08-19, 19:22, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc): > > drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’: > drivers/dma/fsldma.c:1165:26: warning: this stateme

Re: [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64

2019-01-19 Thread Vinod Koul
On 24-12-18, 05:29, Peng Ma wrote: > Hi Scott, > > Oh, I did not see the in_XX64/out_XX64 supported only __powerpc64__ just now. > Thanks for your reminder. Can you send the formal patch for this... FWIW, fsl patches were not merged last cycle because of reported regression... > > #ifdef __pow

Re: [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64

2019-02-03 Thread Vinod Koul
On 25-01-19, 05:54, Peng Ma wrote: > Hi Vinod, > > Sorry to replay late. > 1:This patch has already send to the patchwork. > Please see the patch link: https://patchwork.kernel.org/patch/10741521/ > 2:I have already compile the fsl patches on arm and powerpc after patched > https://patchwor

Re: [RFC PATCH 1/2] RapidIO: Add DMA Engine support for RIO data transfers

2011-10-01 Thread Vinod Koul
But this brings in a subsystem details to dmaengine which I don't agree with yet. Why can't we abstract this out?? After going thru the patch, I do not believe that this this is case of SLAVE transfers, Dan can you please take a look at this patch > Signed-off-by: Alexandre Bounine &

Re: [RFC PATCH 2/2 -mm] RapidIO: TSI721 Add DMA Engine support

2011-10-01 Thread Vinod Koul
- Adds DMA Engine callback routines Dan please review this, I donot agree with approach here > > Signed-off-by: Alexandre Bounine > Cc: Vinod Koul > Cc: Kumar Gala > Cc: Matt Porter > Cc: Li Yang > --- > drivers/rapidio/devices/Kconfig |8 + > drivers/rapidio/dev

RE: [RFC PATCH 1/2] RapidIO: Add DMA Engine support for RIO data transfers

2011-10-06 Thread Vinod Koul
On Mon, 2011-10-03 at 09:52 -0700, Bounine, Alexandre wrote: > Vinod Koul wrote: > > > > On Fri, 2011-09-30 at 17:38 -0400, Alexandre Bounine wrote: > > Please CC *maintainers* on your patches, get_maintainers.pl will tell > > you who. Adding Dan here > > Based o

RE: [RFC PATCH 1/2] RapidIO: Add DMA Engine support for RIO data transfers

2011-10-15 Thread Vinod Koul
On Fri, 2011-10-07 at 12:08 -0700, Bounine, Alexandre wrote: > Vinod Koul wrote: > > > > On Mon, 2011-10-03 at 09:52 -0700, Bounine, Alexandre wrote: Adding Jassi to this and sorry for late reply... > ... skip ... > > > > > > Second, having ability to pass pri

Re: [RFC PATCH 1/2] RapidIO: Add DMA Engine support for RIO data transfers

2011-10-17 Thread Vinod Koul
On Mon, 2011-10-17 at 21:22 +0530, Jassi Brar wrote: > On 15 October 2011 23:05, Vinod Koul wrote: > > > Another alternate approach could be to add one more argument to > > prep_slave_sg API which allows us to pass additional runtime specific > > parameters. This ca

Re: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-01-30 Thread Vinod Koul
On Thu, 2012-01-26 at 16:22 -0500, Alexandre Bounine wrote: > As we agreed during our discussion about adding DMA Engine support for RapidIO > subsystem, RapidIO and similar clients may benefit from adding an extra > context > parameter to device_prep_slave_sg() callback. > See https://lkml.org/lk

RE: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-01-30 Thread Vinod Koul
On Mon, 2012-01-30 at 08:55 -0800, Bounine, Alexandre wrote: > On Monday, January 30, 2012 at 4:31 AM, Vinod Koul wrote: > > > > On Thu, 2012-01-26 at 16:22 -0500, Alexandre Bounine wrote: > > > As we agreed during our discussion about adding DMA Engine support for >

Re: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-01-31 Thread Vinod Koul
On Wed, 2012-02-01 at 01:09 +0100, Guennadi Liakhovetski wrote: > On Mon, 30 Jan 2012, Vinod Koul wrote: > > > On Thu, 2012-01-26 at 16:22 -0500, Alexandre Bounine wrote: > > > As we agreed during our discussion about adding DMA Engine support for > > > RapidI

Re: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-02-01 Thread Vinod Koul
On Wed, 2012-02-01 at 12:58 +0100, Guennadi Liakhovetski wrote: > > The two things are completely orthogonal and shouldn't be clubbed. > > For your issue we need a separate debate on how to solve this... I am > > open to ideas... > > Well, I'm not sure whether they are necessarily always orthogona

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-07 Thread Vinod Koul
On Tue, 2012-03-06 at 22:33 +, Russell King - ARM Linux wrote: > [v2 - more or less same description. Including lakml in cc for the full > set] > > This patch series cleans up the handling of cookies in DMA engine drivers. > This is done by providing a set of inline library functions for comm

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-12 Thread Vinod Koul
On Mon, 2012-03-12 at 16:11 +, Russell King - ARM Linux wrote: > On Wed, Mar 07, 2012 at 07:24:26PM +0530, Vinod Koul wrote: > > On Tue, 2012-03-06 at 22:33 +, Russell King - ARM Linux wrote: > > > [v2 - more or less same description. Including lakml in cc for

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-13 Thread Vinod Koul
On Mon, 2012-03-12 at 21:53 +0530, Vinod Koul wrote: > > > I applied the v2 on a branch and also rebased on top of > slave-dma.next. > > > There were few conflicts in imx-dma.c. Sacha, Javier, pls see that > merge > > > is right. > > > > > >

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-13 Thread Vinod Koul
On Tue, 2012-03-13 at 12:31 +, Russell King - ARM Linux wrote: > On Tue, Mar 13, 2012 at 02:10:36PM +0530, Vinod Koul wrote: > > Please see if the below patch is the right fix for build failures in > > addition to one suggested by Jassi. > > I'm not sure that Jassi&#

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-19 Thread Vinod Koul
On Tue, 2012-03-13 at 20:08 +0530, Vinod Koul wrote: > On Tue, 2012-03-13 at 12:31 +, Russell King - ARM Linux wrote: > > On Tue, Mar 13, 2012 at 02:10:36PM +0530, Vinod Koul wrote: > > > Please see if the below patch is the right fix for build failures in > > > a

Re: [PATCH v5 1/2] dmaengine: Add context parameter to prep_dma_sg and prep_interleaved_dma

2012-03-26 Thread Vinod Koul
On Thu, 2012-03-22 at 19:52 +0530, Ravi Kumar V wrote: > Add new context parameter to DMA SG and Interleaveid mode for passing Typo > per transfer specific private data, using this it enables the > dma devices which needs to pass the parameters whic

Re: [PATCH v5 1/2] dmaengine: Add context parameter to prep_dma_sg and prep_interleaved_dma

2012-03-26 Thread Vinod Koul
On Mon, 2012-03-26 at 12:25 +0530, Trilok Soni wrote: > > > > You need to > > 1) add wrappers over interleaved api which dont expose this > additional > > parameter > > 2) move existing users to use these wrappers > > Above two steps would be exactly same as > https://lkml.org/lkml/2012/3/8/401 -

Re: [PATCH V2 1/2] rapidio: add DMA engine support for RIO data transfers

2012-03-27 Thread Vinod Koul
() interface > with an extra parameter to pass target specific information. > Uses scatterlist to describe local data buffer. Address flat data buffer > on a remote side. > > Signed-off-by: Alexandre Bounine Acked by: Vinod Koul > --- > > This patch is applicable to linux-ne

Re: [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor

2012-04-23 Thread Vinod Koul
On Mon, 2012-04-23 at 10:50 +0100, Russell King - ARM Linux wrote: > On Mon, Apr 23, 2012 at 06:40:06PM +0900, Boojin Kim wrote: > > I met a problem on DMA cyclic mode (DMA_CYCLIC) for sound playback. > > Kernel BUG occurs during DMA transfer with DMA cyclic mode. > > This patch makes the cookies i

Re: [PATCH 00/59] dma: Convert to platform remove callback returning void

2023-09-28 Thread Vinod Koul
On Tue, 19 Sep 2023 15:31:08 +0200, Uwe Kleine-König wrote: > this series convert nearly all platform drivers below drivers/dma to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver sid

Re: [PATCH 00/59] dma: Convert to platform remove callback returning void

2023-09-28 Thread Vinod Koul
On 19-09-23, 15:31, Uwe Kleine-König wrote: > Hello, > > this series convert nearly all platform drivers below drivers/dma to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. I

Re: [PATCH v2] dmaengine: Explicitly include correct DT includes

2023-08-01 Thread Vinod Koul
On Tue, 18 Jul 2023 08:31:35 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other.

Re: [PATCH v13 07/15] phy: fsl: Add Lynx 10G SerDes driver

2023-04-12 Thread Vinod Koul
On 11-04-23, 14:43, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC typica

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

2023-05-08 Thread Vinod Koul
On 13-04-23, 12:05, Sean Anderson wrote: > This adds support for the PLLs found in Lynx 10G "SerDes" devices found on > various NXP QorIQ SoCs. There are two PLLs in each SerDes. This driver has > been split from the main PHY driver to allow for better review, even though > these PLLs are not prese

Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

2023-05-08 Thread Vinod Koul
On 13-04-23, 12:05, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC typica

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

2023-05-09 Thread Vinod Koul
On 08-05-23, 11:31, Sean Anderson wrote: > On 5/8/23 05:15, Vinod Koul wrote: > >> +int lynx_clks_init(struct device *dev, struct regmap *regmap, > >> + struct clk *plls[2], struct clk *ex_dlys[2], bool compat); > > > > so you have an exported symbol

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

2023-05-16 Thread Vinod Koul
On 09-05-23, 11:26, Sean Anderson wrote: > On 5/9/23 09:00, Vinod Koul wrote: > > On 08-05-23, 11:31, Sean Anderson wrote: > >> On 5/8/23 05:15, Vinod Koul wrote: > > > >> >> +int lynx_clks_init(struct device *dev, struct regmap *regmap, > >> >&

Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

2023-05-16 Thread Vinod Koul
On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >&

Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver

2023-05-16 Thread Vinod Koul
On 16-05-23, 11:11, Sean Anderson wrote: > On 5/16/23 09:22, Vinod Koul wrote: > > On 09-05-23, 11:26, Sean Anderson wrote: > >> On 5/9/23 09:00, Vinod Koul wrote: > >> > On 08-05-23, 11:31, Sean Anderson wrote: > >> >> On 5/8/23 05:15, Vinod Koul

Re: [PATCH v4 0/8] phy: Add support for Lynx 10G SerDes

2022-09-02 Thread Vinod Koul
On 30-08-22, 17:44, Sean Anderson wrote: > > ping? > > Vinod/Kishon: any comments on the driver itself? Not sure why this is not in my queue or pw, can you please rebase and resend Thanks -- ~Vinod

Re: [PATCH v5 0/8] phy: Add support for Lynx 10G SerDes

2022-09-13 Thread Vinod Koul
On 09-09-22, 11:05, Sean Anderson wrote: > > I noticed in patchwork [1] that this entire series is marked as "Changes > Requested," despite having received only automated feedback on one patch > in the series. I am concerned about this because last time this occurred > [2], the series received no

Re: [PATCH v6 4/8] phy: fsl: Add Lynx 10G SerDes driver

2022-09-23 Thread Vinod Koul
On 20-09-22, 16:23, Sean Anderson wrote: > This adds support for the Lynx 10G "SerDes" devices found on various NXP > QorIQ SoCs. There may be up to four SerDes devices on each SoC, each > supporting up to eight lanes. Protocol support for each SerDes is highly > heterogeneous, with each SoC typica

Re: [PATCH v9 00/10] phy: Add support for Lynx 10G SerDes

2023-01-20 Thread Vinod Koul
On 19-01-23, 11:22, Sean Anderson wrote: > On 1/18/23 11:54, Vinod Koul wrote: > > On 17-01-23, 11:46, Sean Anderson wrote: > >> > >> I noticed that this series is marked "changes requested" on patchwork. > >> However, I have received only automate

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-03-28 Thread Vinod Koul
Hi Allen, Subsytem is dmaengine, can you rename this to dmaengine: ... On 27-03-24, 16:03, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue suppor

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-03-28 Thread Vinod Koul
On 28-03-24, 11:08, Arnd Bergmann wrote: > On Thu, Mar 28, 2024, at 06:55, Vinod Koul wrote: > > On 27-03-24, 16:03, Allen Pais wrote: > >> The only generic interface to execute asynchronously in the BH context is > >> tasklet; however, it's marked deprecat

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-03-29 Thread Vinod Koul
On 28-03-24, 13:01, Allen wrote: > > >> > Since almost every driver associates the tasklet with the > > >> > dma_chan, we could go one step further and add the > > >> > work_queue structure directly into struct dma_chan, > > >> > with the wrapper operating on the dma_chan rather than > > >> > the w

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-03-29 Thread Vinod Koul
On 28-03-24, 12:39, Allen wrote: > > I think that is very great idea. having this wrapped in dma_chan would > > be very good way as well > > > > Am not sure if Allen is up for it :-) > > Thanks Arnd, I know we did speak about this at LPC. I did start > working on using completion. I dropped it a

  1   2   >