Re: [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency

2015-05-29 Thread Vaidyanathan Srinivasan
* Preeti U Murthy [2015-05-29 19:17:17]: [snip] > > + if (max_idle_state > 1) { > > + snooze_timeout_en = true; > > + snooze_timeout = cpuidle_state_table[1].target_residency * > > +tb_ticks_per_usec; > > + } > > Any idea why we don't have sno

Re: [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency

2015-06-03 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2015-05-30 20:38:22]: > On Sat, 2015-05-30 at 11:31 +0530, Vaidyanathan Srinivasan wrote: > > In shared lpar case, spinning in guest context may potentially take > > away cycles from other lpars waiting to run on the same physical cpu. > > > &

Re: [RFC PATCH 4/5] cpuidle/ppc: CPU goes tickless if there are no arch-specific constraints

2013-07-28 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2013-07-27 16:30:05]: > On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote: > > *The lapic of a broadcast CPU is active always*. Say CPUX, wants the > > broadcast CPU to wake it up at timeX. Since we cannot program the lapic > > of a remote CPU, CPUX will need to

Re: [RFC PATCH 4/5] cpuidle/ppc: CPU goes tickless if there are no arch-specific constraints

2013-07-28 Thread Vaidyanathan Srinivasan
* Preeti U Murthy [2013-07-27 13:20:37]: > Hi Ben, > > On 07/27/2013 12:00 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2013-07-26 at 08:09 +0530, Preeti U Murthy wrote: > >> *The lapic of a broadcast CPU is active always*. Say CPUX, wants the > >> broadcast CPU to wake it up at timeX. Since w

[PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-21 Thread Vaidyanathan Srinivasan
the driver This fix resolves the page accounting warning shown below: BUG: Bad rss-counter state mm:c007d34ac600 idx:1 val:19 The above warning is triggered since _PAGE_SPECIAL was incorrectly being set for the normal kernel COW pages. Signed-off-by: Vaidyanathan Srinivasan --- arch/powe

Re: [PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-24 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2015-06-21 23:56:16]: > opal-prd driver will mmap() firmware code/data area as private > mapping to prd user space daemon. Write to this page will > trigger COW faults. The new COW pages are normal kernel RAM > pages accounted by the kernel and are

Re: [PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-25 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2015-06-25 11:45:46]: [snip] > Hi Ben, > > remap_pfn_range() is the correct method to map the firmware pages > because we will not have struct page associated with this RAM area. > > We do a memblock_reserve() in early boot and take out this me

[RESEND PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-28 Thread Vaidyanathan Srinivasan
the driver This fix resolves the page accounting warning shown below: BUG: Bad rss-counter state mm:c007d34ac600 idx:1 val:19 The above warning is triggered since _PAGE_SPECIAL was incorrectly being set for the normal kernel COW pages. Signed-off-by: Vaidyanathan Srinivasan --- arch/powe

[PATCH] powerpc: default arch idle could cede processor on pseries

2013-09-04 Thread Vaidyanathan Srinivasan
cpuidle in initialized. Reported-by: Paul Mackerras Signed-off-by: Vaidyanathan Srinivasan Acked-by: Deepthi Dharwar diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index c11c823..fd4f995 100644 --- a/arch/powerpc/platforms/pseries

[PATCH v2] powerpc: Default arch idle could cede processor on pseries

2013-09-05 Thread Vaidyanathan Srinivasan
ll the bells and whisles of cpuidle. Reported-by: Paul Mackerras Signed-off-by: Vaidyanathan Srinivasan Acked-by: Deepthi Dharwar Signed-off-by: Benjamin Herrenschmidt diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index c11c823..54b998f

[PATCH 0/3] sched: Fixes for task placement in SMT threads

2013-10-21 Thread Vaidyanathan Srinivasan
. This series applies on v3.12-rc6 and tested on x86 and powerpc. --Vaidy --- Preeti U Murthy (2): sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group sched: Aggressive balance in domains whose groups share package resources Vaidyanathan Srinivas

[PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-21 Thread Vaidyanathan Srinivasan
CE comes before the check for ASYM_PACKING. Priority is given to avoid more than one busy thread in a core as much as possible before attempting asymmetric packing. Signed-off-by: Preeti U Murthy Signed-off-by: Vaidyanathan Srinivasan --- kernel/sched/fair.c | 19 +-- 1 f

[PATCH 2/3] sched: Fix asymmetric scheduling for POWER7

2013-10-21 Thread Vaidyanathan Srinivasan
his domain has no idle cpu. Hence, nr_busy check against group weight can be removed. Reported-by: Michael Neuling Signed-off-by: Vaidyanathan Srinivasan Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sc

[PATCH 3/3] sched: Aggressive balance in domains whose groups share package resources

2013-10-21 Thread Vaidyanathan Srinivasan
ame group. Signed-off-by: Preeti U Murthy Signed-off-by: Vaidyanathan Srinivasan --- kernel/sched/fair.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 828ed97..bbcd96b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fai

[BUG][PATCH] powerpc: fix numa distance for form0 device tree

2013-03-22 Thread Vaidyanathan Srinivasan
encoded as form0. Signed-off-by: Vaidyanathan Srinivasan diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index bba87ca..6a252c4 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -201,7 +201,7 @@ int __node_distance(int a, int b) int distance = LOCA

Re: [BUG][PATCH] powerpc: fix numa distance for form0 device tree

2013-03-22 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2013-03-22 21:19:35]: [snip] > Prior to the above commit: > #define node_distance(from,to) > ((from) == (to) ? LOCAL_DISTANCE : REMOTE_DISTANCE) > > Restoring compatible behavior with this patch for old powerpc systems >

Re: Kernel crash caused by cpufreq

2014-07-28 Thread Vaidyanathan Srinivasan
* Michael Ellerman [2014-07-28 17:03:10]: > On Fri, 2014-07-25 at 11:07 +1000, Gavin Shan wrote: > > I'm tracing one LSI interrupt issue on P8 box, and eventually into the > > following kernel crash. Not sure if there is one fix against this? :-) > > Vaidy wrote that I'm pretty sure (on CC). Ye

[PATCH] powerpc/cpuidle: Fix parsing of idle state flags from device-tree

2014-08-03 Thread Vaidyanathan Srinivasan
Flags from device-tree need to be parsed with accessors for interpreting correct value in little-endian. Signed-off-by: Vaidyanathan Srinivasan --- drivers/cpuidle/cpuidle-powernv.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/cpuidle/cpuidle

[PATCH] powerpc/cpufreq: Add pr_warn() on OPAL firmware failures

2014-08-03 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan --- Tested on powernv and pseries platforms with v3.16-rc7 kernel. drivers/cpufreq/powernv-cpufreq.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv

[PATCH v1 0/2] powernv: cpufreq support for IBM POWERNV platform

2014-02-10 Thread Vaidyanathan Srinivasan
): powernv, cpufreq: Add per-core locking to serialize frequency transitions Vaidyanathan Srinivasan (1): powernv: cpufreq driver for powernv platform arch/powerpc/include/asm/reg.h|4 + drivers/cpufreq/Kconfig.powerpc |9 + drivers/cpufreq/Makefile |1 drivers

[PATCH v1 2/2] powernv, cpufreq: Add per-core locking to serialize frequency transitions

2014-02-10 Thread Vaidyanathan Srinivasan
k and use the ones that belongs to the first thread sibling of the core. cpu_first_thread_sibling() macro is used to find the *common* lock for all thread siblings belonging to a core. Signed-off-by: Srivatsa S. Bhat Signed-off-by: Vaidyanathan Srinivasan --- drivers/cpufreq/powernv-cpufreq.c |

[PATCH v1 1/2] powernv: cpufreq driver for powernv platform

2014-02-10 Thread Vaidyanathan Srinivasan
IBM POWER non-virtualized platforms. PState table is obtained from OPAL v3 firmware through device tree. powernv_cpufreq back-end driver would parse the relevant device-tree nodes and initialise the cpufreq subsystem on powernv platform. Signed-off-by: Vaidyanathan Srinivasan Signed-off-by:

Re: [PATCH v3 1/5] powernv: cpufreq driver for powernv platform

2014-03-21 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2014-03-21 16:13:17]: > Hi Viresh, > > On Fri, Mar 21, 2014 at 02:11:32PM +0530, Viresh Kumar wrote: > > On Thu, Mar 20, 2014 at 5:40 PM, Gautham R. Shenoy > > wrote: > > > From: Vaidyanathan Srinivasan > > > > Hi Vaidy, > &

Re: [PATCH v4] powernv, cpufreq: cpufreq driver for powernv platform

2014-03-27 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2014-03-27 15:00:50]: [snip] > > > + u32 len_ids, len_freqs; > > > + > > > + power_mgt = of_find_node_by_path("/ibm,opal/power-mgt"); > > > + if (!power_mgt) { > > > + pr_warn("power-mgt node not found\n"); > > > + return -ENODEV

Re: [PATCH] pseries/energy: Use OF accessor functions to read ibm,drc-indexes

2019-03-08 Thread Vaidyanathan Srinivasan
t; Fixes: commit e83636ac3334 ("pseries/drc-info: Search DRC properties for CPU > indexes") > Cc: #v4.16+ > Reported-by: Pavithra R. Prakash > Signed-off-by: Gautham R. Shenoy Reviewed-by: Vaidyanathan Srinivasan > --- > arch/powerpc/platforms/pseries/pseries_energy.

Re: [PATCH v5 1/3] powerpc/powernv: Interface to define support and preference for a SPR

2020-03-18 Thread Vaidyanathan Srinivasan
using the above interface and retains the > legacy functionality of self restore. > > Signed-off-by: Pratik Rajesh Sampat > Reviewed-by: Ram Pai Reviewed-by: Vaidyanathan Srinivasan > --- > arch/powerpc/platforms/powernv/idle.c | 316 +- > 1 file cha

Re: [PATCH v5 2/3] powerpc/powernv: Introduce Self save support

2020-03-18 Thread Vaidyanathan Srinivasan
le respecting it's preferences. > > This implementation allows mixing of support for the SPRs, which > means that a SPR can be self restored while another SPR be self saved if > they support and prefer it to be so. > > Signed-off-by: Pratik Rajesh Sampat > Reviewed-by: Ra

Re: [PATCH v5 3/3] powerpc/powernv: Parse device tree, population of SPR support

2020-03-18 Thread Vaidyanathan Srinivasan
* Pratik Rajesh Sampat [2020-03-17 19:40:18]: > Parse the device tree for nodes self-save, self-restore and populate > support for the preferred SPRs based what was advertised by the device > tree. > > Signed-off-by: Pratik Rajesh Sampat > Reviewed-by: Ram Pai Reviewe

Re: [PATCH v3 1/2] powerpc/vcpu: Assume dedicated processors as non-preempt

2019-12-06 Thread Vaidyanathan Srinivasan
werpc/mm/numa.c > index 50d68d21ddcc..ffb971f3a63c 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -1568,9 +1568,13 @@ int prrn_is_enabled(void) > return prrn_enabled; > } > > +DEFINE_STATIC_KEY_FALSE(shared_processor); > +EXPORT_SYMBOL_GPL(shared_processor); > + > void __init shared_proc_topology_init(void) > { > if (lppaca_shared_proc(get_lppaca())) { > + static_branch_enable(&shared_processor); > bitmap_fill(cpumask_bits(&cpu_associativity_changes_mask), > nr_cpumask_bits); > numa_update_cpu_topology(false); Reviewed-by: Vaidyanathan Srinivasan Thanks Srikar for the fix. --Vaidy

Re: [Skiboot] [PATCH v8 1/3] Self Save: Introducing Support for SPR Self Save

2020-04-29 Thread Vaidyanathan Srinivasan
hristian R. Geddes > Signed-off-by: Prem Shanker Jha > Signed-off-by: Akshay Adiga > Signed-off-by: Pratik Rajesh Sampat Reviewed-by: Vaidyanathan Srinivasan > 2. The commit also incorporates changes that make STOP API project > agnostic changes include defining wrapper functions whi

Re: [PATCH v8 2/3] API to verify the STOP API and image compatibility

2020-04-29 Thread Vaidyanathan Srinivasan
SAD G. BRAHMASAMUDRA > Reviewed-by: Gregory S Still > Reviewed-by: Jennifer A Stofer > Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/77614 > Tested-by: Jenkins OP Build CI > Tested-by: Jenkins OP HW > Reviewed-by: Daniel M Crowell > Signed-off-by: Pratik Rajesh

Re: [Skiboot] [PATCH v8 3/3] Self save API integration

2020-04-29 Thread Vaidyanathan Srinivasan
ing and usage. > > Signed-off-by: Pratik Rajesh Sampat Reviewed-by: Vaidyanathan Srinivasan > --- > doc/opal-api/opal-slw-self-save-reg-181.rst | 51 ++ > doc/opal-api/opal-slw-set-reg-100.rst | 5 + > doc/power-management.rs

Re: [PATCH] powerpc: fix VMX fix for memcpy case

2012-10-06 Thread Vaidyanathan Srinivasan
8 7ca62850 7cc300d0 78c7e102 > 7cf01120 > [ 18.824923] 78c60660 39200010 39400020 39600030 <7e00200c> 7c0020ce > 38840010 409f001c > [ 18.824935] ---[ end trace 0bb95124affaaa45 ]--- > [ 18.825046] Unrecoverable VMX/Altivec Unavailable Exception f20 at > c0052d08 >

[PATCH v5 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-10-06 Thread Vaidyanathan Srinivasan
patch series is conservative and has more error checking in device tree parsing and drc index matching code than what may be required. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY

[PATCH v5 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-10-06 Thread Vaidyanathan Srinivasan
pu_core_index_of_thread(5) = 1 cpu_first_thread_of_core(1) = 4 cpu_core_index_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Make API changes to few callers. Export symbols for use in modules. Signed-off-by: Vaidyanathan

[PATCH v5 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-10-06 Thread Vaidyanathan Srinivasan
Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h |3 arch/powerpc/platforms/pseries/Kconfig | 10 + arch/powerpc/platforms/pseries/Makefile |1 arch/powerpc/platforms/pseries/pseries_energy.c | 326 +++ 4

Re: [PATCH 2/4]: CPUIDLE: Introduce architecture independent cpuidle_pm_idle in drivers/cpuidle/cpuidle.c

2009-08-28 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2009-08-28 09:01:12]: > On Fri, 2009-08-28 at 08:48 +0200, Peter Zijlstra wrote: > > > > > void cpuidle_install_idle_handler(void) > > > { > > > . > > > . > > > cpuidle_pm_idle = cpuidle_idle_call; > > > } > > > > All I'm seeing here is a frig

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-16 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2009-09-16 18:35:16]: > On Wed, 2009-09-16 at 21:54 +0530, Dipankar Sarma wrote: > > > No, for this specific case, latency isn't an issue. The issue is - > > how do we cede unused vcpus to hypervisor for better energy management ? > > Yes, it can be done by a hypervisor manager

Re: [v6 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.

2009-09-25 Thread Vaidyanathan Srinivasan
* Arjan van de Ven [2009-09-24 14:22:28]: > On Thu, 24 Sep 2009 10:42:41 +0530 > Arun R Bharadwaj wrote: > > > * Arun R Bharadwaj [2009-09-22 16:55:27]: > > > > Hi Len, (or other acpi folks), > > > > I had a question regarding ACPI-cpuidle interaction in the current > > implementation. > >

Re: [PATCH v2 0/2] cpu: pseries: Offline state framework.

2009-09-25 Thread Vaidyanathan Srinivasan
* Arjan van de Ven [2009-09-24 13:41:23]: > On Thu, 24 Sep 2009 13:33:07 +0200 > Peter Zijlstra wrote: > > > On Thu, 2009-09-24 at 18:38 +1000, Benjamin Herrenschmidt wrote: > > > On Thu, 2009-09-24 at 09:51 +0200, Peter Zijlstra wrote: > > > > > I don't quite follow your logic here. This is us

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-28 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2009-09-25 16:48:40]: > On Thu, 2009-09-24 at 10:51 +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2009-09-15 at 14:11 +0200, Peter Zijlstra wrote: > > > I still think its a layering violation... its the hypervisor manager > > > that should be bothered in what state an off-lin

Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework

2009-09-28 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2009-09-26 07:12:48]: > On Fri, 2009-09-25 at 16:48 +0200, Peter Zijlstra wrote: > > On Thu, 2009-09-24 at 10:51 +1000, Benjamin Herrenschmidt wrote: > > > On Tue, 2009-09-15 at 14:11 +0200, Peter Zijlstra wrote: > > > > I still think its a layering violation... its the

Re: [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.

2009-10-07 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2009-10-06 20:04:39]: > On Tue, 2009-10-06 at 22:05 +0530, Arun R Bharadwaj wrote: > > > Also, the per-cpu nature of registration/unregistration of cpuidle > > has been maintained as ACPI needs this. > > Right, so can't we ditch that and have acpi default to the lowest common

Re: [v8 PATCH 2/8]: cpuidle: implement a list based approach to register a set of idle routines.

2009-10-08 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2009-10-08 14:25:37]: > On Thu, 2009-10-08 at 17:31 +0530, Arun R Bharadwaj wrote: > > > > > Uhm, no, it would mean ACPI putting its idle routines on the same level > > > as all others. > > > > > > > Putting them all on the same level would mean, we need an > > enable/disable

Re: [PATCH v5 0/4] pseries: Add cede support for cpu-offline

2009-11-23 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2009-11-24 14:35:09]: > On Fri, 2009-10-30 at 10:52 +0530, Gautham R Shenoy wrote: > > Hi, > > > > This is version 5 of patch series that provides a framework to choose the > > state a pseries CPU must be put to when it is offlined. > > > > Previous versions can be fou

[PATCH v6 0/2] pseries: Add cede support for cpu-offline

2009-11-26 Thread Vaidyanathan Srinivasan
Hi, This is version 6 of patch series that provides a framework to choose the state a pseries CPU must be put to when it is offlined. Previous versions can be found here: Version 5: http://lkml.org/lkml/2009/10/30/6 Version 4: http://lkml.org/lkml/2009/10/9/59 Version 3: http://lkml.org/lkml/2009

[PATCH v6 1/2] pseries: Add code to online/offline CPUs of a DLPAR node

2009-11-26 Thread Vaidyanathan Srinivasan
uld only have to deal with one set of sysfs tunables namely "probe" and release". Signed-off-by: Gautham R Shenoy Signed-off-by: Nathan Fontenot Acked-by: Vaidyanathan Srinivasan --- arch/powerpc/platforms/pseries/dlpar.c | 101 1 files changed,

[PATCH v6 2/2] pseries: Serialize cpu hotplug operations during deactivate Vs deallocate

2009-11-26 Thread Vaidyanathan Srinivasan
writes to the "online" sysfs tunable. This patch employs a mutex to provide this serialization, which is a no-op on all architectures except PPC_PSERIES Signed-off-by: Gautham R Shenoy Acked-by: Vaidyanathan Srinivasan --- arch/powerpc/platforms/pseries/dlpar.c

Re: [PATCH] powerpc: Quieten cede latency printk

2010-02-08 Thread Vaidyanathan Srinivasan
* Balbir Singh [2010-02-08 16:37:37]: > On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard wrote: > > > > The cede latency stuff is relatively new and we don't need to complain about > > it not working on older firmware. > > > > Signed-off-by: Anton Blanchard > > Acked-by: Balbir Singh > > Seem

[PATCH] powerpc: reset kernel stack on cpu online from cede state

2010-02-22 Thread Vaidyanathan Srinivasan
start_secondary() is called to continue the online operation. Added new function start_secondary_resume() to do the above steps. Signed-off-by: Vaidyanathan Srinivasan diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S index 9258074

[PATCH] powerpc: export data from new hcall H_EM_GET_PARMS

2010-02-25 Thread Vaidyanathan Srinivasan
data directly to user space for administrative tools to interpret and use. cat /proc/powerpc/lparcfg will export power mode data Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h |1 + arch/powerpc/kernel/lparcfg.c | 19

[PATCH v2 0/3] powerpc: bug fixes in pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
from cede state http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-February/080515.html Thanks, Vaidy --- Vaidyanathan Srinivasan (3): powerpc: reset kernel stack on cpu online from cede state powerpc: move checks in pseries_mach_cpu_die() powerpc: reduce printk from pseri

[PATCH v2 1/3] powerpc: reset kernel stack on cpu online from cede state

2010-03-01 Thread Vaidyanathan Srinivasan
. Added new function start_secondary_resume() to do the above steps. Signed-off-by: Vaidyanathan Srinivasan Cc: Gautham R Shenoy --- arch/powerpc/kernel/head_64.S | 11 +++ arch/powerpc/platforms/pseries/hotplug-cpu.c|9 - arch/powerpc

[PATCH v2 2/3] powerpc: move checks in pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
of the consistent states and not hit the run over BUG() Signed-off-by: Vaidyanathan Srinivasan Cc: Gautham R Shenoy --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 30 +- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH v2 3/3] powerpc: reduce printk from pseries_mach_cpu_die()

2010-03-01 Thread Vaidyanathan Srinivasan
= b2802fff Timebase value = 2fa8f95035f4a cpu 62 (hwid 62) got prodded to go online cpu 58 (hwid 58) ceding for offline with hint 2 Signed-off-by: Vaidyanathan Srinivasan Cc: Gautham R Shenoy --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 11 --- 1 files changed, 0

[RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-03 Thread Vaidyanathan Srinivasan
hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-07 Thread Vaidyanathan Srinivasan
* Dipankar Sarma [2010-03-06 00:48:11]: > On Wed, Mar 03, 2010 at 11:48:22PM +0530, Vaidyanathan Srinivasan wrote: > > static void __init cpu_init_thread_core_maps(int tpc) > > diff --git a/arch/powerpc/platforms/pseries/Kconfig > > b/arch/powerpc/platforms/pseries/Kcon

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-09 Thread Vaidyanathan Srinivasan
* Dipankar Sarma [2010-03-09 00:58:26]: > On Mon, Mar 08, 2010 at 12:20:06PM +0530, Vaidyanathan Srinivasan wrote: > > * Dipankar Sarma [2010-03-06 00:48:11]: > > > > > Shouldn't we create this only for supported platforms ? > > > > Hi Dipanka

[PATCH v2] powerpc: export data from new hcall H_EM_GET_PARMS

2010-03-10 Thread Vaidyanathan Srinivasan
and use. cat /proc/powerpc/lparcfg will export power mode data Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h |1 + arch/powerpc/kernel/lparcfg.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/arch/powerpc

Re: [PATCH v2] powerpc: export data from new hcall H_EM_GET_PARMS

2010-03-22 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2010-03-10 17:49:25]: > Hi Ben, > > I have cleaned up the code from the previous post: > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-February/080630.html > > Changes from v1: > * Removed redundant return statements and rearranged code >

[PATCH v2 repost] powerpc: export data from new hcall H_EM_GET_PARMS

2010-04-01 Thread Vaidyanathan Srinivasan
for administrative tools to interpret and use. cat /proc/powerpc/lparcfg will export power mode data Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h |1 + arch/powerpc/kernel/lparcfg.c | 12 +++- 2 files changed, 12 insertions(+), 1

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-04-07 12:04:49]: > On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: > > Hi, > > > diff --git a/arch/powerpc/kernel/setup-common.c > > b/arch/powerpc/kernel/setup-common.c > > index 03dd6a2..fbd93e3 100644 >

[RFC PATCH v2 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-05-07 Thread Vaidyanathan Srinivasan
whitespace cleanups Please review and let me know your comments. I will post the next version ready for inclusion into powerpc/next tree along with test reports. The current patch series is on 2.6.34-rc6. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core

[RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-07 Thread Vaidyanathan Srinivasan
cpu_thread_to_core() to cpu_core_of_thread(int cpu) Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/cputhreads.h | 15 +-- arch/powerpc/kernel/smp.c | 17 +++-- arch

[RFC PATCH v2 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-05-07 Thread Vaidyanathan Srinivasan
/pseries_(de)activate_hint will provide hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan

Re: [RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-09 Thread Vaidyanathan Srinivasan
* Paul Mackerras [2010-05-10 09:05:22]: > On Fri, May 07, 2010 at 05:18:42PM +0530, Vaidyanathan Srinivasan wrote: > > > These APIs take logical cpu number as input > > Change cpu_first_thread_in_core() to cpu_leftmost_thread_sibling() > > Change cpu_

Re: [RFC PATCH v2 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-05-17 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2010-05-10 11:18:01]: > * Paul Mackerras [2010-05-10 09:05:22]: > > > On Fri, May 07, 2010 at 05:18:42PM +0530, Vaidyanathan Srinivasan wrote: > > > > > These APIs take logical cpu number as input > > >

Re: [PATCH 1/5] sched: fix capacity calculations for SMT4

2010-06-01 Thread Vaidyanathan Srinivasan
* Peter Zijlstra [2010-05-31 10:33:16]: > On Fri, 2010-04-16 at 15:58 +0200, Peter Zijlstra wrote: > > > > > > Hrmm, my brain seems muddled but I might have another solution, let me > > ponder this for a bit.. > > > > Right, so the thing I was thinking about is taking the group capacity > int

[PATCH v3 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-23 Thread Vaidyanathan Srinivasan
availability This patch series will apply on 2.6.35-rc3 as well as powerpc/next tree. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY arch/powerpc/include/asm/cputhreads.h | 15

[PATCH v3 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-06-23 Thread Vaidyanathan Srinivasan
= 7 cpu_core_of_thread(5) = 1 cpu_first_thread_of_core(1) = 4 cpu_core_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Sriniva

[PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-23 Thread Vaidyanathan Srinivasan
/pseries_(de)activate_hint will provide hints for activation and deactivation of cpus respectively. Added new driver module arch/powerpc/platforms/pseries/pseries_energy.c under new config option CONFIG_PSERIES_ENERGY Signed-off-by: Vaidyanathan Srinivasan

Re: [PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-06-27 Thread Vaidyanathan Srinivasan
Linux to have access to all information that the hypervisor has offered through this hcall interface. > Other comments below. > > > > > Signed-off-by: Vaidyanathan Srinivasan > > --- > > arch/powerpc/include/asm/hvcall.h |3 > > arch/powe

[PATCH v4 0/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
powerpc/next tree for further testing. I could incrementally reduce some of the error checks as suggested by Michael Neuling as next steps. Thanks, Vaidy --- Vaidyanathan Srinivasan (2): powerpc: cleanup APIs for cpu/thread/core mappings powerpc: add support for new hcall H_BEST_ENERGY

[PATCH v4 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-07-21 Thread Vaidyanathan Srinivasan
= 7 cpu_core_of_thread(5) = 1 cpu_first_thread_of_core(1) = 4 cpu_core_of_thread() is used in cpu_to_drc_index() in the module and cpu_first_thread_of_core() is used in drc_index_to_cpu() in the module. Made API changes to few callers. Exported symbols for use in modules. Signed-off-by: Vaidyanathan Sriniva

[PATCH v4 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
Signed-off-by: Vaidyanathan Srinivasan --- arch/powerpc/include/asm/hvcall.h |3 arch/powerpc/platforms/pseries/Kconfig | 10 + arch/powerpc/platforms/pseries/Makefile |1 arch/powerpc/platforms/pseries/pseries_energy.c | 326 +++ 4

Re: [PATCH v3 2/2] powerpc: add support for new hcall H_BEST_ENERGY

2010-07-21 Thread Vaidyanathan Srinivasan
* Michael Neuling [2010-06-28 16:11:06]: [snip] > > These hints are abstract number given by the hypervisor based on > > the extended knowledge the hypervisor has regarding the current system > > topology and resource mappings. > > > > The activate and the deactivate part is for the two distinc

Re: [PATCH] powerpc: ONLINE to OFFLINE CPU state transition during removal

2010-07-22 Thread Vaidyanathan Srinivasan
* Robert Jennings [2010-07-22 21:43:44]: > If a CPU remove is attempted using the 'release' interface on hardware > which supports extended cede, the CPU will be put in the INACTIVE state > rather than the OFFLINE state due to the default preferred_offline_state > in that situation. In the INACT

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-07-22 Thread Vaidyanathan Srinivasan
* Darren Hart [2010-07-22 21:44:04]: > On 07/22/2010 04:57 PM, Darren Hart wrote: > > On 07/22/2010 03:25 PM, Benjamin Herrenschmidt wrote: > >> On Thu, 2010-07-22 at 11:24 -0700, Darren Hart wrote: > >>> > >>> 1) How can the preempt_count() get mangled across the H_CEDE hcall? > >>> 2) Should we

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-07-23 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-07-23 15:11:00]: > On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: > > Yes. extended_cede_processor() will return with interrupts enabled in > > the cpu. (This is done by the hypervisor). Under normal cases we > > cannot b

Re: [PATCH v4 1/2] powerpc: cleanup APIs for cpu/thread/core mappings

2010-08-05 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-08-03 14:44:13]: > On Thu, 2010-07-22 at 06:27 +0530, Vaidyanathan Srinivasan wrote: > > These APIs take logical cpu number as input > > Change cpu_first_thread_in_core() to cpu_leftmost_thread_sibling() > > Change cpu_las

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart [2010-08-04 21:45:51]: > On 07/23/2010 12:07 AM, Vaidyanathan Srinivasan wrote: > >* Benjamin Herrenschmidt [2010-07-23 15:11:00]: > > > >>On Fri, 2010-07-23 at 10:38 +0530, Vaidyanathan Srinivasan wrote: > >>>Yes. extended_cede_processor() wi

Re: [PATCH] powerpc: ONLINE to OFFLINE CPU state transition during removal

2010-08-05 Thread Vaidyanathan Srinivasan
* Nathan Fontenot [2010-07-26 14:13:35]: > On 07/22/2010 11:13 PM, Vaidyanathan Srinivasan wrote: > > * Robert Jennings [2010-07-22 21:43:44]: > > > >> If a CPU remove is attempted using the 'release' interface on hardware > >> which supports extende

Re: [PATCH][RFC] preempt_count corruption across H_CEDE call with CONFIG_PREEMPT on pseries

2010-08-05 Thread Vaidyanathan Srinivasan
* Darren Hart [2010-08-05 19:19:00]: > On 07/22/2010 10:09 PM, Benjamin Herrenschmidt wrote: > > On Thu, 2010-07-22 at 21:44 -0700, Darren Hart wrote: > > > >> suggestion I updated the instrumentation to display the > >> local_save_flags and irqs_disabled_flags: > > > >> Jul 22 23:36:58 igoor

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-05 Thread Vaidyanathan Srinivasan
* Shaohua Li [2009-08-06 09:58:55]: > Hi, > > On Wed, Aug 05, 2009 at 10:25:53PM +0800, Gautham R Shenoy wrote: > > In this patch-series, we propose to extend the CPU-Hotplug infrastructure > > and allow the system administrator to choose the desired state the CPU > > should > > go to when it i

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-09 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki [2009-08-09 15:22:02]: > On Sunday 09 August 2009, Pavel Machek wrote: > > Hi! > > > > > > Also, approaches such as [1] can make use of this > > > > extended infrastructure instead of putting the CPU to an arbitrary > > > > C-state > > > > when it is offlined, thereby provid

Re: [PATCH v2] powerpc/powernv: Add ultravisor message log interface

2019-08-28 Thread Vaidyanathan Srinivasan
* Claudio Carvalho [2019-08-24 23:19:19]: > > On 8/23/19 9:48 AM, Michael Ellerman wrote: > > Hi Claudio, > > Hi Michael, > > > > > Claudio Carvalho writes: > >> Ultravisor (UV) provides an in-memory console which follows the OPAL > >> in-memory console structure. > >> > >> This patch extends

Re: [PATCH] powerpc/powernv/prd: Validate whether address to be mapped is part of system RAM

2019-10-02 Thread Vaidyanathan Srinivasan
he PTE mapping. > CC: Aneesh Kumar K.V > CC: Jeremy Kerr > CC: Vaidyanathan Srinivasan > Signed-off-by: Vasant Hegde Signed-off-by: Vaidyanathan Srinivasan > --- > arch/powerpc/platforms/powernv/opal-prd.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) &

Re: [PATCH] powerpc/powernv/prd: Validate whether address to be mapped is part of system RAM

2019-10-03 Thread Vaidyanathan Srinivasan
* Jeremy Kerr [2019-10-03 15:07:24]: > Hi Vasant, > > > > OK. How about we just don't do that? > > > > Yes. Hostboot will fix that. It will make sure that HBRT is loaded > > into regular memory. > > Super. > > > > It sounds like we're just trying to work around an invalid > > > representation

Re: [PATCH] powerpc/powernv/prd: Validate whether address to be mapped is part of system RAM

2019-10-04 Thread Vaidyanathan Srinivasan
* Jeremy Kerr [2019-10-04 11:27:46]: > Hi Vaidy, > > > The current topic is who owns setting up the ATT bits for that piece > > of memory. It is the kernel today. Kernel decides to set this up as > > normal memory or I/O memory and sets the bits in page table entry. > > > > > Or, what if ther

Re: [PATCH v2] cpuidle-pseries: Fix CEDE latency conversion from tb to us

2020-09-03 Thread Vaidyanathan Srinivasan
s a warning in case we discover an extended-cede state with > wakeup latency to be 0. In such a case, ensure that CEDE(0) has a > non-zero wakeup latency. > > Fixes: commit d947fb4c965c ("cpuidle: pseries: Fixup exit latency for > CEDE(0)") > > Signed-off-by: Gautham

Re: [PATCH v2] powerpc/cpuidle: Set CPUIDLE_FLAG_POLLING for snooze state

2022-12-02 Thread Vaidyanathan Srinivasan
this > > is the correct version which is tested on powernv, pseries (shared and > > dedicated partitions) > > > > drivers/cpuidle/cpuidle-powernv.c | 5 - > > drivers/cpuidle/cpuidle-pseries.c | 8 ++-- > > 2 files changed, 10 insertions(+), 3 deletions(-) Hi Aboorva, Thanks for the patch. This fixes the unpredictable idle state selection issue under differ idle interval patterns. Reviewed-by: Vaidyanathan Srinivasan --Vaidy

2.6.24-rc1 on PPC64: machine check exception

2007-11-05 Thread Vaidyanathan Srinivasan
Hi, I got the following exception on a 128-way PPC64 machine while running ebizzy-0.2 benchmark. cpu 0x48: Vector: 200 (Machine Check) at [c06df1bb37c0] pc: c007a26c: .exit_robust_list+0x78/0x228 lr: c007a240: .exit_robust_list+0x4c/0x228 sp: c06df1bb3a40 ms

Re: 2.6.24-rc1 on PPC64: machine check exception

2007-11-05 Thread Vaidyanathan Srinivasan
Anton Blanchard wrote: > Hi > >> I got the following exception on a 128-way PPC64 machine while running >> ebizzy-0.2 benchmark. > > Is it a 64bit application? Im guessing its fixed by this: Hi Anton, The ebizzy application I tried is 64-bit. > http://patchwork.ozlabs.org/linuxppc/patch?id=144

Re: 2.6.24-rc1 on PPC64: machine check exception

2007-11-15 Thread Vaidyanathan Srinivasan
> >> http://patchwork.ozlabs.org/linuxppc/patch?id=14475 > > Thanks for pointing me to this patch. I will try out and let you know if > this fixed the problem. Hi Anton, This patch fixed the problem. I am able to run and profile ebizzy on 128-way PPC64. However this fix is not included in 2.

Re: [PATCH] cpuidle/pseries: Fixup CEDE0 latency only for POWER10 onwards

2021-04-22 Thread Vaidyanathan Srinivasan
dcoded value of exit > latency, which is 10us. Though this is higher than the measured > values, we would be erring on the side of caution. > > Reported-by: Enrico Joedecke > Fixes: commit d947fb4c965c ("cpuidle: pseries: Fixup exit latency for > CEDE(0)") > Sig

Re: [PATCH] cpuidle/pseries: Fixup CEDE0 latency only for POWER10 onwards

2021-04-23 Thread Vaidyanathan Srinivasan
* Michal Such?nek [2021-04-23 09:35:51]: > On Thu, Apr 22, 2021 at 08:37:29PM +0530, Gautham R. Shenoy wrote: > > From: "Gautham R. Shenoy" > > > > Commit d947fb4c965c ("cpuidle: pseries: Fixup exit latency for > > CEDE(0)") sets the exit latency of CEDE(0) based on the latency values > > of th

Re: [PATCH] cpuidle/pseries: Fixup CEDE0 latency only for POWER10 onwards

2021-04-23 Thread Vaidyanathan Srinivasan
* Michal Such?nek [2021-04-23 19:45:05]: > On Fri, Apr 23, 2021 at 09:29:39PM +0530, Vaidyanathan Srinivasan wrote: > > * Michal Such?nek [2021-04-23 09:35:51]: > > > > > On Thu, Apr 22, 2021 at 08:37:29PM +0530, Gautham R. Shenoy wrote: > >

Re: [PATCH] cpuidle/pseries: Fixup CEDE0 latency only for POWER10 onwards

2021-04-24 Thread Vaidyanathan Srinivasan
* Michal Such?nek [2021-04-23 20:42:16]: > On Fri, Apr 23, 2021 at 11:59:30PM +0530, Vaidyanathan Srinivasan wrote: > > * Michal Such?nek [2021-04-23 19:45:05]: > > > > > On Fri, Apr 23, 2021 at 09:29:39PM +0530, Vaidyanathan Srinivasan wrote: > > > > * M

Re: [PATCH 0/5] cpuidle-pseries: Parse extended CEDE information for idle.

2020-07-19 Thread Vaidyanathan Srinivasan
* Gautham R Shenoy [2020-07-07 16:41:34]: > From: "Gautham R. Shenoy" > > Hi, > > On pseries Dedicated Linux LPARs, apart from the polling snooze idle > state, we currently have the CEDE idle state which cedes the CPU to > the hypervisor with latency-hint = 0. > > However, the PowerVM hypervi

Re: [PATCH 1/5] cpuidle-pseries: Set the latency-hint before entering CEDE

2020-07-19 Thread Vaidyanathan Srinivasan
cede states through the > cpuidle framework, where each of them will have a different > cede-latency hint. > > Signed-off-by: Gautham R. Shenoy Reviewed-by: Vaidyanathan Srinivasan > --- > drivers/cpuidle/cpuidle-pseries.c | 10 +- > 1 file changed, 9 insertion

  1   2   >