Re: Q: define i2c nodes in device tree?

2009-03-27 Thread Timur Tabi
s/f000.soc5200 are from the device tree directly. They're not related to any device driver. I believe you'll find those entries still there even if your driver isn't loaded at all. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] QE USB Host Integration for MPC832x

2009-04-02 Thread Timur Tabi
to any other QE devices for standard functionality, I'm not aware of any. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Timur Tabi
ut what the right dev pointer was. ASoC is kinda screwy in that many fields are not initialized when you think they should be. More than once I passed a pointer to a wrong object without realizing it, even though the code worked. I'll check out these two patches on Monday. -- Timur T

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-06 Thread Timur Tabi
x28 > ... > > This patch fixes the issue by using card's device instead. > > Signed-off-by: Anton Vorontsov > --- Acked-by: Timur Tabi Mark and Takashi: this patch is a must-fix for 2.6.30 -- Timur Tabi Linux kernel developer at Freescale

Re: sata device failed to IDENTIFY...

2009-04-06 Thread Timur Tabi
On Mon, Mar 23, 2009 at 3:07 AM, rizwan ahmad wrote: > ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 310) > ata1.00: qc timeout (cmd 0xec) > ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4) I'm seeing the same exact thing on a Freescale MPC8610 HPCD board. This happens only on 2.6.30. I

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-07 Thread Timur Tabi
hange and keep setting intx? cc'ing linuxppc-dev I really don't know what should be done. It seems to make sense to have the PCI layer enable interrupts. This seems to be a powerpc-specific bug, but I don't know enough of the PCI subsystem. -- Timu

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-07 Thread Timur Tabi
On Tue, Apr 7, 2009 at 7:52 PM, Michael Ellerman wrote: > Can you post some more details, or point us at a thread? http://marc.info/?t=12391165216&r=1&w=2 -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing li

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Timur Tabi
On Tue, Apr 7, 2009 at 9:09 PM, Michael Ellerman wrote: > Have you confirmed that INTX is disabled before that call? How do I do that? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org ht

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Timur Tabi
Tejun Heo wrote: > Running "lspci -nnvvvxxx" before loading the driver should be enough. That might be difficult. My root file system is on my SATA drive. It'll be a while before I can build an NFS rootfs. -- Timur Tabi Linux kernel deve

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Timur Tabi
Tejun Heo wrote: > Yeah, right. The following patch should do the trick then. Thanks, I appreciate it. I get this output: XXX PCI_COMMAND=0x407 -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Timur Tabi
On Wed, Apr 8, 2009 at 4:31 PM, Tejun Heo wrote: > Hmmm... for now, > I think it would be best to revert the original change.  Jeff, can you > please do that? Actually, give me a few days before you do that. A colleague gave me some suggestions to debug this. -- Timur Tabi Lin

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-09 Thread Timur Tabi
oping that the latest U-Boot would fix this problem, but it doesn't. Earlier U-Boot couldn't find my SATA drive, so I thought that was a clue. The latest U-Boot does find the SATA drive, but the Linux driver still doesn't get interrupts. -- Timur Tabi Linux kernel developer at Free

Re: [PATCH] powerpc/85xx: Add P2020DS board support

2009-04-15 Thread Timur Tabi
d that has an ULI 1575 on it? Can't we define some property in the device tree to handle this? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-16 Thread Timur Tabi
irk_uli5288(). So please, don't revert any patches. And thanks to everyone for helping me resolve this issue. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: don't disable SATA interrupts on Freescale MPC8610 HPCD

2009-04-20 Thread Timur Tabi
does this, and so SATA support on the 8610 HPCD is broken. The original quirk function disabled INTx because it caused some other interrupt problem during early development on this board, but no one remembers any more what that problem was, and it doesn't seem to occur any more. Signed-off

Re: MPC8349E's DMA controller like ISA controller but with more feature?

2009-04-20 Thread Timur Tabi
gister, which is how ISA DMA is frequently used. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
we'll need to define a whole bunch of new structures to replace all of the "+ offset" usages. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Scott Wood wrote: > Timur Tabi wrote: >>>these two are related and seem like we could look for "fsl,cpm2" >> That's okay, as long as you don't break compatibility with older >> device trees that don't have that property, unless you can demo

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
I've nack'd patches before that broke backwards compatibility unnecessarily. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
ds compatibility. I'm tired of debugging customer issues where the kernel is updated but the firmware and device tree aren't. IMHO, Kernel developers are generally too lax when it comes to firmware and device tree backwards compatibility, and I think that's wrong. -- Timur Tabi Linu

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
ay. Specifically, I was referring to this comment: these two are related and seem like we could look for "fsl,cpm2" And my point was that not all device trees have "fsl,cpm2" in their CPM nodes. -- Timur Tabi Linux kernel developer at Freescale _

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
ernel that looks for the command-proc property > anymore. In that case, I have no issues. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
On Wed, Apr 22, 2009 at 5:33 PM, Scott Wood wrote: > All I'm asking is that we treat a mandatory dts upgrade as seriously as a > mandatory firmware upgrade. I agree with this statement 100%. -- Timur Tabi Linux kernel developer a

Re: removing get_immrbase()??

2009-04-23 Thread Timur Tabi
e device trees in the kernel is because we didn't have a better place to put them. Keeping them in the kernel repository was just convenient. So I personally don't consider the *location* of the DTS files to be a basis for deciding what they really mean. -- Timur Tabi Linux kerne

Re: removing get_immrbase()??

2009-04-23 Thread Timur Tabi
have should be considered tenuous (for lack of a better word). We should *strive* to maintain backwards compatibility. If that means adding a few lines of isolated code every now and then, I don't see that as a bad thing at all. -- Timur Tabi Linux

Re: removing get_immrbase()??

2009-04-23 Thread Timur Tabi
it. I'm saying we should make an effort to minimize the problem. Adding a few isolated lines of code to maintain that compatibility, and running a few tests, is not a bad idea and can save headaches for some people in the future. -- Timur Tabi

Re: removing get_immrbase()??

2009-04-23 Thread Timur Tabi
cifics, because I don't remember. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: MPC8349E's DMA controller like ISA controller but with more feature?

2009-04-24 Thread Timur Tabi
nnel that you want. I'm afraid that you're going to have to study the DMA programming model, and my device driver, and write a brand new driver from scratch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linu

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
hed reads. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH v6] introduce macro spin_event_timeout()

2009-04-27 Thread Timur Tabi
hardware register until a status bit changes. The timeout ensures that the loop still terminates if the bit doesn't change as expected. This macro makes it easier for driver developers to perform this kind of operation properly. Signed-off-by: Timur Tabi --- I'm making this a PowerPC-spec

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
> Would you like us to check any other transaction/register combos? Yes, could you try this on non-PCI memory? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
evice in the IMMR, but I don't see anything there that would constitute a memory buffer. I test this change on an 8610 and DMA to a register I/O, where this bit isn't even defined, and it made no difference. So I guess this change is okay. Acked-by: Timur Tabi -- Timur Tabi Linux ke

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
"This driver tells the DMA controller to use the PCI Read Multiple command, instead of the PCI Read Line command, for PCI read operations. Please be aware that this setting may result in read pre-fetching on some platforms." -- Timur Tab

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
David Hawkins wrote: > Ira will add your comment to the body of the code near > the PRC_RM command and submit a new patch. I'd rather have it near the top where people can see it. -- Timur Tabi Linux kernel developer at Freescale ___ L

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
n blocks of > local SDRAM showed no change in performance with this patch. The dmatest > driver was also used to verify the correctness of the transfers, and showed > no errors. > > Signed-off-by: Ira W. Snyder Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-27 Thread Timur Tabi
s are documented as specifically for PCI, so it would > be surprising if it had any effect elsewhere. Surely you wouldn't really be surprised by incorrect documentation of our parts. :-) -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-de

Re: [PATCH] fsldma: use PCI Read Multiple command

2009-04-28 Thread Timur Tabi
iver does not support copying data to/from a single register address. It's just a off-loaded memcpy. So we don't need to worry about what happens to a fixed address. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing lis

Re: removing get_immrbase()??

2009-04-28 Thread Timur Tabi
ew comments, and that should be enough. It won't always be possible to add such code, but at the very least, I expect the driver/kernel to clearly indicate what's missing from the device tree. In Kumar's example above, I expect the kernel to say that the MCM node is missing. -- Tim

Re: [PATCH v6] introduce macro spin_event_timeout()

2009-04-29 Thread Timur Tabi
On Mon, Apr 27, 2009 at 2:05 PM, Timur Tabi wrote: > The macro spin_event_timeout() takes a condition and timeout value > (in microseconds) as parameters.  It spins until either the condition is true > or the timeout expires.  It returns the result of the condition when the loop > wa

Re: [PATCH] powerpc/fsl: Add multiple MSI bank support

2010-03-21 Thread Timur Tabi
/* or some other error code */ The comment is inappropriate. I put it there as a reminder that maybe EBUSY is not the best choice. But if it is, then the comment should be removed. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-de

[PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-23 Thread Timur Tabi
Define a binding for embedding a QE firmware blob into the device tree. Also define a new property for the QE node that links to a firmware node. Signed-off-by: Timur Tabi --- .../powerpc/dts-bindings/fsl/cpm_qe/qe.txt | 50 1 files changed, 50 insertions(+), 0

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-24 Thread Timur Tabi
empty fsl,qe-firmware node at the root, and the boot loader just fills it in. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-24 Thread Timur Tabi
/ { model = "MPC8323EMDS"; compatible = "MPC8323EMDS", "MPC832xMDS", "MPC83xxMDS"; #address-cells = <1>; #size-cells = <1>; ... qe_firmware:qe-firmware { compatible = "fsl,qe-firmwar

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-24 Thread Timur Tabi
ed the QE blob in the DTB, whether it's a DTB created by DTC or updated by U-Boot, we might already have a GPL issue. I'll have to get back to you on that one. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-24 Thread Timur Tabi
M. Warner Losh wrote: > Is there some reason that the firmware couldn't be loaded by uboot as > part of its initialization? Unfortunately, our hardware is frequently designed such that the same firmware needs to be loaded by U-Boot and then again by the kernel. -- Timur Tabi L

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
are is not GPL, so I can't link it into the kernel. Believe me, it would have solved a lot of problems if we could. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
ise to define where > data-only nodes like this should live. Under /chosen perhaps? I personally don't care that much; /chosen is okay with me, but > It > wouldn't be good to place it somewhere where it will be confused for > an actual device node. .

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
ly got some insight on >> the best way to handle this without an incompatible .dtb file format >> change. > > What Segher suggested sounds like it's fundamentally a .dtb file format > change. That's the impression I got, as well. -- Timur Tabi Linux kern

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
ed)); > Put each firmware blob into a separate property, and make > the names reasonable (ie. mpc-qe-firmware). Have the QE > reference the firmware blob by property name. I don't like the idea of using the property name as a pseudo-compatible string. -- Timur Tabi Linux kernel de

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
ntained within the > tree. Eh, I don't know. Maybe if you bought me dinner first, you could talk me into it. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
a violation of the license, but having U-Boot dynamically embed it into a DTB isn't. Ok, maybe that's a bit ridiculous, but just humor me. In this case, it would useful to have the microcode in its own node with properties describing the microcode. Anyway, I may have gone off in t

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
8 { compatible = "fsl,qe"; fsl,firmware-phandle = <&qe_firmware>; ... } qe_firmware:qe-firmware { } See how the qe-firmware node is blank? It's just a placeholder for the firmware. U-Boot would then just need to update that node when it embeds the microco

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-25 Thread Timur Tabi
ill use different microcode binaries, and it also means that the initrd becomes SOC-specific. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
... } Without the compatible property, the only way I'd know that the child node contains a firmware is to look at the actual name of the child node, which (as Scott and I believe) is not better than a compatible property. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
0 { compatible = "fsl,qe"; fsl,firmware-phandle = <&qefw>; ... } -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
o the other? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] [v2] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
Define a binding for embedding a QE firmware blob into the device tree. Also define a new property for the QE node that links to a firmware node. Signed-off-by: Timur Tabi --- .../powerpc/dts-bindings/fsl/cpm_qe/qe.txt | 54 1 files changed, 54 insertions(+), 0

Re: [PATCH] [v2] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
Grant Likely wrote: > The node must be a child of a QE node. A QE node can reference the > firmware from another QE node by using the fsl,firmware-phandle > property. Ok. I'll post a V3 once everyone else has a chance to comment. -- Timur Tabi Linux kernel develope

[PATCH] [v3] powerpc/fsl: add device tree binding for QE firmware

2010-03-26 Thread Timur Tabi
Define a binding for embedding a QE firmware blob into the device tree. Also define a new property for the QE node that links to a firmware node. Signed-off-by: Timur Tabi --- .../powerpc/dts-bindings/fsl/cpm_qe/qe.txt | 54 1 files changed, 54 insertions(+), 0

[PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-26 Thread Timur Tabi
An upcoming change in the architecture of ALSA SoC (ASoC) will require the MPC8610 HPCD's ASoC fabric driver to register as a standard platform driver. Therefore, we need to call platform_device_register_simple() from the board's platform code. Signed-off-by: Timur Tabi --- Kumar

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
s not recognize two DMA devices for a single SSI. If you can fix that, then I can turn the DMA driver into an OF driver. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
ess-than-ideal, but it does restore functionality to the 8610, and without needing any U-Boot or device-tree changes. So unless there are any real objections, I'd like it to be merged. Otherwise, 8610 audio will be broken in the next release. -- Timur Tabi Linux kernel developer at Free

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
On Tue, Apr 27, 2010 at 10:28 AM, Timur Tabi wrote: > I can say for certain whether that will actually work. Ugh, I meant to write, "I can't say for certain". -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mai

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
ase, I still have the same problem with how to generate an 'id' based on a device tree node. We have the idea of a 'phandle', which is a unique integer for a node, but there's no way to create phandles from within Linux. They have to exist in the DTS first, and I'm

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
ta to the tree at runtime. I know. It just would have been nice if my nodes already had phandles in them. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
ecause there are no DT nodes that it can probe against. BenH is suggestion that maybe we can create one, but I'm not sure that's really the best approach. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxpp

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
the SSI node means that the SSI is not connected to a codec, so it should just be ignored altogether. An SSI is useless if it's not connected to a codec. > BTW Timur, there is nothing wrong with registering multiple devices > that all have the of_node pointer set to the same node. Sorry, I don't understand what you're getting at. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
... codec-handle = <&cs4270_1 &cs4270_2>; }; -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Timur Tabi
see how that can be handled with the current code. Each SSI is independent, and audio is streamed to it via DMA. The current SSI driver would need to be completely rewritten in order to initiate both DMA operations simultaneously. The clocking is the least of my problems. -- Timur Tab

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
r too simple and you want a list of more complex > objects. Yeah, I don't like it either. It seems arbitrary. > I think the ideal is something that's purely descriptive of the hardware > and doesn't include any policy decisions. I like to think that this is what we have today. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
abric driver is a platform driver. I might be able to move some code from the fabric driver into the SSI driver to make it the fabric driver less obnoxious about scanning the device tree. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
er via the platform data, it's going to have to know what information the fabric driver needs. Then the SSI driver is not board-independent. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.or

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
ULL, "fsl,mpc8610-ssi"))) { This finds every SSI node. I then extract the information from the SSI nodes and all the other nodes, and then register it with ASoC. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
capture-dma = &dma01; codec = &cs4270; } }; -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Timur Tabi
e place for collecting > nodes for stuff like this.  Perhaps this: > > system { >        compatible = "system-devices"; >        sound0 { >                compatible = "fsl,mpc8610hpcd-sound"; >                fsl,ssi = &ssi0; >                fsl,playback-

Re: [PATCH 0/5] Rework MPC5121 DIU support (for 2.6.35)

2010-04-29 Thread Timur Tabi
her issue on that board, so I can't test these patches for you just yet. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-04-29 Thread Timur Tabi
u_data *parent; > +       char *edid_data; edid_data should be "u8 *". "char *" is should be used only for strings or arrays of characters. > +       /* Still not found, use preferred mode from database if any */ > +       if (!has_default_mode && info->monsp

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-29 Thread Timur Tabi
hrough the whole boot process. > + * Move area descriptor and gamma table elsewhere, they are > + * destroyed by bootmem allocator otherwise. The frame buffer > + * address range will be reserved in setup_arch() after bootmem > + * allocator is up. > + */ > +void __init mpc512x_init_diu(void) > +{ > +       struct device_node *np; > +       void __iomem *diu_reg; > +       phys_addr_t desc; > +       void __iomem *vaddr; > +       unsigned long mode, pix_fmt, res, bpp; > +       unsigned long dst; > + > +       np = of_find_compatible_node(NULL, NULL, "fsl,mpc5121-diu"); > +       if (!np) { > +               pr_err("No DIU node\n"); > +               return; > +       } Shouldn't you be probing as an OF driver instead of manually searching for the DIU node? > + > +       diu_reg = of_iomap(np, 0); > +       of_node_put(np); > +       if (!diu_reg) { > +               pr_err("Can't map DIU\n"); > +               return; > +       } > + > +       mode = in_be32(diu_reg + 0x1c); > +       if (mode != 1) { How can in_be32() return a -1? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
lloc warning"). >> > +       mode = in_be32(diu_reg + 0x1c); >> > +       if (mode != 1) { >> >> How can in_be32() return a -1? > > It is a 1, not -1. I will use appropriate macro here and also > change to use a struct instead of adding offset to register bas

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
the largest possible integer. > > -1 is not the largest possible integer.  LONG_MAX, perhaps? What, you don't like implicit casting of -1 to an unsigned? :-) Since err is a long integer, LONG_MAX is the better choice. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
ode, so that no one else will wonder what you're doing. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-30 Thread Timur Tabi
annel. When I boot Linux, I get this: asoc: cs4270 <-> /s...@e000/s...@16000 mapping ok sysfs: cannot create duplicate filename '/devices/platform/soc-audio/cs4270' so it looks like when asoc is processing the dai_link, it tries to c

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-30 Thread Timur Tabi
On Fri, Apr 30, 2010 at 4:46 PM, Timur Tabi wrote: > When I boot Linux, I get this: > > asoc: cs4270 <-> /s...@e000/s...@16000 mapping ok > sysfs: cannot create duplicate filename '/devices/platform/soc-audio/cs4270' *sigh* never mind. The problem was that the

[PATCH 1/2] powerpc/8610: add probing for individual DMA channels, not just DMA controllers

2010-05-03 Thread Timur Tabi
ianfar (or any other networking device) on the 8610. Signed-off-by: Timur Tabi --- Kumar, the ASoC mainters are willing to pick up this patch, but they want an ACK from you first. Or, you could pick it up, since by itself it's harmless. arch/powerpc/platforms/86xx/mpc8610_hpcd.c |

Re: [PATCH 1/2] powerpc/8610: add probing for individual DMA channels, not just DMA controllers

2010-05-04 Thread Timur Tabi
Mark Brown wrote: > On Mon, May 03, 2010 at 04:54:15PM -0500, Timur Tabi wrote: > >> { .compatible = "simple-bus", }, >> -{ .compatible = "gianfar", }, >> +/* So that the DMA channel nodes can be probed individually:

Re: [alsa-devel] [PATCH 1/2] powerpc/8610: add probing for individual DMA channels, not just DMA controllers

2010-05-05 Thread Timur Tabi
little late in the cycle for a patch that doesn't do anything? I was expecting this patch to go into Liam's tree. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Page fault on vmalloc'ed memory

2010-05-05 Thread Timur Tabi
> vmalloc'ed area on powerpc?  Thanks a lot. Can you be more specific? Post the oops message, and tell us the specific x86 code that you think is missing. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxpp

Re: [alsa-devel] [PATCH 1/2] powerpc/8610: add probing for individual DMA channels, not just DMA controllers

2010-05-05 Thread Timur Tabi
Mark Brown wrote: > On Wed, May 05, 2010 at 06:39:01AM -0500, Timur Tabi wrote: >> On Wed, May 5, 2010 at 6:22 AM, Mark Brown > >>> Just looking at the scheduling here with regard to the merge window and >>> the fact that this doesn't seem to hurt the existing

Re: Using dmaengine on Freescale P2020 RDB

2011-04-08 Thread Timur Tabi
> 2. If dmaengine is correct, what can I do to free up a channel for my own use? There must be something else in your system using up the channels. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@

Login prompt on a video console instead of serial port?

2011-05-02 Thread Timur Tabi
node. So my question is: what do I need to do get the login prompt on the video console? That is, stdout goes to /dev/fb0 but stdin is still from /dev/ttyS0. I presume I need to direct "linux,stdout-path" to the fslfb node in the device tree, but there doesn't appear to be sup

Re: Login prompt on a video console instead of serial port?

2011-05-02 Thread Timur Tabi
l devices, since it insists on a baud rate as one of the parameters. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/86xx: don't pretend that we support 8-bit pixels on the MPC8610 HPCD

2011-05-09 Thread Timur Tabi
DIU video controller. The DIU driver does not currently support palette mode, but the MPC8610 HPCD board file returned a non-zero (although incorrect) pixel format value for 8-bit mode. Signed-off-by: Timur Tabi --- arch/powerpc/platforms/86xx/mpc8610_hpcd.c | 97 ++-- 1 fil

Updating the define_machine() structure at runtime?

2011-05-16 Thread Timur Tabi
ble(root, "fsl,P4080DS-hv")) { mach_p4080_ds.get_irq = ehv_pic_get_irq; ... return 1; } else return 0; #endif -- Timur Tabi Linux kernel developer at Freescale ___ Lin

[PATCH 0/7] This patchset adds support for running Linux under the Freescale hypervisor,

2011-05-19 Thread Timur Tabi
have hypervisor extensions (e.g. the P4080 which has an e500mc core). I think it makes sense for this patchset to go through Kumar Gala's -next branch, but I still need ACKs from various people on the parts that are not e500-specific. 1. powerpc: make irq_choose_cpu() available to all PIC driver

[PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver

2011-05-19 Thread Timur Tabi
tty driver, which is used to handle user-space input and output. The byte channel used for the console is designated as the default tty. Signed-off-by: Timur Tabi --- arch/powerpc/include/asm/udbg.h |1 + arch/powerpc/kernel/udbg.c |2 + drivers/tty/Kconfig | 33 ++ d

[PATCH 5/7] powerpc/85xx: add board support for the Freescale hypervisor

2011-05-19 Thread Timur Tabi
Add support for the ePAPR-compliant Freescale hypervisor (aka "Topaz") on the Freescale P3041DS, P4080DS, and P5020DS reference boards. Signed-off-by: Timur Tabi --- arch/powerpc/platforms/85xx/Kconfig |3 +++ arch/powerpc/platforms/85xx/corenet_ds.c |7 +++ ar

[PATCH 1/7] powerpc: make irq_choose_cpu() available to all PIC drivers

2011-05-19 Thread Timur Tabi
From: Stuart Yoder Move irq_choose_cpu() into arch/powerpc/kernel/irq.c so that it can be used by other PIC drivers. The function is not MPIC-specific. Signed-off-by: Stuart Yoder Signed-off-by: Timur Tabi --- arch/powerpc/include/asm/irq.h |2 ++ arch/powerpc/kernel/irq.c | 35

[PATCH 4/7] powerpc: add Freescale hypervisor partition control functions

2011-05-19 Thread Timur Tabi
; ppc_md.power_off = fsl_hv_halt; ppc_md.halt = fsl_hv_halt; Signed-off-by: Timur Tabi --- arch/powerpc/sysdev/fsl_soc.c | 27 +++ arch/powerpc/sysdev/fsl_soc.h |3 +++ 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch

[PATCH 2/7] powerpc: introduce ePAPR embedded hypervisor hcall interface

2011-05-19 Thread Timur Tabi
r3 5. Other returned parameters are in other registers. To provide this service to the kernel, these steps are wrapped in inline assembly functions. Standard ePAPR hcalls are in epapr_hcalls.h, and Freescale extensions are in fsl_hcalls.h. Signed-off-by: Timur Tabi --- arch/powerpc/include/asm/e

[PATCH 7/7] drivers/misc: introduce Freescale hypervisor management driver

2011-05-19 Thread Timur Tabi
partition upon receiving the shutdown doorbell from a manager partition 4. An interface for receiving callbacks when a managed partition shuts down. Signed-off-by: Timur Tabi --- drivers/misc/Kconfig |7 + drivers/misc/Makefile |1 + drivers/misc/fsl_hypervisor.c | 941

<    1   2   3   4   5   6   7   8   9   10   >