Re: [PATCH 03/11] time/hrtimer:Introduce hrtimer_get_res64() with timespec64 type for getting the timer resolution

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces hrtimer_get_res64() function to get the timer resolution > with timespec64 type, and moves the hrtimer_get_res() function into FYI, That function is about to go away, but it's not a big deal to sort that out once I applied the hrtimer

Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces the 'struct itimerspec64' for 64bit to replace > itimerspec, > and also introduces the conversion methods: itimerspec64_to_itimerspec() and > itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year. > > Signed-off-

Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Thomas Gleixner wrote: > On Mon, 20 Apr 2015, Baolin Wang wrote: > > This patch introduces the 'struct itimerspec64' for 64bit to replace > > itimerspec, > > and also introduces the conversion methods: itimerspec64_to_itimerspec() and > &g

Re: [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: > @@ -771,6 +771,7 @@ SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id, > struct itimerspec __user *, setting) > { > struct itimerspec cur_setting; > + struct itimerspec64 cur_setting64; > struct k_itimer *timr; > struct k

Re: [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: > /* Set clock_realtime */ > static int posix_clock_realtime_set(const clockid_t which_clock, > - const struct timespec *tp) > + const struct timespec64 *tp) > { > - return do_sys_settimeo

Re: [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function

2015-04-20 Thread Thomas Gleixner
On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces some functions for converting cputime to timespec64 and > back, > that repalce the timespec type with timespec64 type, as well as for arch/s390 > and > arch/powerpc architecture. No. We want a patch which adds the functions and the

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: > > COMPAT_SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id, > >struct compat_itimerspec __user *, setting) > > As a side note, I want to kill off the get_fs()/set_fs() calls in > the process. These always make me dizzy when I try t

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: > On Tuesday 21 April 2015 16:14:26 Thomas Gleixner wrote: > > > Note the use of a separate __kernel_itimerspec64 for the user interface > > > here, which I think will be needed to hide the differences between the > > > normal

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Arnd Bergmann wrote: > I know there are concerns about this, in particular because C11 and > POSIX both require tv_nsec to be 'long', unlike timeval->tv_usec, > which is a 'suseconds_t' and can be defined as 'long long'. > > a) > > struct timespec { > time_t tv_sec; >

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Thomas Gleixner wrote: > On Tue, 21 Apr 2015, Arnd Bergmann wrote: > > I know there are concerns about this, in particular because C11 and > > POSIX both require tv_nsec to be 'long', unlike timeval->tv_usec, > > which is a 'suseco

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Wed, 22 Apr 2015, Arnd Bergmann wrote: > On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: > > On Tue, 21 Apr 2015, Thomas Gleixner wrote: > > > So we could save one translation step if we implement new syscalls > > which have a scalar nsec interface instead

Re: [Patch v2 08/14] genirq: Introduce helper function irq_data_get_affinity_mask()

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Jiang Liu wrote: > Introduce helper function irq_data_get_affinity_mask() and > irq_get_affinity_mask() to hide implementation details, That patch does way more than introducing the functions. Again: Patch 1: Introduce helpers Patch 2-n: Convert users subsystem wise Thanks

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: You failed to thread the patch series again ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: > This patch series changes the 32-bit time types (timespec/itimerspec) to > the 64-bit types (timespec64/itimerspec64), since 32-bit time types will > break in the year 2038. That's only true for 32bit systems. All in all the patch series looks rather reas

Re: [v3,33/36] genirq: Use helper function to access irq_data->msi_desc

2015-06-03 Thread Thomas Gleixner
On Tue, 2 Jun 2015, Michael Ellerman wrote: > Though I would point out we already have 16 irq_foo_get_bar() accessors?! Say thanks to the people who mindlessly fiddled in the core managed fields of irqdesc and irqdata. The hard to track down wreckage they caused me to enforce accessors. The new a

Re: bit fields && data tearing

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Paul E. McKenney wrote: > On Fri, Sep 05, 2014 at 01:34:52PM -0700, H. Peter Anvin wrote: > > On 09/05/2014 01:14 PM, Peter Hurley wrote: > > > > > > Here's how I read the two statements. > > > > > > First, the commit message: > > > > > > "It [this commit] documents that CPUs

Re: [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument

2014-09-25 Thread Thomas Gleixner
On Thu, 25 Sep 2014, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:11AM +0800, Yijing Wang wrote: > > Msi_chip functions setup_irq/teardown_irq rarely use msi_chip > > argument. > > That's not true. Out of the four drivers that you modify two use the > parameter. And the two that don't pr

Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip

2014-09-25 Thread Thomas Gleixner
On Thu, 25 Sep 2014, Yijing Wang wrote: > Introduce weak arch_find_msi_chip() to find the match msi_chip. > Currently, MSI chip associates pci bus to msi_chip. Because in > ARM platform, there may be more than one MSI controller in system. > Associate pci bus to msi_chip help pci device to find th

Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip

2014-09-26 Thread Thomas Gleixner
On Fri, 26 Sep 2014, Yijing Wang wrote: > On 2014/9/25 18:38, Thomas Gleixner wrote: > > On Thu, 25 Sep 2014, Yijing Wang wrote: > > > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. > >> Currently, MSI chip associates pci bus to msi_chip. Be

Re: [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic

2014-11-27 Thread Thomas Gleixner
On Thu, 27 Nov 2014, Heiko Carstens wrote: > On Thu, Nov 27, 2014 at 09:03:01AM +0100, David Hildenbrand wrote: > > > Code like > > > spin_lock(&lock); > > > if (copy_to_user(...)) > > > rc = ... > > > spin_unlock(&lock); > > > really *should* generate warnings like it did before. >

Re: [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic

2014-11-27 Thread Thomas Gleixner
On Thu, 27 Nov 2014, David Hildenbrand wrote: > > OTOH, there is no reason why we need to disable preemption over that > > page_fault_disabled() region. There are code pathes which really do > > not require to disable preemption for that. > > > > We have that seperated in preempt-rt for obvious re

Re: [PATCH] powerpc: secondary CPUs signal to master before setting active and online (fixes kernel BUG at kernel/smpboot.c:134!)

2014-12-10 Thread Thomas Gleixner
On Tue, 9 Dec 2014, Linus Torvalds wrote: > On Mon, Dec 8, 2014 at 3:58 PM, Anton Blanchard wrote: > > Hi Ingo, > > > >> At that point I thought the previous task_cpu() was somewhat ingrained > >> in the scheduler and came up with the patch. If not, we could go on a > >> hunt to see what else need

Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread Thomas Gleixner
er (ibmvscsi) seems to be doing that from softirq context. > > This converts the few non-irqsafe locks into irqsafe ones, making them > consistent with the rest of the code. Fun. https://lkml.org/lkml/2013/2/4/416 seems to have got lost > Signed-off-by: Benjamin Herrenschmidt > CC:

Re: [PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-12 Thread Thomas Gleixner
On Fri, 12 Jun 2015, Baolin Wang wrote: Sigh. Again threading of the series failed. Some patches are, the whole series is not. Can you please get your tools straight? You neither managed to cc me on the security patch. > - Modify the subject line and the changelog: > timekeeping: Change the i

[patch 01/20] powerpc/media5200: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 03/20] powerpc/pq2ads: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 02/20] powerpc/52xx: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 00/20] powerpc: Interrupt cleanups and API change preparation

2015-07-13 Thread Thomas Gleixner
The following patch series contains the following changes: - Consolidation of chained interrupt handler setup/removal - Switch to functions which avoid a redundant interrupt descriptor lookup - Preparation of interrupt flow handlers for the 'irq' argument removal The ser

[patch 04/20] powerpc/axon_msi: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 05/20] powerpc/cell: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 06/20] powerpc/spider-pic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 07/20] powerpc/hlwd-pic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 08/20] powerpc/holly: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 09/20] powerpc/mpc7448: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 10/20] powerpc/mpic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 11/20] powerpc/qe_ic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 12/20] powerpc/uic: Consolidate chained IRQ handler install/remove

2015-07-13 Thread Thomas Gleixner
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle. Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Benja

[patch 13/20] powerpc/irq: Use access helper irq_data_get_affinity_mask()

2015-07-13 Thread Thomas Gleixner
From: Jiang Liu This is a preparatory patch for moving irq_data struct members. Signed-off-by: Jiang Liu Cc: linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Signed-off-by: Thomas Gleixner --- arch/powerpc/kernel/irq.c |2 +- arch/powerpc/sysdev

[patch 14/20] powerpc/mpc52xx: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner Cc: Jiang Liu Cc: Julia Lawall Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch

[patch 15/20] powerpc/cpm2: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner Cc: Jiang Liu Cc: Julia Lawall Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch

[patch 16/20] powerpc/ipic: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner Cc: Jiang Liu Cc: Julia Lawall Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch

[patch 17/20] powerpc/mpc8xx: Use irq_set_handler_locked()

2015-07-13 Thread Thomas Gleixner
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle. Signed-off-by: Thomas Gleixner Cc: Jiang Liu Cc: Julia Lawall Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch

[patch 18/20] powerpc/mpc5121: Prepare cpld_pic_cascade for irq argument removal

2015-07-13 Thread Thomas Gleixner
: Thomas Gleixner Cc: Julia Lawall Cc: Jiang Liu --- arch/powerpc/platforms/512x/mpc5121_ads_cpld.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: tip/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c

[patch 19/20] powerpc/85xx: Prepare cascade handlers for irq argument removal

2015-07-13 Thread Thomas Gleixner
: Thomas Gleixner Cc: Julia Lawall Cc: Jiang Liu --- arch/powerpc/platforms/85xx/mpc85xx_cds.c |3 ++- arch/powerpc/platforms/85xx/socrates_fpga_pic.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) Index: tip/arch/powerpc/platforms/85xx/mpc85xx_cds.c

[patch 20/20] powerpc/cell: Prepare iic_ioexc_cascade for irq argument removal

2015-07-13 Thread Thomas Gleixner
: Thomas Gleixner Cc: Julia Lawall Cc: Jiang Liu --- arch/powerpc/platforms/cell/interrupt.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: tip/arch/powerpc/platforms/cell/interrupt.c === --- tip.orig/arch/powerpc

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-15 Thread Thomas Gleixner
On Wed, 15 Jul 2015, Baolin Wang wrote: > The cputime_to_timespec() and timespec_to_cputime() functions are > not year 2038 safe on 32bit systems due to that the struct timepsec > will overflow in 2038 year. And how is this relevant? cputime is not based on wall clock time at all. So what has 203

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-15 Thread Thomas Gleixner
On Wed, 15 Jul 2015, Baolin Wang wrote: > On 15 July 2015 at 18:31, Thomas Gleixner wrote: > > On Wed, 15 Jul 2015, Baolin Wang wrote: > > > >> The cputime_to_timespec() and timespec_to_cputime() functions are > >> not year 2038 safe on 32bit systems due to t

Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime()

2015-07-16 Thread Thomas Gleixner
On Thu, 16 Jul 2015, Baolin Wang wrote: > On 15 July 2015 at 19:55, Thomas Gleixner wrote: > > On Wed, 15 Jul 2015, Baolin Wang wrote: > > > >> On 15 July 2015 at 18:31, Thomas Gleixner wrote: > >> > On Wed, 15 Jul 2015, Baolin Wang wrote: > >

Re: [PATCH 1/3] x86, irq: Rename VECTOR_UNDEFINED and VECTOR_RETRIGGERED to IRQ_*

2015-07-17 Thread Thomas Gleixner
On Sun, 12 Jul 2015, Bjorn Helgaas wrote: > The per-cpu vector_irq[] table is indexed by CPU vector numbers, and each > entry contains an IRQ number. > > Rename the special values VECTOR_UNDEFINED and VECTOR_RETRIGGERED to > IRQ_UNDEFINED and IRQ_RETRIGGERED to indicate that they are in the IRQ >

Re: [patch 00/20] powerpc: Interrupt cleanups and API change preparation

2015-07-31 Thread Thomas Gleixner
On Thu, 16 Jul 2015, Michael Ellerman wrote: Sorry I missed your reply ... > On Mon, 2015-07-13 at 20:50 +0000, Thomas Gleixner wrote: > > The following patch series contains the following changes: > > > > - Consolidation of chained interrupt handler setup/removal >

[PATCH] powerpc: Mark low level irq handlers NO_THREAD

2013-02-13 Thread Thomas Gleixner
These low level handlers cannot be threaded. Mark them NO_THREAD Reported-by: leroy christophe Tested-by: leroy christophe Signed-off-by: Thomas Gleixner --- arch/powerpc/platforms/8xx/m8xx_setup.c |1 + arch/powerpc/sysdev/cpm1.c |1 + 2 files changed, 2 insertions

Re: [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-18 Thread Thomas Gleixner
On Mon, 18 Feb 2013, Srivatsa S. Bhat wrote: > Lockup observed while running this patchset, with CPU_IDLE and INTEL_IDLE > turned > on in the .config: > > smpboot: CPU 1 is now offline > Kernel panic - not syncing: Watchdog detected hard LOCKUP on cpu 11 > Pid: 0, comm: swapper/11 Not tainted 3.

Re: [PATCH V4 6/9] cpuidle/ppc: Add basic infrastructure to enable the broadcast framework on ppc

2013-11-29 Thread Thomas Gleixner
On Fri, 29 Nov 2013, Preeti U Murthy wrote: > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index b44b52c..cafa788 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -129,6 +129,8 @@ config PPC > select GENERIC_CMOS_UPDATE > select GENERIC_TIME_VSYSCALL_O

Re: [PATCH V4 7/9] cpuidle/powernv: Add "Fast-Sleep" CPU idle state

2013-11-29 Thread Thomas Gleixner
On Fri, 29 Nov 2013, Preeti U Murthy wrote: > +static enum hrtimer_restart handle_broadcast(struct hrtimer *hrtimer) > +{ > + struct clock_event_device *bc_evt = &bc_timer; > + ktime_t interval, next_bc_tick, now; > + > + now = ktime_get(); > + > + if (!restart_broadcast(bc_evt)) >

Re: [PATCH V4 7/9] cpuidle/powernv: Add "Fast-Sleep" CPU idle state

2013-12-02 Thread Thomas Gleixner
On Mon, 2 Dec 2013, Preeti U Murthy wrote: > On 11/29/2013 08:09 PM, Thomas Gleixner wrote: > > This supports HIGHRES and NO_HZ if done right, without polling at > > all. So you can even let the last CPU which handles the broadcast > > hrtimer go for a long sleep, just no

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-22 Thread Thomas Gleixner
On Wed, 15 Jan 2014, Preeti U Murthy wrote: > diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c > index 086ad60..d61404e 100644 > --- a/kernel/time/clockevents.c > +++ b/kernel/time/clockevents.c > @@ -524,12 +524,13 @@ void clockevents_resume(void) > #ifdef CONFIG_GENERIC_CLOCKEV

Re: [PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-02-04 Thread Thomas Gleixner
On Fri, 24 Jan 2014, Preeti U Murthy wrote: > -extern void tick_broadcast_oneshot_control(unsigned long reason); > +extern int tick_broadcast_oneshot_control(unsigned long reason); > -static inline void tick_broadcast_oneshot_control(unsigned long reason) { } > +static inline int tick_broadcast_on

Re: [PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-04 Thread Thomas Gleixner
> +++ b/kernel/time/tick-broadcast-hrtimer.c > +/* > + * This is called from the guts of the broadcast code when the cpu > + * which is about to enter idle has the earliest broadcast timer event. > + */ > +static int bc_set_next(ktime_t expires, struct clock_event_device *bc) > +{ > + ktime_t n

Re: [PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-04 Thread Thomas Gleixner
On Tue, 4 Feb 2014, Preeti U Murthy wrote: > Do you want me to send out the next version with the above corrections > including the patch added to this thread where we handle archs setting > the CPUIDLE_FLAG_TIMER_STOP flag? Yes please. ___ Linuxppc-dev

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-05 Thread Thomas Gleixner
On Thu, 23 Jan 2014, Daniel Lezcano wrote: > On 01/23/2014 08:12 AM, Yijing Wang wrote: > > Currently, clocksource_register() and __clocksource_register_scale() > > functions always return 0, it's pointless, make functions void. > > And remove the dead code that check the clocksource_register_hz()

RE: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-05 Thread Thomas Gleixner
Yijing, On Thu, 23 Jan 2014, David Laight wrote: > From: Linuxppc-dev Tony Prisk > > On 23/01/14 20:12, Yijing Wang wrote: > > > Currently, clocksource_register() and __clocksource_register_scale() > > > functions always return 0, it's pointless, make functions void. > > > And remove the dead cod

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Thomas Gleixner
An Thu, 6 Feb 2014, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre Acked-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/2] ARM64: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Thomas Gleixner
On Thu, 6 Feb 2014, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre Acked-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-06 Thread Thomas Gleixner
On Thu, 6 Feb 2014, Preeti U Murthy wrote: Compiler warnings are not so important, right? kernel/time/tick-broadcast.c: In function ‘tick_broadcast_oneshot_control’: kernel/time/tick-broadcast.c:700:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type] kernel/time/ti

Re: [PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-06 Thread Thomas Gleixner
On Thu, 6 Feb 2014, Preeti U Murthy wrote: > On 02/06/2014 09:33 PM, Thomas Gleixner wrote: > > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > > > > Compiler warnings are not so important, right? > > > > kernel/time/tick-broadcast.c: In function ‘tick_broadcast_

Re: [PATCH V4 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-11 Thread Thomas Gleixner
On Tue, 11 Feb 2014, Daniel Lezcano wrote: > On 02/07/2014 09:06 AM, Preeti U Murthy wrote: > Setting the smp affinity on the earliest timer should be handled automatically > with the CLOCK_EVT_FEAT_DYNIRQ flag. Did you look at using this flag ? How should this flag help? Not at all, because the h

Re: [PATCH] rapidio/tsi721: fix tasklet termination in dma channel release

2014-02-21 Thread Thomas Gleixner
gned-off-by: Alexandre Bounine > Cc: Matt Porter > Cc: Xiaotian Feng > Cc: Thomas Gleixner > Cc: Mike Galbraith > Cc: Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[patch 02/26] powerpc:evh_pic: Kill irq_desc abuse

2014-02-23 Thread Thomas Gleixner
in tree. The solution is simple: Remove the brainfart and use the proper functions, which should have been used in the first place Signed-off-by: Thomas Gleixner Cc: Benjamin Herrenschmidt Cc: Ashish Kalra Cc: Timur Tabi Cc: Kumar Gala Cc: ppc --- arch/powerpc/sysdev/ehv_pic.c | 10 ++--

[patch 01/26] powerpc: irq: Use generic_handle_irq

2014-02-23 Thread Thomas Gleixner
No functional change Signed-off-by: Thomas Gleixner Cc: Benjamin Herrenschmidt Cc: ppc --- arch/powerpc/kernel/irq.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Index: tip/arch/powerpc/kernel/irq.c

[patch 03/26] powerpc: eeh: Kill another abuse of irq_desc

2014-02-23 Thread Thomas Gleixner
g the proper interfaces for retrieving the information for the 'hack around' irq_desc is core internal and it's clear enough stated. Replace at least the irq_desc abuse with the proper functions and add a big fat comment why this is absurd and completely wrong. Signed-off-by: T

Re: [patch 03/26] powerpc: eeh: Kill another abuse of irq_desc

2014-02-24 Thread Thomas Gleixner
On Mon, 24 Feb 2014, Gavin Shan wrote: > On Sun, Feb 23, 2014 at 09:40:09PM -0000, Thomas Gleixner wrote: > >commit 91150af3a (powerpc/eeh: Fix unbalanced enable for IRQ) is > >another brilliant example of trainwreck engineering. > > > >The patch "fixes&quo

Re: [PATCH 1/2] sched: Remove unused mc_capable() and smt_capable()

2014-03-04 Thread Thomas Gleixner
logy.h |1 - > arch/sparc/include/asm/topology_64.h |2 -- > arch/x86/include/asm/topology.h |6 -- > 6 files changed, 17 deletions(-) Acked-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"

2014-03-04 Thread Thomas Gleixner
On Wed, 5 Mar 2014, Benjamin Herrenschmidt wrote: > On Tue, 2014-03-04 at 15:15 -0800, tip-bot for Thomas Gleixner wrote: > > Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e > > Gitweb: > > http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e &

Re: [PATCH 1/2 v2] irqdomain: add support for creating a continous mapping

2014-03-14 Thread Thomas Gleixner
ort for continuous allocation of virqs for a range > of hwirqs. The function is based on irq_create_mapping() but due to the > number argument there is very little in common now. > > Cc: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > Scott, this is what you su

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread Thomas Gleixner
> Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Andrew Morton > Signed-off-by: Laura Abbott For the x86 part: Acked-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread Thomas Gleixner
On Sat, 22 Mar 2014, James Bottomley wrote: > On Sat, 2014-03-22 at 11:13 -0700, Laura Abbott wrote: > > Rather than have architectures #define ARCH_HAS_SG_CHAIN in an architecture > > specific scatterlist.h, make it a proper Kconfig option and use that > > instead. At same time, remove the header

Re: [PATCH V2] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-20 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Preeti U Murthy wrote: > --- a/kernel/time/tick-broadcast.c > +++ b/kernel/time/tick-broadcast.c > @@ -675,8 +675,8 @@ static void broadcast_move_bc(int deadcpu) > > if (!bc || !broadcast_needs_cpu(bc, deadcpu)) > return; > - /* This moves the broadcas

Re: [PATCH] idle/tick-broadcast: Exit cpu idle poll loop when cleared from tick_broadcast_force_mask

2015-01-20 Thread Thomas Gleixner
On Mon, 19 Jan 2015, Preeti U Murthy wrote: > An idle cpu enters cpu_idle_poll() if it is set in the > tick_broadcast_force_mask. > This is so that it does not incur the overhead of entering idle states when > it is expected > to be woken up anytime then through a broadcast IPI. The condition tha

Re: [PATCH] idle/tick-broadcast: Exit cpu idle poll loop when cleared from tick_broadcast_force_mask

2015-01-21 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Preeti U Murthy wrote: > On 01/20/2015 04:51 PM, Thomas Gleixner wrote: > > On Mon, 19 Jan 2015, Preeti U Murthy wrote: > >> An idle cpu enters cpu_idle_poll() if it is set in the > >> tick_broadcast_force_mask. > >> This is so that it doe

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-21 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Preeti U Murthy wrote: > diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c > index 5544990..f3907c9 100644 > --- a/kernel/time/clockevents.c > +++ b/kernel/time/clockevents.c > @@ -568,6 +568,7 @@ int clockevents_notify(unsigned long reason, void *arg) > >

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-22 Thread Thomas Gleixner
On Thu, 22 Jan 2015, Preeti U Murthy wrote: > On 01/21/2015 05:16 PM, Thomas Gleixner wrote: > How about when the cpu that is going offline receives a timer interrupt > just before setting its state to CPU_DEAD ? That is still possible right > given that its clock devices may n

Re: [PATCH V2] cpuidle: Add missing checks to the exit condition of cpu_idle_poll()

2015-01-22 Thread Thomas Gleixner
red() to the exit condition of cpu_idle_poll() > to avoid this. > > Signed-off-by: Preeti U Murthy Reviewed-by: Thomas Gleixner > --- > Changes from V1: Modified the Changelog > > kernel/sched/idle.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > &g

Re: [PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

2016-04-27 Thread Thomas Gleixner
at contain a two older implementations of > the CONFIG_RTC_DRV_CMOS driver. > > This removes x86 from the list. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.

[BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-16 Thread Thomas Gleixner
With this commit applied, my MPC5200 board fails to boot 4.3-rc1. The boot failure is silent. Bisection pointed straight to this commit. Reverting it on top of 4.3-rc1 works like a charm. Thanks, tglx ___ Linuxppc-dev mailing list Linuxppc-dev@

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-16 Thread Thomas Gleixner
On Wed, 16 Sep 2015, Scott Wood wrote: > On Wed, 2015-09-16 at 18:23 +0200, Thomas Gleixner wrote: > > With this commit applied, my MPC5200 board fails to boot 4.3-rc1. The > > boot failure is silent. > > > > Bisection pointed straight to this commit. Reverting it

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Wed, 16 Sep 2015, Steven Rostedt wrote: > On Wed, 16 Sep 2015 22:01:06 +0200 (CEST) > Thomas Gleixner wrote: > > So now I have to chase down that one: > > > > [0.230210] ftrace: allocating 16560 entries in 49 pages > > [0.273313] [ cut here ]

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Thu, 17 Sep 2015, Steven Rostedt wrote: > On Thu, 17 Sep 2015 12:13:15 +0200 (CEST) > Thomas Gleixner wrote: > > > Digging deeper. My assumption that it's a post powerpc merge failure > > turned out to be wrong. > > Does 4.2 have the problem? No. Neither d

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-17 Thread Thomas Gleixner
On Thu, 17 Sep 2015, Steven Rostedt wrote: > On Thu, 17 Sep 2015 16:38:52 +0200 (CEST) > Thomas Gleixner wrote: > > > On Thu, 17 Sep 2015, Steven Rostedt wrote: > > > > > On Thu, 17 Sep 2015 12:13:15 +0200 (CEST) > > > Thomas Gleixner wrote: > >

Re: [BUG] Revert 0b05e2d671c4 'powerpc/32: cacheable_memcpy becomes memcpy'

2015-09-18 Thread Thomas Gleixner
On Fri, 18 Sep 2015, Segher Boessenkool wrote: > On Fri, Sep 18, 2015 at 08:01:57PM +1000, Michael Ellerman wrote: > > Weird. > > > > Can you try: > > > > d690740f22f6 ("powerpc/powernv: Enable LEDS support") > > > > That is the commit before my merge of Scott's tree, which had all the > > F

RE: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

2015-09-22 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Wang Dongsheng wrote: > > On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote: > > > mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets IRQF_NO_SUSPEND > > > flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak > > > is not implemented. Also there's

RE: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

2015-09-23 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Wang Dongsheng wrote: > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Thomas Gleixner > > Sent: Wednesday, September 23, 2015 11:49 AM > > To: Wang Dongs

Re: [PATCH v6 40/53] PCI: Unify skip_ioresource_align()

2015-10-01 Thread Thomas Gleixner
t; Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Arnd Bergmann > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-a...@vger.kernel.org > Signed-off-by: Yinghai Lu Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH v3 27/41] x86: define __smp_xxx

2016-01-12 Thread Thomas Gleixner
d Bergmann Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 13/41] x86: reuse asm-generic/barrier.h

2016-01-12 Thread Thomas Gleixner
preparation to refactoring this code area. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Arnd Bergmann Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

2016-01-26 Thread Thomas Gleixner
On Thu, 21 Jan 2016, Zhao Qiang wrote: > 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info How do you trigger that overflow? The above does not explain WHY we need these checks. > diff --git a/drivers/soc/fsl/qe/q

Re: [PATCH v2 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Thomas Gleixner
On Wed, 27 Jan 2016, Christian Borntraeger wrote: > We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC > is not set. It will return false in that case. > > Signed-off-by: Christian Borntraeger > Acked-by: David Rientjes Acked-by:

Re: [PATCH v2 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Thomas Gleixner
, which ignored > CONFIG_DEBUG_PAGEALLOC. Do we need to fence this as well? > > Signed-off-by: Christian Borntraeger Reviewed-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: PROBLEM: monotonic clock going backwards on ppc64

2019-03-01 Thread Thomas Gleixner
On Sat, 2 Mar 2019, Michael Ellerman wrote: > > The problem seems to be in vDSO code in > > arch/powerpc/kernel/vdso64/gettimeofday.S. > > You're right, the wall-to-monotonic offset (wtom_clock_sec) is a signed > 32-bit value, so that seems like it's going to have problems. > > If I do `date -s

Re: [RFC PATCH v2 08/14] watchdog/hardlockup: Decouple the hardlockup detector from perf

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Detect hard lockups on a system > + * > + * Copyright (C) Intel Corporation 2019 > + * > + * Note: All of this code comes from the original perf-specific hardlockup > + * detector. And because you copied it

Re: [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation

2019-03-26 Thread Thomas Gleixner
On Thu, 28 Feb 2019, Ricardo Neri wrote: > > > > > > -#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) > > > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) || \ > > > +defined(CONFIG_X86_HARDLOCKUP_DETECTOR_HPET) > > > > Why not instead make CONFIG_X86_HARDLOCKUP_DETECTOR_HPET select > > CONFIG_HA

  1   2   3   4   5   6   7   8   9   >