Re: usb: gadget: fsl_udc_core: Checking for a failed platform_get_irq() call in fsl_udc_probe()

On Thu,Apr 9,2020 08:28:28 Markus Elfring wrote: > I was unsure if I noticed another programming mistake. > Do other contributors know the affected software module better than me? I discovered this problem fews days ago, and doing experiments on the hardware to test my idea. Thanks Tang Bin

[PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. Signed-off-by: Tang Bin Signed-off-by: Shengju Zha

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

age. Will another fine-tuning become relevant also for this wording? Maybe that's not quite accurate. Thus it must be fixed. Wording alternative: Thus adjust the error detection and corresponding exception handling. Got it. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang How

Re: usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

case empty)? I don't know what you mean of "instead of leaving one case empty". I suggest to reconsider also the proposed specification “… ? : …”. What you mean is the way I'm written？ I have provided two ways of patching, both functional can be verified on hardware. Thanks for your patience. Tang Bin

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

Hi On 2020/4/14 16:30, Dan Carpenter wrote: On Fri, Apr 10, 2020 at 04:05:06PM +0800, Tang Bin wrote: Thus it must be fixed. Wording alternative: Thus adjust the error detection and corresponding exception handling. Got it. Wow... No, don't listen to Markus when it comes to wr

[PATCH] ASoC: fsl_micfil: Omit superfluous error message in fsl_micfil_probe()

In the function fsl_micfil_probe(), when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang --- sound/soc/fsl/fsl_micfil.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH] ASoC: fsl_xcvr: Use devm_platform_ioremap_resource_byname() to simplify code

In this function, devm_platform_ioremap_resource_byname() should be suitable to simplify code. Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_xcvr.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 6dd0a5fcd455

[PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

The function fsl_spdif_probe() is only called with an openfirmware platform device. Therefore there is no need to check that the passed in device is NULL. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_spdif.c | 3 --- 1 file changed, 3 deletions(-) diff --git a

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check infsl_spdif_probe()

Hi Mark 在 2020/8/27 0:53, Mark Brown 写道: On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: The function fsl_spdif_probe() is only called with an openfirmware platform device. Therefore there is no need to check that the passed in device is NULL. Why is this an issue - the check will

[PATCH] ASoC: fsl_spdif: Utilize the defined parameter to clear code

Utilize the defined parameter 'dev' to make the code cleaner. Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_spdif.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 455f96908..b6d5563df 100644 -

[PATCH] ASoC: fsl_micfil: Fix format and unused assignment

In the function fsl_micfil_startup(), the two lines of dev_err() can be shortened to one line. And delete unused initialized value of 'ret', because it will be assigned by the function fsl_micfil_set_mclk_rate(). Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_micfil.c | 5 ++--- 1 fi

Re: [PATCH] ASoC: fsl_micfil: Fix format and unused assignment

On 2020/5/18 18:25, Mark Brown wrote: On Mon, May 18, 2020 at 03:44:05PM +0800, Tang Bin wrote: In the function fsl_micfil_startup(), the two lines of dev_err() can be shortened to one line. And delete unused initialized value of 'ret', because it will be assigned by th

[PATCH] ASoC: fsl_micfil: Fix indentation to put on one line affected code

In the function fsl_micfil_startup(), the two lines of dev_err() can be shortened to one line. Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_micfil.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index f7f2d29f1

[PATCH] ASoC: fsl_micfil: Fix unused assignment in fsl_set_clock_params()

Delete unused initialized value of 'ret', because it will be assigned by the function fsl_micfil_set_mclk_rate(). Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_micfil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fs

[PATCH] ASoC: fsl_xcvr: Omit superfluous error message in fsl_xcvr_probe()

In the function fsl_xcvr__probe(), when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_xcvr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b