[async_tx-next PATCH 2/2] fsldma: Fix cookie issues

2010-02-22 Thread Steven J. Magnani
fsl_dma_update_completed_cookie() appears to calculate the last completed cookie incorrectly in the corner case where DMA on cookie 1 is in progress just following a cookie wrap. Signed-off-by: Steven J. Magnani --- diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c --- a/drivers/dma

[async_tx-next PATCH 0/2] fsldma: Fix cookie issues

2010-02-22 Thread Steven J. Magnani
er, it's a nice model to follow. Regards, ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space mo

[async_tx-next PATCH 1/2] fsldma: Fix cookie issues

2010-02-22 Thread Steven J. Magnani
fsl_dma_tx_submit() only sets the cookie on the first descriptor of a transaction. It should set the cookie on all. Signed-off-by: Steven J. Magnani --- diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c --- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.0 -0600 +++ b/drivers/dma

[async_tx-next PATCH v2 1/2] fsldma: Fix cookie issues

2010-02-25 Thread Steven J. Magnani
fsl_dma_tx_submit() only sets the cookie on the first descriptor of a transaction. It should set the cookie on all. Signed-off-by: Steven J. Magnani --- diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c --- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.0 -0600 +++ b/drivers/dma

[async_tx-next PATCH v2 2/2] fsldma: Fix cookie issues

2010-02-25 Thread Steven J. Magnani
fsl_dma_update_completed_cookie() appears to calculate the last completed cookie incorrectly in the corner case where DMA on cookie 1 is in progress just following a cookie wrap. Signed-off-by: Steven J. Magnani --- diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c --- a/drivers/dma

Re: [PATCH] [RFC] Xilinx MPMC SDMA subsystem

2010-03-29 Thread Steven J. Magnani
On Fri, 2010-03-26 at 17:53 -0600, Grant Likely wrote: > I've not got time to review this patch right now, but Sergey and > Steven, you both posted MPMC drivers on the same day; Steven on the > microblaze list and Sergey on the powerpc list. Can you two please > coordinate and figure out how to mo

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Steven J. Magnani
cant you use netdev_alloc_skb_ip_align() in this driver ? > > That should work. I switched to that in the older xilinx_lltemac driver without any problem. Steven J. Magnani "I claim this network for

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Steven J. Magnani
headers should define NET_SKB_PAD as well? ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include ___ Lin

Re: [PATCH] [RFC] Xilinx MPMC SDMA subsystem

2010-04-20 Thread Steven J. Magnani
, some suggestions are 'mpmcsdma' (long, but precise), 'xildma', 'xsdma', or 'xdma' (also perhaps too generic). As time permits, I'll work on refactoring the DMA engine driver to use the sdma driver - I'll post change requests for anything else I need

Re: [microblaze-uclinux] [PATCHv2] [RFC] Xilinx MPMC SDMA subsystem

2010-04-27 Thread Steven J. Magnani
On Wed, 2010-04-28 at 02:06 +0400, Sergey Temerkhanov wrote: > This is the 2nd version of Xilinx MPMC LocalLink SDMA subsystem > > Changelog v2: > * Changed the functions and struct definition prefix from sdma_ to xllsdma_ > * Platform bus bindings and various changes by St

Re: [microblaze-uclinux] [PATCHv2] [RFC] Xilinx MPMC SDMA subsystem

2010-04-28 Thread Steven J. Magnani
Grant - Thanks for the feedback. My responses are inline. --Steve On Tue, 2010-04-27 at 23:13 -0600, Grant Likely wrote: > Hi Sergey and Steven, > > On Tue, Apr 27, 2010 at 8:29 PM, Steven J. Magnani > wrote: > > On Wed, 2010-04-28 at 02:06 +0400, Sergey Temerkhanov wrote