Re: Invalid perf_branch_entry.to entries question

2013-05-08 Thread Stephane Eranian
On Wed, May 8, 2013 at 5:59 PM, Peter Zijlstra wrote: > On Tue, May 07, 2013 at 11:35:28AM +1000, Michael Neuling wrote: >> Peter & Stephane, >> >> We are plumbing the POWER8 Branch History Rolling Buffer (BHRB) into >> struct perf_branch_entry. >> >> Sometimes on POWER8 we may not be able to fill

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-16 Thread Stephane Eranian
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra wrote: > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote: >> Peter, >> >> BTW PowerPC also has the ability to filter on conditional branches. Any >> chance we could add something like the follow to perf also? >> > > I don't see an im

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-17 Thread Stephane Eranian
On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra wrote: > On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote: >> Peter Zijlstra wrote: > >> > Wouldn't it be mostly conditional branches that are the primary control >> > flow >> > and can get predicted wrong? I mean, I'm sure someone w

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-17 Thread Stephane Eranian
On Sat, May 18, 2013 at 12:14 AM, Michael Neuling wrote: > Stephane Eranian wrote: > >> On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra wrote: >> > On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote: >> >> Peter Zijlstra wrote: >> >

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-21 Thread Stephane Eranian
On Tue, May 21, 2013 at 10:50 AM, Peter Zijlstra wrote: > On Tue, May 21, 2013 at 03:41:35PM +1000, Michael Neuling wrote: >> Peter Zijlstra wrote: >> >> Can we add your signed-off-by on this? >> >> We are cleaning up our series for conditional branches and would like to >> add this as part of th

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-21 Thread Stephane Eranian
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote: > Peter Zijlstra wrote: > >> On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote: >> > On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra >> > wrote: >> > > We should always have pro

Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL

2013-05-22 Thread Stephane Eranian
Hi, On Wed, May 22, 2013 at 8:43 AM, Anshuman Khandual wrote: > On 05/21/2013 07:25 PM, Stephane Eranian wrote: >> On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote: >>> Peter Zijlstra wrote: >>> >>>> On Wed, May 15, 2013 at 03:37:22PM +0200, Step

Re: [PATCH 1/5] perf: New conditional branch filter criteria in branch stack sampling

2013-05-23 Thread Stephane Eranian
onality with either HW filtering support (if present) or > with SW filtering of instructions. > Reviewed-by: Stephane Eranian > Signed-off-by: Anshuman Khandual > --- > include/uapi/linux/perf_event.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 4/5] x86, perf: Add conditional branch filtering support

2013-05-23 Thread Stephane Eranian
JCC. > Reviewed-by: Stephane Eranian > Signed-off-by: Peter Zijlstra > Signed-off-by: Anshuman Khandual > --- > arch/x86/kernel/cpu/perf_event_intel_lbr.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_lbr.c > b/arch/

Re: [PATCH 5/5] perf, documentation: Description for conditional branch filter

2013-05-23 Thread Stephane Eranian
On Wed, May 22, 2013 at 8:22 AM, Anshuman Khandual wrote: > Adding documentation support for conditional branch filter. > Reviewed-by: Stephane Eranian > Signed-off-by: Anshuman Khandual > --- > tools/perf/Documentation/perf-record.txt | 3 ++- > 1 file changed, 2 inserti

Re: [V6 00/11] perf: New conditional branch filter

2014-05-27 Thread Stephane Eranian
Hi, On Mon, May 5, 2014 at 11:09 AM, Anshuman Khandual wrote: > > This patchset is the re-spin of the original branch stack > sampling > patchset which introduced new PERF_SAMPLE_BRANCH_COND branch filter. This > patchset > also enables SW based branch filtering support for boo

Re: [V6 00/11] perf: New conditional branch filter

2014-06-02 Thread Stephane Eranian
On Wed, May 28, 2014 at 10:04 AM, Anshuman Khandual wrote: > On 05/27/2014 05:39 PM, Stephane Eranian wrote: >> I have been looking at those patches and ran some tests. >> And I found a few issues so far. >> >> I am running: >> $ perf record -j any_ret -e cycles:u

Re: [V6 00/11] perf: New conditional branch filter

2014-06-02 Thread Stephane Eranian
On Mon, Jun 2, 2014 at 6:04 PM, Anshuman Khandual wrote: > On 06/02/2014 06:29 PM, Stephane Eranian wrote: >> On Wed, May 28, 2014 at 10:04 AM, Anshuman Khandual >> wrote: >>> On 05/27/2014 05:39 PM, Stephane Eranian wrote: >>>> I have been looking at those pa

Re: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr

2015-11-05 Thread Stephane Eranian
.org/patch/539244/ > > Would appreciate comments and feedback. > > Signed-off-by: Madhavan Srinivasan > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Stephane Eranian > Cc: Russell King > Cc: Cat

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Stephane Eranian
On Tue, Oct 16, 2012 at 12:08 PM, Robert Richter wrote: > Sukadev, > > On 15.10.12 17:55:34, Robert Richter wrote: >> On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: >> > + { .type = PERF_TYPE_HARDWARE, .config = >> > PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, >> > + { .type = PERF_TYPE_HARDW

Re: perf: POWER-event translation questions

2012-11-09 Thread Stephane Eranian
Generic name > > cmpl-stall-fxu stalled-cycles-fixed-point > cmpl-stall-lsu stalled-cycles-load-store > cmpl-stall-ifu stalled-cycles-instruction-fetch > cmpl-stall-bru stalled-cycles-branch-unit > > But like Ste

Re: [PATCH] powerpc: perf: power_pmu_start restores incorrect values, breaking frequency events

2012-02-19 Thread Stephane Eranian
Glad to see you fixed the PPC problem. On Thu, Feb 16, 2012 at 5:57 AM, Paul Mackerras wrote: > On Thu, Feb 16, 2012 at 03:48:22PM +1100, Anton Blanchard wrote: >> >> perf on POWER stopped working after commit e050e3f0a71b (perf: Fix >> broken interrupt rate throttling). That patch exposed a bug

Re: perfmon2 needs hard_irq_disable() for powerpc

2007-11-26 Thread Stephane Eranian
Hello Sonny, On Mon, Nov 26, 2007 at 02:44:38AM -0500, Sonny Rao wrote: > Hi, I've been reading through the perfmon2 patch for 2.6.23 and it > dawned on me that in the powerpc architecture we have the notion of > lazy-disabling of interrupts where we don't actually disable > interrupts unless we s