Re: [PATCH] mm: rename and document alloc_pages_exact_node

2015-07-21 Thread Robin Holt
#x27;t allow the node id > to be -1. Unfortunately the name of the function can easily suggest that the > allocation is restricted to the given node. In truth, the node is only > preferred, unless __GFP_THISNODE is among the gfp flags. > ... >

Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-10-18 Thread Robin Holt
On Tue, Oct 18, 2011 at 12:44:07AM -0500, Kumar Gala wrote: > > On Aug 16, 2011, at 10:32 PM, Robin Holt wrote: > > > David, > > > > The following set of patches have been reviewed by the above parties and > > all comments have been integrated. Although the p

Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-10-18 Thread Robin Holt
ch arm based soc. The match string could be there and the devicetree binding would match on each equivalent. Robin > > fsl,ppc-flexcan & fsl,arm-flexcan. > > > On Mon, Aug 15, 2011 at 09:13:50AM -0600, Grant Likely wrote: > >> On Mon, Aug 15, 2011 at 9:03 AM, Robin H

Re: [PATCH 6/8] v2 Update node sysfs code

2010-09-28 Thread Robin Holt
This patch may work, but it appears it is lacking in, at least the link_mem_sections() function. Assuming you have a memory block covering 2GB and a section size of 128MB (some values we are toying with for large SGI machines), you end up calling register_mem_sect_under_node() 16 times which then

Re: [PATCH 2/8] v2 Add section count to memory_block struct

2010-09-28 Thread Robin Holt
In the next patch, you introduce a mutex for adding/removing memory blocks. Is there really a need for this to be atomic? If you reorder the patches so the mutex comes first, would the atomic be needed any longer? Robin On Mon, Sep 27, 2010 at 02:22:24PM -0500, Nathan Fontenot wrote: > Add a sec

Re: [PATCH 0/8] v2 De-Couple sysfs memory directories from memory sections

2010-09-28 Thread Robin Holt
I was tasked with looking at a slowdown in similar sized SGI machines booting x86_64. Jack Steiner had already looked into the memory_dev_init. I was looking at link_mem_sections(). I made a dramatic improvement on a 16TB machine in that function by merely caching the most recent memory section a

Re: [PATCH 4/8] v2 Allow memory block to span multiple memory sections

2010-09-28 Thread Robin Holt
> +u32 __weak memory_block_size_bytes(void) > +{ > + return MIN_MEMORY_BLOCK_SIZE; > +} > + > +static u32 get_memory_block_size(void) Can we make this an unsigned long? We are testing on a system whose smallest possible configuration is 4GB per socket with 512 sockets. We would like to be abl

Re: [PATCH 0/8] v2 De-Couple sysfs memory directories from memory sections

2010-09-28 Thread Robin Holt
On Tue, Sep 28, 2010 at 02:44:40PM +0200, Avi Kivity wrote: > On 09/27/2010 09:09 PM, Nathan Fontenot wrote: > >This set of patches decouples the concept that a single memory > >section corresponds to a single directory in > >/sys/devices/system/memory/. On systems > >with large amounts of memory

Re: [PATCH 0/8] v2 De-Couple sysfs memory directories from memory sections

2010-09-29 Thread Robin Holt
On Tue, Sep 28, 2010 at 01:17:33PM -0500, Nathan Fontenot wrote: > On 09/28/2010 07:38 AM, Robin Holt wrote: > > I was tasked with looking at a slowdown in similar sized SGI machines > > booting x86_64. Jack Steiner had already looked into the memory_dev_init. >

Re: [PATCH 0/8] v2 De-Couple sysfs memory directories from memory sections

2010-09-30 Thread Robin Holt
On Wed, Sep 29, 2010 at 02:28:30PM -0500, Robin Holt wrote: > On Tue, Sep 28, 2010 at 01:17:33PM -0500, Nathan Fontenot wrote: ... > My next task is to implement a x86_64 SGI UV specific chunk of code > to memory_block_size_bytes(). Would you consider adding that to your > patch set?

Re: [PATCH 2/9] v3 Add mutex for adding/removing memory blocks

2010-10-01 Thread Robin Holt
Nathan Fontenot Reviewed-by: Robin Holt I am fine with this patch by itself, but its only real function is to protect the count introduced by the next patch. You might want to combine the patches, but if not, that is fine as well. Robin ___ Linuxppc-d

Re: [PATCH 1/9] v3 Move find_memory_block routine

2010-10-01 Thread Robin Holt
On Fri, Oct 01, 2010 at 01:28:39PM -0500, Nathan Fontenot wrote: > Move the find_memory_block() routine up to avoid needing a forward > declaration in subsequent patches. > > Signed-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___

Re: [PATCH 3/9] v3 Add section count to memory_block struct

2010-10-01 Thread Robin Holt
has been > removed so we can remove the memory block. > > Signed-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/9] v3 rename phys_index properties of memory block struct

2010-10-01 Thread Robin Holt
igned-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 8/9] v3 Define memory_block_size_bytes for x86_64 with CONFIG_X86_UV set

2010-10-01 Thread Robin Holt
On Fri, Oct 01, 2010 at 01:37:05PM -0500, Nathan Fontenot wrote: > Define a version of memory_block_size_bytes for x86_64 when CONFIG_X86_UV is > set. > > Signed-off-by: Robin Holt > Signed-off-by: Jack Steiner I think this technically needs a Signed-off-by: since you are pass

Re: [PATCH 9/9] v3 Update memory hotplug documentation

2010-10-01 Thread Robin Holt
On Fri, Oct 01, 2010 at 01:37:49PM -0500, Nathan Fontenot wrote: > Update the memory hotplug documentation to reflect the new behaviors of > memory blocks reflected in sysfs. > > Signed-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___

Re: [PATCH 4/9] v3 Allow memory blocks to span multiple memory sections

2010-10-01 Thread Robin Holt
On Fri, Oct 01, 2010 at 01:31:51PM -0500, Nathan Fontenot wrote: > Update the memory sysfs code such that each sysfs memory directory is now > considered a memory block that can span multiple memory sections per > memory block. The default size of each memory block is SECTION_SIZE_BITS > to mainta

Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries

2010-10-01 Thread Robin Holt
On Fri, Oct 01, 2010 at 01:35:54PM -0500, Nathan Fontenot wrote: > Define a version of memory_block_size_bytes() for powerpc/pseries such that > a memory block spans an entire lmb. > > Signed-off-by: Nathan Fontenot Reviewed-by

Re: [PATCH 6/9] v3 Update node sysfs code

2010-10-01 Thread Robin Holt
dditional > parameter to unregister_mem_sect_under_nodes so that we know which memory > section of the memory block to unregister. > > Signed-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@l

Re: [PATCH 4/9] v3 Allow memory blocks to span multiple memory sections

2010-10-01 Thread Robin Holt
routine. > > Signed-off-by: Nathan Fontenot Reviewed-by: Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries

2010-10-03 Thread Robin Holt
On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote: > * Nathan Fontenot [2010-10-01 13:35:54]: > > > Define a version of memory_block_size_bytes() for powerpc/pseries such that > > a memory block spans an entire lmb. > > I hope I am not missing anything obvious, but why not just call i

Re: [PATCH 0/4] De-couple sysfs memory directories from memory sections

2011-01-10 Thread Robin Holt
> >> The root of this issue is in sysfs directory creation. Every time > >> a directory is created a string compare is done against all sibling > >> directories to ensure we do not create duplicates. The list of > >> directory nodes in sysfs is kept as an unsorted list which results > >> in this b

Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source.

2011-08-06 Thread Robin Holt
On Sat, Aug 06, 2011 at 11:52:45AM -0500, Kumar Gala wrote: > > On Aug 6, 2011, at 8:58 AM, Marc Kleine-Budde wrote: > > > On 08/06/2011 06:05 AM, Robin Holt wrote: > >> flexcan driver needs the clk_get, clk_get_rate, etc functions > >> to work. This patch p

[RFC 1/4] [flexcan] Remove #include

2011-08-08 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt To: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net...@vger.kernel.org

[RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-08 Thread Robin Holt
I added a clock source for the p1010rdb so the flexcan driver could find its clock frequency. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list --- Could I also get a

[RFC 0/4] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V7

2011-08-08 Thread Robin Holt
last patches are both applied, the tree will compile for either ppc or arm, but will not work without all patches. If the ppc patch (4/4) gets applied before 1/4, we could have a random config tester detect a compile failure on ppc if they select NET, CAN, and CAN_FLEXCAN. Thanks, Robin Holt

[RFC 3/4] [flexcan] Add of_match to platform_device definition.

2011-08-08 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt To: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c

[RFC 2/4] [flexcan] Abstract off read/write for big/little endian.

2011-08-08 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-08 Thread Robin Holt
Argh. I sent an earlier (non-working) version of this patch. Here is the correct one. I added a clock source for the p1010rdb so the flexcan driver could find its clock frequency. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 Cc: socketcan-c

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 09:11:33AM +0200, Wolfgang Grandegger wrote: > > + return &p1010_rdb_system_clock; > > Just returning fsl_get_sys_freq() here would already be fine. I'm also > missing the factor of two here: > > return fsl_get_sys_freq() / 2; I am working on the other comm

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 09:11:33AM +0200, Wolfgang Grandegger wrote: > On 08/09/2011 08:33 AM, Robin Holt wrote: > > Argh. I sent an earlier (non-working) version of this patch. Here is > > the correct one. > > Please always resend the complete series of patches with an

[Patch 0/4] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V8

2011-08-09 Thread Robin Holt
last patches are both applied, the tree will compile for either ppc or arm, but will not work without all patches. If the ppc patch (4/4) gets applied before 1/4, we could have a random config tester detect a compile failure on ppc if they select NET, CAN, and CAN_FLEXCAN. Thanks, Robin Holt

[PATCH 3/4] [flexcan] Add of_match to platform_device definition.

2011-08-09 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt To: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c

[PATCH 1/4] [flexcan] Remove #include

2011-08-09 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt To: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net...@vger.kernel.org

[PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock frequency. The p1010 can device only has an oscillator of system bus frequency divided by 2. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 Cc

[PATCH 2/4] [flexcan] Abstract off read/write for big/little endian.

2011-08-09 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde To: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 02:33:31PM +0200, Marc Kleine-Budde wrote: > On 08/09/2011 07:55 AM, Robin Holt wrote: > > I added a clock source for the p1010rdb so the flexcan driver > > could find its clock frequency. > > > > Signed-off-by: Robin Holt > > To: Mar

[Patch 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V9

2011-08-09 Thread Robin Holt
submission of patch 5. Thanks, Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/5] [flexcan] Remove #include

2011-08-09 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt To: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH 2/5] [flexcan] Abstract off read/write for big/little endian.

2011-08-09 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH 3/5] [flexcan] Add of_match to platform_device definition.

2011-08-09 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt To: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c

[PATCH 4/5] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock frequency. The p1010 can device only has an oscillator of system bus frequency divided by 2. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , To: U Bhaskar-B22300

[PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Robin Holt
the standard for node naming in that they have a trailing -v1.0. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: Kumar Gala --- .../devicetree/bindings/net/can/fsl

Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 02:45:58PM +, U Bhaskar-B22300 wrote: > Hi Robin, > Where are you doing the irq handling ie request_irq() for the powerpc > based P1010. > Or the existing code of ARM based FlexCAN will work for P1010 ?? It appears that the of_device stuff got moved under t

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 01:17:47PM -0500, Scott Wood wrote: > On 08/09/2011 09:43 AM, Robin Holt wrote: > > In working with the socketcan developers, we have come to the conclusion > > the fsl-flexcan device tree bindings need to be cleaned up. > > The driver does not depen

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Robin Holt
I guess my poor wording may have gotten me in trouble. I am getting ready to repost this patch, but I want to ensure I am getting it as right as possible. I think I should reword the commit message to indicate we are removing the Documentation/.../fsl-flexcan.txt file which has essentially become

[PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-09 Thread Robin Holt
believe they are all ready for forwarding to David S. Miller for the netdev tree. I think patch 4 is ready for submission to the PPC85xx maintainer. Patch 5 changed from the previous post by adding a second compatible string for the fsl,p1010_flexcan. Thanks, Robin Holt

[PATCH v10 1/5] [flexcan] Remove #include

2011-08-09 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt To: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v10 2/5] [flexcan] Abstract off read/write for big/little endian.

2011-08-09 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v10 3/5] [flexcan] Add of_match to platform_device definition.

2011-08-09 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt To: Marc Kleine-Budde Acked-by: Wolfgang Grandegger To: U Bhaskar-B22300 Cc: socketcan-c

[PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Robin Holt
I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock frequency. The p1010 can device only has an oscillator of system bus frequency divided by 2. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , To: U Bhaskar-B22300

[PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Robin Holt
*dts* files are not following the standard for node naming in that they have a trailing -v1.0. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 To: Scott Wood Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: Kumar

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
This leaves the most flexibility for segragating future specific revisions of the flexcan interface if needed. 6) I failed to Cc: you or the device tree list when I submitted version 10 of the patches. I have added both to the patch header so they will be included in the next pass.

Re: [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:01:58PM +0200, Marc Kleine-Budde wrote: > On 08/10/2011 05:05 AM, Robin Holt wrote: > > With all the patches applied, my p1010rdb works for communicating between > > its two can ports and also can communicate with an external PSOC. I have > > d

Re: [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:56:01AM +0200, Marc Kleine-Budde wrote: > On 08/10/2011 05:06 AM, Robin Holt wrote: > > diff --git a/arch/powerpc/platforms/85xx/clock.c > > b/arch/powerpc/platforms/85xx/clock.c > > new file mode 100644 > > index 000..16fae04 >

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > Hi Robin, > > On 08/10/2011 05:06 AM, Robin Holt wrote: > > In working with the socketcan developers, we have come to the conclusion > > the Documentation...fsl-flexcan.txt device tree documentation needs

Re: [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition.

2011-08-10 Thread Robin Holt
On Tue, Aug 09, 2011 at 10:06:02PM -0500, Robin Holt wrote: > On powerpc, the OpenFirmware devices are not matched without specifying > an of_match array. Introduce that array as that is used for matching > on the Freescale P1010 processor. > > Signed-off-by: Robin Holt > To:

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 09:45:17AM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 9:15 AM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > >> Hi Robin, > >> > >> On 08/10/2011 05:06 AM, Robin Holt

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > > > > -Original Message- > > From: Robin Holt [mailto:h...@sgi.com] > > Sent: Wednesday, August 10, 2011 7:46 PM > > To: Wolfgang Grandegger > > Cc: Robin Holt; Marc Kleine-Budde;

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 09:52:07AM -0500, Kumar Gala wrote: > > On Aug 9, 2011, at 3:59 PM, Robin Holt wrote: > > > I guess my poor wording may have gotten me in trouble. I am getting > > ready to repost this patch, but I want to ensure I am getting it as > > right as

[PATCH v11 0/5] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010)

2011-08-10 Thread Robin Holt
correct form. Thanks, Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v11 1/5] flexcan: Remove #include

2011-08-10 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v11 2/5] flexcan: Abstract off read/write for big/little endian.

2011-08-10 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v11 3/5] flexcan: Add of_match to platform_device definition.

2011-08-10 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
I added a simple clock source for the p1010rdb so the flexcan driver could determine a clock frequency. The p1010 flexcan device only has an oscillator of system bus frequency divided by 2. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , Cc: U Bhaskar

[PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
clock source can not be selected. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 To: Scott Wood To: Grant Likely To: Kumar Gala Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: devicetree-disc...@lists.ozlab

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:53:15AM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > >> > >> > >>> -Original Message- > >>> Fro

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > On 08/10/2011 11:27 AM, Robin Holt wrote: > > -CPI Clock- Can Protocol Interface Clock > > - This CLK_SRC bit of CTRL(control register) selects the clock source to > > - the CAN Protocol Interface(CPI) to be

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:17:45PM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 12:16 PM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 11:53:15AM -0500, Kumar Gala wrote: > >> > >> On Aug 10, 2011, at 11:00 AM, Robin Holt wrote: > >> > &g

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > On 08/10/2011 12:19 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > >> On 08/10/2011 11:27 AM, Robin Holt wrote: > >>> -CPI Clock- Can Protocol Interface Clock &g

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 01:27:52PM -0500, Scott Wood wrote: > On 08/10/2011 01:23 PM, Wolfgang Grandegger wrote: > > On 08/10/2011 06:00 PM, Robin Holt wrote: > >> On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: > > ... > >> It looks like the wa

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 01:40:30PM -0500, Scott Wood wrote: > On 08/10/2011 01:30 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > >> On 08/10/2011 12:19 PM, Robin Holt wrote: > >>> On Wed, Aug 10, 2011 at 11:56:28AM -0500, Sco

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 08:16:33PM +0200, Wolfgang Grandegger wrote: > On 08/10/2011 07:01 PM, Kumar Gala wrote: > > > > On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > > > >> I added a simple clock source for the p1010rdb so the flexcan driver > >>

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:46:27PM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 1:16 PM, Wolfgang Grandegger wrote: > > > On 08/10/2011 07:01 PM, Kumar Gala wrote: > >> > >> On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > >> > >>>

[PATCH] p1010rdb: gianfar config does not have queues.

2011-08-11 Thread Robin Holt
oblem resolved. Signed-off-by: Robin Holt To: U Bhaskar-B22300 Cc: PPC list Cc: Eric Dumazet diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi index 7f51104..91566aa 100644 --- a/arch/powerpc/boot/dts/p1010si.dtsi +++ b/arch/powerpc/boot/dts/p1010si

[PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010)

2011-08-11 Thread Robin Holt
really only reflect changes in the drivers/net/can tree. I, therefore, believe it is probably best to route them through David S. Miller's netdev tree. Wolfgang and Kumar, does that seem correct to you? Thanks, Robin Holt ___ Linuxppc-dev mailing

[PATCH v11 1/6] flexcan: Remove #include

2011-08-11 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v11 2/6] flexcan: Abstract off read/write for big/little endian.

2011-08-11 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-11 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B

[PATCH v11 4/6] flexcan: Add of_match to platform_device definition.

2011-08-11 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-11 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt To: Kumar Gala To: Wol

[PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Robin Holt
Allow the p1010 processor to select the flexcan network driver. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: Kumar Gala --- arch/powerpc/boot/dts

Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Robin Holt
On Thu, Aug 11, 2011 at 06:35:08PM +0200, Wolfgang Grandegger wrote: > On 08/11/2011 06:07 PM, Robin Holt wrote: > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt > > Acked-by: Marc Kleine-Budde , > > Acked-by

Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Robin Holt
On Thu, Aug 11, 2011 at 12:41:34PM -0500, Kumar Gala wrote: > > On Aug 11, 2011, at 11:07 AM, Robin Holt wrote: > > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt > > Acked-by: Marc Kleine-Budde , > >

Re: [PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-12 Thread Robin Holt
On Thu, Aug 11, 2011 at 10:53:43AM -0600, Grant Likely wrote: > On Thu, Aug 11, 2011 at 10:07 AM, Robin Holt wrote: > > +- compatible : Should be "fsl,-flexcan" and "fsl,flexcan" > > Don't do this. "fsl,flexcan" is far too generic. B

[PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010)

2011-08-12 Thread Robin Holt
really only reflect changes in the drivers/net/can tree. I, therefore, believe it is probably best to route them through David S. Miller's netdev tree. Wolfgang and Kumar, does that seem correct to you? Thanks, Robin Holt ___ Linuxppc-dev mailing

[PATCH v12 1/6] flexcan: Remove #include

2011-08-12 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v12 2/6] flexcan: Abstract off read/write for big/little endian.

2011-08-12 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-12 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bh

[PATCH v12 4/6] flexcan: Add of_match to platform_device definition.

2011-08-12 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-12 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt To: Kumar Gala To: Wol

[PATCH v12 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-12 Thread Robin Holt
Allow the p1010 processor to select the flexcan network driver. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger , Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: Kumar Gala --- arch/powerpc/Kconfig

Re: [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-15 Thread Robin Holt
believe we have agreement on all the other code changes in these patches. Is this change acceptable as is and if we get a better resolution on the fsl,flexcan name later, we can update the documentation and driver then? Thanks, Robin On Fri, Aug 12, 2011 at 03:45:49AM -0500, Robin Holt wrote

Re: [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-15 Thread Robin Holt
On Mon, Aug 15, 2011 at 09:13:50AM -0600, Grant Likely wrote: > On Mon, Aug 15, 2011 at 9:03 AM, Robin Holt wrote: > > Grant, > > > > Earlier, you had asked for a more specific name for the compatible > > property of the Freescale flexcan device.  I still have not

[PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-08-16 Thread Robin Holt
x27;s commit 6c37e46. Could you please queue these up for the next appropriate push to Linus' tree? Thanks, Robin Holt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v13 1/6] flexcan: Remove #include

2011-08-16 Thread Robin Holt
powerpc does not have a mach-/clock.h. When testing, I found neither arm nor powerpc needed the mach/clock.h at all so I removed it. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v13 2/6] flexcan: Abstract off read/write for big/little endian.

2011-08-16 Thread Robin Holt
Make flexcan driver handle register reads in the appropriate endianess. This was a basic search and replace and then define some inlines. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: socketcan-c...@lists.berlios.de Cc: net

[PATCH v13 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-16 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger ,

[PATCH v13 4/6] flexcan: Add of_match to platform_device definition.

2011-08-16 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v13 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-16 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt Acked-by: Wolfgang Grand

  1   2   >