Re: [PATCH v5 4/4] arm64: Kconfig: Enable HOTPLUG_SMT

2024-08-27 Thread Pierre Gondois
Hello Yicong, Is it necessary to have an explicit dependency over SMP for arm64 ? Cf. commit 4b3dc9679cf7 ("arm64: force CONFIG_SMP=y and remove redundant #ifdefs") Regards, Pierre On 8/6/24 10:53, Yicong Yang wrote: From: Yicong Yang Enable HOTPLUG_SMT for SMT control. Signed-off-by: Yic

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-08-27 Thread Pierre Gondois
Hello Yicong, IIUC we are looking for the maximum number of threads a CPU can have in the platform. But is is actually possible to have a platform with CPUs not having the same number of threads ? For instance kernel/cpu.c::cpu_smt_num_threads_valid() will check that the number of threads is eith

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-08-29 Thread Pierre Gondois
Hello Yicong, On 8/29/24 09:40, Yicong Yang wrote: Hi Pierre, On 2024/8/27 23:40, Pierre Gondois wrote: Hello Yicong, IIUC we are looking for the maximum number of threads a CPU can have in the platform. But is is actually possible to have a platform with CPUs not having the same number of

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-09-02 Thread Pierre Gondois
Hello Yicong On 8/30/24 11:35, Yicong Yang wrote: On 2024/8/29 20:46, Pierre Gondois wrote: Hello Yicong, On 8/29/24 09:40, Yicong Yang wrote: Hi Pierre, On 2024/8/27 23:40, Pierre Gondois wrote: Hello Yicong, IIUC we are looking for the maximum number of threads a CPU can have in the

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-09-05 Thread Pierre Gondois
Hello Yicong, Wondering if we can avoid this 2nd loop. Greg express the worries of looping twice on large scale system in v1. Maybe we could use the hetero_id and get the necessary information in one loop, I need further think. I found this comments (not sure this is what you are refering to

Re: [PATCH v6 2/4] arch_topology: Support SMT control for OF based system

2024-10-23 Thread Pierre Gondois
Hello Yicong, On 10/15/24 04:18, Yicong Yang wrote: From: Yicong Yang On building the topology from the devicetree, we've already gotten the SMT thread number of each core. Update the largest SMT thread number and enable the SMT control by the end of topology parsing. The core's SMT control p

Re: [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-11-07 Thread Pierre Gondois
On 10/31/24 13:17, Yicong Yang wrote: On 2024/10/30 22:55, Thomas Gleixner wrote: On Wed, Oct 30 2024 at 20:54, Yicong Yang wrote: +#ifndef topology_is_primary_thread +#define topology_is_primary_thread topology_is_primary_thread Please do not glue defines and functions together w/o a n

Re: [PATCH v7 3/4] arm64: topology: Support SMT control on ACPI based system

2024-11-07 Thread Pierre Gondois
On 10/30/24 13:54, Yicong Yang wrote: From: Yicong Yang For ACPI we'll build the topology from PPTT and we cannot directly get the SMT number of each core. Instead using a temporary xarray to record the heterogeneous information (from ACPI_PPTT_ACPI_IDENTICAL) and SMT information of the firs

Re: [PATCH v6 3/4] arm64: topology: Support SMT control on ACPI based system

2024-10-24 Thread Pierre Gondois
Hello Yicong, On 10/15/24 04:18, Yicong Yang wrote: From: Yicong Yang For ACPI we'll build the topology from PPTT and we cannot directly get the SMT number of each core. Instead using a temporary xarray to record the heterogeneous information (from ACPI_PPTT_ACPI_IDENTICAL) and SMT information

Re: [PATCH v9 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-11-15 Thread Pierre Gondois
Hello Yicong, On 11/14/24 15:11, Yicong Yang wrote: From: Yicong Yang Currently if architectures want to support HOTPLUG_SMT they need to provide a topology_is_primary_thread() telling the framework which thread in the SMT cannot offline. However arm64 doesn't have a restriction on which thre

Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-03-03 Thread Pierre Gondois
On 2/28/25 20:06, Sudeep Holla wrote: On Fri, Feb 28, 2025 at 06:51:16PM +0100, Pierre Gondois wrote: On 2/28/25 14:56, Sudeep Holla wrote: On Tue, Feb 18, 2025 at 10:10:17PM +0800, Yicong Yang wrote: From: Yicong Yang For ACPI we'll build the topology from PPTT and we cannot dir

Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-03-04 Thread Pierre Gondois
On 3/3/25 15:40, Yicong Yang wrote: On 2025/3/3 19:16, Sudeep Holla wrote: On Mon, Mar 03, 2025 at 10:56:12AM +0100, Pierre Gondois wrote: On 2/28/25 20:06, Sudeep Holla wrote: Ditto as previous patch, can get rid if it is default 1. On non-SMT platforms, not calling

Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-03-04 Thread Pierre Gondois
On 3/4/25 11:02, Sudeep Holla wrote: On Tue, Mar 04, 2025 at 09:25:02AM +0100, Pierre Gondois wrote: On 3/3/25 15:40, Yicong Yang wrote: On 2025/3/3 19:16, Sudeep Holla wrote: On Mon, Mar 03, 2025 at 10:56:12AM +0100, Pierre Gondois wrote: On 2/28/25 20:06, Sudeep Holla wrote: Ditto

Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-02-28 Thread Pierre Gondois
smt/active:0 smt/control:-1 If cpu_smt_set_num_threads() is called: active:0 control:notsupported So it might be slightly better to still initialize max_smt_thread_num. Otherwise I tested the patches on arm64 ACPI smt platforms and it worked well, so for all the patches (if there are no other major modifications): Reviewed-by: Pierre Gondois Regards, Pierre