build log
Currently, the O= build shows the absolute path to the script:
CALL/abs/path/to/source/of/linux/arch/powerpc/kernel/prom_init_check.sh
With this commit, it is always a relative path to the timestamp file:
PROMCHK arch/powerpc/kernel/prom_init_check
Signed-off-by: Masah
s always supported. Not only GNU ar but also llvm-ar supports it.
With the 'D' option hard-coded, there is no more user of ar-option
or KBUILD_ARFLAGS.
Signed-off-by: Masahiro Yamada
---
Documentation/kbuild/makefiles.rst | 5 -
Makefile | 4
arch/
The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the
'true' command.
Remove the meaningless code.
Signed-off-by: Masahiro Yamada
---
arch/mips/Makefile.postlink| 3 ---
arch/powerpc/Makefile.postlink | 3 ---
arch/riscv/Makefile.postlink
The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the
'true' command.
Remove the meaningless code.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nicolas Schier
---
(no changes since v1)
arch/mips/Makefile.postlink| 3 ---
arch/powerpc/Makefile.postlink
: *** [Makefile:1844: modules] Error 2
make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350:
__build_one_by_one] Error 2
make: *** [Makefile:234: __sub-make] Error 2
Signed-off-by: Masahiro Yamada
---
arch/powerpc/lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On Tue, Nov 21, 2023 at 6:55 PM Aneesh Kumar K.V
wrote:
>
> "Nicholas Piggin" writes:
>
> > On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote:
> >> crtsavres.o is linked to modules. However, as explained in commit
> >> d0e628cd817f ("kbu
Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
deprecated , which is now a wrapper of .
Replace #include with #include .
After all the lines are converted, and
will be removed.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/epapr_hcalls.S |
There is no EXPORT_SYMBOL line there, hence #include
is unneeded.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/entry_32.S | 1 -
arch/powerpc/kernel/head_40x.S | 1 -
arch/powerpc/kernel/head_44x.S | 1 -
arch/powerpc/kernel/head_64.S
All *.S files under arch/powerpc/ have been converted to include
instead of .
Remove .
Signed-off-by: Masahiro Yamada
---
arch/powerpc/include/asm/Kbuild | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 419319c4963c
rk.h | 2 +-
> arch/s390/include/asm/irq_work.h| 2 --
> arch/x86/include/asm/irq_work.h | 1 -
> include/linux/irq_work.h | 3 +++
> 8 files changed, 5 insertions(+), 10 deletions(-)
>
--
Best Regards
Masahiro Yamada
owerpc/configs/{guest.config => guest.fragment} (85%)
> delete mode 100644 arch/powerpc/configs/le.config
> create mode 100644 arch/powerpc/configs/le.fragment
> rename arch/powerpc/configs/{mpc85xx_base.config => mpc85xx_base.fragment}
> (94%)
> rename arch/powerpc/configs/{mpc86xx_base.config => mpc86xx_base.fragment}
> (86%)
> rename arch/powerpc/configs/{ppc64le.config => ppc64le.fragment} (65%)
> rename {kernel => arch/x86}/configs/x86_debug.config (90%)
> delete mode 100644 kernel/configs/tiny-base.config
> create mode 100644 kernel/configs/tiny-base.fragment
>
> --
> 2.34.1
>
--
Best Regards
Masahiro Yamada
Use single-quotes to avoid escape sequences (\\n).
Signed-off-by: Masahiro Yamada
---
Makefile | 8
arch/powerpc/Makefile | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 87a9eef3fb4b..d09600f7a036 100644
--- a/Makefile
On Tue, Aug 29, 2023 at 3:55 PM Nicolas Schier wrote:
>
> On Mon 28 Aug 2023 16:17:07 GMT, Michael Ellerman wrote:
> > Masahiro Yamada writes:
> > > On Sat, Aug 26, 2023 at 4:55 AM Kees Cook wrote:
> > >>
> > >> Hi,
> > >>
> > >
On Wed, Aug 30, 2023 at 10:00 AM Nicolas Schier wrote:
>
> On Tue 29 Aug 2023 20:35:31 GMT, Masahiro Yamada wrote:
> > Use single-quotes to avoid escape sequences (\\n).
> >
> > Signed-off-by: Masahiro Yamada
> > ---
>
> Is this really necessary? Testing w/
On Thu, Aug 31, 2023 at 9:03 AM Kees Cook wrote:
>
> On Tue, Aug 29, 2023 at 11:57:19PM +0900, Masahiro Yamada wrote:
> > The attached patch will work too.
> >
> > I dropped the "in the first line" restriction
> > because SPDX might be placed in the firs
.@vger.kernel.org
> Cc: linux-kbu...@vger.kernel.org
> Cc: linux-harden...@vger.kernel.org
> Signed-off-by: Kees Cook
> Co-developed-by: Masahiro Yamada
> ---
> v3:
> - Use Makefile logic from Masahiro Yamada
> - Use "# Help: " prefix, but only on desired f
On Sat, Sep 2, 2023 at 4:50 AM Kees Cook wrote:
>
> On Fri, Sep 01, 2023 at 04:58:37PM +0900, Masahiro Yamada wrote:
> > On Fri, Sep 1, 2023 at 4:13 AM Kees Cook wrote:
> > >
> > > Currently the Kconfig fragments in kernel/configs and arch/*/configs
> >
; in head_booke.h, so it is possible for THREAD_SHIFT to be undefined. Add
> the include to ensure that THREAD_SHIFT is always defined.
>
> Reported-by: kernel test robot
> Link: https://lore.kernel.org/202304050954.yskldczh-...@intel.com/
> Signed-off-by: Nathan Chancellor
> -
On Thu, Jan 19, 2023 at 9:37 PM Masahiro Yamada wrote:
>
> On Thu, Jan 19, 2023 at 9:12 PM Joel Stanley wrote:
> >
> > On Thu, 19 Jan 2023 at 08:24, Masahiro Yamada wrote:
> > >
> > > Commit e4412739472b ("Documentation: raise minimum supported version
On Mon, Jun 26, 2023 at 10:58 AM Nicholas Piggin wrote:
>
> On Sun Jun 25, 2023 at 6:02 PM AEST, Masahiro Yamada wrote:
> > On Thu, Jan 19, 2023 at 9:37 PM Masahiro Yamada
> > wrote:
> > >
> > > On Thu, Jan 19, 2023 at 9:12 PM Joel Stanley wrote:
> >
On Sat, Aug 20, 2022 at 7:02 PM Christophe Leroy
wrote:
>
> Hi,
>
> Le 13/05/2022 à 13:39, Masahiro Yamada a écrit :
> > include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
> > as a placeholder.
> >
> > Genksyms writes the version CRCs i
not giving Fixes tag because I do not know since when it has been
broken, but presumably it has been for a long while.
Link:
https://lore.kernel.org/lkml/38605f6a-a568-f884-f06f-ea4da5b21...@csgroup.eu/
Reported-by: Christophe Leroy
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/systbl.S
On Sat, Aug 20, 2022 at 11:15 PM Christophe Leroy
wrote:
>
>
>
> Le 20/08/2022 à 14:51, Masahiro Yamada a écrit :
> > On Sat, Aug 20, 2022 at 7:02 PM Christophe Leroy
> > wrote:
> >>
> >> Hi,
> >>
> >> Le 13/05/2022 à 13:39, Masahiro
On Thu, Aug 25, 2022 at 4:53 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
> > Christophe Leroy reported that commit 7b4537199a4a ("kbuild: link
> > symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS") broke
> > mpc85xx_defconfig + CO
gt;= 2.25 is already required, another version test
for --save-restore-funcs on PPC64 is always met.
PPC is the last user of ld-ifversion. With all the callers removed,
the macro definition in scripts/Makefile.compiler can go away.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefil
On Sun, Aug 28, 2022 at 2:37 AM Christophe Leroy
wrote:
>
>
>
> Le 27/08/2022 à 18:40, Masahiro Yamada a écrit :
> > The checkbin in arch/powerpc/Makefile errors out if ld <= 2.24.
> > So, the requirement on PPC is binutils >= 2.25. It is cleaner to
> > speci
On Tue, Aug 30, 2022 at 7:44 PM Michael Ellerman wrote:
>
> Christophe Leroy writes:
> > Le 27/08/2022 à 20:03, Masahiro Yamada a écrit :
> >> On Sun, Aug 28, 2022 at 2:37 AM Christophe Leroy
> >> wrote:
> >>> Le 27/08/2022 à 18:40, Masahiro Yamada a é
Binutils 2.23 was released in 2012. Almost 10 years old.
We already require GCC 5.1, which was released in 2015.
Bump the binutils version to 2.25.1, which was also released in 2015.
Suggested-by: Nick Desaulniers
Signed-off-by: Masahiro Yamada
---
Documentation/process/changes.rst | 4
The minimum supported version of binutils has been raised to 2.25.1.
Drop the old code.
PPC is the last user of ld-ifversion. With all the callers removed,
the macro definition in scripts/Makefile.compiler can go away.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 21
XT
> + string
> + depends on RUST
> + default $(shell,command -v $(RUSTC) >/dev/null 2>&1 && $(RUSTC)
> --version || echo n)
> +
> +config BINDGEN_VERSION_TEXT
> + string
> + depends on RUST
> + default $(shell,command -v $(BINDGEN) >/dev/null 2>&1 && $(BINDGEN)
> --version || echo n)
> +
Where are these config options used?
I grep'ed but no hit.
masahiro@zoe:~/ref/linux-next$ git grep RUSTC_VERSION_TEXT
init/Kconfig:config RUSTC_VERSION_TEXT
masahiro@zoe:~/ref/linux-next$ git grep BINDGEN_VERSION_TEXT
init/Kconfig:config BINDGEN_VERSION_TEXT
> --
> 2.37.1
>
--
Best Regards
Masahiro Yamada
y considered to be a potential userspace break
> because kmod tools inspect this kernel module metadata. Masahiro Yamada
> suggested [2] that this could instead be done with a section per-field.
> This gives us the ability to be more flexible with this format in the
> future, as a new fi
Would setting up Rust symbols so that they have a crc built out of .rmeta be
> > sufficient for you to consider this useful? If not, can you help me
> > understand
> > what level of precision would be required?
>
> What exactly does .rmeta have to do with the function signature? That's
> all you care about here.
rmeta is generated per crate.
CRC is computed per symbol.
They have different granularity.
It is weird to refuse a module for incompatibility
of a symbol that it is not using at all.
> thanks,
>
> greg k-h
--
Best Regards
Masahiro Yamada
bH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> https://www.tq-group.com/
>
--
Best Regards
Masahiro Yamada
On Wed, Dec 13, 2023 at 8:22 PM Matthias Schiffer
wrote:
>
> On Tue, 2023-12-12 at 17:13 +, Masahiro Yamada wrote:
> >
> >
> > On Wed, Dec 13, 2023 at 1:17 AM Matthias Schiffer
> > wrote:
> > >
> > > This reverts commit dd7699e37f289fa433f42c6
On Mon, Feb 5, 2024 at 10:22 PM Jan Stancek wrote:
>
> On Mon, Feb 5, 2024 at 12:50 PM Michael Ellerman wrote:
> >
> > Jan Stancek writes:
> > > On Tue, Nov 21, 2023 at 10:51:34AM +1000, Nicholas Piggin wrote:
> > >>On Tue Nov 21, 2023 at 9:23 AM AEST, Mas
them with:
GCOV_PROFILE_interrupt.o := n
KCOV_INSTRUMENT_interrupt.o := n
UBSAN_SANITIZE_interrupt.o := n
However, nobody has noticed the functional change in the past three
years, so they were unneeded.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/Makefile | 3 ---
1 file changed, 3 deletion
Commit 2fb857bc9f9e ("powerpc/kcsan: Add exclusions from instrumentation")
added KCSAN_SANITIZE_early_64.o to arch/powerpc/kernel/Makefile, while
it does not compile early_64.o.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/Makefile | 1 -
1 file changed, 1 deletion(-)
di
+To: Daniel Axtens
Maybe, we should check if the issue fixed by
2f26ed1764b42a8c40d9c48441c73a70d805decf
came back.
On Fri, Feb 16, 2024 at 10:55 PM Masahiro Yamada wrote:
>
> Commit ab1a517d55b0 ("powerpc/syscall: Rename syscall_64.c into
> interrupt.c") missed to
On Thu, Jan 19, 2023 at 9:12 PM Joel Stanley wrote:
>
> On Thu, 19 Jan 2023 at 08:24, Masahiro Yamada wrote:
> >
> > Commit e4412739472b ("Documentation: raise minimum supported version of
> > binutils to 2.25") allows us to remove the checks for old binutils.
lter %.lds,$^) $(filter %.o,$^);
> > > $(cmd_vdso_check)
> >
> > If no CC64FLAGS := xxx is set, this can go?
>
> Good catch! CC64FLAGS can be removed. Masahiro, I am happy to send a v3
> when I am back online next week but if you are able to fix it up during
> application, please feel free to do so (once the PowerPC folks give
> their Acks of course).
I removed CC64FLAGS locally.
Just two comments.
- Is 7f3d349065d0c643f7f7013fbf9bc9f2c90b675f
applicable to powerpc too?
Maybe, as a follow-up cleanup, use $(LD)
and remove -Wl, prefixes.
- ldflags-y still pulls $(KBUILD_CFLAGS).
Potentially, a new flag addition to KBUILD_CFLAGS
may trigger a new -Wunused-command-line-argument warning.
I hope somebody takes a closer look at which flags
are really needed for the linker.
> > > quiet_cmd_vdso64as = VDSO64A $@
> > >cmd_vdso64as = $(VDSOCC) $(a_flags) $(CC64FLAGS) $(AS64FLAGS) -c
> > > -o $@ $<
> > >
> > >
> > > --
> > > 2.39.0
> > >
>
> Thanks for the review, cheers!
> Nathan
--
Best Regards
Masahiro Yamada
h/s390/kernel/vdso64/Makefile| 4 +--
> arch/s390/purgatory/Makefile| 2 +-
> arch/x86/boot/compressed/Makefile | 2 +-
> drivers/gpu/drm/amd/display/dc/dml/Makefile | 3 ++-
> scripts/Kconfig.include | 2 +-
> scripts/Makefile.clang | 2 ++
> scripts/Makefile.compiler | 8 +++---
> scripts/as-version.sh | 2 +-
> 21 files changed, 74 insertions(+), 98 deletions(-)
> ---
> base-commit: 88603b6dc419445847923fcb7fe5080067a30f98
> change-id: 20221228-drop-qunused-arguments-0c5c7dae54fb
>
> Best regards,
> --
> Nathan Chancellor
>
--
Best Regards
Masahiro Yamada
t; >
> > $ clang --target=powerpc64-linux-gnu -fno-integrated-as -m64 -### \
> > -x assembler-with-cpp -c -o /dev/null /dev/null &| grep gnu-as
> >"/usr/bin/powerpc64-linux-gnu-as" "-a32" "-mppc" "-many" "-o"
> > "/dev/null" "/tmp/null-ab8f8d.s"
> >
> > Remove this flag altogether to avoid future issues.
> >
> > Fixes: 1421dc6d4829 ("powerpc/kbuild: Use flags variables rather than
> > overriding LD/CC/AS")
> > Signed-off-by: Nathan Chancellor
> > Reviewed-by: Nick Desaulniers
> > ---
> > Cc: m...@ellerman.id.au
>
> Acked-by: Michael Ellerman (powerpc)
>
> cheers
--
Best Regards
Masahiro Yamada
On Thu, Jan 26, 2023 at 11:07 AM Nathan Chancellor wrote:
>
> On Thu, Jan 26, 2023 at 10:29:54AM +0900, Masahiro Yamada wrote:
> > On Wed, Jan 25, 2023 at 1:11 PM Michael Ellerman
> > wrote:
> > >
> > > Nathan Chancellor writes:
> > > >
7;-Qunused-arguments' with clang")
Link:
https://github.com/llvm/llvm-project/commit/ca6d5813d17598cd180995fb3bdfca00f364475f
Signed-off-by: Nathan Chancellor
Signed-off-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
; | sed -n -e '/^$/!p' |
# Remove the dot prefix for ppc64; symbol names with a dot (.) hold entry
# point addresses.
-sed -e 's/^\.//' |
+sed -e 's/^\.//g' |
sort -u |
# Ignore __this_module. It's not an exported symbol, and will be resolved
# when the final .ko's are linked.
--
Best Regards
Masahiro Yamada
o in this direction in the former discussion.
I am not sure how much effort is needed to track down the issue
in this version.
If we add new sections to keep the backward compatibility
for the current "__versions", this issue may not exist.
> In general I think it'd be more reliable to add a dummy NULL entry at
> the end of the modversion array.
>
> Moreover, I think we also need to enforce struct modversion_info to be
> __packed, just to make sure that no extra padding is added (otherwise it
> may break our logic to determine the offset of the next entry).
>
> > @@ -2062,16 +2066,25 @@ static void add_versions(struct buffer *b, struct
> > module *mod)
> > s->name, mod->name);
> > continue;
> > }
> > - if (strlen(s->name) >= MODULE_NAME_LEN) {
> > - error("too long symbol \"%s\" [%s.ko]\n",
> > - s->name, mod->name);
> > - break;
> > - }
> > - buf_printf(b, "\t{ %#8x, \"%s\" },\n",
> > -s->crc, s->name);
> > + name_len = strlen(s->name);
> > + name_len_padded = (name_len + 1 + 3) & ~3;
> > +
> > + /* Offset to next entry */
> > + tmp = TO_NATIVE(8 + name_len_padded);
>
> ^ Here's another issue that I found, you can't use TO_NATIVE() in this
> way, some compilers are complaining (like on s390x this doesn't build).
>
> So we need to do something like:
>
> /* Offset to next entry */
> tmp = 8 + name_len_padded
> tmp = TO_NATIVE(tmp);
>
> I'll do some additional tests with these changes and send an updated
> patch (for those that are interested).
>
> -Andrea
--
Best Regards
Masahiro Yamada
NEL_IBT))
>
> +ifneq ($(objtool-args-y),)
> cmd_objtool = $(if $(objtool-enabled), ; $(objtool) $(objtool-args) $@)
> +endif
> +
> cmd_gen_objtooldep = $(if $(objtool-enabled), { echo ; echo '$@: $$(wildcard
> $(objtool))' ; } >> $(dot-target).cmd)
>
> endif # CONFIG_OBJTOOL
> --
> 2.34.1
>
--
Best Regards
Masahiro Yamada
_entry *fcur)
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index c65bb0fbd136..8fff27b9bdcb 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -290,6 +290,13 @@ ifneq ($(objtool-args-y),)
> cmd_objtool = $(if $(objtool-enabled), ; $(objtool) $(objtool-args) $@)
> endif
>
> +cmd_objtool_vmlinux :=
> +ifeq ($(CONFIG_HAVE_OBJTOOL_FTR_FIXUP),y)
> +cmd_objtool_vmlinux = $(if $(objtool-enabled), ; $(objtool) $(objtool-args)
> $@)
> +vmlinux:
> +$(cmd_objtool_vmlinux)
This is complete garbage.
At first, I thought it was a build rule for vmlinux,
but it is not because $(cmd_objtool_vmlinux) is indented
by 4 spaces, not a tab.
Of course, you cannot add a vmlinux build rule here.
If it had been a tab instead of 4 spaces,
Make would have shown a warning.
> +endif
> +
> cmd_gen_objtooldep = $(if $(objtool-enabled), { echo ; echo '$@: $$(wildcard
> $(objtool))' ; } >> $(dot-target).cmd)
>
> endif # CONFIG_OBJTOOL
--
Best Regards
Masahiro Yamada
On Tue, Apr 23, 2024 at 1:19 AM Sathvika Vasireddy
wrote:
>
> Hi Masahiro, thanks for reviewing.
>
> On 4/22/24 5:39 PM, Masahiro Yamada wrote:
>
> On Mon, Apr 22, 2024 at 6:25 PM Sathvika Vasireddy wrote:
>
> Currently, when objtool is enabled and none of the supported
s/module.lds is fine because 'make clean' keeps all the build
artifacts under scripts/.
You can add arch-specific sections in .
Signed-off-by: Masahiro Yamada
Tested-by: Jessica Yu
---
Makefile | 1 -
arch/arm/Makefile
On Tue, Sep 1, 2020 at 3:23 AM Masahiro Yamada wrote:
>
> The vdso linker script is preprocessed on demand.
> Adding it to 'targets' is enough to include the .cmd file.
>
> Signed-off-by: Masahiro Yamada
> ---
Applied to linux-kbuild.
> arch/arm64/kernel/v
pts/module.lds.S.
scripts/module.lds is fine because 'make clean' keeps all the
build artifacts under scripts/.
You can add arch-specific sections in .
Signed-off-by: Masahiro Yamada
Tested-by: Jessica Yu
Acked-by: Will Deacon
---
Changes in v2:
- Fix the race between the
perhaps "depends on DRM_OFDRM = n"
I do not know the intention of this dependency.
Recommendation is to use "depends on" instead of "select" though.
BTW, this is similar to what you asked before.
https://lore.kernel.org/linux-kbuild/e1a6228d-1341-6264-d97a-e2bd52a65...@infradead.org/
I tried to fix it in the past, but the issue was not as shallow as I
had expected.
I did not get around to revisiting this topic.
https://patchwork.kernel.org/project/linux-kbuild/patch/1543216969-2227-1-git-send-email-yamada.masah...@socionext.com/
--
Best Regards
Masahiro Yamada
On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh wrote:
>
> utsrelease.h is potentially generated on each build.
> By removing this unused include we can get rid of some spurious
> recompilations.
>
> Signed-off-by: Thomas Weißschuh
> ---
Reviewed-by: Masahiro Yama
nclude
> ")
> Signed-off-by: Thomas Weißschuh
> ---
Assuming you will fix the commit description,
Reviewed-by: Masahiro Yamada
> arch/powerpc/mm/nohash/kaslr_booke.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c
On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh wrote:
>
> Commit 2df8220cc511 ("kbuild: build init/built-in.a just once") moved
> the usage of the define UTS_VERSION to the file version-timestamp.c.
With s/UTS_VERSION/UTS_RELEASE/,
Reviewed-by: Masahiro Yamada
>
&g
um fw_opt - options to control firmware loading behaviour
> > *
> >
> > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
>
Applied to linux-kbuild.
Thanks.
--
Best Regards
Masahiro Yamada
On Sun, Nov 27, 2022 at 7:18 AM Masahiro Yamada wrote:
>
> On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh wrote:
> >
> > Commit 2df8220cc511 ("kbuild: build init/built-in.a just once") moved
> > the usage of the define UTS_VERSION to the file version-t
_VERSION.
> >
> > Could the maintainers fix this up when applying?
> > I also changed it locally so it will be fixed for v2.
>
> I'll take this patch, but not the others.
>
> cheers
Okay, I applied 1/3 and 3/3 to the kbuild tree.
--
Best Regards
Masahiro Yamada
Some scripts increase the verbose level when V=1, but others when
not V=0.
I think the former is correct because V=2 is not a log level but
a switch to print the reason for rebuilding.
Signed-off-by: Masahiro Yamada
---
Documentation/Makefile | 2 +-
arch/powerpc/kernel
symbol names.
section __version_crc:
0x12345678
0x23456789
0x34567890
section __version_sym:
"very_very_very_very_long_symbol"
"another_very_very_very_very_very_long_symbol"
"yet_another_very_very_very_very_very_long_symbol"
You can iterate in each section with this:
crc += sizeof(u32);
name += strlen(name) + 1;
Benefits:
- No next pointer
- No padding
- *.mod.c is kept human readable.
BTW, the following is impossible
because the pointer reference to .rodata
is not available at this point?
struct modversion_info {
u32 crc;
const char *name:
};
--
Best Regards
Masahiro Yamada
Commit e4412739472b ("Documentation: raise minimum supported version of
binutils to 2.25") allows us to remove the checks for old binutils.
There is no more user for ld-ifversion. Remove it as well.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 22 +-
ip]
LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko
ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or
directory
make[1]: *** [scripts/Makefile.modfinal:61:
arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1
make: *** [Makefile:1924: modules] Error 2
Signed-off
On Thu, Jan 28, 2021 at 9:52 AM Masahiro Yamada wrote:
>
> These are NOT exported to userspace.
>
> The headers listed in arch/sparc/include/uapi/asm/Kbuild are exported.
>
> Signed-off-by: Masahiro Yamada
Applied to linux-kbuild/fixes.
> ---
>
> arch/sparc/inc
must be relative to the current Makefile.
Fix all of them so the if_changed rules work correctly.
Signed-off-by: Masahiro Yamada
Acked-by: Geert Uytterhoeven
---
arch/alpha/kernel/syscalls/Makefile | 11 +-
arch/ia64/kernel/syscalls/Makefile | 11 +-
arch/
The 'syscall' variables are not directly used in the commands.
Remove the $(srctree)/ prefix because we can rely on VPATH.
Signed-off-by: Masahiro Yamada
---
arch/alpha/kernel/syscalls/Makefile | 2 +-
arch/arm/tools/Makefile | 2 +-
arch/ia64/kernel/syscall
On Thu, Jan 28, 2021 at 9:51 AM Masahiro Yamada wrote:
>
>
> As of v5.11-rc1, 12 architectures duplicate similar shell scripts:
>
> $ find arch -name syscalltbl.sh | sort
> arch/alpha/kernel/syscalls/syscalltbl.sh
> arch/arm/tools/syscalltbl.sh
> arch/ia64/kerne
On Mon, Feb 15, 2021 at 9:50 AM Masahiro Yamada wrote:
>
> The rules in these Makefiles cannot detect the command line change
> because the prerequisite 'FORCE' is missing.
>
> Adding 'FORCE' will result in the headers being rebuilt every time
> because the &
> >>>
> >>> I have found the bad commit. It's "Merge tag 'kbuild-v5.12' of
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild" [1]
> >>>
> >>> The changes in the Makefile (a/Makefile) are responsible for the
> >>> compiling errors. [2]
> >>>
> >>> I was able to revert this bad commit. After that it compiled without any
> >>> problems.
> >>>
> >>> Could you please compile the latest Git kernel and confirm this issue?
> >>>
> >>> Thanks,
> >>> Christian
> >>>
> >>> [1]
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6fbd6cf85a3be127454a1ad58525a3adcf8612ab
> >>>
> >>> [2]
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/Makefile?id=6fbd6cf85a3be127454a1ad58525a3adcf8612ab
> >>>
--
Best Regards
Masahiro Yamada
Many architectures duplicate similar shell scripts.
This commit converts powerpc to use scripts/syscallhdr.sh.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/syscalls/Makefile | 11 +++
arch/powerpc/kernel/syscalls/syscallhdr.sh | 36 --
2 files changed, 4
Many architectures duplicate similar shell scripts.
This commit converts powerpc to use scripts/syscalltbl.sh. This also
unifies syscall_table_32.h and syscall_table_c32.h.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/include/asm/Kbuild | 1 -
arch/powerpc/kernel/syscalls
# install path that should be copied to the correct location
Perhaps, we can remove this if the ppc maintainers approve it ?
> + path=$4
> + shift 4
> + while [ $# -ne 0 ]; do
> + image_name=$(basename "$1")
> + install "$1" "$path"/"$image_name"
> + shift
> + done;
> + sync
> + ;;
> x86)
> if [ -x /sbin/lilo ]; then
> /sbin/lilo
> --
> 2.31.1
>
--
Best Regards
Masahiro Yamada
According to Documentation/process/changes.rst, the minimum supported
GCC version is 4.9.
This workaround is dead code.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 6 --
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index
Christoph Hellwig
> Tested-by: Heiko Stuebner
> Cc: Palmer Dabbelt
> ---
Please use "arch:" or something for the commit subject.
I want to see "kconfig:" for
changes under scripts/kconfig/.
--
Best Regards
Masahiro Yamada
I think this hack is a bad idea. arch/powerpc/boot/Makefile is the
only user. Let's stop doing this.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/boot/Makefile | 4 ++--
scripts/Makefile.clean | 8 +---
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc
ilar rules
- Remove redundant 'clean-files' (Having 'targets' is enough)
- Move the flavour into the build command
This still avoids the build failures fixed by commit 4ee812f6143d
("crypto: vmx - Avoid weird build failures").
Signed-off-by: Masahiro Yamada
On Sun, May 1, 2022 at 8:57 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
> > I think this hack is a bad idea. arch/powerpc/boot/Makefile is the
> > only user. Let's stop doing this.
> >
> > Signed-off-by: Masahiro Yamada
> > ---
> >
>
ols is boolean (EXPORT_SYMBOL or EXPORT_SYMBOL_GPL).
I renamed the field name to is_gpl_only. If it is true, only GPL-compat
modules can use it.
Signed-off-by: Masahiro Yamada
---
Changes in v3:
- New patch
scripts/mod/modpost.c | 108 +-
1 file change
add_intree_flag(), add_retpoline(), and add_staging_flag() are small
enough to be merged into add_header().
Signed-off-by: Masahiro Yamada
---
Changes in v3:
- New patch
scripts/mod/modpost.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a
assed, it is
equivalent to find_module().
Please note there are still false positives in the composite module,
like below (or when both are built-in). I have no idea how to do this
correctly.
[Sample 2] (not fixed by this commit)
Makefile:
obj-m += mymod.o
mymod-objs := mymod1.o mymod2.
- Refactor the code more
- Avoid too long argument error
Masahiro Yamada (15):
modpost: mitigate false-negatives for static EXPORT_SYMBOL checks
modpost: change the license of EXPORT_SYMBOL to bool type
modpost: merge add_{intree_flag,retpoline,staging_flag} to add_header
modpost: move
A *.mod file lists the member objects of a module, but vmlinux does
not have such a file to list out all the member objects.
Generate this list to allow modpost to know all the member objects.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nicolas Schier
---
(no changes since v2)
Changes in v2
A later commit will add more code to this list_for_each_entry loop.
Before that, move the loop body into a separate helper function.
Signed-off-by: Masahiro Yamada
---
Changes in v3:
- New patch
scripts/mod/modpost.c | 56 ---
1 file changed, 31
.
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- Move to the end of the series because this is now optional
scripts/mod/file2alias.c | 2 --
scripts/mod/list.h | 52
scripts/mod/modpost.c| 39
longer use the linker magic. The new C implementation
works in the same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro
(ELF)|
foo2.c ---> foo2.o ---/ |
(LLVM bitcode) foo.mod.o --/
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- replace the chain of $(if ...) with $(and )
scripts/Kbuild.include| 4 +++
scripts/Makefile.build| 58 -
hnson reported before [1].
[1]
https://lore.kernel.org/linux-kbuild/4c02050c4e95e4cb8cc04282695f8...@codeaurora.org/
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- New patch
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
Now modpost reads symbol versions from .*.cmd files.
These merged *.symversions are not used any more.
Signed-off-by: Masahiro Yamada
---
(no changes since v1)
scripts/Makefile.build | 21 ++---
scripts/link-vmlinux.sh | 15 ---
2 files changed, 2 insertions
->is_static is set to true at allocation, then to false if the symbol
comes from the dump file.
It is simpler to use !mod->from_dump as the init value.
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- New patch
scripts/mod/modpost.c | 4 ++--
1 file chan
es instead of
from ELF objects.
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- Simplify the implementation (parse .cmd files after ELF)
scripts/mod/modpost.c | 177 ++
1 file changed, 129 insertions(+), 48 deletions(-)
diff
-by: Masahiro Yamada
Tested-by: Nicolas Schier
Reviewed-by: Nicolas Schier
---
(no changes since v2)
Changes in v2:
- Fix CONFIG_MODULE_REL_CRCS=y case
scripts/Makefile.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index
t status'.
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- New patch
scripts/Makefile.build | 6 --
scripts/genksyms/genksyms.c | 3 +--
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index dff
mpare drivers/gpu/drm/i915/.built-in.a.cmd with/without this commit.
Signed-off-by: Masahiro Yamada
---
(no changes since v2)
Changes in v2:
- New patch
scripts/Makefile.build | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.
On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote:
>
> Currently, enum export is tristate, but export_unknown does not make
> sense in any way.
>
> If the symbol name starts with "__ksymtab_", but the section name
> does not start with "___ksymtab+"
On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote:
>
>
> This is the third batch of cleanups in this development cycle.
This series is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
lto-cleanup-v3
--
Best Regards
Masahiro Yamada
ilar rules
- Remove redundant 'clean-files' (Having 'targets' is enough)
- Move the flavour into the build command
This still avoids the build failures fixed by commit 4ee812f6143d
("crypto: vmx - Avoid weird build failures").
Signed-off-by: Masa
Hi Herbert,
On Fri, May 6, 2022 at 7:23 PM Herbert Xu wrote:
>
> On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> > I notieced the log is not properly aligned:
> >
> > PERL drivers/crypto/vmx/aesp8-ppc.S
> > CC [M] fs/xfs/xfs_reflink.o
When I refactored this Makefile, I accidentally changed the CONFIG
option.
Fixes: b52455a73db9 ("crypto: vmx - Align the short log with Makefile cleanups")
Reported-by: kernel test robot
Signed-off-by: Masahiro Yamada
---
drivers/crypto/vmx/Makefile | 2 +-
1 file changed, 1 inser
On Sat, May 7, 2022 at 11:02 AM Herbert Xu wrote:
>
> On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
> >
> > Sorry, I just noticed the 0day bot had reported the error.
> >
> > I sent v2.(CONFIG_LITTLE_ENDIAN --> CONFIG_CPU_LITTLE_ENDIAN)
>
On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote:
>
>
> This is the third batch of cleanups in this development cycle.
>
> Major changes in v3:
>
> - Generate symbol CRCs as C code, and remove CONFIG_MODULE_REL_CRCS.
>
> Major changes in v2:
>
> - V1 did not
201 - 300 of 479 matches
Mail list logo
