Re: [PATCH 3/9] powerpc: remove CONFIG_PCI_QSPAN

2018-10-31 Thread Masahiro Yamada
gt; - Say Y here if you have a system based on a Motorola 8xx-series > - embedded processor with a QSPAN PCI interface, otherwise say N. > - > config PCI_8260 > bool > depends on PCI && 8260 > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 4/9] powerpc: remove CONFIG_MCA leftovers

2018-10-31 Thread Masahiro Yamada
amp; SCSI > + depends on EISA && SCSI > select SCSI_SPI_ATTRS > ---help--- > This driver is for NCR53c710 based SCSI host adapters. > > - It currently supports Compaq EISA cards and NCR MCA cards > + It currently supports Compaq EISA cards. > > config SCSI_DC395x > tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support" > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI

2018-10-31 Thread Masahiro Yamada
lp > > @@ -219,6 +221,7 @@ config AKEBONO > > select SWIOTLB > > select 476FPE > > select PPC4xx_PCI_EXPRESS > > + select PCI > > select PCI_MSI > > select PPC4xx_HSTA_MSI > > select I2C > > -- > > 2.19.1 > > -- Best Regards Masahiro Yamada

Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci

2018-10-31 Thread Masahiro Yamada
Hi Christoph, On Fri, Oct 19, 2018 at 9:58 PM Masahiro Yamada wrote: > > On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux > wrote: > > > > index a68b34183107..b185794549be 100644 > > > --- a/arch/arm/mach-pxa/Kconfig > > > +++ b/arch/arm/

Re: [PATCH 1/2] Makefile: Export clang toolchain variables

2018-11-04 Thread Masahiro Yamada
u take a look at my patch, please? https://patchwork.kernel.org/patch/10667369/ By using it as a prerequisite, your patch set will be more simplified. -- Best Regards Masahiro Yamada

[PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-05 Thread Masahiro Yamada
Collect basic Clang options such as --target, --prefix, --gcc-toolchain, -no-integrated-as into a single variable CLANG_FLAGS so that it can be easily reused in other parts of Makefile. Signed-off-by: Masahiro Yamada --- Changes in v2: - Use := flavor instead of = because $(CLANG_FLAGS) is

[PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally

2018-11-05 Thread Masahiro Yamada
ff-by: Masahiro Yamada --- Changes in v2: - New patch Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 93315eb..da11700 100644 --- a/Makefile +++ b/Makefile @@ -497,8 +497,8 @@ CLANG_GCC_TC:= --gcc-toolchain=$(GCC_TOOLCHAIN)

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-11 Thread Masahiro Yamada
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote: > > On 11/09/2018 10:29 AM, Nick Desaulniers wrote: > > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada > > wrote: > >> > >> Collect basic Clang options such as --target, --prefix, --gcc-toolchain, > >

[PATCH 0/2] Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely

2018-11-11 Thread Masahiro Yamada
1/2: remove dead code, which is logically obvious because the minimum GCC version is now 4.6 2/2: we can say -funit-at-a-time is no longer useful according to GCC 4.6 manual I hope, this series can be applied through x86 tree. Masahiro Yamada (2): um: remove -fno-unit-at-a-time

[PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-11-11 Thread Masahiro Yamada
GCC 4.6 manual says: -funit-at-a-time This option is left for compatibility reasons. -funit-at-a-time has no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder and -fno-section-anchors. Enabled by default. Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile | 4

[PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-11-11 Thread Masahiro Yamada
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") bumped the minimum GCC version to 4.6 for all architectures. '$(call cc-option,-fno-unit-at-a-time)' is now dead code since '$(cc-version) -lt 0400' is always false. Signed-off-by: Masahiro Yama

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-11 Thread Masahiro Yamada
On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman wrote: > > Masahiro Yamada writes: > > On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote: > >> > >> On 11/09/2018 10:29 AM, Nick Desaulniers wrote: > >> > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yam

Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-12 Thread Masahiro Yamada
'export'. > Either way, I think it would be clearer to export this after all the > relevant flags are set. OK. It is just a matter of preference, but I will move the export line below when I pick up this patch set. > > KBUILD_CFLAGS += $(CLANG_FLAGS) > > KBUILD_AFLAGS += $(CLANG_FLAGS) > > -- > > 2.19.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally

2018-11-13 Thread Masahiro Yamada
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada wrote: > > We are still a way off the Clang's integrated assembler support for > the kernel. Hence, -no-integrated-as is mandatory to build the kernel > with Clang. If you had an ancient version of Clang that does not > recogn

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-13 Thread Masahiro Yamada
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada wrote: > > Collect basic Clang options such as --target, --prefix, --gcc-toolchain, > -no-integrated-as into a single variable CLANG_FLAGS so that it can be > easily reused in other parts of Makefile. > > Signed-off-b

Re: [PATCH v2 2/2] powerpc/boot: Set target when cross-compiling for clang

2018-11-13 Thread Masahiro Yamada
LANG > > +BOOTCFLAGS += $(CLANG_FLAGS) > > +BOOTAFLAGS += $(CLANG_FLAGS) > > +endif > > + > > ifdef CONFIG_DEBUG_INFO > > BOOTCFLAGS += -g > > endif > > -- > > 2.19.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-13 Thread Masahiro Yamada
ted-as > KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v4

2018-11-22 Thread Masahiro Yamada
_MSI for riscv > - update x86 and riscv defconfigs to include PCI > - actually inclue drivers/eisa/Kconfig > - adjust some captilizations -- Best Regards Masahiro Yamada

Re: [PATCH 9/9] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-11-22 Thread Masahiro Yamada
-off-by: Christoph Hellwig > Acked-by: Thomas Gleixner > --- -- Best Regards Masahiro Yamada

Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v4

2018-11-22 Thread Masahiro Yamada
On Fri, Nov 23, 2018 at 11:32 AM Masahiro Yamada wrote: > > Hi Christoph, > > > On Fri, Nov 16, 2018 at 4:08 AM Christoph Hellwig wrote: > > > > Hi all, > > > > currently every architecture that wants to provide on of the common > > periphal busses n

Re: [PATCH 3/9] MIPS: remove the HT_PCI config option

2018-11-22 Thread Masahiro Yamada
this also select PCI_DOMAINS to preserve the existing behavior? > > > > If not, could you explain why in the commit message? > > Ah, I see - PCI already selects PCI_DOMAINS. I think it would have been > worth mentioning OK, I added "PCI already selects PCI_DOMAINS" in the commit description. > but I don't mind if you don't think it a big enough > deal to respin the patch, so: > > Acked-by: Paul Burton > > Thanks, > Paul -- Best Regards Masahiro Yamada

Re: [PATCH 1/9] arm: remove EISA kconfig option

2018-11-22 Thread Masahiro Yamada
e difference between arch/powerpc/Kconfig and arch/arm/Kconfig is the presence of ---help--- property. I squashed this to "eisa: consolidate EISA ..." > Suggested-by: Masahiro Yamada > Signed-off-by: Christoph Hellwig > --- > arch/arm/Kconfig | 15 --- > 1 f

Re: [PATCH 2/9] alpha: force PCI on for non-jensen configs

2018-11-22 Thread Masahiro Yamada
IO > select ARCH_NO_PREEMPT > select ARCH_USE_CMPXCHG_LOCKREF > + select PCI if !ALPHA_JENSEN > select HAVE_AOUT > select HAVE_IDE > select HAVE_OPROFILE > -- > 2.19.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 5/9] PCI: consolidate the PCI_DOMAINS and PCI_DOMAINS_GENERIC config options

2018-11-22 Thread Masahiro Yamada
Of course, it is just a matter of slight taste. I just wanted the code to look consistent. -- Best Regards Masahiro Yamada

[PATCH 3/3] arch: remove redundant generic-y defines

2018-12-05 Thread Masahiro Yamada
Now that Kbuild automatically creates asm-generic wrappers for missing mandatory headers, it is redundant to list the same headers in generic-y and mandatory-y. Suggested-by: Sam Ravnborg Signed-off-by: Masahiro Yamada --- arch/alpha/include/uapi/asm/Kbuild | 5 - arch/arc/include

Re: [PATCH v2 01/34] kbuild: Add support for DT binding schema checks

2018-12-07 Thread Masahiro Yamada
eparate from a normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-...@vger.kernel.org > Cc: devicet...

Re: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger wrote: > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > bumped the minimum GCC version

Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > GCC 4.6 manual says: > > > > -funit-at-a-time > > This option is left for compatibility reasons. -funit-at-a-time has > > no effect,

Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-08 Thread Masahiro Yamada
Hi Borislav, On Sat, Dec 8, 2018 at 8:34 PM Borislav Petkov wrote: > > On Sat, Dec 08, 2018 at 03:36:52PM +0900, Masahiro Yamada wrote: > > x86 maintainers, > > > > Ping. > > You got the required ACKs. If you want me to carry this one and the > UML one through

Re: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-12-08 Thread Masahiro Yamada
Hi Richard, On Sat, Dec 8, 2018 at 5:55 PM Richard Weinberger wrote: > > Am Samstag, 8. Dezember 2018, 07:35:47 CET schrieb Masahiro Yamada: > > x86 maintainers, > > > > > > Ping. > > I thought you carry this via your kbuild tree. > That said, I can mer

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-10 Thread Masahiro Yamada
ntly, the validation targets are separate from a normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek >

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
/%.yaml,%.example.dtb, $(DT_SCHEMA_FILES))) > > > > I do not understand this line. > > Why is it necessary? > > > > *.example.dtb files are generated anyway > > since they are listed in extra-y. > > It is enforcing the ordering. Without it, the binding checks and > building .schema.yaml.tmp happen in parallel because both only have > the source files as dependencies. The '|' keeps the dependencies out > of the dependency list($^). What kind problem would you see if the binding checks and building .schema.yaml.tmp happen in parallel? -- Best Regards Masahiro Yamada

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
On Wed, Dec 12, 2018 at 3:36 AM Rob Herring wrote: > > On Tue, Dec 11, 2018 at 10:03 AM Masahiro Yamada > wrote: > > > > On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote: > > > > > > > > > > +$(obj)/%.example.dts: $(src)/%.yaml FO

Re: [PATCH v4] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
normal build to > avoid a hard dependency on the external DT schema project and because > there are lots of warnings generated. > > Cc: Jonathan Corbet > Cc: Mark Rutland > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-...@vger.kernel.org > Cc: devicet...@vger.ke

Re: [PATCH 00/15] kbuild: refactor headers_install and support compile-test of UAPI headers

2019-06-18 Thread Masahiro Yamada
On Tue, Jun 4, 2019 at 7:15 PM Masahiro Yamada wrote: > > > Multiple people have suggested to compile-test UAPI headers. > > Currently, Kbuild provides simple sanity checks by headers_check > but they are not enough to catch bugs. > > The most recent patch I know is Davi

Re: [PATCH v2] powerpc/mm: mark more tlb functions as __always_inline

2019-06-23 Thread Masahiro Yamada
On Tue, May 21, 2019 at 10:19 PM Masahiro Yamada wrote: > > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error > with gcc 9.1.1: > > arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': > arch/powerpc/mm/book3s64/radix_tlb.c:104:2: war

Re: [PATCH v2] powerpc/boot: pass CONFIG options in a simpler and more robust way

2019-06-23 Thread Masahiro Yamada
On Mon, May 13, 2019 at 11:24 PM Masahiro Yamada wrote: > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > with -j 1") was also wrong. > > The correct depen

Re: [PATCH v2] powerpc/boot: pass CONFIG options in a simpler and more robust way

2019-07-05 Thread Masahiro Yamada
On Thu, Jul 4, 2019 at 9:26 AM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > > with

[PATCH v3 1/2] powerpc/boot: add {get, put}_unaligned_be32 to xz_config.h

2019-07-05 Thread Masahiro Yamada
ded : | #ifdef __KERNEL__ | # include | # include | # include However, doing so would cause tons of definition conflicts since the bootwrapper has duplicated everything. I just added copies of {get,put}_unaligned_be32, following the bootwrapper coding convention. Signed-off-by:

[PATCH v3 2/2] powerpc/boot: pass CONFIG options in a simpler and more robust way

2019-07-05 Thread Masahiro Yamada
ons are accessible from all .c and .S files in arch/powerpc/boot/. I also removed the -traditional flag to make include/linux/kconfig.h work. This flag makes the preprocessor imitate the behavior of the pre-standard C compiler, but I do not understand why it is necessary. Signed-off-by: Masahiro Ya

[PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-12 Thread Masahiro Yamada
nneeded. Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index c345b79414a9..46ed198a3aa3 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -112,7 +112,6 @@ ifeq ($(HAS_BIARCH),y

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-13 Thread Masahiro Yamada
On Sat, Jul 13, 2019 at 10:17 PM Segher Boessenkool wrote: > > On Sat, Jul 13, 2019 at 07:47:44AM -0500, Segher Boessenkool wrote: > > On Sat, Jul 13, 2019 at 12:21:06PM +0900, Masahiro Yamada wrote: > > > The KBUILD_ARFLAGS addition in arch/powerpc/Makefile has never worked

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-15 Thread Masahiro Yamada
iscussing whether or not to revive GNUTARGET=elf$(BITS)-$(GNUTARGET) in a *separate* patch, correct? -- Best Regards Masahiro Yamada

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-16 Thread Masahiro Yamada
On Tue, Jul 16, 2019 at 3:16 AM Segher Boessenkool wrote: > > On Mon, Jul 15, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote: > > On Mon, Jul 15, 2019 at 4:30 PM Segher Boessenkool > > wrote: > > > > > > On Mon, Jul 15, 2019 at 05:05:34PM +1000, Mi

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-17 Thread Masahiro Yamada
ilt-in.a creating empty archive: drivers/video/fbdev/omap2/omapfb/displays/built-in.a creating empty archive: drivers/video/fbdev/omap2/omapfb/dss/built-in.a BTW, your commit 8995ac8702737147115e1c75879a1a2d75627b9e dates back to 2008. At that time, thin archive was not used. -- Best Regards Masahiro Yamada

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-17 Thread Masahiro Yamada
On Thu, Jul 18, 2019 at 1:46 AM Segher Boessenkool wrote: > > On Thu, Jul 18, 2019 at 12:19:36AM +0900, Masahiro Yamada wrote: > > On Wed, Jul 17, 2019 at 11:38 PM Segher Boessenkool > > wrote: > > > > > > On Tue, Jul 16, 2019 at 10:15:47PM +1000, Mi

[PATCH 2/3] kbuild: rebuild modules when module linker scripts are updated

2019-08-14 Thread Masahiro Yamada
Currently, the timestamp of module linker scripts are not checked. Add them to the dependency of modules so they are correctly rebuilt. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 5 + Makefile | 3 ++- arch/arm/Makefile

[PATCH] jump_label: move 'asm goto' support test to Kconfig

2018-12-30 Thread Masahiro Yamada
'asm goto' support in Kconfig, then make JUMP_LABEL depend on CC_HAS_ASM_GOTO. Ugly #ifdef HAVE_JUMP_LABEL will go away, and CONFIG_JUMP_LABEL will match to the real kernel capability. Signed-off-by: Masahiro Yamada --- This is a trivial conversion from the build system PoV. I want to

Re: jump_label: move 'asm goto' support test to Kconfig

2019-01-02 Thread Masahiro Yamada
nel cannot be compiled with Clang since it lacks the asm-goto support. $ make CC=clang Compiler lacks asm-goto support. arch/x86/Makefile:293: recipe for target 'checkbin' failed make: *** [checkbin] Error 1 -- Best Regards Masahiro Yamada

Re: [RFC PATCH kernel] powerpc/stack_protector: Fix external modules building

2019-01-10 Thread Masahiro Yamada
ifdef CONFIG_STACKPROTECTOR > prepare: stack_protector_prepare > > +ifeq ($(KBUILD_EXTMOD),) > stack_protector_prepare: prepare0 > +else > +stack_protector_prepare: > +endif Honestly, I think this is ugly. Do you want me to send an alternative solution? > ifdef CONFIG_PPC64 > $(eval KBUILD_CFLAGS += -mstack-protector-guard-offset=$(shell awk > '{if ($$2 == "PACA_CANARY") print $$3;}' include/generated/asm-offsets.h)) > else > -- > 2.17.1 > -- Best Regards Masahiro Yamada

[PATCH 3/3] powerpc: math-emu: remove unneeded header search paths

2019-01-10 Thread Masahiro Yamada
without these header search paths. Signed-off-by: Masahiro Yamada --- arch/powerpc/math-emu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/Makefile index 494df26..a879403 100644 --- a/arch/powerpc/math-emu

[PATCH 1/3] KVM: powerpc: remove -I. header search paths

2019-01-10 Thread Masahiro Yamada
t they are completely useless. Signed-off-by: Masahiro Yamada --- arch/powerpc/kvm/Makefile | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kvm/Makefile b/arch/powerpc/kvm/Makefile index 64f1135..3223aec 100644 --- a/arch/powerpc/kvm/Makefile +++ b/arch/powerpc/kvm/Makefile @@ -1

[PATCH 0/3] powerpc: some header search path cleanups

2019-01-10 Thread Masahiro Yamada
I am trying to get rid of crappy magic from Kbuild core makefiles. Before that, I want to drop as many useless paths as possible. Actually, many Makefiles are adding around pointless options. This series cleans some powerpc Makefiles. (only compile-tested by 0day bot) Masahiro Yamada (3

[PATCH 2/3] powerpc: remove redundant header search path additions

2019-01-10 Thread Masahiro Yamada
The same path -Iarch/$(ARCH) is passed to KBUILD_CPPFLAGS, KBUILD_AFLAGS, and KBUILD_CFLAGS. As you see in scripts/Makefile.lib, KBUILD_CPPFLAGS is passed to c_flags and a_flags as well. Passing it to KBUILD_CPPFLAGS is enough. Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile | 4

[PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-14 Thread Masahiro Yamada
for per-task stack canaries") Fixes: 0a1213fa7432 ("arm64: enable per-task stack canaries") Cc: linux-stable # v4.20 Reported-by: Samuel Holland Reported-by: Alexey Kardashevskiy Signed-off-by: Masahiro Yamada --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 7:35 PM Mathieu Malaterre wrote: > > On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada > wrote: > > > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > > caused kernel panic on PowerPC if an external module is used w

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 7:45 PM Alexey Kardashevskiy wrote: > > > > On 15/01/2019 18:19, Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > > caused kernel panic on PowerPC if an external module is used with > > CO

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-16 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 5:07 PM Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > caused kernel panic on PowerPC if an external module is used with > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed

[PATCH 2/3] kbuild: add real-prereqs shorthand for $(filter-out FORCE, $^)

2019-01-16 Thread Masahiro Yamada
ned-off-by: Masahiro Yamada --- Documentation/devicetree/bindings/Makefile | 2 +- arch/mips/boot/Makefile| 2 +- arch/powerpc/boot/Makefile | 2 +- arch/x86/realmode/rm/Makefile | 3 +-- scripts/Kbuild.include | 4 +++

[PATCH v2 3/4] kbuild: add real-prereqs shorthand for $(filter-out FORCE, $^)

2019-01-17 Thread Masahiro Yamada
cmd_link_multi-m because $^ may include auto-generated dependencies from the .*.cmd file when a single object module is changed into a multi object module. Refer to commit 69ea912fda74 ("kbuild: remove unneeded link_multi_deps"). I added some comment to avoid accidental breakage. Signed-off-by

Re: [PATCH 0/3] powerpc: some header search path cleanups

2019-01-17 Thread Masahiro Yamada
Hi Michael, On Fri, Jan 11, 2019 at 2:20 PM Masahiro Yamada wrote: > > I am trying to get rid of crappy magic from Kbuild core makefiles. > > Before that, I want to drop as many useless paths as possible. > Actually, many Makefiles are adding around pointless options. > &g

[PATCH] powerpc/prom_init: add __init markers to all functions

2019-01-30 Thread Masahiro Yamada
e', so inlining is guaranteed because PowerPC never enables CONFIG_OPTIMIZE_INLINING. However, it would be better to leave the inlining decision to the compiler. I replaced 'inline' with __init. Signed-off-by: Masahiro Yamada --- arch/powerpc/kernel/prom_init.c | 24 --

Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-02-05 Thread Masahiro Yamada
On Tue, Feb 5, 2019 at 7:33 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > It is fragile to rely on the compiler's optimization to avoid the > > section mismatch. Some functions may not be necessarily inlined > > when the compiler's inlining

Re: [PATCH 06/11] lockdep: consolidate the LOCKDEP_SUPPORT symbol

2019-02-14 Thread Masahiro Yamada
n nds32. It is now available in lib/Kconfig.debug, so this commit enables LOCKDEP_SUPPORT for nds32. - -- Best Regards Masahiro Yamada

Re: [PATCH 11/11] s390: don't redefined the HAS_IOMEM symbol

2019-02-14 Thread Masahiro Yamada
___ > linux-riscv mailing list > linux-ri...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Best Regards Masahiro Yamada

Re: [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol

2019-02-14 Thread Masahiro Yamada
ef5 100644 > --- a/arch/nios2/Kconfig.debug > +++ b/arch/nios2/Kconfig.debug > @@ -1,8 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > > -config TRACE_IRQFLAGS_SUPPORT > - def_bool y > - > config EARLY_PRINTK > bool "Activate early kernel debugging" > default y -- Best Regards Masahiro Yamada

Re: [PATCH 09/11] lib: consolidate the GENERIC_CSUM symbol

2019-02-15 Thread Masahiro Yamada
> - > config NO_IOPORT_MAP > bool > You missed to add 'select GENERIC_CSUM' for unicore32. -- Best Regards Masahiro Yamada

Re: [PATCH 08/11] lib: consolidate the GENERIC_BUG symbol

2019-02-15 Thread Masahiro Yamada
if BUG > + select GENERIC_BUG_RELATIVE_POINTERSif X86_64 Precisely, select GENERIC_BUG_RELATIVE_POINTERSif X86_64 && BUG -- Best Regards Masahiro Yamada

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-15 Thread Masahiro Yamada
t; Regarding the #ifdef __KERNEL__ , I think we should do a wide cleanup in > arch/powerpc/include/asm, not only asm/checksum.h > > Christophe Please send such cleanups to PowerPC ML instead of to me (Kbuild). Christoph, I think this one is independent of the rest of this series. How about separating it if you volunteer to Powerpc cleansup? -- Best Regards Masahiro Yamada

Re: [PATCH 02/11] riscv: remove the HAVE_KPROBES option

2019-02-15 Thread Masahiro Yamada
lt 3 if 64BIT > default 2 > > -config HAVE_KPROBES > - def_bool n > - > menu "Platform type" > > choice > -- > 2.20.1 > > > ___ > linux-riscv mailing list > linux-ri...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Best Regards Masahiro Yamada

[PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-02-15 Thread Masahiro Yamada
"arch/powerpc/configs/x86_64_defconfig"! *** After this commit, it will succeed: $ make ARCH=powerpc defconfig *** Default configuration is based on 'ppc64_defconfig' # # configuration written to .config # Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile |

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-02-15 Thread Masahiro Yamada
On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote: > > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada > wrote: > > > > I often test all Kconfig commands for all architectures. To ease my > > workflow, I want 'make defconfig' at least w

Re: [PATCH 10/11] lib: consolidate the GENERIC_HWEIGHT symbol

2019-02-17 Thread Masahiro Yamada
6/um/Kconfig > index f5a8cded3ca4..1628a54af003 100644 > --- a/arch/x86/um/Kconfig > +++ b/arch/x86/um/Kconfig > @@ -49,6 +49,3 @@ config ARCH_HAS_SC_SIGNALS > > config ARCH_REUSE_HOST_VSYSCALL_AREA > def_bool !64BIT > - > -config GENERIC_HWEIGHT > - def_bool y > diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig > index d02c25184ca0..ff57afdeda04 100644 > --- a/arch/xtensa/Kconfig > +++ b/arch/xtensa/Kconfig > @@ -47,9 +47,6 @@ config XTENSA > with reasonable minimum requirements. The Xtensa Linux project has > a home page at <http://www.linux-xtensa.org/>. > > -config GENERIC_HWEIGHT > - def_bool y > - > config ARCH_HAS_ILOG2_U32 > def_bool n > > diff --git a/lib/Kconfig b/lib/Kconfig > index bd2e7e74c321..91019f26d0a8 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -35,6 +35,13 @@ config RATIONAL > config GENERIC_CSUM > bool > > +config ARCH_HAS_HWEIGHT > + bool > + > +config GENERIC_HWEIGHT > + default y if !ARCH_HAS_HWEIGHT > + bool > + > config GENERIC_STRNCPY_FROM_USER > bool > > -- > 2.20.1 > > > ___ > linux-riscv mailing list > linux-ri...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Best Regards Masahiro Yamada

[PATCH v2] powerpc/prom_init: add __init markers to all functions

2019-02-19 Thread Masahiro Yamada
fect of 'inline'; GCC does not report -Wunused-function warnings for functions with 'inline' marker. Signed-off-by: Masahiro Yamada --- Changes in v2: - Add __maybe_unsed to prom_getproplen() - Add __init to enter_prom() as well arch/powerpc/kernel/prom_init.c | 29

Re: [PATCH v4 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-29 Thread Masahiro Yamada
; export CROSS32CC CROSS32AR > > ifeq ($(CROSS_COMPILE),) > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v4 4/4] powerpc/kbuild: move -mprofile-kernel check to Kconfig

2018-05-29 Thread Masahiro Yamada
t? > endif > > CFLAGS-$(CONFIG_CELL_CPU) += $(call cc-option,-mcpu=cell) > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-30 Thread Masahiro Yamada
the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html All applied to linux-kbuild/kconfig. Thanks! -- Best Regards Masahiro Yamada

Re: [PATCH v5 1/4] powerpc/kbuild: set default generic machine type for 32-bit compile

2018-05-30 Thread Masahiro Yamada
> -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 3/4] powerpc/kbuild: Use flags variables rather than overriding LD/CC/AS

2018-05-30 Thread Masahiro Yamada
quot;) { > + $cc .= " -mbig-endian "; > + $ld .= " -EB "; > + $ldemulation = "ppc" > +} else { > + $cc .= " -mlittle-endian "; > + $ld .= " -EL "; > + $ldemulation = "lppc" > +} > if ($bits == 64) { > - $type = ".quad"; > +$type = ".quad"; > +$cc .= " -m64 "; > +$ld .= " -m elf64".$ldemulation." "; > +} else { > +$cc .= " -m32 "; > +$ld .= " -m elf32".$ldemulation." "; > } > > } elsif ($arch eq "arm") { > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-30 Thread Masahiro Yamada
h patch must go after it. >> >> v5 changes: >> - Patch 4 update to syntax changed since kconfig-shell-v3 release. >> - Patch 4 suggestions from Masahiro Yamada, remove unnecessary "OK" >> output from check mprofile script, and fold CC_USING_MPROFILE_KERNEL &g

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-30 Thread Masahiro Yamada
2018-05-31 13:31 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2018-05-30 23:39 GMT+09:00 Michael Ellerman : >>> Nicholas Piggin writes: >>> >>>> This series of patches improves th powerpc kbuild system. The >>>> motivation was

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-31 Thread Masahiro Yamada
2018-05-31 20:51 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2018-05-31 13:31 GMT+09:00 Michael Ellerman : >>> Masahiro Yamada writes: >>>> 2018-05-30 23:39 GMT+09:00 Michael Ellerman : >>>>> Nicholas Piggin writes: >>>>&

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-06-01 Thread Masahiro Yamada
Hi. 2018-06-01 19:34 GMT+09:00 Michael Ellerman : > Hi Masahiro, > > Masahiro Yamada writes: > ... >> >> Also, the change logs could be dropped. >> >> I see >> >> Since v1: reworded changelog to explain the cause of the problem (thanks >> Se

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Masahiro Yamada
ror} which isn't > used in the expansion of the macros but serves to push people to > document the reason for using them - per feedback from Kees Cook.] > > Signed-off-by: Arnd Bergmann > Signed-off-by: Paul Burton > Cc: Michal Marek > Cc: Masahiro Yamada >

Re: [PATCH v2 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Masahiro Yamada
x/compiler_types.h. > - Drop all but GCC 8 macros, since we only need to define macros for > versions that we need to introduce pragmas for, and as of this > series that's just GCC 8. > - Capitalize comments in linux/compiler-gcc.h to match the style of > the rest of t

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Masahiro Yamada
2018-06-20 4:02 GMT+09:00 Paul Burton : > Hi Masahiro, > > On Wed, Jun 20, 2018 at 02:34:35AM +0900, Masahiro Yamada wrote: >> 2018-06-16 9:53 GMT+09:00 Paul Burton : >> > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h >> > index

Re: [PATCH v2 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()

2018-06-23 Thread Masahiro Yamada
plied to linux-kbuild/fixes. (since we need to fix warnings from GCC 8.1) Thanks! -- Best Regards Masahiro Yamada

[PATCH] kbuild: move bin2c back to scripts/ from scripts/basic/

2018-06-25 Thread Masahiro Yamada
9301 ("Revert "kexec/purgatory: Add clean-up for purgatory directory"") and commit d6605b6bbee8 ("x86/build: Remove unnecessary preparation for purgatory") removed the redundant purgatory build magic entirely. That means that the move of bin2c was unnecessary in the first

Re: [PATCH] kbuild: move bin2c back to scripts/ from scripts/basic/

2018-07-02 Thread Masahiro Yamada
2018-06-26 1:40 GMT+09:00 Masahiro Yamada : > Commit 8370edea81e3 ("bin2c: move bin2c in scripts/basic") moved bin2c > to the scripts/basic/ directory, incorrectly stating "Kexec wants to > use bin2c and it wants to use it really early in the build process. > See arch/x

Re: [PATCHv5 4/4] arm64: Add build salt to the vDSO

2018-07-03 Thread Masahiro Yamada
s: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473k/dom1359731141352.html It says ';' starts a comment line although it is not the case of GAS. Same for 3/4. -- Best Regards Masahiro Yamada

Re: [PATCHv5 0/4] Salted build ids via ELF notes

2018-07-03 Thread Masahiro Yamada
plain the background of this work, but the cover letter cannot be committed in git. Could you add this in 1/4 please? If I read only the simple log in 1/4, I would wonder why it is useful... > v5 uses the approach suggested by Masahiro Yamada which uses the > existing ELF not

Re: [PATCHv5 1/4] kbuild: Add build salt to the kernel and modules

2018-07-03 Thread Masahiro Yamada
ID is unique, even if the > actual file contents don't change. The easiest way to do this is to insert > a section with some data. > > Add an ELF note to both the kernel and module which contains some data based > off of a config option. > > Signed-off-by: Masahiro Yamada >

Re: [PATCHv6 0/4] Salted build ids via ELF notes

2018-07-08 Thread Masahiro Yamada
hanged, 47 insertions(+) > create mode 100644 include/linux/build-salt.h > > -- > 2.17.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: powerpc: 32BIT vs. 64BIT (PPC32 vs. PPC64)

2018-07-30 Thread Masahiro Yamada
ect ZLIB_DEFLATE >> + help >> + This option selects whether a 32-bit or a 64-bit kernel >> + will be built. >> + >> source "arch/powerpc/platforms/Kconfig.cputype" >> >> config PPC32 >> diff --git a/arch/powerpc/platforms/Kconfig.cputype >> b/arch/powerpc/platforms/Kconfig.cputype >> index e6a1de521319..f6e5d6ef9782 100644 >> --- a/arch/powerpc/platforms/Kconfig.cputype >> +++ b/arch/powerpc/platforms/Kconfig.cputype >> @@ -1,12 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -config PPC64 >> - bool "64-bit kernel" >> - default n >> - select ZLIB_DEFLATE >> - help >> - This option selects whether a 32-bit or a 64-bit kernel >> - will be built. >> - >> menu "Processor support" >> choice >> prompt "Processor Type" >> > > > -- > ~Randy > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada

Re: [PATCH] powerpc/Makefile: Mark phony targets as PHONY

2020-02-18 Thread Masahiro Yamada
Fix it by adding them to the PHONY variable which is marked phony in > the top-level Makefile. In arch/powerpc/boot/Makefile we do it > manually. You can do likewise in arch/powerpc/boot/Makefile because it is marked phony in scripts/Makefile.build -- Best Regards Masahiro Yamada

Re: [PATCH v2] powerpc/Makefile: Mark phony targets as PHONY

2020-02-18 Thread Masahiro Yamada
Fix it by adding them to the PHONY variable which is marked phony in > the top-level Makefile, or in scripts/Makefile.build for the boot > Makefile. > > Suggested-by: Masahiro Yamada > Signed-off-by: Michael Ellerman > --- Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-08-18 Thread Masahiro Yamada
Hi, On Fri, Jul 19, 2019 at 12:43 PM Michael Ellerman wrote: > > Segher Boessenkool writes: > > On Thu, Jul 18, 2019 at 11:19:58AM +0900, Masahiro Yamada wrote: > >> On Thu, Jul 18, 2019 at 1:46 AM Segher Boessenkool > >> wrote: > >> Kbuild always

powerpc asm-prototypes.h seems odd

2019-08-27 Thread Masahiro Yamada
$(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/asm-prototypes.h) -- Best Regards Masahiro Yamada

Re: linux-next: build warnings after merge of the kbuild tree

2019-09-03 Thread Masahiro Yamada
quot; else cmd_relocs_check = \ $(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh "$(OBJDUMP)" "$@" > -- > Cheers, > Stephen Rothwell -- Best Regards Masahiro Yamada

Re: linux-next: build warnings after merge of the kbuild tree

2019-09-03 Thread Masahiro Yamada
On Wed, Sep 4, 2019 at 10:00 AM Masahiro Yamada wrote: > > Hi Stephen, > > On Wed, Sep 4, 2019 at 9:13 AM Stephen Rothwell wrote: > > For today's linux-next, please squash the following too. (This is my fault, since scripts/mkuboot.sh is a bash script) diff --git a

<    1   2   3   4   5   >