Masahiro Yamada (6):
kbuild: fix cc-ifversion macro
kbuild: do not add $(call ...) to invoke cc-version or cc-fullversion
kbuild,gcov: remove unnecessary workaround
kbuild,gcov: simplify kernel/gcov/Makefile
kbuild: allow cc-ifversion to have the argument for false condition
kbuild
The macros cc-version, cc-fullversion and ld-version take no argument.
It is not necessary to add $(call ...) to invoke them.
Signed-off-by: Masahiro Yamada
---
Documentation/kbuild/makefiles.txt | 4 ++--
arch/parisc/Makefile | 2 +-
arch/powerpc/Makefile | 6
On Thu, Mar 14, 2019 at 11:27 AM Michael Ellerman wrote:
>
> Mathieu Malaterre writes:
> > On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada
> > wrote:
> >>
> >> On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote:
> >> >
> >> > On
tch would break my driver.
Probably, all the 8250* drivers would be broken in the same way.
For 8250 drivers, request_mem_region() is called
from 8250_port.c
Let's not touch around the code you do not
understand how it works.
Thanks.
Masahiro Yamada
> drivers/tty/serial/8250/8250_u
bounds
[-Warray-bounds]
trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
^~~~~
The fixup is not included in this. The patch is available in ML:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409393.html
Signed-off-by: Masahiro
On Wed, Mar 20, 2019 at 3:21 PM Masahiro Yamada
wrote:
>
> Commit 60a3cdd06394 ("x86: add optimized inlining") introduced
> CONFIG_OPTIMIZE_INLINING, but it has been available only for x86.
>
> The idea is obviously arch-agnostic although we need some code fixups.
>
Hi Arnd,
On Wed, Mar 20, 2019 at 6:39 PM Arnd Bergmann wrote:
>
> On Wed, Mar 20, 2019 at 7:41 AM Masahiro Yamada
> wrote:
>
> > It is unclear to me how to fix it.
> > That's why I ended up with "depends on !MIPS".
> >
> >
> >
Hi Arnd,
On Wed, Mar 20, 2019 at 10:05 PM Arnd Bergmann wrote:
>
> On Wed, Mar 20, 2019 at 11:19 AM Masahiro Yamada
> wrote:
> > On Wed, Mar 20, 2019 at 6:39 PM Arnd Bergmann wrote:
> > >
> > > On Wed, Mar 20, 2019 at 7:41 AM Masahiro Yamada
> > >
t; early_print("no ATAGS support: can't continue\n");
>
I do not know why to reproduce it,
but is "__init __noreturn" more sensible than
"__always_inline" here?
--
Best Regards
Masahiro Yamada
On Mon, Mar 25, 2019 at 3:10 PM Masahiro Yamada
wrote:
>
> Hi Arnd,
>
>
>
>
> On Wed, Mar 20, 2019 at 10:34 PM Arnd Bergmann wrote:
> >
> > On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote:
> > >
> > > I've added your patch to my ra
Hi Heiko,
On Thu, Mar 21, 2019 at 5:02 PM Heiko Carstens
wrote:
>
> On Wed, Mar 20, 2019 at 03:20:27PM +0900, Masahiro Yamada wrote:
> > Commit 60a3cdd06394 ("x86: add optimized inlining") introduced
> > CONFIG_OPTIMIZE_INLINING, but it has been available only
pmi_msghandler.o: defined in discarded section
> > `exit.text' of drivers/char/ipmi/ipmi_msghandler.o
>
> Wouldn't it be useful to activate -Winline gcc warning to ease finding
> out problematic usage of inline keyword ?
Yes, it is useful to find out
which function is causing the error.
Thanks for the tip.
--
Best Regards
Masahiro Yamada
On Mon, Mar 25, 2019 at 4:33 PM Arnd Bergmann wrote:
>
> On Mon, Mar 25, 2019 at 7:11 AM Masahiro Yamada
> wrote:
> > On Wed, Mar 20, 2019 at 10:34 PM Arnd Bergmann wrote:
> > >
> > > On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote:
> > > >
&
\
- if [ "$(findstring $(CC_FLAGS_FTRACE),$(_c_flags))" = \
-"$(CC_FLAGS_FTRACE)" ]; then \
- $(sub_cmd_record_mcount)\
- fi
+cmd_record_mcount = $(if $(findstring $(CC_FLAGS_FTRACE),$(_c_flags)),\
+ $(sub_cmd_record_mcount))
endif # CC_USING_RECORD_MCOUNT
endif # CONFIG_FTRACE_MCOUNT_RECORD
--
Best Regards
Masahiro Yamada
Hi Joe,
On Wed, Mar 27, 2019 at 2:33 AM Joe Lawrence wrote:
>
> On Tue, Mar 26, 2019 at 02:29:47PM +0900, Masahiro Yamada wrote:
> > On Tue, Mar 26, 2019 at 1:05 AM Joe Lawrence
> > wrote:
> > >
> > > CC_FLAGS_FTRACE may contain trailing whitespace t
le (0)
^~~
./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro
'asm_volatile_goto'
asm_volatile_goto(
^
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/arm64/incl
raint in 'asm'
asm volatile(
^~~
arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm'
asm volatile(
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/mips/kernel/cpu-bugs64.c | 4 ++--
1 file changed, 2 insertio
query':
./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't
match constraints
asm volatile(
^~~
./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a s
t;ARM: add IPI tracepoints") # v3.17
Signed-off-by: Arnd Bergmann
[yamada.masah...@socionext.com: rebase on v5.0-rc1]
Signed-off-by: Masahiro Yamada
---
This is a long-standing issue, and
Arnd posted this patch two years ago:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-Febru
Major changes in v2:
- Eliminate more errors and warnings
- Delete 'depends on !MIPS'
- Split into separate patches
Arnd Bergmann (1):
ARM: prevent tracing IPI_CPU_BACKTRACE
Masahiro Yamada (10):
arm64: mark (__)cpus_have_const_cap as __always_inline
MIPS: mark mult_sh_alig
from the
function .prom_getproplen() to the function .init.text:.call_prom()
The function .prom_getproplen() references
the function __init .call_prom().
This is often because .prom_getproplen lacks a __init
annotation or the annotation of .call_prom is wrong.
Signed-off-by: Masahiro Yamada
setup_machine_tags() to the function .init.text:early_print()
The function setup_machine_tags() references
the function __init early_print().
This is often because setup_machine_tags lacks a __init
annotation or the annotation of early_print is wrong.
Signed-off-by: Masahiro Yamada
---
Changes in v2
ix.c:104:2: error: asm operand 3 probably doesn't match
constraints [-Werror]
asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
arch/powerpc/mm/tlb-radix.c:104:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate pa
gt;data_access);
~~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
drivers/mtd/nand/raw/vf610_nfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c
inde
ile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- new patch
arch/powerpc/mm/tlb-radix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
index a2b2848f0ae3..14ff414d1
gcr_base'
arch/mips/mm/sc-mips.o:sc-mips.c:(.text.unlikely+0x44): more undefined
references to `mips_gcr_base'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- new patch
arch/mips/include/asm/bitops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/a
proves the "Kernel hacking" Kconfig menu as
e61aca5158a8 ("Merge branch 'kconfig-diet' from Dave Hansen') suggested;
this config option would be a good fit in the "compiler option" menu.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a se
le (0)
^~~
./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro
'asm_volatile_goto'
asm_volatile_goto(
^
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
Major changes in v3:
- Fix link error for arch/mips/configs/ci20_defconfig
Major changes in v2:
- Eliminate more errors and warnings
- Delete 'depends on !MIPS'
- Split into separate patches
Masahiro Yamada (10):
arm64: mark (__)cpus_have_const_cap as __always_inline
raint in 'asm'
asm volatile(
^~~
arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm'
asm volatile(
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
arch/mips/kernel/cpu-bugs64.c | 4 ++--
1 fi
ix.c:104:2: error: asm operand 3 probably doesn't match
constraints [-Werror]
asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
arch/powerpc/mm/tlb-radix.c:104:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- sp
gt;data_access);
~~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
drivers/mtd/nand/raw/vf610_nfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/r
query':
./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't
match constraints
asm volatile(
^~~
./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
ile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- new patch
arch/powerpc/mm/tlb-radix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
index a2b2
gcr_base'
arch/mips/mm/sc-mips.o:sc-mips.c:(.text.unlikely+0x44): more undefined
references to `mips_gcr_base'
Signed-off-by: Masahiro Yamada
---
Changes in v3:
- forcibly inline __ffs() too
Changes in v2:
- new patch
arch/mips/include/asm/bitops.h | 4 ++--
1 file changed, 2 insertio
setup_machine_tags() to the function .init.text:early_print()
The function setup_machine_tags() references
the function __init early_print().
This is often because setup_machine_tags lacks a __init
annotation or the annotation of early_print is wrong.
Signed-off-by: Masahiro Yamada
---
Changes in v3
from the
function .prom_getproplen() to the function .init.text:.call_prom()
The function .prom_getproplen() references
the function __init .call_prom().
This is often because .prom_getproplen lacks a __init
annotation or the annotation of .call_prom is wrong.
Signed-off-by: Masahiro Yamada
proves the "Kernel hacking" Kconfig menu as
e61aca5158a8 ("Merge branch 'kconfig-diet' from Dave Hansen') suggested;
this config option would be a good fit in the "compiler option" menu.
Signed-off-by: Masahiro Yamada
Acked-by: Borislav Petkov
---
Changes in
On Sat, Apr 20, 2019 at 12:45 AM Mathieu Malaterre wrote:
>
> Hi,
>
> On Fri, Apr 19, 2019 at 12:06 PM Masahiro Yamada
> wrote:
> >
> > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common
> > place. We need to eliminate potential issues beforeh
Hi Christophe,
On Tue, Mar 26, 2019 at 3:03 PM Christophe Leroy
wrote:
>
> Hi Masahiro,
>
> Le 25/03/2019 à 07:44, Masahiro Yamada a écrit :
> > Hi Christophe,
> >
> >
> > On Sat, Mar 23, 2019 at 5:27 PM LEROY Christophe
> > wrote:
> >>
>
raint in 'asm'
asm volatile(
^~~
arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm'
asm volatile(
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
arch/mips/kernel/cpu-bugs64.c | 4 ++--
1 fi
t;ARM: add IPI tracepoints") # v3.17
Signed-off-by: Arnd Bergmann
[yamada.masah...@socionext.com: rebase on v5.1-rc1]
Signed-off-by: Masahiro Yamada
---
This is a long-standing issue, and
Arnd posted this patch two years ago:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-Febru
Split into separate patches
Arnd Bergmann (1):
ARM: prevent tracing IPI_CPU_BACKTRACE
Masahiro Yamada (10):
arm64: mark (__)cpus_have_const_cap as __always_inline
MIPS: mark mult_sh_align_mod() as __always_inline
s390/cpacf: mark scpacf_query() as __always_inline
mtd: rawnand: vf61
query':
./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't
match constraints
asm volatile(
^~~
./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
le (0)
^~~
./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro
'asm_volatile_goto'
asm_volatile_goto(
^
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
gcr_base'
arch/mips/mm/sc-mips.o:sc-mips.c:(.text.unlikely+0x44): more undefined
references to `mips_gcr_base'
Signed-off-by: Masahiro Yamada
---
Changes in v3:
- forcibly inline __ffs() too
Changes in v2:
- new patch
arch/mips/include/asm/bitops.h | 4 ++--
1 file changed, 2 insertio
ile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- new patch
arch/powerpc/mm/tlb-radix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
index a2b2
setup_machine_tags() to the function .init.text:early_print()
The function setup_machine_tags() references
the function __init early_print().
This is often because setup_machine_tags lacks a __init
annotation or the annotation of early_print is wrong.
Signed-off-by: Masahiro Yamada
---
Changes in v3
ix.c:104:2: error: asm operand 3 probably doesn't match
constraints [-Werror]
asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
arch/powerpc/mm/tlb-radix.c:104:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- sp
from the
function .prom_getproplen() to the function .init.text:.call_prom()
The function .prom_getproplen() references
the function __init .call_prom().
This is often because .prom_getproplen lacks a __init
annotation or the annotation of .call_prom is wrong.
Signed-off-by: Masahiro Yamada
gt;data_access);
~~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
drivers/mtd/nand/raw/vf610_nfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/r
proves the "Kernel hacking" Kconfig menu as
e61aca5158a8 ("Merge branch 'kconfig-diet' from Dave Hansen') suggested;
this config option would be a good fit in the "compiler option" menu.
Signed-off-by: Masahiro Yamada
Acked-by: Borislav Petkov
---
Changes in
tall
> > $ make install
> > make: 'install' is up to date.
> > $
> >
> > Fix it by adding them to the PHONY variable which is marked phony in
> > the top-level Makefile, or in scripts/Makefile.build for the boot
> > Makefile.
> >
>
On Thu, Oct 24, 2019 at 7:13 PM Michal Simek wrote:
>
> msi.h is generic for all architectures expect of x86 which has own version.
Maybe a typo? "except"
Anyway, the code looks good to me.
Reviewed-by: Masahiro Yamada
> Enabling MSI by including msi.h to architec
directive.
Include to make it self-contained, and add it to
the compile-test coverage.
Signed-off-by: Masahiro Yamada
---
arch/mips/include/uapi/asm/msgbuf.h| 1 +
arch/parisc/include/uapi/asm/msgbuf.h | 1 +
arch/powerpc/include/uapi/asm/msgbuf.h | 2 ++
arch/sparc/include/uapi/asm
/asm/sembuf.h:31:2: error: unknown type name ‘__kernel_ulong_t’
__kernel_ulong_t __unused4;
^~~~
It is just a matter of missing include directive.
Include to make it self-contained, and add it to
the compile-test coverage.
Signed-off-by: Masahiro Yamada
---
arch/mips/include
just a matter of missing include directive.
Include to make it self-contained, and add it to
the compile-test coverage.
Signed-off-by: Masahiro Yamada
---
arch/s390/include/uapi/asm/ipcbuf.h | 2 ++
arch/sparc/include/uapi/asm/ipcbuf.h | 2 ++
arch/xtensa/include/uapi/asm/ipcbuf.h | 2
Hi Andrew,
I think this patch has already been picked up to your tree,
but I noticed a typo in the commit message just now.
Please see below.
On Wed, Oct 30, 2019 at 3:40 PM Masahiro Yamada
wrote:
>
> The user-space cannot compile due to some missing type
> definitions. For example,
x27;t add (U)INT32_MAX to any more.
Instead, add them to the in-kernel libfdt_env.h to compile fdt.c and
fdt_addresses.c
Signed-off-by: Masahiro Yamada
---
arch/powerpc/boot/libfdt_env.h | 2 ++
include/linux/libfdt_env.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/arch/powerpc
These are kernel source code even though they are just two-line wrappers.
Files without explicit license information fall back to GPL-2.0-only,
which is the project default.
Signed-off-by: Masahiro Yamada
---
lib/fdt.c| 1 +
lib/fdt_empty_tree.c | 1 +
lib/fdt_ro.c | 1
efile messes.
Another nice thing is we no longer need to maintain the separate
libfdt_env.h since we can include , and the
diff stat also looks nice.
Signed-off-by: Masahiro Yamada
---
arch/arm/boot/compressed/.gitignore | 9 ---
arch/arm/boot/compressed/Makefile
pretty easy to refactor the ARM decompressor
to reuse
So, 2/3 simplifies the Makefile and deletes its own
libfdt_env.h
On the other hand, the PPC boot-wrapper is a can of worms.
I give up refactoring it.
Let's keep it closed, and just update arch/powerpc/boot/libfdt_env.h
Masahiro Yama
These are kernel source code even though they are just two-line wrappers.
Files without explicit license information fall back to GPL-2.0-only,
which is the project default.
Signed-off-by: Masahiro Yamada
---
Changes in v2: None
lib/fdt.c| 1 +
lib/fdt_empty_tree.c | 1 +
lib
x27;t add (U)INT32_MAX to any more.
Instead, add them to the in-kernel libfdt_env.h to compile fdt.c and
fdt_addresses.c
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- Fix ppc libfdt_env.h
arch/powerpc/boot/libfdt_env.h | 2 ++
include/linux/libfdt_env.h | 3 +++
2 files changed, 5 in
x ppc libfdt_env.h
Masahiro Yamada (3):
libfdt: add SPDX-License-Identifier to libfdt wrappers
ARM: decompressor: simplify libfdt builds
libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h
arch/arm/boot/compressed/.gitignore | 9 ---
arch/arm/boot/compressed/Makefile
efile messes.
Another nice thing is we no longer need to maintain the separate
libfdt_env.h since we can include , and the
diff stat also looks nice.
Signed-off-by: Masahiro Yamada
---
Changes in v2: None
arch/arm/boot/compressed/.gitignore | 9 ---
arch/arm/boot/compressed/Mak
Hi Rob,
(+CC: David Daney)
On Mon, Nov 4, 2019 at 11:00 PM Rob Herring wrote:
>
> On Fri, Nov 1, 2019 at 1:19 AM Masahiro Yamada
> wrote:
> >
> > These are kernel source code even though they are just two-line wrappers.
> >
> > Files without explicit license
On Tue, Nov 5, 2019 at 10:04 AM Rob Herring wrote:
>
> On Fri, Nov 1, 2019 at 3:12 AM Masahiro Yamada
> wrote:
> >
> > Copying source files during the build time may not end up with
> > as clean code as you expect.
> >
> > lib/fdt*.c simply wrap scripts/dtc
Hi Andrew,
I think you modified the commit log before applying this patch.
I just noticed a typo.
commit 411865d8dd2c31f56eefc54bc16fabb47e1bfb73
Author: Masahiro Yamada
Date: Wed Nov 6 16:07:08 2019 +1100
arch: sembuf.h: make uapi asm/sembuf.h self-contained
Uuserspace cannot
fixed-width types.
Accordingly, we already have S/U32_MAX for their max values.
So, we should not add (U)INT32_MAX to any more.
Instead, add them to the in-kernel libfdt_env.h to compile the
latest libfdt.
Signed-off-by: Masahiro Yamada
---
My initial plan was to change this in a series of 3
On Wed, Nov 13, 2019 at 4:13 PM Masahiro Yamada
wrote:
>
> The DTC v1.5.1 added references to (U)INT32_MAX.
>
> This is no problem for user-space programs since defines
> (U)INT32_MAX along with (u)int32_t.
>
> For the kernel space, libfdt_env.h needs to be adjusted be
ependencies to only be
> dtc.
>
> This change enables support 'dtbs_install' on some arches which were
> missing the target.
>
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Cc: Vineet Gupta
> Cc: Russell King
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Yoshi
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.
The GCC version checks in arch/powerpc/Makefile are obsolete now.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Mak
y be
> dtc.
>
> This change enables support 'dtbs_install' on some arches which were
> missing the target.
>
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Cc: Vineet Gupta
> Cc: Russell King
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Yoshinori S
Hi Rob,
2018-09-07 21:17 GMT+09:00 Rob Herring :
> On Fri, Sep 7, 2018 at 5:33 AM Masahiro Yamada
> wrote:
>>
>> 2018-09-06 8:53 GMT+09:00 Rob Herring :
>> > There is nothing arch specific about building dtb files other than their
>> > location under /arch/*/
2018-08-27 8:56 GMT+09:00 Rob Herring :
> On Sat, Aug 25, 2018 at 9:06 PM Masahiro Yamada
> wrote:
>>
>> Hi Rob,
>>
>>
>> 2018-08-22 6:55 GMT+09:00 Rob Herring :
>> > There is nothing arch specific about building dtb files other than their
>> &g
y be
> dtc.
>
> This change enables support 'dtbs_install' on some arches which were
> missing the target.
>
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Cc: Vineet Gupta
> Cc: Russell King
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Yoshinori S
t; +dtbs_install: dtbs
>> + $(Q)$(MAKE) $(dtbinst)=$(dtstree)
>> +
>> +all: dtbs
>> +
>> +endif
Ah, right.
Even x86 can enable OF and OF_UNITTEST.
Another solution might be,
guard it by 'depends on ARCH_SUPPORTS_OF'.
This is actually what ACPI does.
menuconfig ACPI
bool "ACPI (Advanced Configuration and Power Interface) Support"
depends on ARCH_SUPPORTS_ACPI
...
--
Best Regards
Masahiro Yamada
2018-09-13 11:51 GMT-04:00 Geert Uytterhoeven :
> Hi Yamada-san,
>
> On Wed, Sep 12, 2018 at 3:02 AM Masahiro Yamada
> wrote:
>> 2018-09-12 0:40 GMT+09:00 Rob Herring :
>> > On Mon, Sep 10, 2018 at 10:04 AM Rob Herring wrote:
>> >> There is nothing arch
e: prepare0
>>> +$(eval KBUILD_CFLAGS += -mstack-protector-guard-offset=$(shell awk
>>> '{if ($$2 == "TSK_STACK_CANARY") print $$3;}'
>>> include/generated/asm-offsets.h))
>>> +
>>
>> Great, it works !
>> Thanks, I have sent v3 of the patches.
>
> Cool.
>
> It would be good to here from someone who knows Kbuild better than me if
> this is acceptable or just a gross hack :)
I am fine with this solution.
Thanks.
--
Best Regards
Masahiro Yamada
#
> -------
> # Modules
>
--
Best Regards
Masahiro Yamada
Clean up the leftover of commit f2910f0e6835 ("powerpc: remove old
GCC version checks").
Signed-off-by: Masahiro Yamada
---
My patch had been sent earlier, with more clean-ups:
https://lore.kernel.org/patchwork/patch/977805/
Anyway, this cleans up the left-over of the Nicholas
Hi Rob,
2018年10月1日(月) 22:26 Rob Herring :
>
> On Mon, Oct 1, 2018 at 12:49 AM Masahiro Yamada
> wrote:
> >
> > Hi Rob,
> >
> >
> > 2018年9月29日(土) 0:43 Rob Herring :
> >
> > > +#
> > > --
be
> dtc.
>
> This change enables support 'dtbs_install' on some arches which were
> missing the target.
>
> Acked-by: Will Deacon
> Acked-by: Paul Burton
> Acked-by: Ley Foon Tan
> Cc: Masahiro Yamada
Please change this to
Acked-by: Masahiro Yamada
Thanks.
_QSPAN
arch/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx
arch/powerpc/Kconfig:config PCI_QSPAN
With your patch, PCI_QSPAN will become
a dead config option.
How about removing it entirely?
--
Best Regards
Masahiro Yamada
so it may be safest to say "Y" anyway.
> -
> -source "drivers/pci/Kconfig"
> -
> config GSC_DINO
> bool "GSCtoPCI/Dino PCI support"
> depends on PCI && GSC
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 56ff8f6d31fc..229a518b68cd 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -3,6 +3,18 @@
> # PCI configuration
> #
>
> +config HAS_PCI
> + bool
> +
> +menuconfig PCI
> + bool "PCI support"
> + depends on HAS_PCI
> +
> + help
> + This option enables support for the PCI local bus, including
> + support for PCI-X and the fundations for PCI Express support.
> + Say 'Y' here unless you know what you are doing.
> +
> source "drivers/pci/pcie/Kconfig"
>
> config PCI_MSI
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
@ -518,11 +521,6 @@ config ALPHA_SRM
>
> If unsure, say N.
>
> -config EISA
> - bool
> - depends on ALPHA_GENERIC || ALPHA_JENSEN || ALPHA_ALCOR ||
> ALPHA_MIKASA || ALPHA_SABLE || ALPHA_LYNX || ALPHA_NORITAKE || ALPHA_RAWHIDE
> - default y
> -
Better to add CONFIG_EISA=y to arch/alpha/defconfig
to not flip the default?
--
Best Regards
Masahiro Yamada
nce
> (when needed) and then handles everything in the bus-specific
> Kconfig file under drivers/.
>
Thanks for great work again.
However, I suspect some breakages
(not testing yet, just quick review by my eyes.)
I left some comments in individual patches.
--
Best Regards
Masahiro Yamada
On Mon, Oct 15, 2018 at 5:57 PM Christoph Hellwig wrote:
>
> On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote:
> > I think HAVE_ is a preferred prefix in this case according to this doc:
> > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kc
+ depends on EISA && SCSI
> select SCSI_SPI_ATTRS
> ---help---
> This driver is for NCR53c710 based SCSI host adapters.
>
> - It currently supports Compaq EISA cards and NCR MCA cards
> + It currently supports Compaq EISA cards.
>
> config SCSI_DC395x
> tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
kernel for an EISA-based machine.
> -
> - Otherwise, say N.
> -
> config SBUS
> bool
>
--
Best Regards
Masahiro Yamada
> Acked-by: Thomas Gleixner
> ---
--
Best Regards
Masahiro Yamada
Acked-by: Thomas Gleixner
--
Best Regards
Masahiro Yamada
HAS_DMA.
We could add 'depends on HAVE_PCI' or something
to guard it to avoid changing the logic.
config PCI_ENDPOINT
bool "PCI Endpoint Support"
depends on HAVE_PCI # Is this correct ??
depends on HAS_DMA
or better to have 'depends on PCI' ?
PCI ML is also CC'ed, so comments are appreciated.
--
Best Regards
Masahiro Yamada
rrect it easily by selecting
> HAVE_EISA for the right arm configs after this series.
What is your concern?
This absolutely looks dead to me.
> Suggested-by: Masahiro Yamada
> Signed-off-by: Christoph Hellwig
> ---
> arch/arm/Kconfig | 15 ---
> 1 file changed, 15 de
Your patch will
> cause Kconfig to complain for those which mandatorily have PCI but
> do not set HAVE_PCI.
Good catch!
But, adding a bunch of 'select HAVE_PCI' along with 'select PCI' is ugly.
Do you have any suggestion?
How about letting CONFIG_ARM to select HAVE_PCI ?
--
Best Regards
Masahiro Yamada
Evaluating cc-name invokes the compiler every time even when you are
not compiling anything, like 'make help'. This is not efficient.
The compiler type has been already detected in the Kconfig stage.
Use CONFIG_CC_IS_CLANG, instead.
Signed-off-by: Masahiro Yamada
---
On Tue, Oct 30, 2018 at 9:36 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index 17be664..338e827 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefil
Evaluating cc-name invokes the compiler every time even when you are
not compiling anything, like 'make help'. This is not efficient.
The compiler type has been already detected in the Kconfig stage.
Use CONFIG_CC_IS_CLANG, instead.
Signed-off-by: Masahiro Yamada
Acked-by: Michae
s/scsi/pcmcia/aha152x_core.c
> b/drivers/scsi/pcmcia/aha152x_core.c
> index dba3716511c5..24b89228b241 100644
> --- a/drivers/scsi/pcmcia/aha152x_core.c
> +++ b/drivers/scsi/pcmcia/aha152x_core.c
> @@ -1,3 +1,3 @@
> -#define PCMCIA 1
> +#define AHA152X_PCMCIA 1
> #define AHA152X_STAT 1
> #include "aha152x.c"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
1 - 100 of 473 matches
Mail list logo
