[PATCH] cpm2_pic: Allow correct flow_types for port C interrupts

2009-11-24 Thread Mark Ware
CPM2 Port C interrupts can be either falling edge, or either edge. Other external interrupts are either falling edge or active low. Signed-Off-By: Mark Ware --- arch/powerpc/sysdev/cpm2_pic.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a

Re: [PATCH] cpm2_pic: Allow correct flow_types for port C interrupts

2009-12-08 Thread Mark Ware
Any comments/Acks/Nacks on this patch? - Mark Mark Ware wrote: > CPM2 Port C interrupts can be either falling edge, or either edge. > Other external interrupts are either falling edge or active low. > > Signed-Off-By: Mark Ware > --- > arch/powerpc/sysdev

Re: [PATCH] cpm2_pic: Allow correct flow_types for port C interrupts

2009-12-08 Thread Mark Ware
Scott Wood wrote: > Mark Ware wrote: >> Mark Ware wrote: >>> CPM2 Port C interrupts can be either falling edge, or either edge. >>> Other external interrupts are either falling edge or active low. > [snip] >>> +/* Port C interru

[PATCH v2] cpm2_pic: Allow correct flow_types for port C interrupts

2009-12-08 Thread Mark Ware
Port C interrupts can be either falling edge, or either edge. Other external interrupts are either falling edge or active low. Signed-Off-By: Mark Ware --- Changed in v2: - Disallow rising edge only on Port C arch/powerpc/sysdev/cpm2_pic.c | 30 +++--- 1 files

Re: [PATCH v2] cpm2_pic: Allow correct flow_types for port C interrupts

2009-12-10 Thread Mark Ware
Scott Wood wrote: > Anton Vorontsov wrote: >>> +if ((flow_type != IRQ_TYPE_EDGE_BOTH) && + >>> (flow_type != IRQ_TYPE_EDGE_FALLING)) { >> >> I'd place one more tab here. > > Or better, align one "flow_type" with the other. > > -Scott > Thanks Anton and Scott. Scott's suggest

[PATCH v3] cpm2_pic: Allow correct flow_types for port C interrupts

2009-12-10 Thread Mark Ware
Port C interrupts can be either falling edge, or either edge. Other external interrupts are either falling edge or active low. Tested on a custom 8280 based board. Signed-off-by: Mark Ware --- Changed in v3: - Cosmetic improvements as suggested by Anton and Scott - Added tested note to changelog

[PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-04-21 Thread Mark Ware
Recent DMA changes result in a BUG() when NULL is passed to dma_alloc_coherent in place of a device. Signed-off-by: Mark Ware --- This patch fixes the BUG() during boot that has appeared during the 2.6.30 window. It has been tested and appears correct on my 8280 based board. Sent to both

[PATCH] fs_enet: Adjust BDs after tx error

2010-05-26 Thread Mark Ware
tx error occurs, TBPTR may sometimes point beyond BDs still marked as ready. This patch walks back through the BDs and points TBPTR to the earliest one marked as ready. Tested on a custom board with a MPC8280. Signed-off-by: Mark Ware --- drivers/net/fs_enet/mac-fcc.c | 49

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-03 Thread Mark Ware
Ben Dooks wrote: On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: Recent DMA changes result in a BUG() when NULL is passed to

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-10 Thread Mark Ware
Ben Dooks wrote: On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: Recent DMA changes result in a BUG() when NULL is passed to

[RFC/PATCH] powerpc: Don't use alloc_bootmem in cpm_uart_cpm2.c

2009-07-20 Thread Mark Ware
This is another alloc_bootmem() -> kzalloc() change, this time to fix the non-fatal badness caused when booting with a cpm2_uart console. Signed-Off-By: Mark Ware --- drivers/serial/cpm_uart/cpm_uart_cpm2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/driv

[PATCH v2] net: Rework mdio-ofgpio driver to use of_mdio infrastructure

2009-07-21 Thread Mark Ware
Changes to the fs_enet driver (aa73832c5a80d6c52c69b18af858d88fa595dd3c) cause kernel crashes when using the mdio-ofgpio driver. The following patch replicates similar changes made to the fs_enet mii-bitbang drivers. --- This version attempts to address Grant's comments below: Grant Likely wr

[PATCH v3] net: Rework mdio-ofgpio driver to use of_mdio infrastructure

2009-07-21 Thread Mark Ware
. Signed-off-by: Mark Ware Acked-by: Grant Likely --- The only changes in v3 are to the commit message. drivers/net/phy/mdio-gpio.c | 77 --- 1 files changed, 36 insertions(+), 41 deletions(-) diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio

Re: [PATCH v3] net: Rework mdio-ofgpio driver to use of_mdioinfrastructure

2009-07-22 Thread Mark Ware
On Thu 23/07/09 2:10 AM , David Miller da...@davemloft.net sent: > Your email client has massively corrupted this patch, I even tried > to fix it up but it's so bad that I just gave up half-way through. > > Please use an attachment or whatever is necessary to get this > patch submitted cleanly a

Re: Re: [PATCH v3] net: Rework mdio-ofgpio driver to use of_mdio infrastructure

2009-07-22 Thread Mark Ware
On Thu 23/07/09 2:10 AM , David Miller da...@davemloft.net sent: > Your email client has massively corrupted this patch, I even tried > to fix it up but it's so bad that I just gave up half-way through. > > Please use an attachment or whatever is necessary to get this > patch submitted cleanly a

[PATCH v3 RESEND] net: Rework mdio-ofgpio driver to use of_mdio infrastructure

2009-07-23 Thread Mark Ware
. Signed-off-by: Mark Ware Acked-by: Grant Likely --- The only changes in v3 are to the commit message. Resent due to patch mangling by mail client. This time for sure... drivers/net/phy/mdio-gpio.c | 77 --- 1 files changed, 36 insertions(+), 41 deletions

Re: [RFC/PATCH] powerpc: Don't use alloc_bootmem in cpm_uart_cpm2.c

2009-07-28 Thread Mark Ware
Scott Wood wrote: > On Mon, Jul 20, 2009 at 09:51:03PM +1000, Mark Ware wrote: >> This is another alloc_bootmem() -> kzalloc() change, this time to >> fix the non-fatal badness caused when booting with a cpm2_uart console. >> >> Signed-Off-By: Mark Ware >>

CPM2 mii-bitbang: Allowing mdio on port pins other than port C

2008-06-15 Thread Mark Ware
sl,mdio-pin = <12>;// PD12 fsl,mdc-pin = <15>; // PC15 The code remains backwards compatible, in that if only one reg range is present it is used for both. Is this a valid (and acceptable) way to extend the reg property? Is their a cleaner way I shou

RE: CPM2 mii-bitbang: Allowing mdio on port pins other than port C

2008-06-18 Thread Mark Ware
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:[EMAIL PROTECTED] > Sent: Monday, 16 June 2008 18:53 > To: linuxppc-dev@ozlabs.org > Cc: Mark Ware > Subject: Re: CPM2 mii-bitbang: Allowing mdio on port pins > other than port C > > Hi Mark,