On 12/01/2014 05:51 PM, Timur Tabi wrote:
On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote:
The driver creates the mapping by calling irq_of_parse_and_map(), so it
also has to dispose the mapping. But the easy way out is to simply use
platform_get_irq() instead of irq_of_parse_map(). In this
On 12/01/2014 07:50 AM, Markus Pargmann wrote:
[...]
devm_request_irq() is used by other drivers too, this should not be a
problem. Looking at the code it seems that irq_dispose_mapping may not
be necessary with devm_request_irq(). So I think it would be better to
remove irq_dispose_mapping() in
On 12/01/2014 07:48 PM, Timur Tabi wrote:
On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote:
The driver creates the mapping by calling irq_of_parse_and_map(), so it
also has to dispose the mapping.
I agree with Markus, this does seem weird. It sounds like you're saying
On 12/01/2014 09:11 PM, Timur Tabi wrote:
On 12/01/2014 02:01 PM, Arnd Bergmann wrote:
>Does this mean that fsl_ssi.c should not be calling
>irq_of_parse_and_map? How else should it get the IRQ?
platform_get_irq()
Ok, but that function also calls irq_create_of_mapping(). So it still
appears
On 07/12/2013 05:26 PM, Gerhard Sittig wrote:
[...]
> Lars, there is a checkpatch warning about a line longer than 80
> characters in the common xlate part -- I didn't dare to change your
> submission, and the part included here is verbatim from your patchwork
> 2331091 (original submission) and 25
On 07/14/2013 10:50 AM, Arnd Bergmann wrote:
> On Saturday 13 July 2013, Gerhard Sittig wrote:
>> [ MPC8308 knowledge required, see below ]
>>
>> On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote:
>>>
>>> On Friday 12 July 2013, Gerhard Sittig wrote:
+++ b/include/dt-bindings/dma/mpc512
On 07/12/2013 05:26 PM, Gerhard Sittig wrote:
[...]
]
> + if (mchan->tcd_nunits)
> + tcd->nbytes = mchan->tcd_nunits * 4;
> + else
> + tcd->nbytes = 64;
Just wondering where does the magic 64 come from?
__
On 07/14/2013 02:01 PM, Gerhard Sittig wrote:
> From: Alexander Popov
>
> introduce support for slave s/g transfer preparation and the associated
> device control callback in the MPC512x DMA controller driver, which adds
> support for data transfers between memory and peripheral I/O to the
> prev
[...]
a/Documentation/devicetree/bindings/sound/fsl,spdif.txt
b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> new file mode 100644
> index 000..a655800
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> @@ -0,0 +1,63 @@
> +Freescale Sony/Philips Digital In
On 08/05/2013 08:09 AM, Nicolin Chen wrote:
> This patch add S/PDIF controller driver for Freescale SoC.
>
> Reviewed-by: Lars-Peter Clausen
You are supposed to only add tags (Acked-by, Reviewed-by, Signed-off-by,
etc.) for other people if they have explicitly said they are OK with it.
On 10/17/2013 02:15 PM, Timur Tabi wrote:
> Xiubo Li wrote:
>> +res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +sai->base = devm_ioremap_resource(&pdev->dev, res);
>
> Why not use of_iomap()?
Because it won't check for conflicting resource regions.
- Lars
_
On 10/17/2013 03:22 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>>> >>+res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>>> >>+sai->base = devm_ioremap_resource(&pdev->dev, res);
>>> >
>>> >Why not u
On 10/17/2013 03:37 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>> >Maybe I've been out of the loop for too long, but why is that a particular
>>> >problem with this driver?
>
>> It is usually something you'd want to check in general to make su
On 10/17/2013 11:01 AM, Xiubo Li wrote:
[...]
> +static int fsl_sai_hw_params(struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params,
> + struct snd_soc_dai *cpu_dai)
> +{
> + int ret;
> +
> + ret = fsl_sai_hw_params_tr(substream, params, cpu_dai,
On 11/12/2013 08:35 AM, Li Xiubo wrote:
+static int fsl_sai_probe(struct platform_device *pdev) {
[...]
+
+ sai->dma_params_rx.addr = res->start + SAI_RDR;
+ sai->dma_params_rx.maxburst = 6;
+ index = of_property_match_string(np, "dma-names", "rx");
+ ret = of_parse_phan
On 05/30/2014 07:33 PM, David Daney wrote:
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe
wrote:
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct
gpio_chip *gpiochip)
On 05/31/2014 01:29 AM, Greg KH wrote:
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote:
On 05/30/2014 07:33 PM, David Daney wrote:
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe
wrote:
--- a/drivers/gpio/gpiolib.c
+++ b
On 06/09/2014 01:18 AM, Ben Dooks wrote:
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote:
On 05/30/2014 07:33 PM, David Daney wrote:
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe
wrote:
--- a/drivers/gpio/gpiolib.c
On 08/18/2014 10:38 AM, Shengjiu Wang wrote:
Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following
error:
sound/built-in.o: In function `fsl_sai_probe':
fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init'
sound/built-in.o: In function `fsl_esai_p
On 08/19/2014 09:41 AM, Shengjiu Wang wrote:
On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote:
On 08/18/2014 10:38 AM, Shengjiu Wang wrote:
Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following
error:
sound/built-in.o: In function `fsl_s
On 08/19/2014 10:36 AM, Lars-Peter Clausen wrote:
On 08/19/2014 09:41 AM, Shengjiu Wang wrote:
On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote:
On 08/18/2014 10:38 AM, Shengjiu Wang wrote:
Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the
followi
On 08/19/2014 12:35 PM, Takashi Iwai wrote:
At Tue, 19 Aug 2014 09:00:06 +,
li.xi...@freescale.com wrote:
How about the following :
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 5ae777a..d42f18c 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -15,7 +15
On 12/06/2013 09:27 PM, Alexander Popov wrote:
2013/10/6 Gerhard Sittig :
On Thu, Oct 03, 2013 at 18:06 +0400, Alexander Popov wrote:
+
+ spin_lock_irqsave(&mchan->lock, flags);
+
+ if (cfg->direction == DMA_DEV_TO_MEM) {
Note that cfg->direction is of a different type
On 01/19/2015 07:55 PM, Wolfram Sang wrote:
[...]
Let's get rid of this code before really nobody knows/understands
anymore what this was for and if it has a subtle use.
Getting rid of this is the right thing, cause it's just not how it should be
done, but unfortunately it is not as simple as
On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote:
On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote:
On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg Kroah-Hartman wrote:
On Mon, Jan 19, 2015 at 07:55:56PM +0100, Wolfram Sang wrote:
diff --git a/drivers/i2c/i2c-core.c b/dr
On 01/20/2015 08:12 AM, Greg Kroah-Hartman wrote:
On Tue, Jan 20, 2015 at 08:05:20AM +0100, Lars-Peter Clausen wrote:
On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote:
On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote:
On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg
On 09/04/2012 10:42 AM, Artem Bityutskiy wrote:
> Aiaiai! :-) [1] [2]
>
> I've build-tested this using aiaiai and it reports that this change breaks
> the build:
>
> dedekind@blue:~/git/maintaining$ ./verify ../l2-mtd/ mpc5121_nfc <
> ~/tmp/julia2.mbox
> Tested the patch(es) on top of the foll
x27;s memory footprint.
> It also is necessary for removing sysdevs from the kernel entirely in
> the future.
>
> Signed-off-by: Rafael J. Wysocki
For the jz4740 part:
Acked-and-tested-by: Lars-Peter Clausen
> ---
> arch/mips/alchemy/common/dbdma.c | 92
> +++---
uring
suspend/resume and since the PM core will automatically fallback directly
to using the device's PM ops if no bus PM ops are specified there is no
need to have any special ibmebus PM ops at all.
Signed-off-by: Lars-Peter Clausen
---
arch/powerpc/kernel/ibmeb
On 11/21/2016 10:52 AM, Michael Ellerman wrote:
> Lars-Peter Clausen writes:
>
>> There are no ibmebus driver that make use of legacy suspend/resume. This
>> patch removes the support for it from ibmebus framework, new ibmebus driver
>> (as unlikely as they are) wanti
30 matches
Mail list logo
