Re: [PATCH v2 1/3 RESEND] block: sed-opal: Implement IOC_OPAL_DISCOVERY

Useful. Thank you Reviewed-by: Jonathan Derrick On 8/18/2022 8:30 AM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Add IOC_OPAL_DISCOVERY ioctl to return raw discovery data to a SED Opal > application. This allows the application to display drive capabilities

Re: [PATCH v2 3/3 RESEND] block: sed-opal: keyring support for SED keys

LGTM thank you! Reviewed-by: Jonathan Derrick On 8/18/2022 8:30 AM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Extend the SED block driver so it can alternatively > obtain a key from a sed-opal kernel keyring. The SED > ioctls will indicate the source of

Re: [PATCH v2 2/3 RESEND] block: sed-opal: Implement IOC_OPAL_REVERT_LSP

Reviewed-by: Jonathan Derrick On 8/18/2022 8:30 AM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > This is used in conjunction with IOC_OPAL_REVERT_TPR to return a drive to > Original Factory State without erasing the data. If IOC_OPAL_REVERT_LSP >

Re: [PATCH v4 3/3] block: sed-opal: keystore access for SED Opal keys

LGTM besides comment below Reviewed-by: Jonathan Derrick On 8/19/2022 4:31 PM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Allow for permanent SED authentication keys by > reading/writing to the SED Opal non-volatile keystore. > > Signed-off-by: Greg Joyce

Re: [PATCH v4 2/3] powerpc/pseries: PLPKS SED Opal keystore support

LGTM Reviewed-by: Jonathan Derrick On 8/19/2022 4:31 PM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Define operations for SED Opal to read/write keys > from POWER LPAR Platform KeyStore(PLPKS). This allows > for non-volatile storage of SED Opal keys. > >

Re: [PATCH v4 1/3] block: sed-opal: SED Opal keystore

Reviewed-by: Jonathan Derrick On 8/19/2022 4:31 PM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Add read and write functions that allow SED Opal keys to stored > in a permanent keystore. > > Signed-off-by: Greg Joyce > --- > block/Makefile |