Re: ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS

2013-04-30 Thread Jeff Garzik
On 04/30/2013 02:41 AM, Anthony Foiani wrote: Apologies for resurrecting a very old thread, but... On 05/30/2012 02:14 PM, Anthony Foiani wrote: Maybe someone who knows devtree really well could crank that out in a few minutes... but I'm not that person. :) Well, I wasn't last year, but this

Re: [PATCH] fsl/sata: create a sysfs entry for rx water mark

2013-04-03 Thread Jeff Garzik
On 03/04/2013 02:20 AM, Qiang Liu wrote: Support config RX WATER MARK via sysfs when running at run-time; A wrokaround for fix the exception happened to some WD HDD, found on WD3000HLFS-01G6U1, WD3000HLFS-01G6U0, some SSD disks. The read performance is also regression (about 30%) when use default

Re: [PATCH][SDK v1.2] sata: I/O load balancing

2012-01-17 Thread Jeff Garzik
On 01/13/2012 04:57 AM, Liu Qiang-B32616 wrote: No, I didn't test small file. I think this won't affect system load. I can have a test and describe the result in next patch. Please do... ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org ht

Re: [PATCH V2] fsl-sata: I/O load balancing

2012-02-10 Thread Jeff Garzik
On 01/19/2012 09:19 PM, qiang@freescale.com wrote: From: Qiang Liu Reduce interrupt signals through reset Interrupt Coalescing Control Reg. Provide dynamic method to adjust interrupt signals and timer ticks by sysfs. It is a tradeoff for different applications. Signed-off-by: Qiang Liu ---

Re: [PATCH V3] fsl-sata: add support for interrupt coalsecing feature

2012-03-02 Thread Jeff Garzik
On 02/28/2012 09:54 PM, Liu Qiang-B32616 wrote: Hi Jeff, Do you plan to apply it to upstream, or any suggestions? Thanks. This patch has been in libata-dev (and thus linux-next) for about 2 weeks... ___ Linuxppc-dev mailing list Linuxppc-dev@lists

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-12 Thread Jeff Garzik
On 04/03/2012 07:56 AM, Sergei Shtylyov wrote: Hello. On 03-04-2012 14:12, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyen --- Changes for v2: - Use git rename feature to change the driver to the newname and for easier review. arch/powerpc/boot/dts/bluestone.dts | 21 + drivers/ata/Mak

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-13 Thread Jeff Garzik
On 04/13/2012 03:18 AM, Thang Nguyen wrote: Thanks Jeff and Sergei, As your suggestion, I will separate the patch into smaller patches and support more features on the SATA DWC driver. The patches I intend to do on the SATA DWC are as below: - Support hardreset: currently the hardreset is not

Re: [PATCH RESEND] pata_mpc52xx: driver needs BMDMA

2010-12-24 Thread Jeff Garzik
On 12/22/2010 10:50 AM, Wolfram Sang wrote: Found by this build-error if BMDMA is disabled: drivers/ata/pata_mpc52xx.c: In function 'mpc52xx_ata_init_one': drivers/ata/pata_mpc52xx.c:662: error: 'ata_bmdma_interrupt' undeclared (first use in this function) ... Move the Kconfig entry to the pro

Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops

2011-01-18 Thread Jeff Garzik
On 01/09/2011 05:48 PM, Tejun Heo wrote: pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which triggers BUG_ON() when a DMA command is issued. Fix it. Signed-off-by: Tejun Heo Reported-by: Roman Fietze Cc: Sergei Shtylyov Cc: sta...@kernel.org --- drivers/ata/pata_mpc52xx.c |2 +

Re: [PATCH] ATA: Add FSL sata v2 controller support

2011-01-18 Thread Jeff Garzik
l.c patch for data_snoop variability directly keys off a call to platform-specific detail (of_device_is_compatible call). Acked-by: Jeff Garzik ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH][v3] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-14 Thread Jeff Garzik
On 03/09/2011 02:17 AM, Prabhakar Kushwaha wrote: When a single device error is detected, the device under the error is indicated by the error bit set in the DER. There is a one to one mapping between register bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP device 0 and bit 1 re

Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-09-08 Thread Jeff Garzik
On 07/29/2009 12:03 PM, ashish kalra wrote: From: Ashish Kalra Date: Wed, 29 Jul 2009 21:15:49 +0530 Fix for non-ncq & ncq commands causing timeouts when both are issued simultaneously to the same device. Signed-off-by: Ashish Kalra --- drivers/ata/sata_fsl.c | 1 + 1 files changed, 1 insertio

Re: [RESEND][PATCH] sata_fsl: hard and soft reset split

2009-09-10 Thread Jeff Garzik
On 06/29/2009 09:26 AM, ashish kalra wrote: Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient & device and PMP detection more reliable. Also includes fix for PMP support, driver tested with Sil3726, Sil4726 & Exar PMP controllers. Signed-off-by: Ashish K

Re: [PATCH] sata_fsl: Split hard and soft reset

2009-11-16 Thread Jeff Garzik
On 11/05/2009 10:02 AM, Kumar Gala wrote: On Oct 16, 2009, at 11:44 AM, Anton Vorontsov wrote: From: Jiang Yutang Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient & device and PMP detection more reliable. Also includes fix for PMP support, driver te

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/16/2009 01:19 AM, Vivek Mahajan wrote: The following patch adds MSI support. Some platforms may have broken MSI, so those are defaulted to use legacy PCI interrupts. Signed-off-by: Vivek Mahajan --- drivers/ata/sata_sil24.c |9 + 1 files changed, 9 insertions(+), 0 deletions

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/17/2009 01:59 AM, Mahajan Vivek-B08308 wrote: From: Grant Grundler [mailto:grund...@google.com] Sent: Monday, November 16, 2009 11:08 PM +static int sata_sil24_msi;/* Disable MSI */ +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); +MODULE_PARM_DESC(msi, "Enable MSI (Default: fa

Re: [PATCH] sata_fsl: Split hard and soft reset

2009-11-19 Thread Jeff Garzik
On 10/16/2009 12:44 PM, Anton Vorontsov wrote: From: Jiang Yutang Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient& device and PMP detection more reliable. Also includes fix for PMP support, driver tested with Sil3726, Sil4726& Exar PMP controllers.

Re: [PATCH][v3] Add asynchronous notification support

2009-11-19 Thread Jeff Garzik
On 07/01/2009 11:29 AM, ashish kalra wrote: Enable device hot-plug support on Port multiplier fan-out ports v3 fixes whitespace/identation issues Signed-off-by: Ashish Kalra --- drivers/ata/sata_fsl.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) applied #upstream _

Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()

2009-12-02 Thread Jeff Garzik
free to carry this in your tree as well. git should be able to sort it out. Acked-by: Jeff Garzik ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-03 Thread Jeff Garzik
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: This is a libata driver for the "macio" IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotplug and suspend/resu

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Jeff Garzik
Michael Ellerman wrote: On Tue, 2009-04-07 at 19:36 -0500, Timur Tabi wrote: On Tue, Apr 7, 2009 at 6:57 PM, Tejun Heo wrote: Hmmm... that means intx isn't set by default. I'm not sure what is the right thing to do here. I think it's something which should be handled by the PCI layer. Oh w

Re: "ahci: drop intx manipulation on msi enable" breaks ULI M1575

2009-04-08 Thread Jeff Garzik
Michael Ellerman wrote: On Wed, 2009-04-08 at 23:23 -0500, Kumar Gala wrote: On Apr 8, 2009, at 6:53 PM, Michael Ellerman wrote: On Wed, 2009-04-08 at 17:15 -0500, Timur Tabi wrote: On Wed, Apr 8, 2009 at 4:31 PM, Tejun Heo wrote: Hmmm... for now, I think it would be best to revert the orig

Re: [PATCH] pata_mpc52xx: optimizing code size by change of ATA timing data types

2010-03-01 Thread Jeff Garzik
On 02/16/2010 02:41 PM, Grant Likely wrote: [cc'd linux-kernel, linux-ide and Jeff Garzik] Hi Roman. you should use ./scripts/get_maintainer.pl to make sure you're cc'ing the right people when posting patches. You should repost so that Jeff has a copy of the patch to pick up (a

Re: [PATCH 21/37] drivers/ata: use .dev.of_node instead of .node in struct of_device

2010-03-11 Thread Jeff Garzik
On 03/11/2010 01:31 PM, Sergei Shtylyov wrote: Hello. Grant Likely wrote: .node is being removed Signed-off-by: Grant Likely --- drivers/ata/pata_macio.c | 2 +- drivers/ata/pata_of_platform.c | 2 +- drivers/ide/pmac.c | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) Should

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 01>

2010-03-17 Thread Jeff Garzik
On 03/17/2010 08:03 AM, Stefan Roese wrote: Hi Rup, On Wednesday 17 March 2010 05:23:16 Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Apart from the other comments, did you take a look at the latest version of this driver in our

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-06 Thread Jeff Garzik
On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. +struct sata_dwc_host_priv { + + void __iomem *scr_addr_sstatus; + u32 sata_dwc_sactive_issued; + u32 sata_dwc_sactive_queued; +

Re: known working sata_sil24.c setup on powerpc platforms?

2011-04-06 Thread Jeff Garzik
On 04/06/2011 01:48 PM, Moffett, Kyle D wrote: On Apr 06, 2011, at 13:00, Leon Woestenberg wrote: after investigating problems with sata_sil24.c on a freescale p2020 soc, I wonder if this driver works on powerpc at all? Does anyone know of a working setup of sata_sil24 on a big endian powerpc s

Re: [PATCH] libata/sas: only set FROZEN flag if new EH is supported

2011-06-21 Thread Jeff Garzik
On 06/21/2011 04:30 PM, Brian King wrote: Looks good to me. Jeff/Tejun - any issues with merging this? Looks good here too -- though of course we want to move towards purging old-EH paths :) Queued... ___ Linuxppc-dev mailing list Linuxppc-dev@li

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-14 Thread Jeff Garzik
On 05/05/2010 01:57 PM, Rupjyoti Sarmah wrote: +static void clear_interrupt_bit(struct sata_dwc_device *hsdev, u32 bit) +{ + out_le32(&hsdev->sata_dwc_regs->intpr, +in_le32(&hsdev->sata_dwc_regs->intpr)); +} + +static u32 qcmd_tag_to_mask(u8 tag) +{ + return 0x00

Re: [PATCH v1]460EX on-chip SATA driver

2010-06-30 Thread Jeff Garzik
On 06/30/2010 02:47 PM, Wolfgang Denk wrote: Dear Rupjyoti Sarmah, In message<3b928476b2fffdcf0694e5436e8a4...@mail.gmail.com> you wrote: I took the mainline kernel v2.6.35-rc3 and downloaded using the git download link. I created the patch on 6/24/2010 after doing a git pull. I don;t think

Re: [PATCH v2]460EX on-chip SATA driver

2010-07-14 Thread Jeff Garzik
On 07/06/2010 07:06 AM, Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by: Prodyut Hazarika --- This patch incorporates the changes advised in the mailing list

Re: [PATCH 1/2] Add support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Feng Kan wrote: Signed-off-by: Feng Kan --- drivers/ata/Kconfig| 76 +- drivers/ata/Makefile |1 + drivers/ata/sata_dwc.c | 2047 3 files changed, 2091 insertions(+), 33 deletions(-) create mode 100644 drivers/ata/sata_dwc.c I don'

Re: [PATCH 1/2] Add support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: Patch 2/2 is just adding the device-tree bits to the platform for this driver to match against, so it's no big deal. However, Feng, we already mentioned that you do a lot of unrelated changes to the Kconfig file that shouldn't be part of this patch, just add the entr

Re: [PATCH 1/2] Added support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Wolfgang Denk wrote: Dear Feng Kan, In message <1241211767-32697-1-git-send-email-f...@amcc.com> you wrote: This adds support for the Designware SATA controller. Signed-off-by: Feng Kan Signed-off-by: Mark Miesfeld --- drivers/ata/Kconfig| 10 + drivers/ata/Makefile |1 + driver

Re: [PATCH 1/3 v3] Added support for Designware SATA controller driver

2009-05-11 Thread Jeff Garzik
Feng Kan wrote: Signed-off-by: Feng Kan Signed-off-by: Mark Miesfeld --- drivers/ata/Kconfig| 10 + drivers/ata/Makefile |1 + drivers/ata/sata_dwc.c | 2053 3 files changed, 2064 insertions(+), 0 deletions(-) create mode 100644 dri

Re: [PATCH v3] sata_fsl: Fix compile warnings

2009-05-15 Thread Jeff Garzik
Kumar Gala wrote: We we build with dma_addr_t as a 64-bit quantity we get: drivers/ata/sata_fsl.c: In function 'sata_fsl_fill_sg': drivers/ata/sata_fsl.c:340: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'dma_addr_t' Signed-off-by: Kumar Gala --- * v2: fixed extra

Re: [PATCH] sata_fsl: Fix the command description of FSL SATA controller

2009-05-15 Thread Jeff Garzik
Kumar Gala wrote: From: Dave Liu The bit 11 of command description is reserved bit in Freescale SATA controller and needs to be set to '1'. This is needed to make sure the last write from the controller to the buffer descriptor is seen before an interrupt is raised. Signed-off-by: Dave Liu S

Re: [PATCH] sata_fsl: Add power mgmt support

2009-06-22 Thread Jeff Garzik
Kumar Gala wrote: From: Dave Liu Signed-off-by: Dave Liu Signed-off-by: Liu Yu Signed-off-by: Kumar Gala --- drivers/ata/sata_fsl.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) applied ___ Linux

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-12 Thread Jeff Garzik
Anton Vorontsov wrote: > Otherwise oops will happen if ethernet device has not been opened: > > Unable to handle kernel paging request for data at address 0x014c > Faulting instruction address: 0xc016f7f0 > Oops: Kernel access of bad area, sig: 11 [#1] > MPC85xx > NIP: c016f7f0 LR: c01722a0 CT

Re: [PATCH] [POWERPC] pasemi: Move electra-ide to pata_of_platform

2008-01-15 Thread Jeff Garzik
Olof Johansson wrote: > Move electra-ide glue over to the new pata_of_platform framework, and > add the quirks needed to that driver. > > --- > > Applied with the rest of the patches to pasemi.git for-2.6.25 > > arch/powerpc/platforms/pasemi/electra_ide.c | 96 > -

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-30 Thread Jeff Garzik
Jochen Friedrich wrote: > fec.c is only used on M68k Coldfire CPUs. Remove leftover > PowerPC code from this driver. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > drivers/net/fec.c | 136 +--- > 1 files changed, 3 insertions(+), 1

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Anton Vorontsov wrote: > On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: >> Anton, >> >> it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and >> was selecting FIXED_MII_100_FDX which is gone. >> >> Can you look into this. I get the following warning now: >> >> scripts

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Kumar Gala wrote: > > On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: > >> Anton Vorontsov wrote: >>> On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: >>>> Anton, >>>> >>>> it looks like the "TI AR7 CPMAC Ethernet s

Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: > On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: >> On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: >> >>> It isn't used anywhere, so remove it. If we'll ever need something >>> like this, we'll use compatible property instead. >>> >>> Signed-off-by: Anton Vor

Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: > - uccf should be set to NULL to not double-free memory on > subsequent calls; > - ind_hash_q and group_hash_q lists should be initialized in the > probe() function, instead of struct_init() (called by open()), > otherwise there will be an oops if ucc_geth_driver remov

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Jeff Garzik wrote: > Doug Maxey wrote: >> Cc: Jan-Bernd Themann <[EMAIL PROTECTED]> >> Signed-off-by: Doug Maxey <[EMAIL PROTECTED]> >> --- >> drivers/net/ehea/ehea.h|3 +++ >> drivers/net/ehea/ehea_hw.h |8 >> 2 files change

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Doug Maxey wrote: > Cc: Jan-Bernd Themann <[EMAIL PROTECTED]> > Signed-off-by: Doug Maxey <[EMAIL PROTECTED]> > --- > drivers/net/ehea/ehea.h|3 +++ > drivers/net/ehea/ehea_hw.h |8 > 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 _

Re: [PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Due to changes in the struct device_driver there is no direct > access to its kobj any longer. The kobj was used to create > sysfs links between eHEA ethernet devices and the driver. > This patch removes the affected sysfs links to resolve > the build problems. > > Signe

Re: [PATCH] [POWERPC] iSeries: fix section mismatch in iseries_veth

2008-02-05 Thread Jeff Garzik
Stephen Rothwell wrote: > WARNING: vmlinux.o(.text+0x25dca0): Section mismatch in reference from the > function .veth_probe() to the function .init.text:.veth_probe_one() > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> > --- > drivers/net/iseries_veth.c |2 +- > 1 files changed, 1 in

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-06 Thread Jeff Garzik
Josh Boyer wrote: > On Thu, 31 Jan 2008 10:14:58 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > >> On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: >>> On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt <[EMAI

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2008-02-06 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

Re: [PATCH 3/5 v3] Tsi108_eth: remove not needed code

2008-02-11 Thread Jeff Garzik
Alex Bounine wrote: > Code clean-up for tsi108_eth network driver. > This patch removes not needed dummy read and the corresponding comment. > The PHY logic requires two reads from the status register to get > current link status. This is done correctly inside mii_check_media(). > > Signed-off-by:

Re: [PATCH 1/5 v2] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: > Bug fix for tsi108_eth network driver. > This patch adds missing linking to driver data. > > Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> > --- > > diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c > linux-2.6.24-fix/drivers/net/tsi108_eth.c > --- linux-2.6.2

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-11 Thread Jeff Garzik
Josh Boyer wrote: > On Wed, 6 Feb 2008 13:21:59 +0100 > Stefan Roese <[EMAIL PROTECTED]> wrote: > >> With the removal the the "rgmii-interface" device_type property from the >> dts files, the newemac driver needs an update to only rely on compatible >> property. >> >> Signed-off-by: Stefan Roese

Re: [PATCH 1/5] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: > Bug fix for tsi108_eth network driver. > This patch adds missing linking to driver data. > > Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> > --- > > diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c > linux-2.6.24-fix/drivers/net/tsi108_eth.c > --- linux-2.6.2

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: > This patch adds kdump support to the ehea driver. As the firmware doesn't free > resource handles automatically, the driver has to run an as simple as possible > free resource function in case of a crash shutdown. The function iterates over > two arrays freeing all resource ha

Re: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-20 Thread Jeff Garzik
Scott Wood wrote: > The lock acquisition in fs_ioctl() does not appear to actually be necessary, > and thus is simply removed. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > This fixes the following bug: > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html > > drivers/

Re: [PATCH] sata_fsl: fix build with ATA_VERBOSE_DEBUG

2008-02-23 Thread Jeff Garzik
Anton Vorontsov wrote: > This patch fixes build and few warnings when ATA_VERBOSE_DEBUG > is defined: > > CC drivers/ata/sata_fsl.o > drivers/ata/sata_fsl.c: In function ‘sata_fsl_fill_sg’: > drivers/ata/sata_fsl.c:338: warning: format ‘%x’ expects type ‘unsigned int’, > but argument 3 has

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Jeff Garzik
Olof Johansson wrote: > On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: >> Olof Johansson writes: >> >>> Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch >>> the dma_lib in the platform code as well, but it's easier if it's all >>> merged through netdev to avoid

Re: [PATCH] fs_enet: Update for API changes

2007-10-17 Thread Jeff Garzik
Scott Wood wrote: > This driver was recently broken by several changes for which this > driver was not (or was improperly) updated: > > 1. SET_MODULE_OWNER() was removed. > 2. netif_napi_add() was only being called when building with > the old CPM binding. > 3. The received/budget test was backwar

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Jeff Garzik
Anton Vorontsov wrote: > Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 > causing NAPI-less ethernet malfunctioning. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> applied ___

Re: [PATCH] fix EMAC driver for proper napi_synchronize API

2007-10-17 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The EMAC driver "fix" was merged by mistake before the dust had settled on > the new napi synchronize interface (and before it got merged). The final > version of that function is spelled without underscores. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECT

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Jeff Garzik
Grant Likely wrote: > On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: >> Domen Puncer wrote: >>> Hello! >>> >>> If there are no objections, I would like to get this merged >>> when bestcomm goes in (any time now?). >>> >>> I

Re: [PATCH] Fix build break in tsi108.c

2007-10-19 Thread Jeff Garzik
Olof Johansson wrote: > Fix build break: > > drivers/net/tsi108_eth.c: In function 'tsi108_init_one': > drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev' > drivers/net/tsi108_eth.c:1633: warning: too few arguments for format > make[2]: *** [drivers/net/tsi108_eth.o] Error 1 > > > S

Re: [PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-19 Thread Jeff Garzik
Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Missing MODULE_LICENSE(), loading this module taints the kernel. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > drivers/net/phy/mdio-bitbang.c |2 ++ > 1 file changed, 2 insertions(+) applied this and the NAPI_How

Re: [PATCH] pasemi_mac: fix typo

2007-10-23 Thread Jeff Garzik
Olof Johansson wrote: > Add missing &: > > drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx': > drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch' > makes pointer from integer without a cast > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > diff --git a/

Re: [PATCH] Use of_get_next_child() in k2_sata_proc_info()

2007-10-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > On Wed, 2007-10-24 at 14:25 +1000, Michael Ellerman wrote: >> k2_sata_proc_info() uses its own hand-rolled loop to check a nodes >> children for a property, this is not safe WRT refcounting, so fix it >> to use of_get_next_child(). >> >> Signed-off-by: Michael Ellerm

Re: [PATCH] ehea: fix port_napi_disable/enable

2007-10-25 Thread Jeff Garzik
Jan-Bernd Themann wrote: > napi_disable / napi_enable must be applied on all ehea queues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxp

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Domen Puncer wrote: > +static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk) > +{ > + while (!bcom_queue_full(rxtsk)) { > + struct sk_buff *skb; > + struct bcom_fec_bd *bd; > + > + skb = dev_alloc_skb(FEC_RX_BUFFER_SIZE); > + if (skb ==

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Dale Farnsworth wrote: > IMO, it's still a requirement that we call dma_unmap_single() for > each call to dma_map_single(). Yep... ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] ehea: add kexec support

2007-10-29 Thread Jeff Garzik
Jan-Bernd Themann wrote: > eHEA resources that are allocated via H_CALLs have a unique identifier each. > These identifiers are necessary to free the resources. A reboot notifier > is used to free all eHEA resources before the indentifiers get lost, i.e > before kexec starts a new kernel. > > Sign

Re: [PATCH v4.3] FEC - fast ethernet controller for mpc52xx

2007-10-29 Thread Jeff Garzik
Domen Puncer wrote: > On 26/10/07 07:18 -0700, Dale Farnsworth wrote: >> On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote: >>> +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) >>> +{ >>> + struct net_device *dev = dev_id; >>> + struct mpc52xx_fec_priv *priv = netd

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-30 Thread Jeff Garzik
Dale Farnsworth wrote: > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: >> This commit made an incorrect assumption: >> -- >> Author: Lennert Buytenhek <[EMAIL PROTECTED]> >> Date: Fri Oct 19 04:10:10 2007 +0200 >> >> mv643xx_eth: Move ethernet register definitions into p

Re: [PATCH 1/2] pasemi_mac: Don't set replace-source-address descriptor bits

2007-11-08 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 10:20:39PM -0600, Olof Johansson wrote: > Don't use the "replace source address with local MAC address" bits, since > it causes problems on some variations of the hardware due to an erratum. > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-2 ___

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-19 Thread Jeff Garzik
Kim Phillips wrote: > On Mon, 5 Nov 2007 12:15:30 -0600 > Kim Phillips <[EMAIL PROTECTED]> wrote: > >> Hello all, >> >> the following patches fix RGMII timing for rev. 2.1 of the mpc8360, >> according to erratum #2 (erratum text included below). Basically the >> most intrusive part is the additio

Re: [PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > On Fri, 2007-11-23 at 22:07 +0300, Valentine Barshak wrote: > >> These patches have some minor ibm_newemac fixes. > > All 3 patches look good, thanks. I'll sign them off and forward them > to Jeff in my next batch. > > Jeff, did you already pick up my previous dro

Re: [PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-23 Thread Jeff Garzik
Thomas Klein wrote: > Using own tx_packets counter instead of firmware counters. > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c |9 +++-- > 2 files changed, 8 insertions(+), 3 deletions(-) applies 1-2

Re: [PATCH] ibm_newemac: Fix possible lockup on close

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > It's a bad idea to call flush_scheduled_work from within a > netdev->stop because the linkwatch will occasionally take the > rtnl lock from a workqueue context, and thus that can deadlock. > > This reworks things a bit in that area to avoid the problem. > > Signed-

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the PATA Platform driver using OF infrastructure. > > Mostly it's just a wrapper around a bit modified pata_platform > driver. > > Patches are well split for the easier review: > > First one factors out platform_device specific bits and modifies > pa

Re: [PATCH 0/8] ibm_newemac: Candidate patches for 2.6.25

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > Here are the patches I have pending for EMAC. With some non-released > patches from Hugh Blemings, I get a taishan (440GX) booting now, > in addition to Ebony (440GP) and various 405GP boards. > > This is 2.6.25 material except for patch #1 which has already been >

Re: [PATCH 1/3][RESEND] phylib: add PHY interface modes for internal delay for tx and rx only

2007-12-01 Thread Jeff Garzik
Kim Phillips wrote: > Allow phylib specification of cases where hardware needs to configure > PHYs for Internal Delay only on either RX or TX (not both). > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> > Acked-by: Li Yang <[EMAIL PROTECTED]> > -

Re: [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This helps to allow the Fedora installer to use the built-in Ethernet on > the Efika for a network install. > > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> > > --- a/drivers/net/fec_mpc52xx.c > +++ b/drivers/net/fec_mpc52xx.c > @@ -971,6 +971,8 @@ mpc52xx_fec_probe

Re: [PATCH] Stop phy code from returning success to unknown ioctls.

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This kind of sucks, and prevents the Fedora installer from using the > device for network installs... > > [EMAIL PROTECTED] phy]# iwconfig eth0 > > Warning: Dri

Re: [PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-12-01 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: RX/TX ring management cleanup > > Prepare a bit for supporting multiple TX queues by cleaning up some > of the ring management and shuffle things around a bit. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-12 ___

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the second spin of the OF-platform PATA driver and > related patches. > > Changes since RFC: > - nuked drivers/ata/pata_platform.h; > - powerpc bits: proper localbus node added. > > > Thanks for the previous review! This time I'm collecting acks, > d

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > Turns out we're freeing the skb when we detect CRC error, but we're > not clearing out info->skb. We could either clear it and have the stack > reallocate it, or just leave it and the rx ring refill code will reuse > the one that was allocated. > > Reusing a freed skb obvio

Re: [PATCH] gianfar: fix compile warning

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Eliminate an uninitialized variable warning. The code is correct, but > a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. > Since addr has never been initialized, and the compiler doesn't know > what dma_al

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-04 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This patch eliminates the warning of unused return values when the driver > registers it sysfs files. Now the driver will print an error if it is > unable to register the sysfs files. > > It also eliminates the macros used to wrap

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > [POWERPC] Move electra-ide support over to new pata_of_platform framework > > Move electra-ide glue over to the new pata_of_platform framework, and > add the quirks needed to that driver. > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > I'll remove th

Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-12-07 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > From: Stefan Roese <[EMAIL PROTECTED]> > > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > These PHY chips are used on PowerPC 440EPx boards. > The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> > > Signed-o

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Jeff Garzik
Kumar Gala wrote: > > On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: > >> Updates the ucc_geth device driver to check the new rx-clock-name and >> tx-clock-name properties first. If present, it uses the new function >> qe_clock_source() to obtain the clock source. Otherwise, it checks the >> dep

Re: [PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-14 Thread Jeff Garzik
Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > Jeff, can you ack this to go through Paul's tree > (assuming nothing wrong with it)? > > drivers/net/gianfar.c | 137 > - > drivers/net/gianfar.h | 13 +++- > driv

Re: [PATCH] [NET][POWERPC] ucc_geth: really fix section mismatch

2007-12-17 Thread Jeff Garzik
Anton Vorontsov wrote: > Commit ed7e63a51d46e835422d89c687b8a3e419a4212a has tried to fix > section mismatch: > > WARNING: vmlinux.o(.init.text+0x17278): Section mismatch: reference to > .exit.text:uec_mdio_exit (between 'ucc_geth_init' and 'uec_mdio_init') > > But that mismatch still happens. >

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-17 Thread Jeff Garzik
Jochen Friedrich wrote: > This patch adds support to use the fixed-link property > of an ethernet node to fs_enet for the > CONFIG_PPC_CPM_NEW_BINDING case. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c |9 - > 1 files changed, 8 in

Re: [PATCH] [POWERPC] pasemi: export pasemi_dma_init()

2007-12-17 Thread Jeff Garzik
Olof Johansson wrote: > Forgot to export this one. Needed when pasemi_mac is compiled as a module. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > Jeff, since the dma_lib stuff went up through netdev-2.6, please apply and > feed this one up with the rest. > > > Thanks, > > O

Re: [PATCH] [POWERPC] pasemi: export pasemi_dma_init()

2007-12-17 Thread Jeff Garzik
Olof Johansson wrote: > Forgot to export this one. Needed when pasemi_mac is compiled as a module. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > Jeff, since the dma_lib stuff went up through netdev-2.6, please apply and > feed this one up with the rest. > > > Thanks, > > O

Re: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

2007-08-07 Thread Jeff Garzik
Thomas Klein wrote: > Fix: Workqueue ehea_driver_wq was not destroyed > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c |1 + > 2 files changed, 2 insertions(+), 1 deletions(-) applied 1-3 to #upstream-fixes

  1   2   3   >