uto-loading for the drivers of devices registered
with OF but that don't have a of_match_table.
Although arguably, those drivers were relying on the assumption that a
MODALIAS=i2c: would always be reported even for the OF case which
is not the true on other subsystems.
[0]: https://lkml.org/
The I2C core always reports the MODALIAS uevent as "i2c:
---
drivers/macintosh/therm_windtunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/therm_windtunnel.c
b/drivers/macintosh/therm_windtunnel.c
index 109dcaa15934..97269567ec01 100644
--- a/drivers/macintosh/therm
The I2C core always reports the MODALIAS uevent as "i2c:
---
drivers/macintosh/therm_windtunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/therm_windtunnel.c
b/drivers/macintosh/therm_windtunnel.c
index 97269567ec01..68dcbcb4fc5b 100644
--- a/drivers/macintosh/therm
instead so the module can be auto-loaded and also
report the correct alias using sysfs:
$ cat /sys/class/i2c-adapter/i2c-8/8-004b/modalias
of:NtrackpadTCatmel,maxtouch
Signed-off-by: Javier Martinez Canillas
---
drivers/i2c/i2c-core.c | 8
1 file changed, 8 insertions(+)
diff --git
Hello Dmitry,
Thanks a lot for your feedback.
On 07/30/2015 06:37 PM, Dmitry Torokhov wrote:
> On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote:
>> Hi Javier,
>>
>> On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote:
>>>
Hello Michael,
On 08/18/2015 12:24 PM, Michael Ellerman wrote:
> On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote:
>> The I2C core always reports the MODALIAS uevent as "i2c:> regardless if the driver was matched using the I2C id_table or the
>> of_mat
Hello Michael,
On 08/19/2015 02:51 AM, Michael Ellerman wrote:
> On Tue, 2015-08-18 at 12:35 +0200, Javier Martinez Canillas wrote:
>> Hello Michael,
>>
>> On 08/18/2015 12:24 PM, Michael Ellerman wrote:
>>> On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Can
c source file:
https://elixir.bootlin.com/linux/v6.6-rc2/source/arch/powerpc/kernel/pci-common.c#L524
That function indeed doesn't use the file argument. So your patch looks
correct to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> * fix commit message (Christophe)
> v3:
> * rename fb_pgprotect() to pgprot_framebuffer() (Arnd)
>
> Signed-off-by: Thomas Zimmermann
> Reviewed-by: Arnd Bergmann
> Acked-by: Geert Uytterhoeven # m68k
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
gin
> Cc: Christophe Leroy
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> drivers/video/fbdev/ps3fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
rivers/video/fbdev/ps3fb.c | 7 ++-
> 2 files changed, 3 insertions(+), 9 deletions(-)
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Biesheuvel
> Cc: Russell King
> Cc: Catalin Marinas
> Cc: Will Deacon
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Cc: Sudip Mukherjee
> Cc: Teddy Wang
> Cc: Helge Deller
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> The header file does not need anything from
> . Declare struct screen_info and remove
> the include statements.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Ard Biesheuvel
> Cc: Hans de Goede
> Cc: Javier Martinez Canillas
> ---
R
Thomas Zimmermann writes:
> The sm750fb driver does not need anything from .
> Remove the include statements.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Sudip Mukherjee
> Cc: Teddy Wang
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Ca
Kirill A. Shutemov"
> Cc: Anshuman Khandual
> Cc: Niklas Schnelle
> Cc: Zi Yan
> Cc: "Mike Rapoport (IBM)"
> Cc: Peter Zijlstra
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_device() should be enough and the check is redundant.
Still, I think that this change should be documented in your commit
message.
With that change,
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
64-SGI] pcdp: add PCDP pci interface support") ?
> unsigned long vga_console_membase;
And this is only used by mdacon (not supported by ia64), vgacon and
vga16fb (not supported by ia64 either).
So this could just be guarded just by CONFIG_VGA_CONSOLE for ia64 ?
The rest of the patch looks g
"Arnd Bergmann" writes:
> On Fri, Jul 7, 2023, at 15:40, Javier Martinez Canillas wrote:
[...]
>> And this is only used by mdacon (not supported by ia64), vgacon and
>> vga16fb (not supported by ia64 either).
>>
>> So this could just be guarded just by CO
function instead, and pass a reference to the screen_info
> there.
>
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; between VGA text console and framebuffer through the screen_info data.
>
> Signed-off-by: Arnd Bergmann
> ---
Patch looks good to me, but I'm not that familiar with some of the arches
to give a proper reviewed-by.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
actually used this was removed in linux-3.10, so this is all dead
> code and can be removed.
>
> The big-endian support in vga16fb.c could also be removed, but I'd just
> leave this in place.
>
> Fixes: 933ee7119fb14 ("powerpc: remove PReP platform")
> Sign
ust skip this code if there is no sysfb that needs to
> be unregistered.
>
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t have at least one of the
> users enabled.
>
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ld is BE or LE or if the Device
Tree has an explicit node defining the endianess. The patch looks good to me:
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
er that switches to this driver instead. Specially since both fbdev and
DRM drivers match against the same "display" OF compatible string.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Fix Daniel's email address. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Daniel Vetter
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> In fb_get_options(), always duplicate the returned option string and
> transfer ownership of the memory to the function's caller.
>
> Until now, only the global option string got duplicated and transferred
> to the caller; the per-driver options were owned by fb_get_op
name could be NULL ?
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Get the kernel's global video= parameter with fb_get_option(). Done
> to unexport the internal fbdev state fb_mode_config. No functional
> changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Get the kernel's global video= parameter with fb_get_option(). Done
> to unexport the internal fbdev state fb_mode_config. No functional
> changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> There are no external users of fb_mode_option. Unexport the variable
> and declare it static.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Move the lookup of the option string into an internal helper. No
> functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
tual
> purpose it not clear to me. Use 'video=off' or 'nomodeset' instead.
>
s/it/is
> Signed-off-by: Thomas Zimmermann
> ---
[..]
> +#include /* for FB_MAX */
I believe including is enough here.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Include in ps3av.c to get video_get_options() and
> avoid the dependency on . The replaced function
> fb_get_options() is just a tiny wrapper around video_get_opions(). No
> functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewe
(), which had been
> provided via .
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Do not claim that there's a default mode in the video= option parser.
> if no option string has been given, the parser does nothing.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
Thomas Zimmermann writes:
> Hi
>
> Am 17.02.23 um 09:37 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>>> In fb_get_options(), always duplicate the returned option string and
>>> transfer ownership of the memory to the function'
oot_display = node;
> + break;
> + }
> + for_each_node_by_type(node, "display") {
> + if (!of_get_property(node, "linux,opened", NULL) || node ==
> boot_display)
> + continue;
> + of_platform_devi
do this ?
Or at least a warning if the do_unregister_framebuffer() call is removed.
Regardless of what you chose to do, the patch looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
f-else" depending on PPC. I'll drop
> of_platform_populate_framebuffers() from the patch and make a separate
> implementation of of_platform_default_populate_init for PPC. Seems like
> the easiest solution to me.
>
That sounds reasonable to me as well. Feel free to retain my R-B tag
when posting v2.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
I know that we follow
https://www.kernel.org/doc/Documentation/process/stable-api-nonsense.rst
but still my opinion is that having a warning for a couple of releases
if registered_fb[i]->device is NULL, instead of just crashing would be
a better way to handle this.
> With offb converted, we could practically remove all of the checks here
> and call platform_device_unregister() unconditionally.
>
Yes for mainline, but as mentioned I thought mostly about out-of-tree. If
folks agree that we shouldn't care about these, I'm Ok with that as well.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
vice, the workaround hould no longer
> be triggered. Update it with a warning and rewrite the comment. Fbdev
> drivers that trigger the hot-unplug workaround really need to be fixed.
>
> Signed-off-by: Thomas Zimmermann
> Suggested-by: Javier Martinez Canillas
> ---
Reviewed-b
;s
> infrastructure.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
I think you could push this without waiting for 2/2 to be ready.
> MAINTAINERS | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/MAI
don't rebuild list on recurring calls */
> +
Nice optimization to cache this.
> + /*
> + * TODO: The ofdrm driver converts framebuffers to the native
> + * format when copying them to device memory. If there are more
> + * formats listed than supported by the driver, the native format
> + * is not supported by the conversion helpers. Therefore *only*
> + * support the native format and add a conversion helper ASAP.
> + */
> + if (drm_WARN_ONCE(dev, i != odev->nformats,
> + "format conversion helpers required for %p4cc",
> + &odev->format->format)) {
> + odev->nformats = 1;
> + }
> +
Interesting. Did you find some formats that were not supported ?
The rest of the patch looks good to me, thanks a lot for writing this.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
OF device table won't be used without
the DTS changes.
[0]: https://lkml.org/lkml/2017/3/14/589
[1]: https://lkml.org/lkml/2017/3/15/99
Best regards,
Javier
Changes in v2:
- Only add a single OF device ID entry for each device type (Wolfram Sang).
Javier Martinez Canillas (22):
dt-bindin
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/fsl/b4qds.dtsi| 8
arch/powerpc/boot/dts/fsl/c293pcie.dts | 2 +-
arch/powerpc/boot/dts/fsl/p1010rdb.dtsi | 2 +-
arch/powerpc/boot/dts/fsl/p1023rdb.dts | 2 +-
arch/powerpc/boot/dts/fsl/p2041rdb
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/mpc8308_p1m.dts | 2 +-
arch/powerpc/boot/dts/mpc8349emitx.dts | 2 +-
arch/powerpc/boot/dts/mpc8377_rdb.dts | 2 +-
arch/powerpc/boot/dts/mpc8377_wlan.dts | 2 +-
arch/powerpc/boot/dts/mpc8378_rdb.dts | 2 +-
arch/po
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/warp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc/boot/dts/warp.dts
index e576ee85c42f..5b36dbf6c9f4 100644
--- a/arch/powerpc/boot/dts/warp.dts
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/digsy_mtc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/digsy_mtc.dts
b/arch/powerpc/boot/dts/digsy_mtc.dts
index 955bff629df3..6c804254b885 100644
--- a/arch/powerp
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/pcm030.dts | 2 +-
arch/powerpc/boot/dts/pcm032.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
index 192e66af0001..c7a26c9f6
by: Javier Martinez Canillas
---
Changes in v2: None
arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts
b/arch/powerpc/boot/dts/mpc5121ads.dts
index 75888ce2c792..dd261fd2ee27 100644
--- a/arch/powerp
.
- Add Geert Uytterhoeven reviewed-by tag.
- Add Geert Uytterhoeven reviewed-by tag.
Changes in v2:
- Only add a single OF device ID entry for each device type (Wolfram Sang).
Javier Martinez Canillas (21):
dt-bindings: i2c: eeprom: Document manufacturer used as generic
fallback
eeprom:
by: Javier Martinez Canillas
---
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/digsy_mtc.dts | 2 +-
arch/powerpc/boot/dts/pcm030.dts| 2 +-
arch/powerpc/boot/dts/pcm032.dts| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/digsy_
by: Javier Martinez Canillas
---
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/fsl/b4qds.dtsi| 8
arch/powerpc/boot/dts/fsl/c293pcie.dts | 2 +-
arch/powerpc/boot/dts/fsl/p1010rdb.dtsi | 2 +-
arch/powerpc/boot/dts/fsl/p1023rdb.dts | 2 +-
arch/powerpc/bo
by: Javier Martinez Canillas
---
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts
b/arch/powerpc/boot/dts/mpc5121ads.dts
index 75888ce2c792..ece5d60256ee 100644
by: Javier Martinez Canillas
---
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc8308_p1m.dts | 2 +-
arch/powerpc/boot/dts/mpc8349emitx.dts | 2 +-
arch/powerpc/boot/dts/mpc8377_rdb.dts | 2 +-
arch/powerpc/boot/dts/mpc8377_wlan.dts | 2 +-
arch/powerpc/boot/dts/mpc8378_rd
by: Javier Martinez Canillas
---
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/warp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc/boot/dts/warp.dts
index e576ee85c42f..19e0ec83b1a5 100644
--- a/arch/powerp
.
Changes in v2:
- Only add a single OF device ID entry for each device type (Wolfram Sang).
Javier Martinez Canillas (20):
dt-bindings: i2c: eeprom: Document vendor to be used and deprecated
ones
eeprom: at24: Add OF device ID table
ARM: dts: omap: Add generic compatible string for
by: Javier Martinez Canillas
---
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/digsy_mtc.dts | 2 +-
arch/powerpc/boot/dts/pcm030.dts| 2 +-
ar
by: Javier Martinez Canillas
---
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/fsl/b4qds.dtsi| 8
arch/powerpc/boot/dts/fsl/c293pcie
by: Javier Martinez Canillas
---
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletio
by: Javier Martinez Canillas
---
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc8308_p1m.dts | 2 +-
arch/powerpc/boot/dts/mpc8349emitx.dts | 4
by: Javier Martinez Canillas
---
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/warp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Hello Geert and Rob,
On Mon, May 22, 2017 at 4:26 PM, Rob Herring wrote:
> On Mon, May 22, 2017 at 9:23 AM, Geert Uytterhoeven
> wrote:
>> Hi Javier,
>>
>> On Mon, May 22, 2017 at 4:01 PM, Javier Martinez Canillas
>> wrote:
>>> This series is a follow-up
Hello Rob,
Thanks a lot for your feedback.
On Mon, May 22, 2017 at 6:52 PM, Rob Herring wrote:
> On Mon, May 22, 2017 at 9:46 AM, Javier Martinez Canillas
> wrote:
[snip]
>>>> | >
>>>> | > at24@50 {
>>>> | > - compati
Hello Geert,
On Mon, May 22, 2017 at 9:30 PM, Geert Uytterhoeven
wrote:
> Hi Javier,
>
> On Mon, May 22, 2017 at 7:15 PM, Javier Martinez Canillas
> wrote:
>>>> I also wonder why this is really needed if AFAIU "renesas,24c02" is
>>>> compatible wi
or "atmel,24c02" and "atmel,24c64" entries.
- Add Geert Uytterhoeven reviewed-by tag.
- Add Geert Uytterhoeven reviewed-by tag.
Changes in v2:
- Only add a single OF device ID entry for each device type (Wolfram Sang).
Javier Martinez Canillas (20):
dt-bindings: i2c: eeprom: D
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5: None
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
1 file changed, 1 inser
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5: None
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/warp.dts | 2 +-
1 file changed, 1 insertion(+),
Hello Rob,
On Tue, May 23, 2017 at 3:42 PM, Rob Herring wrote:
> On Mon, May 22, 2017 at 9:02 AM, Javier Martinez Canillas
> wrote:
>> The at24 driver allows to register I2C EEPROM chips using different vendor
>> and devices, but the I2C subsystem does not take the vendor in
Hello Wolfram,
On Tue, May 23, 2017 at 3:34 PM, Javier Martinez Canillas
wrote:
>
> This series is a follow-up to patch [0] that added an OF device ID table
> to the at24 EEPROM driver. As you suggested [1], this version instead of
> adding entries for every used tuple, only a
b Herring).
Changes in v3:
- Fix wrong .data values for "atmel,24c02" and "atmel,24c64" entries.
- Add Geert Uytterhoeven reviewed-by tag.
- Add Geert Uytterhoeven reviewed-by tag.
Changes in v2:
- Only add a single OF device ID entry for each device type (Wolfram Sang).
Javi
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5: None
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
1 file changed, 1 inser
by: Javier Martinez Canillas
---
Changes in v5:
- Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: N
by: Javier Martinez Canillas
---
Changes in v5: None
Changes in v4:
- Only use the atmel manufacturer in the compatible string instead of
keeping the deprecated ones (Rob Herring).
Changes in v3: None
Changes in v2: None
arch/powerpc/boot/dts/warp.dts | 2 +-
1 file changed, 1 insertion(+),
Hello Wolfram,
On Thu, Jun 15, 2017 at 8:54 PM, Javier Martinez Canillas
wrote:
>
> This series is a follow-up to patch [0] that added an OF device ID table
> to the at24 EEPROM driver. As you suggested [1], this version instead of
> adding entries for every used tuple, only a
Hello Wolfram,
On Mon, Jul 31, 2017 at 5:30 PM, Wolfram Sang wrote:
>
>> Patches can be applied independently since the DTS changes without driver
>> changes are no-op and the OF table won't be used without the DTS changes.
>
> But there is a dependency, no? If I apply the driver patch,
> non-con
Hello Wolfram,
On Mon, Aug 28, 2017 at 6:01 PM, Wolfram Sang wrote:
>
>> > But there is a dependency, no? If I apply the driver patch,
>> > non-converted device trees will not find their eeproms anymore. So, I
>>
>> I don't think that's correct. If you apply this patch before the DTS
>> changes,
Hello Wolfram,
On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang wrote:
>
>> I don't have a DT based system at hand now, but I'll test it again and
>> let you know probably tomorrow.
>
> I will try again today, too. Thanks!
>
Ok, I had some time to do some tests again. I used an ARM Chromebook
(Exy
>
> I think we should talk about the same case: Let me repeat what I did:
>
> 1) I added your patch "eeprom: at24: Add OF device ID table"
> 2) I added an EEPROM node to an I2C
>
> + eeprom@50 {
> + compatible = "renesas,24c01";
> + reg = <0x50>;
> + };
>
> -
Hello Geert,
On Wed, Aug 30, 2017 at 10:15 PM, Geert Uytterhoeven
wrote:
> Hi Javier,
>
> On Wed, Aug 30, 2017 at 9:57 PM, Javier Martinez Canillas
> wrote:
>>> I think we should talk about the same case: Let me repeat what I did:
>>>
>>> 1) I added you
return 0;
> }
>
> static void ssd130x_i2c_shutdown(struct i2c_client *client)
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
idea, even patchwork made a mess of it, see
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220628140313.74984-7-u.kleine-koe...@pengutronix.de/
>
FYI, for patches like these what I usually use is:
./scripts/get_maintainer.pl --nogit-fallback --no-m --no-r
--
Best regards
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Remove the unused mem field from struct simpledrm_device.
>
> Signed-off-by: Thomas Zimmermann
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
is
desirable? Without this additional context, this feels like going
backwards, since you are dropping few helpers that have quite self
contained code and making simpledrm_device_create() much larger.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Replace the remaining uses of the field pdev by upcasts from the Linux
> device and remove the field.
>
> Signed-off-by: Thomas Zimmermann
Much better indeed.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Ca
uot;no simplefb configuration found\n");
>> return ERR_PTR(-ENODEV);
>> }
>> + if (!stride)
>> + stride = format->cpp[0] * width;
>
> DIV_ROUND_UP(drm_format_info_bpp(format) * width, 8)
>
I think you mea
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Replace the simple-KMS helpers with the regular atomic helpers. The
> regular helpers are better architectured and therefore allow for easier
> code sharing among drivers. No functional changes.
>
Acked-by: Javier Martinez Canillas
_t *fourccs_end = fourccs + nfourccs;
> +
> + while (fourccs < fourccs_end) {
> + if (*fourccs == fourcc)
> + return true;
> + ++fourccs;
> + }
> + return false;
> +}
This seems a helper that could be useful besides the drm_fwfb_helper.c fi
nd
> color format is pre-initialized by the system's firmware. Runtime
> modesetting via DRM is not possible. The display is useful during
> early boot stages or as error fallback.
>
I'm not familiar with OF display but the driver looks good to me.
Reviewed-by: Javier Martine
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Add a dedicated CRTC state to ofdrm to later store information for
> palette updates.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/tiny/ofdrm.c | 62 ++--
>
Reviewed-by: Jav
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Add a per-model device-function structure in preparation of adding
> color-management support. Detection of the individual models has been
> taken from fbdev's offb.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: J
1 - 100 of 105 matches
Mail list logo
