[REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

these helper when appropriate. This fixes the case of a negative X register and allows to lift the restriction that bpf programs with negative offsets can't be jited. Signed-off-by: Jan Seiffert I have only compile tested this, -ENOHARDWARE. Can someone with more powerpc kung-fu review and

[REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits

The function is renamed to make it a little more clear what it does. It is not added to any .h because it is not for general consumption, only for bpf internal use (and so by the jits). Signed-of-by: Jan Seiffert --- a/net/core/filter.c +++ b/net/core/filter.c @@ -40,8 +40,12 @@ #include

[REGRESSION][PATCH V4 0/3] bpf jit drops the ball on negative memory references

g patch series to fix this situation. Patch 1 exports the helper function the interpreter uses. Patch 2 incorporates the helper into the x86 jit (so it depends on patch 1). Patch 3 incorporates the helper into the powerpc jit (so it depends on patch 1). Lightly tested on x86, but

Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits

David Laight schrieb: > >> The function is renamed to make it a little more clear what it does. >> It is not added to any .h because it is not for general >> consumption, only for bpf internal use (and so by the jits). > > I'd have thought it better to put in into a bfp_internal.h > (or similar

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

Benjamin Herrenschmidt schrieb: > On Wed, 2012-04-04 at 08:11 +1000, Benjamin Herrenschmidt wrote: >> On Tue, 2012-04-03 at 18:03 -0400, David Miller wrote: >> >>>> Signed-off-by: Jan Seiffert >>>> >>>> I have only compile tested this, -ENOH

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

Benjamin Herrenschmidt schrieb: > On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: > >>> Matt's having a look at powerpc >> >> Ok, he hasn't so I'll dig a bit. >> >> No obvious wrongness (but I'm not very familiar with bpf), though I do >> have a comment: sk_negative_common() and b

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

Benjamin Herrenschmidt schrieb: > On Mon, 2012-04-30 at 06:27 +0200, Jan Seiffert wrote: >> Benjamin Herrenschmidt schrieb: >>> On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: >>> >>>>> Matt's having a look at powerpc >>>>

[REGRESSION][PATCH V5 3/3] bpf jit: Let the powerpc jit handle negative offsets

these helper when appropriate. This fixes the case of a negative X register and allows to lift the restriction that bpf programs with negative offsets can't be jited. Tested-by: Benjamin Herrenschmidt Signed-off-by: Jan Seiffert --- arch/powerpc/net/bpf_jit.h |8 +++- arch/powerp