[PATCH] hvc_xen: avoid uninitialized variable warning

Older compilers don't recognize that "v" can't be used uninitialized; other code using hvm_get_parameter() zeros the value too, so follow suit here. Signed-off-by: Jan Beulich --- drivers/tty/hvc/hvc_xen.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 6/6] x86: switch the 64bit uncached page clear to SSE/AVX v2

>>> On 09.08.12 at 17:03, "Kirill A. Shutemov" >>> wrote: > ENTRY(clear_page_nocache) > CFI_STARTPROC > - xorl %eax,%eax > - movl $4096/64,%ecx > + push %rdi > + call kernel_fpu_begin > + pop%rdi You use CFI annotations elsewhere, so why don't you use pushq

Re: [PATCH v2 4/6] x86: Add clear_page_nocache

>>> On 09.08.12 at 17:03, "Kirill A. Shutemov" >>> wrote: > From: Andi Kleen > > Add a cache avoiding version of clear_page. Straight forward integer variant > of the existing 64bit clear_page, for both 32bit and 64bit. While on 64-bit this is fine, I fail to see how you avoid using the SSE2 i

Re: [PATCH v2 4/6] x86: Add clear_page_nocache

>>> On 13.08.12 at 13:43, "Kirill A. Shutemov" >>> wrote: > On Thu, Aug 09, 2012 at 04:22:04PM +0100, Jan Beulich wrote: >> >>> On 09.08.12 at 17:03, "Kirill A. Shutemov" >> >>> wrote: > > ... > >>

Re: linux-next: build warning in Linus' tree

>>> On 18.11.10 at 04:55, Benjamin Herrenschmidt >>> wrote: > On Mon, 2010-10-25 at 17:03 +1100, Stephen Rothwell wrote: >> Hi Arnaud, >> >> On Sun, 24 Oct 2010 23:47:09 -0400 Arnaud Lacombe wrote: >> > >> > The following patch should fix this warning. >> >> I think the following is preferable

Re: linux-next: tree build failure

>>> Hollis Blanchard 09/29/09 2:00 AM >>> >First, I think there is a real bug here, and the code should read like >this (to match the comment): >/* type has to be known at build time for optimization */ >-BUILD_BUG_ON(__builtin_constant_p(type)); >+BUILD_BUG_ON(!__builtin_constant_p(ty

Re: linux-next: tree build failure

>>> roel kluin 29.09.09 11:51 >>> >On Tue, Sep 29, 2009 at 11:28 AM, Jan Beulich wrote: >>>>> Hollis Blanchard 09/29/09 2:00 AM >>> >>>First, I think there is a real bug here, and the code should read like >>>this (to match

Re: linux-next: tree build failure

>>> Hollis Blanchard 30.09.09 01:39 >>> >On Tue, 2009-09-29 at 10:28 +0100, Jan Beulich wrote: >> >>> Hollis Blanchard 09/29/09 2:00 AM >>> >> >First, I think there is a real bug here, and the code should read like >> >this (to ma

Re: linux-next: tree build failure

>>> Hollis Blanchard 02.10.09 17:48 >>> >On Wed, 2009-09-30 at 07:35 +0100, Jan Beulich wrote: >> The one Rusty suggested the other day may help here. I don't like it >> as a drop-in replacement for BUILD_BUG_ON() though (due to it >> deferring th

Re: linux-next: tree build failure

>>> Hollis Blanchard 15.10.09 00:57 >>> >On Fri, 2009-10-09 at 12:14 -0700, Hollis Blanchard wrote: >> Rusty's version of BUILD_BUG_ON() does indeed fix the build break, and >> also exposes the bug in kvmppc_account_exit_stat(). So to recap: >> >> original: built but didn't work >> Jan's: doesn't

Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring

On 30.11.2022 10:26, Roger Pau Monné wrote: > On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: >> On Tue, 29 Nov 2022, Roger Pau Monne wrote: >>> The hvc machinery registers both a console and a tty device based on >>> the hv ops provided by the specific implementation. Those tw

[PATCH, ppc64] improve dedotify()

e the table, which would result in this code possibly, but unintentionally screwing up other symbol names. Besides that, the presented alternative is both smaller and faster. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> --- arch/powerpc/kernel/module_64.c | 10 -- 1 file changed, 4

[PATCH 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU

xenboot_write_console() is dealing with these quite fine so I don't see why xenboot_console_setup() would return -ENOENT in this case. Adjust documentation accordingly. Signed-off-by: Jan Beulich --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/k

[PATCH 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0

first domU_write_console() failed - later ones aren't going to succeed. Signed-off-by: Jan Beulich --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -632,17 +632,16 @@ static void xenboot_write_console(struct unsigned int linelen, off = 0; const char *pos;

Re: [PATCH] swiotlb: set IO TLB segment size via cmdline

On 14.09.2021 17:10, Roman Skakun wrote: > From: Roman Skakun > > It is possible when default IO TLB size is not > enough to fit a long buffers as described here [1]. > > This patch makes a way to set this parameter > using cmdline instead of recompiling a kernel. > > [1] https://www.xilinx.com

Re: [PATCH] swiotlb: set IO TLB segment size via cmdline

On 15.09.2021 15:37, Roman Skakun wrote: >>> From: Roman Skakun >>> >>> It is possible when default IO TLB size is not >>> enough to fit a long buffers as described here [1]. >>> >>> This patch makes a way to set this parameter >>> using cmdline instead of recompiling a kernel. >>> >>> [1] https:/

Re: [PATCH] swiotlb: set IO TLB segment size via cmdline

On 17.09.2021 11:36, Roman Skakun wrote: > I use Xen PV display. In my case, PV display backend(Dom0) allocates > contiguous buffer via DMA-API to > to implement zero-copy between Dom0 and DomU. Why does the buffer need to be allocated by Dom0? If it was allocated by DomU, it could use grants to g

[PATCH v2 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0

first domU_write_console() failed - later ones aren't going to succeed. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -632,17 +632,16 @@ static void xenboot_write_console(struct unsigned int linelen, off = 0;

[PATCH v2 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU

xenboot_write_console() is dealing with these quite fine so I don't see why xenboot_console_setup() would return -ENOENT in this case. Adjust documentation accordingly. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/Documentation/admin-guide/kernel-parameters.txt

Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices

On 22.10.2021 08:47, Juergen Gross wrote: > Today the non-essential pv devices are hard coded in the xenbus driver > and this list is lacking multiple entries. > > This series reworks the detection logic of non-essential devices by > adding a flag for that purpose to struct xenbus_driver. I'm won

Re: [PATCH v2] xen/hvc: replace BUG_ON() with negative return value

On 07.07.2021 11:10, Juergen Gross wrote: > Xen frontends shouldn't BUG() in case of illegal data received from > their backends. So replace the BUG_ON()s when reading illegal data from > the ring page with negative return values. > > Signed-off-by: Juergen Gross Revi