[PATCH v2 9/9] perf jevents: Add model list option

2022-12-21 Thread Ian Rogers
This allows the set of generated jevents events and metrics be limited to a subset of the model names. Appropriate if trying to minimize the binary size where only a set of models are possible. Signed-off-by: Ian Rogers --- tools/perf/pmu-events/Build | 3 ++- tools/perf/pmu-events

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-15 Thread Ian Rogers
On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev wrote: > > > > > On 28-Sep-2022, at 10:24 AM, Athira Rajeev > > wrote: > > > > Hi All, > > > > Looking for what direction we can take here. > > Do we want to change all tests in tools/perf/tests/shell except > > test_intel_pt.sh to use "bash" or go

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-16 Thread Ian Rogers
On Mon, Jan 16, 2023 at 4:00 AM Athira Rajeev wrote: > > > > > On 16-Jan-2023, at 11:47 AM, Ian Rogers wrote: > > > > On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev > > wrote: > >> > >> > >> > >>> On 28-Sep-2022, at 10:24

Re: [PATCH V3 11/14] tools/perf: Add support to use libcapstone in powerpc

2024-06-03 Thread Ian Rogers
On Fri, May 31, 2024 at 11:10 PM Athira Rajeev wrote: > > Now perf uses the capstone library to disassemble the instructions in > x86. capstone is used (if available) for perf annotate to speed up. > Currently it only supports x86 architecture. Patch includes changes to > enable this in powerpc. F

Re: [PATCH 1/3] tools/perf: Fix the nrcpus in perf bench futex to enable the run when all CPU's are not online

2024-06-07 Thread Ian Rogers
hich is not allocated on the cpumask. Fix this by changing > the size of cpumask to number of possible cpus and not the number > of online cpus. > > Signed-off-by: Athira Rajeev For the series: Reviewed-by: Ian Rogers Thanks, Ian > --- > tools/perf/bench/futex-hash.c |

Re: [PATCH] Perf: Calling available function for stats printing

2024-06-27 Thread Ian Rogers
On Thu, Jun 27, 2024 at 6:37 AM Abhishek Dubey wrote: > > For printing dump_trace, just use existing stats_print() > function. > > Signed-off-by: Abhishek Dubey Thanks Abishek, the change looks good but it needs to be rebased on top of Commit 411ee13598ef ("perf hist: Add symbol_conf.skip_empty"

Re: [PATCH] perf report: Calling available function for stats printing

2024-06-28 Thread Ian Rogers
On Fri, Jun 28, 2024 at 11:32 AM Abhishek Dubey wrote: > > For printing dump_trace, just use existing stats_print() > function. > > Signed-off-by: Abhishek Dubey Reviewed-by: Ian Rogers Thanks, Ian > --- > tools/perf/builtin-report.c | 3 +-- > 1 file changed, 1 i

Re: [PATCH] perf vendor events power10: Update JSON/events

2024-07-23 Thread Ian Rogers
On Mon, Jul 22, 2024 at 10:27 PM Kajol Jain wrote: > > Update JSON/events for power10 platform with additional events. > Also move PM_VECTOR_LD_CMPL event from others.json to > frontend.json file. > > Signed-off-by: Kajol Jain Reviewed-by: Ian Rogers > --- >

Re: [PATCH 1/3] perf vendor events power10: Update JSON/events

2024-08-27 Thread Ian Rogers
On Mon, Aug 26, 2024 at 10:33 PM Kajol Jain wrote: > > Update JSON/events for power10 platform with additional events. > > Signed-off-by: Kajol Jain For the series: Reviewed-by: Ian Rogers Just to note, the moving of events in patches 2 and 3 is necessary as the filename sets th

Re: [PATCH] tools/perf/tests: Fix compilation error with strncpy in tests/tool_pmu

2024-10-16 Thread Ian Rogers
On Wed, Oct 16, 2024 at 5:30 AM Athira Rajeev wrote: > > > > > On 14 Oct 2024, at 10:56 PM, Namhyung Kim wrote: > > > > Hello Athira, > > > > On Sun, Oct 13, 2024 at 11:07:42PM +0530, Athira Rajeev wrote: > >> perf fails to compile on systems with GCC version11 > >> as below: > >> > >> In file in

Re: [PATCH] tools/perf/tests: Fix compilation error with strncpy in tests/tool_pmu

2024-10-16 Thread Ian Rogers
On Wed, Oct 16, 2024 at 11:23 AM Athira Rajeev wrote: > > > > > On 16 Oct 2024, at 8:36 PM, Ian Rogers wrote: > > > > On Wed, Oct 16, 2024 at 5:30 AM Athira Rajeev > > wrote: > >> > >> > >> > >>> On 14 Oct 2024, at 10:56 PM

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

2024-11-04 Thread Ian Rogers
On Sun, Nov 3, 2024 at 8:17 PM Athira Rajeev wrote: > > > > > On 30 Oct 2024, at 5:29 AM, Namhyung Kim wrote: > > > > Hello, > > > > On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: > >> The "Simple expression parser" test fails on powerpc > >> as below: > >> > >> parsing metric: #s

[PATCH v1] perf test expr: Fix system_tsc_freq for only x86

2024-12-04 Thread Ian Rogers
: 609aa2667f67 ("perf tool_pmu: Switch to standard pmu functions and json descriptions") Reported-by: Athira Rajeev Closes: https://lore.kernel.org/linux-perf-users/20241022140156.98854-1-atraj...@linux.vnet.ibm.com/ Co-developed-by: Athira Rajeev Signed-off-by: Ian Rogers --- tools/perf/te

Re: [PATCH v1] perf test expr: Fix system_tsc_freq for only x86

2024-12-04 Thread Ian Rogers
On Wed, Dec 4, 2024 at 9:47 PM Namhyung Kim wrote: > > Hi Ian, > > On Wed, Dec 04, 2024 at 06:23:05PM -0800, Ian Rogers wrote: > > The refactoring of tool PMU events to have a PMU then adding the expr > > literals to the tool PMU made it so that the literal system_tsc_fre

Re: [PATCH v1] perf test expr: Fix system_tsc_freq for only x86

2024-12-04 Thread Ian Rogers
On Wed, Dec 4, 2024 at 10:33 PM Ian Rogers wrote: > > On Wed, Dec 4, 2024 at 9:47 PM Namhyung Kim wrote: > > > > Hi Ian, > > > > On Wed, Dec 04, 2024 at 06:23:05PM -0800, Ian Rogers wrote: > > > The refactoring of tool PMU events to have a PMU then adding

Re: [PATCH] perf: Fix display of kernel symbols

2025-01-06 Thread Ian Rogers
On Mon, Jan 6, 2025 at 11:38 AM Christophe Leroy wrote: > > Since commit 659ad3492b91 ("perf maps: Switch from rbtree to lazily > sorted array for addresses"), perf doesn't display anymore kernel > symbols on powerpc, allthough it still detects them as kernel addresses. > > # Overhead Com

Re: [PATCH] libperf: Add back guard on MAX_NR_CPUS

2025-01-06 Thread Ian Rogers
On Mon, Jan 6, 2025 at 11:38 AM Christophe Leroy wrote: > > Building perf with EXTRA_CFLAGS="-DMAX_NR_CPUS=1" fails: > > CC /home/chleroy/linux-powerpc/tools/perf/libperf/cpumap.o > cpumap.c:16: error: "MAX_NR_CPUS" redefined [-Werror] >16 | #define MAX_NR_CPUS 4

Re: [PATCH] libperf: Add back guard on MAX_NR_CPUS

2025-01-07 Thread Ian Rogers
On Tue, Jan 7, 2025 at 12:50 AM Christophe Leroy wrote: > > Le 06/01/2025 à 21:05, Ian Rogers a écrit : > > On Mon, Jan 6, 2025 at 11:38 AM Christophe Leroy > > wrote: > >> > >> Building perf with EXTRA_CFLAGS="-DMAX_NR_CPUS=1" fails: > >&

Re: [PATCH v2] perf: Fix display of kernel symbols

2025-01-08 Thread Ian Rogers
dress of the following map. > > Fix it by really taking the next entry, also make sure that entry > follows current one by making sure entries are sorted. > > Fixes: 659ad3492b91 ("perf maps: Switch from rbtree to lazily sorted array > for addresses") > Signed-off-b

Re: [PATCH] tools/lib/perf: Fix -Werror=alloc-size-larger-than in cpumap.c

2025-05-13 Thread Ian Rogers
On Tue, May 13, 2025 at 2:13 PM Arnaldo Carvalho de Melo wrote: > > On Fri, May 02, 2025 at 01:14:32PM +0530, Mukesh Kumar Chaurasiya wrote: > > On Fri, Apr 25, 2025 at 02:46:43PM -0300, Arnaldo Carvalho de Melo wrote: > > > Maybe that max() call in perf_cpu_map__intersect() somehow makes the > >

Re: [PATCH] tools/lib/perf: Fix -Werror=alloc-size-larger-than in cpumap.c

2025-05-13 Thread Ian Rogers
On Tue, May 13, 2025 at 3:12 PM Ian Rogers wrote: > > On Tue, May 13, 2025 at 2:13 PM Arnaldo Carvalho de Melo > wrote: > > > > On Fri, May 02, 2025 at 01:14:32PM +0530, Mukesh Kumar Chaurasiya wrote: > > > On Fri, Apr 25, 2025 at 02:46:43PM -0300, Arnaldo Carvalh

Re: [PATCH] tools/lib/perf: Fix -Werror=alloc-size-larger-than in cpumap.c

2025-05-21 Thread Ian Rogers
On Wed, May 21, 2025 at 10:28 AM Likhitha Korrapati wrote: > > Hi Ian, > > On 5/21/25 21:15, Ian Rogers wrote: > > On Wed, May 21, 2025 at 6:03 AM Likhitha Korrapati > > wrote: > >> > >> Hi Arnaldo, > >> > >> On 5/14/25 02:43, Arnaldo

Re: [PATCH] tools/lib/perf: Fix -Werror=alloc-size-larger-than in cpumap.c

2025-05-21 Thread Ian Rogers
On Wed, May 21, 2025 at 6:03 AM Likhitha Korrapati wrote: > > Hi Arnaldo, > > On 5/14/25 02:43, Arnaldo Carvalho de Melo wrote: > > On Fri, May 02, 2025 at 01:14:32PM +0530, Mukesh Kumar Chaurasiya wrote: > >> On Fri, Apr 25, 2025 at 02:46:43PM -0300, Arnaldo Carvalho de Melo wrote: > >>> Maybe th

<    1   2