Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

2015-04-08 Thread Herbert Xu
rged originally but crypto/842.c needs to be moved over to drivers/crypto. Your software implementation should take its places as the reference implementation. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.

Re: [PATCH 11/11] crypto: add crypto compression sefltest

2015-04-08 Thread Herbert Xu
erage bytes per > second compression and decompression rates. Any errors reported by the > compressor during compression or decompression will end the test and > be logged. > > Signed-off-by: Dan Streetman Please use the existing infrastructure in testmgr/tcrypt. Thanks, -- Emai

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

2015-04-08 Thread Herbert Xu
that it's obvious that this is not a generic implementation. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

2015-04-08 Thread Herbert Xu
course. There is nothing wrong with it exporting this via the crypto API. It's just in an unusual spot for a driver. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt __

Re: [PATCH v3 00/17] crypto: talitos - Add support for SEC1

2015-04-18 Thread Herbert Xu
patchset. Since a kernel can be built > with support for both MPC82xx and MPC83xx at the same time, talitos > driver shall support both SEC1 and SEC2+ at the same time. > > Based on cryptodev-2.6 tree All applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org

Re: [PATCH 04/10] crypto: change 842 alg to use software

2015-05-06 Thread Herbert Xu
how the name works. All implementations of 842 should bear that name. They should differentiate themselves based on cra_driver_name. For example, we generally call the software implementation of foo "foo-generic". Cheers, -- Email: Herbert Xu Home Page: http://gondor.ap

Re: [PATCH 10/10] drivers/crypto/nx: add hardware 842 crypto comp alg

2015-05-06 Thread Herbert Xu
an set the driver name to nx842 or 842-nx. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 10/10] drivers/crypto/nx: add hardware 842 crypto comp alg

2015-05-07 Thread Herbert Xu
to the crypto layer, as we do for ciphers and hashes. But as you say we could make the next guy who writes a comp driver do this :) Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___

Re: [PATCHv3 00/10] add 842 hw compression for PowerNV platform

2015-05-11 Thread Herbert Xu
On Thu, May 07, 2015 at 01:49:11PM -0400, Dan Streetman wrote: > > v3 changes the sw and hw crypto drivers to use the same alg name "842", > and different driver names, "842-generic" and "842-nx" All applied. Thanks a lot! -- Email: Herbert Xu Home Pa

Re: [PATCH 1/6] crypto: md5: add MD5 initial vectors

2015-05-17 Thread Herbert Xu
On Sun, May 17, 2015 at 12:54:12PM +0200, LABBE Corentin wrote: > This patch simply adds the MD5 IV in the md5 header. > > Signed-off-by: LABBE Corentin All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [PATCH] crypto: nx - tweak Makefile dependencies

2015-05-27 Thread Herbert Xu
sn't apply against the cryptodev tree. Please rebase it. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] drivers: char: hw_random: printk replacement

2014-09-15 Thread Herbert Xu
: unused variable ‘warning’ [-Wunused-variable] make[1]: *** [drivers/char/hw_random/intel-rng.o] Error 1 Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc

Re: [PATCH v2] drivers: char: hw_random: printk replacement

2014-10-01 Thread Herbert Xu
/hw_random/intel-rng.c | 13 ++--- > drivers/char/hw_random/pasemi-rng.c | 2 +- > drivers/char/hw_random/pseries-rng.c | 2 +- > drivers/char/hw_random/via-rng.c | 8 > 6 files changed, 16 insertions(+), 17 deletions(-) Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-10-31 Thread Herbert Xu
gt; > Before your Signed-off-by. They will then pick it up once it's merged into > > Linus' tree. See Documentation/stable_kernel_rules.txt > > > > cheers > > > > Oops... should I repost then ? Don't worry, I can fix this up. Cheers, -- Email: H

Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-11-06 Thread Herbert Xu
rn buffer size for sure. > > Signed-off-by: Greg Kurz Patch applied to crypto. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing

Re: [PATCH 5/6] [RFC] crypto/testmgr: add null test for 842 algorithm

2015-07-04 Thread Herbert Xu
oper test) is to just insert the null test into the list in the > testmgr. > > Signed-off-by: Nishanth Aravamudan Please add some real test vectors instead. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.ap

Re: [PATCH 6/6] nx-842-platform: if NX842 platform drivers are not modules, don't try to load them

2015-07-06 Thread Herbert Xu
_init() runs before the platform driver > nx842_pseries_init() or nx842_powernv_init() functions, which are what > normally set the static platform driver. > > Signed-off-by: Nishanth Aravamudan > Cc: Dan Streetman > Cc: Herbert Xu > Cc: "David S. Miller" > Cc:

Re: [PATCH 0/6] drivers/nx-842: reduce verbosity of logging

2015-07-06 Thread Herbert Xu
On Thu, Jul 02, 2015 at 03:38:00PM -0700, Nishanth Aravamudan wrote: > Currently, on a LPAR with the nx-842 device disabled, the following > messages are emitted: Patches 1-3 applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.

Re: [PATCH v2] crypto/nx-842-{powerpc, pseries}: reduce chattiness of platform drivers

2015-07-07 Thread Herbert Xu
On Mon, Jul 06, 2015 at 10:06:21AM -0700, Nishanth Aravamudan wrote: > > v2: > Rather than not loading, just reduce the verbosity Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/p

Re: [PATCH 0/2] Uncomment VSX enable routine for instructions access

2015-07-14 Thread Herbert Xu
> Adding enable_kernel_vsx() to access VSX instructions All applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.o

Re: [PATCH v2 0/2] drivers/crypto/nx: fixes when input data is too large

2013-08-08 Thread Herbert Xu
ists for SHA-2 Both patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Herbert Xu
ever your patch was totally white-space damaged. I've fixed it this time, but please fix this in your future submissions. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt __

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-09 Thread Herbert Xu
her NX fixes > and I can safely take them out of linuxppc patchwork ? Yes of course. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing

Re: [PATCH] crypto: nx - fix concurrency issue

2013-08-14 Thread Herbert Xu
, we need to protect the data stored into the context. > > This patch makes use of spin locks to protect the data where a race > condition can happen. > > Reviewed-by: Fionnuala Gunter > Reviewed-by: Joy Latten > Signed-off-by: Marcelo Cerri Patch applied. Thanks a lot!

Re: [PATCH] crypto:nx - fix nx-aes-gcm verification

2013-08-21 Thread Herbert Xu
the code to retrieve the input authtag from src > instead of dst. > > Reviewed-by: Fionnuala Gunter > Reviewed-by: Marcelo Cerri > Signed-off-by: Joy Latten Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://g

Re: [PATCH 03/10] crypto: nx - fix limits to sg lists for AES-CBC

2013-08-28 Thread Herbert Xu
Reviewed-by: Joy Latten > Signed-off-by: Marcelo Cerri This patch does not apply against the current cryptodev tree. Please regenerate your pathces. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 00/10] Series of fixes for NX driver

2013-09-02 Thread Herbert Xu
- Fixed conflict. All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] hwrng: Use KBUILD_MODNAME in pseries-rng.c

2013-10-07 Thread Herbert Xu
On Wed, Sep 25, 2013 at 07:24:16PM +1000, Michael Ellerman wrote: > Signed-off-by: Michael Ellerman Both patches applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.

Re: [RFC, prePATCH] crypto: talitos modified for powerpc 88x security engine

2014-07-23 Thread Herbert Xu
o happy about the quantity > of #ifdef Yeah these ifdefs have got to go. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-

Re: [PATCH v1 0/3] SHA256 for PPC/SPE

2015-01-25 Thread Herbert Xu
to relax the conditions similar to sha1_ssse3 on x86? If not how about going async with cryptd? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Lin

Re: [v2,1/3] crypto: ppc/sha256 - assembler

2015-02-27 Thread Herbert Xu
leakage. > > The code is endian independant. > > Signed-off-by: Markus Stockhausen All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linu

Re: [PATCH 2/5] crypto: talitos: Remove MD5_BLOCK_SIZE

2015-03-01 Thread Herbert Xu
Martin Hicks wrote: > This is properly defined in the md5 header file. Please resubmit with sign-off. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linux

Re: [v2,1/7] crypto: powerpc/aes - register defines

2015-03-01 Thread Herbert Xu
On Sun, Feb 22, 2015 at 09:59:38AM +0100, Markus Stockhausen wrote: > Define some register aliases for better readability. > > Signed-off-by: Markus Stockhausen All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apa

Re: [v1,1/3] crypto: powerpc/sha1 - assembler

2015-03-02 Thread Herbert Xu
e interrupt ourselves and push sensitive > data from another context onto our stack. Clear this area > in the stack afterwards to avoid information leakage. > > The code is endian independant. > > Signed-off-by: Markus Stockhausen All applied. Thanks! -- Email: Herbert Xu Home Pa

Re: [v1,1/3] crypto: powerpc/md5 - assembler

2015-03-04 Thread Herbert Xu
d as > delta values. > > Signed-off-by: Markus Stockhausen All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

2015-03-05 Thread Herbert Xu
rivers/crypto/talitos.c: patch does not apply Also the patches are coming in a random order. Please send them one at a time to ensure proper ordering. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___

Re: [PATCH v2 5/5] crypto: talitos: Add software backlog queue handling

2015-03-05 Thread Herbert Xu
is flag would apply only to request __ctx[]. > > Herbert, would this be an acceptable addition to crypto API? How would such a flag work? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor

Re: [PATCH v2 2/5] crypto: talitos: Remove MD5_BLOCK_SIZE

2015-03-06 Thread Herbert Xu
Kim Phillips wrote: > On Tue, 3 Mar 2015 08:21:34 -0500 > Martin Hicks wrote: > >> This is properly defined in the md5 header file. >> >> Signed-off-by: Martin Hicks >> --- > > Acked-by: Kim Phillips Patches 1-2 applied. Thanks.

Re: [PATCH] crypto: powerpc - move files to fix build error

2015-03-09 Thread Herbert Xu
;, > needed by 'arch/powerpc/crypto/sha1-ppc-spe.o'. Stop. > Makefile:947: recipe for target 'arch/powerpc/crypto' failed > > Move the two sha1 spe files under crypto/, and whilst there, rename > other powerpc crypto files with underscores to use dashes for >

Re: crash in ppc4xx-rng on canyonland

2016-04-05 Thread Herbert Xu
e is successfully loaded before the RNG is accessed. It's probably easier to just merge the two drivers but still maintaining the original driver names. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: crash in ppc4xx-rng on canyonland

2016-04-18 Thread Herbert Xu
dd some error handling when the RNG probe fails. For example, if the RNG probe fails we should probably not call remove on it later. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _

Re: crash in ppc4xx-rng on canyonland

2016-04-20 Thread Herbert Xu
rng was left enabled (note: the v1 code >disabled the hwrng device as part of crypto4xx_remove. >so it wasn't enabled when the crypto4xx driver was >unloaded) Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http:/

Re: [PATCH] crypto: vmx - VMX crypto should depend on CONFIG_VSX

2015-09-08 Thread Herbert Xu
ers/built-in.o: In function `.p8_aes_setkey': > aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec' > aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' > > Signed-off-by: Michael Ellerman Could you please cc linux-cry...@vger.kernel.o

Re: [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX

2015-09-10 Thread Herbert Xu
errors such as: > > drivers/built-in.o: In function `.p8_aes_setkey': > aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec' > aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' > > Signed-off-by: Michael Ellerman

Re: [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX

2015-09-10 Thread Herbert Xu
On Fri, Sep 11, 2015 at 10:47:07AM +1000, Michael Ellerman wrote: > > Is that targeted for 4.3 ? Yes I'm only accepting 4.3 patches for the time being. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH 1/2] char: hw_random: Fix module autoload for OF platform drivers

2015-09-18 Thread Herbert Xu
On Tue, Sep 15, 2015 at 06:41:33PM +0200, Luis de Bethencourt wrote: > This platform drivers have a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Patch applied. Thanks. --

Re: [PATCH] crypto: talitos - add new crypto modes

2015-12-04 Thread Herbert Xu
On Tue, Dec 01, 2015 at 12:44:15PM +0100, Christophe Leroy wrote: > This patch adds the following algorithms to the talitos driver: > * ecb(aes) > * ctr(aes) > * ecb(des) > * cbc(des) > * ecb(des3_ede) > > Signed-off-by: Christophe Leroy Patch applied. Thanks. -- Emai

Re: [PATCH] crypto/nx842: Mask XERS0 bit in return value

2015-12-17 Thread Herbert Xu
, BUSY or REJECTED) will be returned for > any given NX request. > > Signed-off-by: Haren Myneni Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _

Re: [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-18 Thread Herbert Xu
p? This is crazy! smp_rmb started out being strictly stronger than smp_read_barrier_depends, when did this stop being the case? -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___

Re: [PATCH] crypto: vmx - fix copy-paste error in CTR mode

2019-03-22 Thread Herbert Xu
ed3 ("crypto: vmx - Add support for VMS instructions by ASM") > Cc: sta...@vger.kernel.org > Signed-off-by: Daniel Axtens > --- > drivers/crypto/vmx/aesp8-ppc.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert X

Re: [PATCH -next] crypto: vmx - Make p8_init and p8_exit static

2019-03-27 Thread Herbert Xu
symbol 'p8_exit' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/crypto/vmx/vmx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: nx842 - remove set but not used variables 'dpadding' and 'max_sync_size'

2019-04-07 Thread Herbert Xu
gned-off-by: YueHaibing > --- > drivers/crypto/nx/nx-842-pseries.c | 6 ++ > drivers/crypto/nx/nx-842.c | 3 +-- > 2 files changed, 3 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: powerpc - convert to use crypto_simd_usable()

2019-04-18 Thread Herbert Xu
ypto/vmx/aes_xts.c| 5 +++-- > drivers/crypto/vmx/ghash.c | 9 - > 8 files changed, 25 insertions(+), 17 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: Replace zero-length array with flexible-array member

2020-03-05 Thread Herbert Xu
ers/crypto/omap-sham.c | 4 ++-- > include/crypto/if_alg.h| 2 +- > 10 files changed, 14 insertions(+), 14 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 4/9] crypto/nx: Initialize coproc entry with kzalloc

2020-03-22 Thread Herbert Xu
.rxwin > is not initialized. > > This patch replaces kmalloc with kzalloc in nx842_powernv_probe() > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Herbert Xu -- Email: Herbert Xu

Re: [PATCH v4 5/9] crypto/nx: Rename nx-842-powernv file name to nx-common-powernv

2020-03-22 Thread Herbert Xu
elete mode 100644 drivers/crypto/nx/nx-842-powernv.c > create mode 100644 drivers/crypto/nx/nx-common-powernv.c Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 6/9] crypto/NX: Make enable code generic to add new GZIP compression type

2020-03-22 Thread Herbert Xu
t; instead of 0 for per_cpu send window in nx_delete_coprocs(). > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-common-powernv.c | 161 > +- > 1 file changed, 101 insertions(+), 60 deletions(-) Acked-by: Herbert Xu -- E

Re: [PATCH v4 7/9] crypto/nx: Enable and setup GZIP compression type

2020-03-22 Thread Herbert Xu
f-by: Haren Myneni > --- > drivers/crypto/nx/nx-common-powernv.c | 43 > ++- > 1 file changed, 37 insertions(+), 6 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 8/9] crypto/nx: Remove 'pid' in vas_tx_win_attr struct

2020-03-22 Thread Herbert Xu
t; arch/powerpc/include/asm/vas.h| 1 - > drivers/crypto/nx/nx-common-powernv.c | 1 - > 2 files changed, 2 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code

2019-10-25 Thread Herbert Xu
c | 4 +--- > drivers/char/hw_random/st-rng.c | 4 +--- > drivers/char/hw_random/tx4939-rng.c | 4 +--- > drivers/char/hw_random/xgene-rng.c | 4 +--- > 13 files changed, 13 insertions(+), 40 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/3] crypto: powerpc - convert SPE AES algorithms to skcipher API

2019-10-25 Thread Herbert Xu
algorithms to skcipher API > > arch/powerpc/crypto/aes-spe-glue.c | 389 - > crypto/Kconfig | 1 + > 2 files changed, 166 insertions(+), 224 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics

2019-10-25 Thread Herbert Xu
d-off-by: Geert Uytterhoeven > --- > drivers/crypto/nx/nx_debugfs.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Avoid weird build failures

2019-11-22 Thread Herbert Xu
Signed-off-by: Michael Ellerman > --- > drivers/crypto/vmx/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] lib/mpi: Fix building for powerpc with clang

2020-04-15 Thread Herbert Xu
ported-by: kbuild test robot > Link: https://github.com/ClangBuiltLinux/linux/issues/991 > Signed-off-by: Nathan Chancellor Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/7] sha1 library cleanup

2020-05-07 Thread Herbert Xu
t; lib/crypto/chacha.c | 1 - > lib/sha1.c | 24 --- > net/core/secure_seq.c | 1 - > net/ipv6/addrconf.c | 10 +++ > net/ipv6/seg6_hmac.c | 1 - > net/mptcp

Re: [PATCH v2] crypto: vmx - Fix sleep-in-atomic bugs

2018-08-25 Thread Herbert Xu
15] [c00338757d90] [c0b02bb8] __sys_recvmsg+0x68/0xe0 > [ 891.866631] [c00338757e30] [c000bbe4] system_call+0x5c/0x70 > > Fixes: 8c755ace357c ("crypto: vmx - Adding CBC routines for VMX module") > Fixes: c07f5d3da643 ("crypto: vmx - Addin

Re: [PATCH] crypto/testmgr: fix skcipher test with CONFIG_VMAP_STACK

2018-12-10 Thread Herbert Xu
test 1 for > > ecb-aes-talitos: ret=22 > > > > IV cannot be on stack when CONFIG_VMAP_STACK is selected because the stack > > cannot be DMA mapped anymore. > > > > This patch allocates it with kmalloc() > > > > This looks like a driver bug to me. Ot

Re: [PATCH] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

2018-12-11 Thread Herbert Xu
ctx->iv, 0, areq->nbytes, 0, ivsize, 0, > areq->base.flags, encrypt); > } Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 4/4] crypto: talitos - drop icv_ool

2019-06-13 Thread Herbert Xu
in my tree before it got merged. > > Do I have to resend it or can Herbert just drop the wrong reference and take > the following one: Please resend since you're going to change the other patches too. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE

2019-06-20 Thread Herbert Xu
set ? 0 : sg->offset; > + offset = pgoffset ? 0 : sg->offset; > + while (offset >= PAGE_SIZE) { > + miter->piter.sg_pgoffset = ++pgoffset; > + offset -= PAGE_SIZE; > + } How about

Re: [PATCH] crypto: vmx - Document CTR mode counter width quirks

2019-06-20 Thread Herbert Xu
ers/crypto/vmx/aesp8-ppc.pl | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - fix max key size for sha384 and sha512

2019-06-20 Thread Herbert Xu
alitos - reduce max key size for SEC1") > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: nx: no need to check return value of debugfs_create functions

2019-06-20 Thread Herbert Xu
ugfs file names, > especially as the whole directiry is deleted at once, so remove the > unneeded structure entirely. > > Cc: "Breno Leitão" > Cc: Nayna Jain > Cc: Paulo Flabiano Smorigo > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > C

Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE

2019-06-24 Thread Herbert Xu
On Mon, Jun 24, 2019 at 08:35:33PM +0300, Imre Deak wrote: > Hi, > > On Thu, Jun 20, 2019 at 02:02:21PM +0800, Herbert Xu wrote: > > On Mon, Jun 17, 2019 at 09:15:02PM +, Christophe Leroy wrote: > > > All mapping iterator logic is based on the assumption that sg->o

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-26 Thread Herbert Xu
receive window credits. > > Fixes: b0d6c9bab5e4 ("crypto/nx: Add P9 NX support for 842 compression > engine") > CC: sta...@vger.kernel.org # v4.14+ > Signed-off-by:Haren Myneni I presume this is being picked up by the powerpc tree? Thanks, -- Email: Herbert Xu Home P

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-27 Thread Herbert Xu
On Fri, Jun 28, 2019 at 11:43:16AM +1000, Michael Ellerman wrote: > > No. I assumed you'd take it because it's in drivers/crypto. > > If you want me to take it that's fine, just let me know. No that's fine Michael. I'll pick it up. Thanks, -

Re: [PATCH] crypto: talitos - eliminate unneeded 'done' functions at build time

2019-06-27 Thread Herbert Xu
+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-27 Thread Herbert Xu
> CRBs from FIFO size and set it to receive window credits. > > Fixes: b0d6c9bab5e4 ("crypto/nx: Add P9 NX support for 842 compression > engine") > CC: sta...@vger.kernel.org # v4.14+ > Signed-off-by:Haren Myneni Patch applied. Thanks. -- Email: Herbert Xu Home P

Re: [PATCH v5 0/4] *** SUBJECT HERE ***

2019-07-03 Thread Herbert Xu
ct talitos_edesc into talitos.h > crypto: talitos - fix hash on SEC1. > crypto: talitos - drop icv_ool > > drivers/crypto/talitos.c | 102 > +++ > drivers/crypto/talitos.h | 28 + > lib/scatterlist.c| 9 +++-- > 3 files changed, 74 insertions(+), 65 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return

2019-08-01 Thread Herbert Xu
e found with Coccinelle. > > Acked-by: Stewart Smith > Signed-off-by: Nishka Dasgupta > > --- > Changes in v2: > - Fixed commit message to match the loop in question. > > drivers/crypto/nx/nx-842-powernv.c | 1 + > 1 file changed, 1 insertion(+) Patch applied.

Re: [PATCH] hwrng: Use device-managed registration API

2019-08-01 Thread Herbert Xu
ers/char/hw_random/powernv-rng.c | 10 +- > drivers/char/hw_random/st-rng.c| 4 +--- > drivers/char/hw_random/xgene-rng.c | 4 +--- > 9 files changed, 9 insertions(+), 36 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.

Re: [PATCH v3] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

2019-01-07 Thread Herbert Xu
alg: skcipher: encryption failed on test 1 for > ecb-aes-talitos: ret=22 > > IV cannot be on stack when CONFIG_VMAP_STACK is selected because the stack > cannot be DMA mapped anymore. > > This patch copies the IV into the extended descriptor when iv is not > a valid

Re: [PATCH v4 1/2] crypto: talitos - reorder code in talitos_edesc_alloc()

2019-01-10 Thread Herbert Xu
rs/crypto/talitos.c | 25 +++-- > 1 file changed, 7 insertions(+), 18 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/6] lib/crc32: treewide: Use existing define with polynomial

2018-07-27 Thread Herbert Xu
| 11 ++- > lib/crc32defs.h | 14 -- > lib/decompress_bunzip2.c | 3 ++- > lib/gen_crc32table.c | 5 +++-- > lib/xz/xz_crc32.c | 3 ++

Re: [PATCH 08/10] crypto/NX: Add NX GZIP user space API

2019-12-17 Thread Herbert Xu
nged, 304 insertions(+), 3 deletions(-) > create mode 100644 drivers/crypto/nx/nx-gzip-powernv.c We already have a kernel compress API which could be exposed to user-space through af_alg. If every driver created their own user-space API it would be unmanageable. Cheers, -- Email: Herbert Xu

Re: [PATCH 08/10] crypto/NX: Add NX GZIP user space API

2019-12-19 Thread Herbert Xu
nostic to the underlying implementation. That is, even when the hardware is absent it would seamlessly switch over to a software implementation. I say normally because there can be exceptions, e.g., with paes and hardware keys. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx/xts - reject inputs that are too short

2020-01-15 Thread Herbert Xu
.@vger.kernel.org # v5.4+ > Signed-off-by: Michael Ellerman > [dja: commit message] > Signed-off-by: Daniel Axtens > --- > drivers/crypto/vmx/aes_xts.c | 3 +++ > 1 file changed, 3 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Using alloc_coherent for caam job rings

2012-07-10 Thread Herbert Xu
> Acked-by: Kim Phillips Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support

2012-07-30 Thread Herbert Xu
; > Seth Jennings (4): All applied. Thanks Seth. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c

2012-08-20 Thread Herbert Xu
34 ++ > > 1 file changed, 18 insertions(+), 16 deletions(-) > > Looks good here. Thanks for doing this! > > Acked-by: Seth Jennings Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.

Re: linux-next: manual merge of the crypto tree with the powerpc tree

2012-05-16 Thread Herbert Xu
om the powerpc tree and commit > 2789c08fffea ("crypto: ux500 - Add driver for CRYP hardware") from the > crypto tree. > > Just context changes. I fixed it up (see below) and can carry the fix as > necessary. Looks fine. Thanks Stephen! -- Email: Herbert Xu Home P

Re: [PATCH 1/2] drivers: crypto: move nx build to driver/crypto Makefile

2012-06-27 Thread Herbert Xu
/Makefile where it > belongs. > > Cc: Kent Yoder > Signed-off-by: Seth Jennings Both patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt __

Re: [PATCH] crypto: add support for the Freescale SEC4/CAAM

2011-03-13 Thread Herbert Xu
Only AEAD algorithms are implemented > at this time, for use with IPsec. > > Many thanks to the Freescale STC team for their contributions > to this driver. > > Signed-off-by: Steve Cornelius > Signed-off-by: Kim Phillips Patch applied. Thanks a lot! -- Email: Herbert

Re: [PATCH] crypto: caam - standardize device tree naming convention to utilize '-vX.Y'

2011-03-23 Thread Herbert Xu
ec-v4.0", "fsl,sec-v4.0"; > > Signed-off-by: Kim Phillips > Cc: Kumar Gala > Cc: Steve Cornelius Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _

Re: [PATCH] crypto: caam - de-CHIP-ify device tree compatibles

2011-03-23 Thread Herbert Xu
nces. > > > > Signed-off-by: Kim Phillips > > Very well. As long as some level of versioning is used on the > compatible values, I guess I can live with it. > > Acked-off-by: Grant Likely Patch applied. Thanks! -- Email: H

Re: [PATCH] AMCC Crypto4xx Device Driver v6

2009-02-04 Thread Herbert Xu
the near future. > > Signed-off-by: James Hsiao Patch applied. Thanks James! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.or

Re: [PATCH] AMCC Crypto4xx Device Driver v6

2009-02-05 Thread Herbert Xu
you can fix it with the V6 > patch. I'll fix it up. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___

Re: [PATCH 1/4] crypto: caam - handle interrupt lines shared across rings

2011-04-15 Thread Herbert Xu
> --- > this, and the remaining patches in this series, tested on p1023, p3041, > p4080, and 32- and 64-bit p5020. All four patches applied. Thanks Kim! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt __

Re: [PATCH 1/4] crypto: caam - handle interrupt lines shared across rings

2011-05-02 Thread Herbert Xu
On Mon, May 02, 2011 at 06:27:27PM -0500, Kim Phillips wrote: > > I don't see them in cryptodev-2.6 - did you forget to push them? Indeed, they were stuck on my other machine. They should be on master now and should show up on the public mirror soon. Thanks, -- Email: Herbert Xu

Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

2011-06-22 Thread Herbert Xu
dow. If they go through the crypto > tree, that's fine too. I'll take it. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

  1   2   3   >