[PATCH 0/2] hvc_console: Add DTR/RTS callbacks to handle HUPCL conditions

Hi folks, this series resolves an issue for hvc back-ends that transfer terminal data over an established communication path. The current implementation of the hvc_console layer notifies its back-ends for tty open, close, and hangups. However, there are conditions where the hangup-on-close (HUPC

[PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

a potential refactoring of the hvc_console to use tty_port functions. Signed-off-by: Hendrik Brueckner --- drivers/tty/hvc/hvc_console.c | 11 ++- drivers/tty/hvc/hvc_console.h |3 +++ 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b

[PATCH 2/2] tty/hvc_iucv: Disconnect IUCV connection when lowering DTR

caused undesired disconnects during the login phase. To prevent these kind of disconnects, implement the dtr_rts callback to implicitly handle the HUPCL termios control via the hvc_console driver. Signed-off-by: Hendrik Brueckner --- drivers/tty/hvc/hvc_iucv.c | 64

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

Hi Benjamin, On Fri, Oct 11, 2013 at 06:15:11PM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2013-07-02 at 17:07 +0200, Hendrik Brueckner wrote: > > Introduce a new callback to explicitly handle the HUPCL termios control > > flag. > > This prepares for a follow-up co

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

Hi Benjamin, On Sat, Oct 12, 2013 at 07:43:24AM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2013-10-11 at 14:47 +0200, Hendrik Brueckner wrote: > > The tiocmget/tiocmset callbacks are used to set and get modem status and > > triggered through an tty ioctl. > > > >

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

On Tue, Oct 15, 2013 at 03:47:50PM -0500, Benjamin Herrenschmidt wrote: > On Tue, 2013-10-15 at 17:36 +0200, Hendrik Brueckner wrote: > > On Sat, Oct 12, 2013 at 07:43:24AM +1100, Benjamin Herrenschmidt wrote: > > > On Fri, 2013-10-11 at 14:47 +0200, Hendrik Brueckner wrote: &g

Re: [PATCH 1/2] tty/hvc_console: Add DTR/RTS callback to handle HUPCL control

On Wed, Oct 16, 2013 at 06:21:12PM -0500, Benjamin Herrenschmidt wrote: > On Wed, 2013-10-16 at 11:04 +0200, Hendrik Brueckner wrote: > > Indeed, two callbacks change the DTR line. The main difference is that > > tiocmget/tiocmset can be called from user space by ioctl. That'

Re: [PATCH v2 15/20] s390: perf/events: advertise PMU exclusion capability

dling events where any exclusion flags are set. > > Signed-off-by: Andrew Murray > --- > arch/s390/kernel/perf_cpum_cf.c | 1 + > arch/s390/kernel/perf_cpum_sf.c | 2 ++ > 2 files changed, 3 insertions(+) Reviewed-by: Hendrik Brueckner

[PATCH] hvc_console: provide (un)locked version for hvc_resize()

_console calls the hvc_resize() function without locking the hvc_struct. According to naming rules, the unlocked version is renamed and prefixed with "__". References to unlocked function calls in hvc back-ends has been updated. Signed-off-by: Hendrik Brueckner Acked-by: Christian Bo

Re: [PATCH] hvc_console: returning 0 from put_chars is not an error

On Thu, Oct 15, 2009 at 02:32:54PM -0500, Scott Wood wrote: > Christian Borntraeger wrote: >> About the backends, there are some that spin until the text is >> delivered (e.g. virtio) , others can drop (e.g. iucv is a connection >> oriented protocol and it will (and has to) drop if there is no >

Re: hvc_console change results in corrupt oops output

On Mon, Jul 04, 2011 at 11:56:27PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-07-04 at 20:57 +1000, Anton Blanchard wrote: > > .../... > > > The hypervisor gives us a busy return, so we could retry a number of > > times instead of dropping it on the floor. We'd need to do it in the > >

[RFC] [PATCH] hvc_console: improve tty/console put_chars handling

Hi folks, On Tue, Jul 05, 2011 at 04:22:43PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2011-07-05 at 04:17 +, Tabi Timur-B04825 wrote: > > On Mon, Jul 4, 2011 at 9:24 AM, Hendrik Brueckner > > wrote: > > > > I started that thread. After much sou

[RFC PATCH 1/5] hvc_console: Adding hangup notifier

From: Hendrik Brueckner <[EMAIL PROTECTED]> I have added a hangup notifier that can be used by hvc console backends to handle a tty hangup. The default irq hangup notifier calls the notifier_del_irq() for compatibility. Acked-by: Christian Borntraeger <[EMAIL PROTECTED]> Signed-off

[RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

From: Hendrik Brueckner <[EMAIL PROTECTED]> After a tty hangup() or close() operation, processes might not reset the termio settings to a sane state. In order to reset the termios to its default settings the tty driver flag TTY_DRIVER_RESET_TERMIOS has been added. TTY driver flag descr

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

c_console: Add tty window resizing using tty_do_resize() From: Hendrik Brueckner <[EMAIL PROTECTED]> The patch provides the hvc_resize() function to update the terminal window dimensions (struct winsize) for a specified hvc console. The function stores the new window size and schedules a f

[RFC PATCH 3/5] hvc_console: Fix loop if put_char() returns 0

From: Hendrik Brueckner <[EMAIL PROTECTED]> If put_char() routine of a hvc console backend returns 0, then the hvc console starts looping in the following scenarios: 1. hvc_console_print() If put_char() returns 0 then the while loop may loop forever. I have added the m

[RFC PATCH 4/5] hvc_console: Add tty window resizing

From: Hendrik Brueckner <[EMAIL PROTECTED]> The patch provides the hvc_resize() function to update the terminal window dimensions (struct winsize) for a specified hvc console. The function stores the new window size and schedules a function that finally updates the tty winsize and signa

[RFC PATCH 5/5] hvc_console: Remove __devexit annotation of hvc_remove()

From: Hendrik Brueckner <[EMAIL PROTECTED]> Removed __devexit annotation of hvc_remove() to avoid a section mismatch if the backend initialization fails and hvc_remove() must be used to clean up allocated hvc structs (called in section __init or __devinit). Acked-by: Christian Bornt

[RFC PATCH 0/5] patches for a network-based hvc backend (s390)

Any review feedback would be greatly appreciated. Thank you in advance. Regards, Hendrik -- Hendrik Brueckner D/3303 Linux on System z Development Tel: +49 7031 16-1073 Fax: +49 7031 16-3456 eMail: [EMAIL PROTECTED] IBM Deutschland Research & Development GmbH, Schoenaicher Str. 220, 71032 B

Re: [RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

Hello, for the sake of completion, here are few more details why I have suggest to add the TTY_DRIVER_RESET_TERMIOS flag: On Tue, Oct 14, 2008 at 10:40:25AM +0100, Alan Cox wrote: > On Tue, 14 Oct 2008 11:12:49 +0200 > Hendrik Brueckner <[EMAIL PROTECTED]> wrote: > > > Af

Re: [RFC PATCH 0/5] patches for a network-based hvc backend (s390)

. that would be really great! Regards Hendrik -- Hendrik Brueckner D/3303 Linux on System z Development Tel: +49 7031 16-1073 Fax: +49 7031 16-3456 eMail: [EMAIL PROTECTED] IBM Deutschland Research & Development GmbH, Schoenaicher Str. 220, 71032 Boeblingen IBM Deutschland Research &

Re: linux-next: ttydev tree build failure

support for > tty window resizing"). > > The former added another call to the function that the latter changed. In linux-next, the pty-simplify-resize patch has changed the tty_do_resize() signature; and therefore the hvc patch did not compile. > I applied the following patch. Th

[patch 0/1] hvc_console: fix: remove duplicate hp->ws winsize check

Hello, this patch fixes a hvc terminal resize problem by removing a duplicate winsize comparison. Ben, could you add this patch to your tree for 2.6.28-rc6 bug fixes? Thanks and regards, Hendrik -- Hendrik Brueckner D/3303 Linux on System z Development eMail: [EMAIL PROTECTED] IBM Deutschland

[patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync

From: Hendrik Brueckner <[EMAIL PROTECTED]> The test to check for a new winsize runs out-of-sync with the underlying tty. After a tty has been released and initialized again, the winsize might differ between the tty and the hp struct. The solution is to simply remove the check and

Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync

Hi Paul, On Wed, Dec 03, 2008 at 08:17:13PM +1100, Paul Mackerras wrote: > Looks OK. Is this going to go in via the s390 tree, or should I put > it in the powerpc tree? The patch should go via the powerpc tree. Thanks and regards, Hendrik ___ Linuxppc-

[patch 0/1] hvc_console: send magic sysrq key to terminal

Hello, the patch allows to send the magic sysrq key to the terminal (if pressed twice), so that it can be consumed by applications (e.g. ^0 is used by some editors...) Ben, Paul, could you add the patch to your powerpc tree? Thanks and regards, Hendrik -- Hendrik Brueckner D/3303 Linux on

[patch 1/1] hvc_console: escape magic sysrq key

From: Hendrik Brueckner The ctrl-o (^O) is a common control key used by several applications like vim. To allow users to send ^O to the terminal, this patch introduces a check if ^O is pressed again if the sysrq_pressed variable is already set. In this case, clear sysrq_pressed state and flip

Re: [patch 1/1 v2] hvc_console: escape magic sysrq key

wice when ^O is meant. Correct. I have updated the comment. > > + sysrq_pressed = (sysrq_pressed) ? 0 : 1; > sysrq_pressed = !sysrc_pressed; Ok, it might look better. [PATCH v2] hvc_console: escape magic sysrq key

Re: [PATCH 1/4] hvc_console: do not set low_latency

> if (hp->ops->notifier_add) > rc = hp->ops->notifier_add(hp, hp->data); > > + if (!hp->irq_requested) > + tty->low_latency = 1; /* Makes flushes to ldisc synchronous. */ > + > /* >* If the notifier fails we return an

Re: [PATCH 1/4 v2] hvc_console: remove tty->low_latency

0>] kthread+0x68/0xa0 [<00109d5a>] kernel_thread_starter+0x6/0xc [<00109d54>] kernel_thread_starter+0x0/0xc 1 lock held by khvcd/748: #0: (hvc_structs_lock){--..}, at: [<002ceb50>] khvcd+0x58/0x12c Signed-off-by: Hendrik Brueckner --- drivers/char/hvc_cons