[PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-12 Thread He Ying
The variable 'uaccess_fulsh' is not referenced outside the file. Perhaps we should define it as static to avoid the warning as follows: arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be static? Reported-by: Hulk Robot Si

[PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c"

2021-03-15 Thread He Ying
mbol 'rfi_flush' was not declared. Should it be static? arch/powerpc/kernel/setup_64.c:952:6: warning: symbol 'entry_flush' was not declared. Should it be static? arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it

[PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-15 Thread He Ying
uaccess_flush' as static because they are not referenced outside the file. Include asm/security_features.h in which 'rfi_flush' is declared. Reported-by: Hulk Robot Signed-off-by: He Ying --- arch/powerpc/kernel/setup_64.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-17 Thread He Ying
Should it be static? Declare 'decrementer_max' in arch/powerpc/include/asm/time.h. And include proper header in which 'rtc_lock' is declared. Move 'dtl_consumer' definition behind "include " because 'dtl_consumer' is declared there. Reported-by: Hulk Robot

[PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread He Ying
Should it be static? Declare 'decrementer_max' and 'rtc_lock' in powerpc asm/time.h. Rename 'rtc_lock' in drviers/rtc/rtc-vr41xx.c to 'vr41xx_rtc_lock' to avoid the conflict with the variable in powerpc asm/time.h. Move 'dtl_consumer' definition behind "inc

[PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread He Ying
ve 'dtl_consumer' definition behind "include " because it is declared there. Reported-by: Hulk Robot Signed-off-by: He Ying --- V2: - Instead of including linux/mc146818rtc.h in powerpc kernel/time.c, declare rtc_lock in powerpc asm/time.h. V3: - Recover to V1, that is

[PATCH] docs: powerpc: Fix misspellings and grammar errors

2021-03-26 Thread He Ying
Reported-by: Hulk Robot Signed-off-by: He Ying --- Documentation/powerpc/booting.rst| 2 +- Documentation/powerpc/dawr-power9.rst| 2 +- Documentation/powerpc/eeh-pci-error-recovery.rst | 2 +- Documentation/powerpc/elfnote.rst| 2 +- Documentation

[PATCH] powerpc: Fix kernel-jump address for ppc64 wrapper boot

2021-06-04 Thread He Ying
on. So, when we want to jump to an address (e.g. addr) to execute for PPC-elf64abi, we should assign the address of addr *NOT* addr itself to the function pointer or system will jump to the wrong address. Link: https://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi.html#FUNC-DES Signed-of

Re: [PATCH] powerpc: Fix kernel-jump address for ppc64 wrapper boot

2021-06-07 Thread He Ying
Hello, 在 2021/6/8 13:26, Oliver O'Halloran 写道: On Fri, Jun 4, 2021 at 7:39 PM He Ying wrote: From "64-bit PowerPC ELF Application Binary Interface Supplement 1.9", we know that the value of a function pointer in a language like C is the address of the function descripto

Re: [PATCH] powerpc: Fix kernel-jump address for ppc64 wrapper boot

2021-06-08 Thread He Ying
Hello, 在 2021/6/8 12:55, Christophe Leroy 写道: Le 04/06/2021 à 11:22, He Ying a écrit :  From "64-bit PowerPC ELF Application Binary Interface Supplement 1.9", we know that the value of a function pointer in a language like C is the address of the function descriptor and the first

[PATCH] powerpc/44x/fsp2: Add missing of_node_put in node_irq_request

2021-11-01 Thread He Ying
Early exits from for_each_compatible_node() should decrement the node reference counter. Signed-off-by: He Ying --- arch/powerpc/platforms/44x/fsp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c index b299e43f5ef9

[PATCH] powerpc: Fix reference leak of node np in opal_lpc_init

2021-11-01 Thread He Ying
adding missing of_node_put(). Signed-off-by: He Ying --- arch/powerpc/kernel/isa-bridge.c | 10 +- arch/powerpc/platforms/powernv/opal-lpc.c | 6 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/isa-bridge.c b/arch/powerpc/kernel/isa

[PATCH] powerpc/sysdev/of_rtc: Fix possible memory leak in of_instantiate_rtc

2021-11-02 Thread He Ying
If of_address_to_resource() in of_instantiate_rtc() fails, previously allocated memory res is not freed. Add missing kfree() for it. Signed-off-by: He Ying --- arch/powerpc/sysdev/of_rtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/of_rtc.c b/arch/powerpc/sysdev

[PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

2021-11-02 Thread He Ying
Early exits from for_each_compatible_node() should decrease the node reference count. Signed-off-by: He Ying --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx

Re: [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

2021-11-08 Thread He Ying
kindly ping... 在 2021/11/3 9:48, He Ying 写道: Early exits from for_each_compatible_node() should decrease the node reference count. Signed-off-by: He Ying --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/embedded6xx