Re: RFC: prepare for struct scatterlist entries without page backing

2015-08-12 Thread Grant Grundler
On Wed, Aug 12, 2015 at 10:00 AM, James Bottomley wrote: > On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote: ... >> However the ccio (parisc) and sba_iommu (parisc & ia64) IOMMUs seem >> to be operate mostly on virtual addresses. It's a fairly odd concept >> that I don't fully grasp, so

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Grant Grundler
y called: pci_msi_enable() -> pci_msi_enable_block() -> msi_capability_init() -> pci_intx_for_msi(dev, 0) -> pci_intx(pdev, 0); (thanks to willy (Mathew Wilcox) for pointing me at msi_capability_init() - I overlooked it) Please add "Reviewed-by: G

[PATCH] linux-next remove wmb() from ide-dma-sff.c and scc_pata.c

2009-03-30 Thread Grant Grundler
NUMA machines. I'm not going to guess how this driver might work. Gmail is broken for sending patches (word wrap). My apologies. I've attached the patch: diff-next-remove_wmb_from_ide-01.txt Patch is against linux-next tree: git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-ne

Re: tracking of PCI address space

2009-04-09 Thread Grant Grundler
On Wed, Apr 08, 2009 at 03:53:55PM -0500, Kumar Gala wrote: > I was wondering if we have anything that tracks regions associated with > the "inbound" side of a pci_bus. > > What I mean is on embedded PPC we have window/mapping registers for both > inbound (accessing memory on the SoC) and outboun

Re: [PATCHv3 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-09-18 Thread Grant Grundler
On Mon, Sep 18, 2023 at 4:42 AM Xi Ruoyao wrote: > > On Mon, 2023-08-14 at 08:40 -0700, Grant Grundler wrote: > > On Sat, Aug 12, 2023 at 5:45 PM David Heidelberg > > wrote: > > > > > > Tested-by: David Heidelberg > > > > Thanks David! > >

Re: [PATCHv3 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-08-14 Thread Grant Grundler
On Sat, Aug 12, 2023 at 5:45 PM David Heidelberg wrote: > > Tested-by: David Heidelberg Thanks David! > For PATCH v4 please fix the typo reported by the bot :) Sorry - I'll do that today. > Seeing messages as > > __aer_print_error: 72 callbacks suppressed > > but it still prints many errors o

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-04-07 Thread Grant Grundler
On Thu, Apr 6, 2023 at 12:50 PM Bjorn Helgaas wrote: > > On Fri, Mar 17, 2023 at 10:51:09AM -0700, Grant Grundler wrote: > > From: Rajat Khandelwal > > > > There are many instances where correctable errors tend to inundate > > the message buffer. We observe such ins

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-04-07 Thread Grant Grundler
[reposting in plain text mode] On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > > On Fri, Apr 07, 2023 at 11:53:27AM -0700, Grant Grundler wrote: > > On Thu, Apr 6, 2023 at 12:50 PM Bjorn Helgaas wrote: > > > On Fri, Mar 17, 2023 at 10:51:09AM -0700, Grant Grundle

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-04-07 Thread Grant Grundler
[reposting in plain text mode] On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > > On Fri, Apr 07, 2023 at 11:53:27AM -0700, Grant Grundler wrote: > > On Thu, Apr 6, 2023 at 12:50 PM Bjorn Helgaas wrote: > > > On Fri, Mar 17, 2023 at 10:51:09AM -0700, Grant Grundle

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-04-08 Thread Grant Grundler
On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > On Fri, Apr 07, 2023 at 11:53:27AM -0700, Grant Grundler wrote: > > On Thu, Apr 6, 2023 at 12:50 PM Bjorn Helgaas > wrote: > > > On Fri, Mar 17, 2023 at 10:51:09AM -0700, Grant Grundler wrote: > >

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-05-17 Thread Grant Grundler
On Wed, May 17, 2023 at 9:03 AM Bjorn Helgaas wrote: > > On Fri, Apr 07, 2023 at 04:46:03PM -0700, Grant Grundler wrote: > > On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > > > On Fri, Apr 07, 2023 at 11:53:27AM -0700, Grant Grundler wrote: > > > > On T

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-05-17 Thread Grant Grundler
On Wed, May 17, 2023 at 9:03 AM Bjorn Helgaas wrote: > > On Fri, Apr 07, 2023 at 04:46:03PM -0700, Grant Grundler wrote: > > On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > > > On Fri, Apr 07, 2023 at 11:53:27AM -0700, Grant Grundler wrote: > > > > On T

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-05-17 Thread Grant Grundler
On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: ... > But I don't think we need output in a single step; we just need a > single instance of ratelimit_state (or one for CPER path and another > for native AER path), and that can control all the output for a single > error. E.g., print_hmi_eve

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-06-05 Thread Grant Grundler
[plain text only this time...] On Wed, May 17, 2023 at 11:11 PM Grant Grundler wrote: > > On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > ... > > But I don't think we need output in a single step; we just need a > > single instance of ratelimit_state (or one

[PATCH 1/2] PCI/AER: correctable error message as KERN_INFO

2023-06-05 Thread Grant Grundler
sages from most audiences. Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..d7bfc6070ddb 100644 --- a/drivers/pci/pcie/aer.c +++

[PATCH 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-06-05 Thread Grant Grundler
38817] igc :2b:00.0:[12] Timeout This gets repeated continuously, thus inundating the buffer. Signed-off-by: Rajat Khandelwal Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 80 +++--- 1 file changed, 51 insertions(+), 29 deletions(-) di

[PATCHv3 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-06-05 Thread Grant Grundler
sages from most audiences. Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..d7bfc6070ddb 100644 --- a/drivers/pci/pcie/aer.c +++

[PATCHv3 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-06-05 Thread Grant Grundler
38817] igc :2b:00.0:[12] Timeout This gets repeated continuously, thus inundating the buffer. Signed-off-by: Rajat Khandelwal Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 80 +++--- 1 file changed, 51 insertions(+), 29 deletions(-) di

Re: [PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-06-05 Thread Grant Grundler
On Wed, May 17, 2023 at 11:11 PM Grant Grundler wrote: > On Fri, Apr 7, 2023 at 12:46 PM Bjorn Helgaas wrote: > ... > > But I don't think we need output in a single step; we just need a > > single instance of ratelimit_state (or one for CPER path and another > > f

[PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-01 Thread Grant Grundler
sages from most audiences. Signed-off-by: Grant Grundler --- This patch will likely conflict with: https://lore.kernel.org/all/20230103165548.570377-1-rajat.khandel...@linux.intel.com/ which I'd also like to see upstream. Please let me know to resubmit mine if Rajat's patch lands fir

Re: [PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-08 Thread Grant Grundler
Ping? Did I miss an email or other work that this patch collides with? cheers, grant On Tue, Feb 28, 2023 at 10:05 PM Grant Grundler wrote: > > Since correctable errors have been corrected (and counted), the dmesg output > should not be reported as a warning, but rather as "

Re: [PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-08 Thread Grant Grundler
On Wed, Mar 8, 2023 at 12:18 PM Bjorn Helgaas wrote: > > On Wed, Mar 08, 2023 at 12:00:48PM -0800, Grant Grundler wrote: > > Ping? Did I miss an email or other work that this patch collides with? > > Nope, we typically make topic branches based on -rc1, so not much > hap

Re: [PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-14 Thread Grant Grundler
On Tue, Mar 14, 2023 at 12:38 PM Bjorn Helgaas wrote: > > On Tue, Feb 28, 2023 at 10:04:53PM -0800, Grant Grundler wrote: > > Since correctable errors have been corrected (and counted), the dmesg output > > should not be reported as a warning, but rather as "informatio

[PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Grant Grundler
sages from most audiences. Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..cb6b96233967 100644 --- a/drivers/pci/pcie/aer

[PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-03-17 Thread Grant Grundler
38817] igc :2b:00.0:[12] Timeout This gets repeated continuously, thus inundating the buffer. Signed-off-by: Rajat Khandelwal Signed-off-by: Grant Grundler --- drivers/pci/pcie/aer.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) di

Re: [PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Grant Grundler
On Tue, Mar 14, 2023 at 5:24 PM Grant Grundler wrote: > > On Tue, Mar 14, 2023 at 12:38 PM Bjorn Helgaas wrote: > > > > On Tue, Feb 28, 2023 at 10:04:53PM -0800, Grant Grundler wrote: > > > Since correctable errors have been corrected (and counted), the dmesg >

Re: [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-03-18 Thread Grant Grundler
On Fri, Mar 17, 2023 at 12:31 PM Bjorn Helgaas wrote: > > On Fri, Mar 17, 2023 at 11:50:22AM -0700, Sathyanarayanan Kuppuswamy wrote: > > On 3/17/23 10:51 AM, Grant Grundler wrote: > > > Since correctable errors have been corrected (and counted), the dmesg > > &

Re: PCI Failed to allocate mem for PCI ROM

2008-01-11 Thread Grant Grundler
On Fri, Jan 11, 2008 at 02:27:16PM -0600, Kumar Gala wrote: >>> I'm getting the following message from the kernel on an embedded ppc32 >>> system: >>> >>> PCI: Failed to allocate mem resource #9:[EMAIL PROTECTED] for :00:00.0 >>> >>> The HW setup is a PCIe host controller and an e1000 NIC card.

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Grant Grundler
On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: > There are many implementations of pcibios_enable_resources() that differ > in minor ways that look more like bugs than architectural differences. > This patch series consolidates most of them to use the x86 version. > > This series i

Re: [2.6 patch] asm/ptrace.h userspace headers cleanup

2008-06-23 Thread Grant Grundler
tion until next branch */ > + > #ifdef __KERNEL__ > > +#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS)) > + > /* XXX should we use iaoq[1] or iaoq[0] ? */ > #define user_mode(regs) (((regs)->iaoq[0] & 3) ? 1 : 0) > #d

Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-02-28 Thread Grant Grundler
On Wed, Feb 27, 2008 at 05:04:42PM -0700, Bjorn Helgaas wrote: > Move PERR and SERR enables from pcibios_enable_resources() to > platform_pci_enable_device() so the former matches other > architectures and can be shared. > > Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> A