RE: [EXTERNAL] Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-06 Thread George Cherian
Hi Guenter, I am summarizing the topics we discussed in multiple threads here. >>On 3/5/25 03:01, Ahmad Fatoum wrote: >> Hi George, >> Hi Guenter, >> >> On 05.03.25 11:34, George Cherian wrote: >>>> why is armada_37xx_wdt also here? >>>> The

[PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

2025-03-05 Thread George Cherian
provision can be enabled by passing watchdog.stop_on_panic=1 via kernel command-line parameter. Signed-off-by: George Cherian --- drivers/watchdog/watchdog_core.c | 35 include/linux/watchdog.h | 2 ++ 2 files changed, 37 insertions(+) diff --git a/drivers

[PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
dicate whether stop function sleeps. - Simplify the stop_on_panic kernel command line parsing. - Enable the panic notiffier only if the watchdog stop function doesn't sleep George Cherian (2): watchdog: Add a new flag WDIOF_STOP_MAYSLEEP drivers: watchdog: Add support for panic notifier

RE: [EXTERNAL] Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
Hi Ahmad, >Hi George, > On 05.03.25 11:10, George Cherian wrote: >> This series adds a new kernel command line option to watchdog core to >> stop the watchdog on panic. This is useul in certain systems which prevents >> successful loading of kdump kernel due to watchdog r

[PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
A new option flag is added to watchdog_info. This helps the watchdog core to check whether stop functions would sleep or not. The option flags of individual drivers are also updated accordingly. Signed-off-by: George Cherian --- drivers/watchdog/advantech_ec_wdt.c | 3 ++- drivers/watchdog

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
From: Marek BehĂșn Sent: Wednesday, March 5, 2025 3:48 PM To: George Cherian Cc: li...@roeck-us.net; w...@linux-watchdog.org; jwer...@chromium.org; evanb...@chromium.org; k...@kernel.org; mazziesacco...@gmail.com; thomas.rich...@bootlin.com; l...@chromium.org; ble...@chromium.org

Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
Hi Ahmad, >Hi George, > >On 05.03.25 12:28, George Cherian wrote: > Hi Ahmad, >>> Hi George, >>> On 05.03.25 11:10, George Cherian wrote: >>>> This series adds a new kernel command line option to watchdog core to >>>> stop the watchdog on

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-15 Thread George Cherian
Hi Julius, >> static const struct watchdog_ops adv_ec_wdt_ops = { >> diff --git a/drivers/watchdog/arm_smc_wdt.c b/drivers/watchdog/arm_smc_wdt.c >> index 8f3d0c3a005f..794cf0086912 100644 >> --- a/drivers/watchdog/arm_smc_wdt.c >> +++ b/drivers/watchdog/arm_smc_wdt.c >> @@ -90,7 +90,8 @@ static c