RE: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Farber, Eliav
On 11/28/2024 12:39 PM, Thomas Gleixner wrote: > This is just wrong. If the interrupt was torn down, then its state is > deactivated and it was masked already. So the EOI handling and the > mask/disable dance are neither required nor make sense. > > So this whole thing should be: > >

RE: [PATCH v4 2/2] kexec: Prevent redundant IRQ masking by checking state before shutdown

2024-11-30 Thread Farber, Eliav
On 11/29/2024 3:32 PM, Thomas Gleixner wrote: >> This patch addresses the issue by: > > Again: git grep 'This patch' Documentation/process/ Done (in v5 series)

RE: [PATCH v4 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-11-30 Thread Farber, Eliav
On 11/29/2024 3:30 PM, Thomas Gleixner wrote: >> Move the machine_kexec_mask_interrupts function to a common location in >> kernel/kexec_core.c, removing duplicate implementations from architecture >> specific files (arch/arm, arch/arm64, arch/powerpc, and arch/riscv). > > Can you please move this

RE: [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-12-03 Thread Farber, Eliav
On 12/3/2024 1:04 PM, Thomas Gleixner wrote: >> + >> +config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD >> + bool "Clear forwarded VM interrupts during kexec" > > This should not be user selectable. Just keep it as: > > config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD > bool > > which defaults to 'n'.

RE: [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation

2024-12-04 Thread Farber, Eliav
On 12/4/2024 1:02 PM, Jiri Slaby wrote: >> + >> +config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD >> + bool "Clear forwarded VM interrupts during kexec" >> + default n >> + help >> + When enabled, this option allows the kernel to clear the active state >> + of interrupts that are f