Re: [PATCH] hvc_xen: avoid uninitialized variable warning

2015-05-28 Thread David Vrabel
On 28/05/15 09:28, Jan Beulich wrote: > Older compilers don't recognize that "v" can't be used uninitialized; > other code using hvm_get_parameter() zeros the value too, so follow > suit here. Applied to for-linus-4.2, thanks. David ___ Linuxppc-dev mai

Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-05 Thread David Vrabel
On 05/09/14 11:09, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. [...] > --- a/arch/x86/pci/xen.c > +++ b/arch/x86/pci/xen.c [...] > @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >

Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq()

2014-09-10 Thread David Vrabel
reparation for using struct > msi_chip instead of weak arch MSI functions in all platforms. Acked-by: David Vrabel But I wonder if it would be better the Xen subsystem to provide its own struct irq_chip instead of adjusting the fields in the generic x86 one. David __

Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-10 Thread David Vrabel
On 09/09/14 03:06, Yijing Wang wrote: > On 2014/9/5 22:29, David Vrabel wrote: >> On 05/09/14 11:09, Yijing Wang wrote: >>> Use MSI chip framework instead of arch MSI functions to configure >>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >

Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq()

2014-09-11 Thread David Vrabel
On 11/09/14 02:22, Yijing Wang wrote: > On 2014/9/10 20:36, David Vrabel wrote: >> On 05/09/14 11:09, Yijing Wang wrote: >>> Commit 0e4ccb150 added two __weak arch functions arch_msix_mask_irq() >>> and arch_msi_mask_irq() to fix a bug found when running xen in x8

Re: [Xen-devel] [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched()

2015-07-20 Thread David Vrabel
On 15/07/15 10:52, Konstantin Khlebnikov wrote: > This code is used only when CONFIG_PREEMPT=n and only in non-atomic context: > xen_in_preemptible_hcall is set only in privcmd_ioctl_hypercall(). > Thus preempt_count is zero and should_resched() is equal to need_resched(). Applied to for-linus-4.3

Re: [PATCH v2 11/20] tty/hvc: xen: Use xen page definition

2015-07-24 Thread David Vrabel
On 09/07/15 21:42, Julien Grall wrote: > The console ring is always based on the page granularity of Xen. [...] > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -392,7 +392,7 @@ static int xencons_connect_backend(struct xenbus_device > *dev, > if (xen_pv_domain()) >

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
page_to_gfn. More complex clean up > will come in follow-up patches. > > I think it may be possible to do further clean up in the x86 code to > ensure that helpers returning machine address (such as virt_address) is > not used by no auto-translated guests. I will let x86 xen expert d

Re: [Xen-devel] [PATCH 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-07-28 Thread David Vrabel
m. Reviewed-by: David Vrabel David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread David Vrabel
On 29/07/15 12:35, Julien Grall wrote: > Hi Wei, > > On 29/07/15 11:13, Wei Liu wrote: >> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: >> [...] >>> diff --git a/drivers/net/xen-netback/netback.c >>> b/drivers/net/xen-netback/netback.c >>> index 7d50711..3b7b7c3 100644 >>> --- a/d

Re: [Xen-devel] [PATCH v3 0/9] Use correctly the Xen memory terminologies

2015-08-11 Thread David Vrabel
On 07/08/15 17:34, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/xen/mm.h [1] for Linux xen code. Applied to for-linus-4.3, thanks. David ___ Linuxppc-dev mailing list Linuxppc-dev@lists

Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition

2015-08-20 Thread David Vrabel
On 07/08/15 17:46, Julien Grall wrote: > The console ring is always based on the page granularity of Xen. [...] > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) > if (r < 0 || v == 0) > goto err; >

Re: [Xen-devel] [RFC PATCH 01/20] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq()

2014-08-12 Thread David Vrabel
On 12/08/14 08:25, Yijing Wang wrote: > Commit 0e4ccb150 added two __weak arch functions arch_msix_mask_irq() > and arch_msi_mask_irq() to fix a bug found when running xen in x86. > Introduced these two funcntions make MSI code complex. This patch > reverted commit 0e4ccb150 and add #ifdef for x86

Re: [PATCH v2] drivers/tty/hvc: don't use module_init in non-modular hyp. console code

2014-01-16 Thread David Vrabel
they are only ever of interest to UML, and UML will never be > using any of this code. For the hvc_xen changes Acked-by: David Vrabel Thanks David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread David Vrabel
cgi?id=58145) > > Change the p2m code to replace ACCESS_ONCE with READ_ONCE. Acked-by: David Vrabel Let me know if you want me to merge this via the Xen tree. David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

Re: [Xen-devel] [PATCH v2 34/34] xen/io: use virt_xxx barriers

2016-01-04 Thread David Vrabel
P guest runs on an SMP host. > > Switch to virt_xxx barriers which serve this exact purpose. Acked-by: David Vrabel David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Xen-devel] [PATCH v2 33/34] xenbus: use virt_xxx barriers

2016-01-04 Thread David Vrabel
-SMP guest runs on an SMP host. > > Switch to virt_xxx barriers which serve this exact purpose. Acked-by: David Vrabel If you're feeling particularly keen there's a rmb() consume_one_event() in drivers/xen/events/events_fifo.c that can be conve

Re: [PATCH v3 39/41] xen/events: use virt_xxx barriers

2016-01-11 Thread David Vrabel
witch to the virt_rmb barrier which serves this exact purpose. > > Pull in asm/barrier.h here to make sure the file is self-contained. > > Suggested-by: David Vrabel > Signed-off-by: Michael S. Tsirkin Acked-by: David Vrabel David __

Re: [PATCH 3/4] sdhci-of: Fix high-speed cards recognition

2009-08-07 Thread David Vrabel
used in the spec. Suggest: /* Controller uses SDCLK instead of TMCLK for data timeouts. */ #define SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK (1 << 24) David -- David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Camb

Re: [RFC v3 20/45] xen: dma-mapping: Use unsigned long for dma_attrs

2016-06-07 Thread David Vrabel
On 02/06/16 16:39, Krzysztof Kozlowski wrote: > Split out subsystem specific changes for easier reviews. This will be > squashed with main commit. Acked-by: David Vrabel David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org