Re: [PATCH] kgdb: Removed kmalloc returned value cast

2013-03-10 Thread Daniel Baluta
On Sun, Mar 10, 2013 at 4:10 PM, Pekka Enberg wrote: > On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad wrote: >> Signed-off-by: Alex Grad >> --- >> arch/powerpc/kernel/kgdb.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kern

Re: [PATCH 1/2] ASoC: fsl_audmix: remove "model" attribute

2019-04-09 Thread Daniel Baluta
Hi Viorel, Few comments inline. On Tue, Apr 9, 2019 at 11:36 AM Viorel Suman wrote: > > Use "of_device_id.data" to specify the machine driver, > instead of "model" DTS attribute. > static int fsl_audmix_probe(struct platform_device *pdev) > { > + struct device *dev = &pdev->dev; You

Re: [PATCH 2/2] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-09 Thread Daniel Baluta
On Tue, Apr 9, 2019 at 11:36 AM Viorel Suman wrote: > > Release the reference to the underlying device taken > by of_find_device_by_node() call. > > Signed-off-by: Viorel Suman Please add here the Reported-by tag pointing to Julia. > --- > sound/soc/fsl/imx-audmix.c | 31 +++---

Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute

2019-04-09 Thread Daniel Baluta
Hi Nicolin, On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen wrote: > > On Tue, Apr 09, 2019 at 11:27:39AM +, Viorel Suman wrote: > > Use "of_device_id.data" to specify the machine driver > > instead of "model" DTS attribute. > > > > Signed-off-by: Viorel Suman > > Acked-by: Nicolin Chen > > >

Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute

2019-04-09 Thread Daniel Baluta
On Wed, Apr 10, 2019 at 9:37 AM Nicolin Chen wrote: > > On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote: > > Hi Nicolin, > > > > On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen wrote: > > > > > > On Tue, Apr 09, 2019 at 11:27:3

Re: [alsa-devel] [PATCH V4] ASoC: fsl_esai: Fix missing break in switch statement

2019-04-10 Thread Daniel Baluta
Hi Shengjiu, On Thu, Apr 11, 2019 at 6:06 AM S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be > independent of each other, so replace fall-through with break. > > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > Since it is obvious that you will need t

Re: [PATCH V2 1/2] ASoC: fsl_asrc: replace the process_option table with function

2019-04-11 Thread Daniel Baluta
Hi Shengjiu, Mostly looking good. See few comments inline: > +/* > + * Select the pre-processing and post-processing options > + * > + * Fsin: input sample rate > + * Fsout: output sample rate > + * pre_proc: return value for pre-processing option > + * post_proc: return value for post-processi

Re: [PATCH 1/2] ASoC: mpc5200_dma: Fix invalid license ID

2019-04-15 Thread Daniel Baluta
On Mon, Apr 15, 2019 at 12:53 AM Fabio Estevam wrote: > > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu > wrote: > > > > As the file had no other license notice/reference, it falls under the > > project license and therefore the proper SPDX id is: GPL-2.0-onl

Re: [PATCH 1/2] ASoC: mpc5200_dma: Fix invalid license ID

2019-04-15 Thread Daniel Baluta
On Mon, Apr 15, 2019 at 10:26 AM Daniel Baluta wrote: > > On Mon, Apr 15, 2019 at 12:53 AM Fabio Estevam wrote: > > > > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu > > wrote: > > > > > > As the file had no other license notice/reference, it falls und

Re: [PATCH -next] ASoC: fsl_micfil: Remove set but not used variable 'osr'

2019-04-17 Thread Daniel Baluta
Hi Yue, Looks good to me. Just one question for Cosmin: On Wed, Apr 17, 2019 at 6:10 PM Yue Haibing wrote: > > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > sound/soc/fsl/fsl_micfil.c: In function 'get_clk_div': > sound/soc/fsl/fsl_micfil.c:154:6: warning: variable 'os

[PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-20 Thread Daniel Baluta
ion selected. 11b - Master Clock (MCLK) 3 option selected. So, this patch will read mclk0 source clock from device tree. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.

[PATCH 0/2] Add runtime PM for SAI digital audio interface

2019-04-20 Thread Daniel Baluta
First patch uses system PM handlers to implement runtime PM. While the second patch moves clock handling from startup/shutdown to runtime PM handlers. Daniel Baluta (1): ASoC: fsl: sai: Add support for runtime pm Shengjiu Wang (1): ASoC: fsl: Move clock operation to PM runtime sound/soc

[PATCH 1/2] ASoC: fsl: sai: Add support for runtime pm

2019-04-20 Thread Daniel Baluta
Basically the same actions as for system PM, so make use of pm_runtime_force_suspend/pm_runtime_force_resume. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sound/soc

[PATCH 2/2] ASoC: fsl: Move clock operation to PM runtime

2019-04-20 Thread Daniel Baluta
From: Shengjiu Wang Turn off/on clocks when device enters suspend/resume. This helps saving power. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 54 + 1 file changed, 44 insertions(+), 10 deletions(-) diff

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Daniel Baluta
Hi Nicolin, Thanks for review! On Sun, Apr 21, 2019 at 8:39 AM Nicolin Chen wrote: > > By following the pattern of previous Subjects: > ASoC: fsl_sai: Fix clock Source for mclk0 I see. Will fix in v2. > > On Sat, Apr 20, 2019 at 03:41:04PM +, Daniel Baluta wrote: > >

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > >

[PATCH 0/3] Add runtime PM for SAI digital audio interface

2019-04-21 Thread Daniel Baluta
pm_runtime_disable - only disable/enable mclk when SAI in master mode. Daniel Baluta (2): ASoC: fsl_sai: Update is_slave_mode with correct value ASoC: fsl_sai: Add support for runtime pm Shengjiu Wang (1): ASoC: fsl_sai: Move clock operation to PM runtime sound/soc/fsl/fsl_sai.c | 84

[PATCH 1/3 v2] ASoC: fsl_sai: Update is_slave_mode with correct value

2019-04-21 Thread Daniel Baluta
mode for each call of fsl_sai_set_dai_fmt. Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index b563004fb89f..d9df98975cf8 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/f

[PATCH 2/3 v2] ASoC: fsl_sai: Add support for runtime pm

2019-04-21 Thread Daniel Baluta
Basically the same actions as for system PM, so make use of pm_runtime_force_suspend/pm_runtime_force_resume. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/sound

[PATCH 3/3 v3] ASoC: fsl_sai: Move clock operation to PM runtime

2019-04-21 Thread Daniel Baluta
From: Shengjiu Wang Turn off/on clocks when device enters suspend/resume. This can help saving power. As a further optimization, we turn off/on mclk only when SAI is in master mode because otherwise mclk is externally provided. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta

Re: [alsa-devel] [PATCH 3/3 v3] ASoC: fsl_sai: Move clock operation to PM runtime

2019-04-22 Thread Daniel Baluta
On Mon, Apr 22, 2019 at 2:07 PM Viorel Suman wrote: > > Hi Daniel, > > On Du, 2019-04-21 at 19:39 +0000, Daniel Baluta wrote: > > From: Shengjiu Wang > > > > Turn off/on clocks when device enters suspend/resume. This > > can help saving power. > > >

[PATCH v3 1/3] ASoC: fsl_sai: Update is_slave_mode with correct value

2019-04-22 Thread Daniel Baluta
mode for each call of fsl_sai_set_dai_fmt. Signed-off-by: Daniel Baluta Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_sai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index b563004fb89f..d9df98975cf8 100644 --- a/sound/soc/fsl/fsl_sai

[PATCH v3 3/3] ASoC: fsl_sai: Move clock operation to PM runtime

2019-04-22 Thread Daniel Baluta
From: Shengjiu Wang Turn off/on clocks when device enters suspend/resume. This can help saving power. As a further optimization, we turn off/on mclk only when SAI is in master mode because otherwise mclk is externally provided. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta

[PATCH v3 2/3] ASoC: fsl_sai: Add support for runtime pm

2019-04-22 Thread Daniel Baluta
Basically the same actions as for system PM, so make use of pm_runtime_force_suspend/pm_runtime_force_resume. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/sound

[PATCH v3 0/3] Add runtime PM for SAI digital audio interface

2019-04-22 Thread Daniel Baluta
n master mode. Daniel Baluta (2): ASoC: fsl_sai: Update is_slave_mode with correct value ASoC: fsl_sai: Add support for runtime pm Shengjiu Wang (1): ASoC: fsl_sai: Move clock operation to PM runtime sound/soc/fsl/fsl_sai.c | 78 + 1 file changed,

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-06 Thread Daniel Baluta
Hi Shengjiu, Comments inline. On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang wrote: > > Audmix support two substream, When two substream start > to run, the trigger function may be called by two substream > in same time, that the priv->tdms may be updated wrongly. > > The expected priv->tdms is 0x

Re: [alsa-devel] [PATCH V2] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-11 Thread Daniel Baluta
t sometimes the > result is 0x2, or 0x1. > > Fixes: be1df61cf06e ("ASoC: fsl: Add Audio Mixer CPU DAI driver") > Cc: > Signed-off-by: Shengjiu Wang > Acked-by: Nicolin Chen Reviewed-by: Daniel Baluta > --- > Change in v2 > -add Fixes, Cc stable, and Acked-by

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-11 Thread Daniel Baluta
On Thu, Nov 7, 2019 at 8:54 AM S.j. Wang wrote: > > Hi > > > > Hi Shengjiu, > > > > Comments inline. > > > > On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang > > wrote: > > > > > > Audmix support two substream, When two substream start to run, the > > > trigger function may be called by two substream

Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED

2019-12-05 Thread Daniel Baluta
On Fri, Nov 29, 2019 at 12:40 AM Michael Walle wrote: > > The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use > IRQF_SHARED to be able to use these SAIs simultaneously. Hi Michael, Thanks for the patch. We have a similar change inside our internal tree (it is on my long TODO list

Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED

2019-12-05 Thread Daniel Baluta
On Thu, Dec 5, 2019 at 11:18 AM Michael Walle wrote: > > Hi Daniel, > > Am 2019-12-05 09:43, schrieb Daniel Baluta: > > On Fri, Nov 29, 2019 at 12:40 AM Michael Walle > > wrote: > >> > >> The LS1028A SoC uses the same interrupt line for adjacent SAIs. Us

[PATCH 05/10] ASoC: fsl_sai: Add support to enable multiple data lines

2019-07-22 Thread Daniel Baluta
data line #0. Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 10 +- sound/soc/fsl/fsl_sai.h | 6 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 768341608695..d0fa02188b7c 100644 --- a/sound/soc

[PATCH 06/10] ASoC: dt-bindings: Document dl_mask property

2019-07-22 Thread Daniel Baluta
SAI supports up to 8 data lines. This property let the user configure how many data lines should be used per transfer direction (Tx/Rx). Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation

[PATCH 03/10] ASoC: fsl_sai: Add registers definition for multiple datalines

2019-07-22 Thread Daniel Baluta
, Receive data register * RFR0..7, Receive FIFO register Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 76 +++-- sound/soc/fsl/fsl_sai.h | 36 --- 2 files changed, 98 insertions(+), 14 deletions(-) diff --git a/sound/soc/fsl

[PATCH 00/10] Add support for new SAI IP version

2019-07-22 Thread Daniel Baluta
ister address space. Patch 10 enable SAI for imx7ulp and imx8mq. This patch introduces Daniel Baluta (8): ASoC: fsl_sai: Add registers definition for multiple datalines ASoC: fsl_sai: Update Tx/Rx channel enable mask ASoC: fsl_sai: Add support to enable multiple data lines ASoC: dt-bindings: Doc

[PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property

2019-07-22 Thread Daniel Baluta
This allows combining multiple-data-line FIFOs into a single-data-line FIFO. Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/fsl-sai.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation

[PATCH 02/10] ASoC: fsl_sai: derive TX FIFO watermark from FIFO depth

2019-07-22 Thread Daniel Baluta
From: Lucas Stach The DMA request schould be triggered as soon as the FIFO has space for another burst. As different versions of the SAI block have different FIFO sizes, the watrmark level needs to be derived from version specific data. Signed-off-by: Lucas Stach --- sound/soc/fsl/fsl_sai.c |

[PATCH 10/10] ASoC: fsl_sai: Add support for imx7ulp/imx8mq

2019-07-22 Thread Daniel Baluta
SAI module on imx7ulp/imx8m features 2 new registers (VERID and PARAM) at the beginning of register address space. On imx7ulp FIFOs can held up to 16 x 32 bit samples. On imx8mq FIFOs can held up to 128 x 32 bit samples. Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 14

[PATCH 01/10] ASoC: fsl_sai: add of_match data

2019-07-22 Thread Daniel Baluta
From: Lucas Stach New revisions of the SAI IP block have even more differences that need be taken into account by the driver. To avoid sprinking compatible checks all over the driver move the current differences into of_match_data. Signed-off-by: Lucas Stach --- sound/soc/fsl/fsl_sai.c | 22 ++

[PATCH 07/10] ASoC: fsl_sai: Add support for FIFO combine mode

2019-07-22 Thread Daniel Baluta
mode is read from fsl,fcomb-mode DT property. By default, if no property is specified fifo combine mode is disabled. [1]https://cache.nxp.com/secured/assets/documents/en/reference-manual/IMX8MDQLQRM.pdf?__gda__=1563728701_38bea7f0f726472cc675cb141b91bec7&fileExt=.pdf Signed-off-by: Daniel Ba

[PATCH 04/10] ASoC: fsl_sai: Update Tx/Rx channel enable mask

2019-07-22 Thread Daniel Baluta
Tx channel enable (TCE) / Rx channel enable (RCE) bits enable corresponding data channel for Tx/Rx operation. Because SAI supports up the 8 channels TCE/RCE occupy up the 8 bits inside TCR3/RCR3 registers we need to extend the mask to reflect this. Signed-off-by: Daniel Baluta --- sound/soc

[PATCH 09/10] ASoC: fsl_sai: Add support for SAI new version

2019-07-22 Thread Daniel Baluta
each board private data. [1]https://cache.nxp.com/secured/assets/documents/en/reference-manual/IMX8MDQLQRM.pdf?__gda__=1563728701_38bea7f0f726472cc675cb141b91bec7&fileExt=.pdf Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 240 +++- sound/soc

Re: [alsa-devel] [PATCH 01/10] ASoC: fsl_sai: add of_match data

2019-07-23 Thread Daniel Baluta
On Tue, Jul 23, 2019 at 8:01 PM Mark Brown wrote: > > On Mon, Jul 22, 2019 at 03:48:24PM +0300, Daniel Baluta wrote: > > From: Lucas Stach > > > > New revisions of the SAI IP block have even more differences that need > > be taken into account by the driver.

Re: [alsa-devel] [PATCH 05/10] ASoC: fsl_sai: Add support to enable multiple data lines

2019-07-24 Thread Daniel Baluta
On Mon, Jul 22, 2019 at 3:58 PM Lucas Stach wrote: > > Am Montag, den 22.07.2019, 15:48 +0300 schrieb Daniel Baluta: > > SAI supports up to 8 Rx/Tx data lines which can be enabled > > using TCE/RCE bits of TCR3/RCR3 registers. > > > > Data lines to be enabled are rea

Re: [alsa-devel] [PATCH 01/10] ASoC: fsl_sai: add of_match data

2019-07-24 Thread Daniel Baluta
On Thu, Jul 25, 2019 at 1:34 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:24PM +0300, Daniel Baluta wrote: > > From: Lucas Stach > > > > New revisions of the SAI IP block have even more differences that need > > be taken into account by the driver.

Re: [alsa-devel] [PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property

2019-07-24 Thread Daniel Baluta
On Thu, Jul 25, 2019 at 2:22 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:31PM +0300, Daniel Baluta wrote: > > This allows combining multiple-data-line FIFOs into a > > single-data-line FIFO. > > > > Signed-off-by: Daniel Baluta > > --- > >

Re: [alsa-devel] [PATCH 09/10] ASoC: fsl_sai: Add support for SAI new version

2019-07-24 Thread Daniel Baluta
On Thu, Jul 25, 2019 at 2:32 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:32PM +0300, Daniel Baluta wrote: > > New IP version introduces Version ID and Parameter registers > > and optionally added Timestamp feature. > > > > VERID and PARAM registers are

Re: [alsa-devel] [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property

2019-07-24 Thread Daniel Baluta
On Thu, Jul 25, 2019 at 2:14 AM Nicolin Chen wrote: > > On Mon, Jul 22, 2019 at 03:48:29PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). >

Re: [alsa-devel] [PATCH v2 4/4] ASoC: add imx-audmix DT binding documentation

2019-01-16 Thread Daniel Baluta
On Tue, Jan 15, 2019 at 10:58 PM Rob Herring wrote: > > On Tue, Jan 08, 2019 at 01:05:51PM +, Viorel Suman wrote: > > Add the DT binding documentation for Audio Mixer > > machine driver. > > > > Signed-off-by: Viorel Suman > > --- > > .../devicetree/bindings/sound/imx-audmix.txt | 24

Re: [PATCH] ASoC: imx-audmix: register the card on a proper dev

2019-08-27 Thread Daniel Baluta
by the value in child device. > > Fixes: b86ef5367761 ("ASoC: fsl: Add Audio Mixer machine driver") > Signed-off-by: Viorel Suman > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta Thanks Shengjiu for the fix! > --- > sound/soc/fsl/imx-audmix.c | 4 ++-- > 1 file

Re: [PATCH] ASoC: imx-audmix: Fix return error with devm_clk_get()

2023-09-15 Thread Daniel Baluta
> Fixes: b86ef5367761 ("ASoC: fsl: Add Audio Mixer machine driver") > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [RFC PATCH v8 00/13] Add audio support in v4l2 framework

2023-10-30 Thread Daniel Baluta
On Mon, Oct 30, 2023 at 3:56 AM Shengjiu Wang wrote: > > On Fri, Oct 27, 2023 at 7:18 PM Hans Verkuil wrote: > > > > Hi Shengjiu, > > > > Is there a reason why this series is still marked RFC? > > > > Just wondering about that. > > In the very beginning I started this series with RFC, So > I stil

Re: [RFC PATCH v2 1/7] ASoC: fsl_asrc: define functions for memory to memory usage

2023-08-01 Thread Daniel Baluta
> +static int fsl_asrc_m2m_check_format(u8 dir, u32 rate, u32 channels, u32 > format) > +{ > + u64 support_format = FSL_ASRC_FORMATS; > + > + if (channels < 1 || channels > 10) > + return -EINVAL; > + > + if (rate < 5512 || rate > 192000) > + return -E

Re: [RFC PATCH v2 5/7] media: imx: fsl_asrc: Add memory to memory driver

2023-08-01 Thread Daniel Baluta
On Tue, Jul 25, 2023 at 10:31 AM Shengjiu Wang wrote: > > Implement the ASRC memory to memory function using > the v4l2 framework, user can use this function with > v4l2 ioctl interface. > > User send the output and capture buffer to driver and > driver store the converted data to the capture buff

Re: [PATCH 0/3] Add support for SAI on i.MX93 platform

2022-10-27 Thread Daniel Baluta
the maxburst to 8 on i.MX93 platform Reviewed-by: Daniel Baluta

Re: [PATCH] ASoC: fsl_asrc fsl_esai fsl_sai: allow CONFIG_PM=N

2022-10-28 Thread Daniel Baluta
77e7e (ASoC: fsl_sai: Don't use devm_regmap_init_mmio_clk) > > Signed-off-by: Maarten Zanders Reviewed-by: Daniel Baluta

Re: [PATCHv3 RESEND 00/10] ASoC: fsl-asoc-card: compatibility integration of a generic codec use case for use with S/PDIF controller

2023-12-18 Thread Daniel Baluta
> > * fsl-asoc-card.txt currently follows the old dt-bindings format. > Should we update it to DT schema format in this patch series > before adding my new properties? > > I know this is extra-work but we would greatly appreciate if you first convert fsl-asoc-card.txt to yml format and then add yo

Re: [PATCH v2] ASoC: fsl_sai: Fix channel swap issue on i.MX8MP

2023-12-19 Thread Daniel Baluta
) > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

2024-01-09 Thread Daniel Baluta
On Tue, Jan 9, 2024 at 9:58 AM Chancel Liu wrote: > > Add compatible string "fsl,imx95-micfil" for i.MX95 platform. > > Signed-off-by: Chancel Liu > --- > .../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/D

Re: [PATCH v2 0/3] ASoC: Support SAI and MICFIL on i.MX95 platform

2024-01-15 Thread Daniel Baluta
ndings: fsl,sai: Add compatible string for i.MX95 platform > ASoC: fsl_sai: Add support for i.MX95 platform > ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 > platform For all patches in the series: Reviewed-by: Daniel Baluta

Re: [PATCHv3 RESEND 00/10] ASoC: fsl-asoc-card: compatibility integration of a generic codec use case for use with S/PDIF controller

2024-01-16 Thread Daniel Baluta
On Fri, Dec 29, 2023 at 3:45 PM Elinor Montmasson wrote: > > Hello > > On Monday, 18 December, 2023 14:54:03, Daniel Baluta wrote > > I know this is extra-work but we would greatly appreciate if you first > > convert fsl-asoc-card.txt > > to yml format and then a

Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Add missing return 0 in remove()

2019-04-25 Thread Daniel Baluta
> So this patch just adds a "return 0" to fix it. > > Fixes: 812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm") > Reported-by: Stephen Rothwell > Signed-off-by: Nicolin Chen Reviewed-by: Daniel Baluta Thanks Nicolin! > --- > sound/soc/fsl/fsl_s

Re: [PATCH 2/3 v2] ASoC: fsl_sai: Add support for runtime pm

2019-04-26 Thread Daniel Baluta
On Fri, Apr 26, 2019 at 1:01 PM Mark Brown wrote: > > On Sun, Apr 21, 2019 at 07:39:09PM +, Daniel Baluta wrote: > > Basically the same actions as for system PM, so make use > > of pm_runtime_force_suspend/pm_runtime_force_resume. > > This doesn't apply against c

Re: [PATCH v3 3/3] ASoC: fsl_sai: Move clock operation to PM runtime

2019-04-26 Thread Daniel Baluta
Hi Mark, This is the only patch in the series that wasn't applied. On Mon, Apr 22, 2019 at 10:03 PM Daniel Baluta wrote: > > From: Shengjiu Wang > > Turn off/on clocks when device enters suspend/resume. This > can help saving power. > > As a further optimization, we

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-05-28 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > >

[PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Daniel Baluta
Chen Signed-off-by: Daniel Baluta --- sound/soc/fsl/imx-wm8962.c | 40 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c index 1b60958..3d894d9 100644 --- a/sound/soc/fsl/imx-wm8962.c +++ b/

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-24 Thread Daniel Baluta
On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen wrote: > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: >> From: Nicolin Chen >> >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better >> to control the MCLK in codec driver.

[PATCH v2] ASoC: imx-wm8960: Let codec driver enable/disable its MCLK

2017-03-24 Thread Daniel Baluta
From: Daniel Baluta WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine driver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Daniel B

[PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK

2017-03-28 Thread Daniel Baluta
codec_clk cleanup * fixed prefix subject Daniel Baluta (2): ASoC: imx-wm8962: Let codec driver enable/disable its MCLK ASoC: imx-wm8962: Fix codec_clk cleanup sound/soc/fsl/imx-wm8962.c | 41 + 1 file changed, 9 insertions(+), 32 deletions

[PATCH v3 1/2] ASoC: imx-wm8962: Let codec driver enable/disable its MCLK

2017-03-28 Thread Daniel Baluta
WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine driver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Daniel Baluta --- sound/soc/fs

[PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
Resource managed devm_clk_get only works with platform's device dev. Reported-by: Nicolin Chen Signed-off-by: Daniel Baluta --- sound/soc/fsl/imx-wm8962.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c index 3d

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: >> Resource managed devm_clk_get only works with platform's device dev. >> > > I feel like this could use an explaination of why not using devm &g

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 6:24 PM, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: >> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > >> > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL); >> > &

Re: [PATCH] ASoC: fsl_micfil: Add a flag to distinguish with different volume control types

2024-10-17 Thread Daniel Baluta
l for this kind of platform. Use common TLV volume control > for other platforms. > > Fixes: cdfa92eb90f5 ("ASoC: fsl_micfil: Correct the number of steps on SX > controls") > Signed-off-by: Chancel Liu Reviewed-by: Daniel Baluta

Re: [PATCH 1/3] ASoC: fsl_micfil: fix regmap_write_bits usage

2024-09-27 Thread Daniel Baluta
On Fri, Sep 27, 2024 at 11:23 AM Shengjiu Wang wrote: > > The last parameter 1 means BIT(0), which should be the > correct BIT(X). > > Fixes: 47a70e6fc9a8 ("ASoC: Add MICFIL SoC Digital Audio Interface driver.") > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH] ASoC: fsl: Use maple tree register cache

2024-09-25 Thread Daniel Baluta
s convert > these drivers to it. This should have no practical impact. > > Signed-off-by: Mark Brown Reviewed-by: Daniel Baluta

Re: [PATCH 0/2] ASoC: imx-card: support playback or capture only

2025-02-11 Thread Daniel Baluta
rd: Add playback_only or capture_only support > > .../devicetree/bindings/sound/imx-audio-card.yaml | 8 > sound/soc/fsl/imx-card.c | 5 + > 2 files changed, 13 insertions(+) For entire patchseries, Reviewed-by: Daniel Baluta

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

2024-12-18 Thread Daniel Baluta
On Wed, Dec 18, 2024 at 4:46 AM Shengjiu Wang wrote: > > Fix sparse warnings: > > fsl_asrc_m2m.c:360:45: sparse: warning: incorrect type in argument 1 > (different base types) > fsl_asrc_m2m.c:360:45: sparse:expected restricted snd_pcm_format_t > [usertype] pcm_forma > fsl_asrc_m2m.c:360:45:

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

2024-12-18 Thread Daniel Baluta
fsl_asrc_m2m: Add memory to memory function") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202412180043.paa4t4sq-...@intel.com/ > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH 2/2] ASoC: fsl_asrc_m2m: return error value in asrc_m2m_device_run()

2025-01-20 Thread Daniel Baluta
mory to memory function") > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH 1/2] ASoC: fsl_asrc_m2m: only handle pairs for m2m in the suspend

2025-01-20 Thread Daniel Baluta
memory to memory function") > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH 0/2] ASoC: fsl: Support MQS on i.MX943

2025-01-13 Thread Daniel Baluta
t; > Shengjiu Wang (2): > ASoC: fsl_mqs: Add i.MX943 platform support > ASoC: dt-bindings: fsl,mqs: Add compatible string for i.MX943 platform For entire patchseries: Reviewed-by: Daniel Baluta

Re: [PATCH v2 2/2] ASoC: imx-audmix: Update correct dai names

2025-02-14 Thread Daniel Baluta
Hi Chancel, This change should be squashed together with patch 1/2 otherwise you break bisectability On Fri, Feb 14, 2025 at 10:15 AM Chancel Liu wrote: > > Update correct dai names which are changed in CPU dai. > > Signed-off-by: Chancel Liu > --- > sound/soc/fsl/imx-audmix.c | 4 ++-- > 1 f