Re: [PATCH 1/5] ASoC: Explicitly include correct DT includes

2023-10-04 Thread Charles Keepax
to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- For the Wolfson/Cirrus bits: Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 2/5] ASoC: Drop unnecessary of_match_device() calls

2023-10-04 Thread Charles Keepax
-off-by: Rob Herring > --- For the cirrus bits: Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH] ASoC: do not include pm_runtime.h if not used

2023-03-07 Thread Charles Keepax
On Tue, Mar 07, 2023 at 12:30:22PM +0200, Claudiu Beznea wrote: > Do not include pm_runtime.h header in files where runtime PM support is > not implemented. > > Signed-off-by: Claudiu Beznea > --- > sound/soc/codecs/cs35l45.h| 1 - > diff --git a/sound/soc/codecs/c

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax > wrote: > > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > >> Resource managed devm_clk_get only works with platform's device dev. >

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > > > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL);

Re: [PATCH] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-20 Thread Charles Keepax
rs/watchdog/wm831x_wdt.c | 5 +--- > drivers/watchdog/wm8350_wdt.c | 5 +--- For the Wolfson parts: Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 01/11] ASoC: codecs: make snd_soc_platform_driver const

2017-08-15 Thread Charles Keepax
ed-off-by: Bhumika Goyal > --- For the Wolfson bits: Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h

2024-05-31 Thread Charles Keepax
On Fri, May 31, 2024 at 01:58:47AM +0300, Andy Shevchenko wrote: > of_gpio.h is deprecated and subject to remove. The drivers in question > don't use it, simply remove the unused header. > > Signed-off-by: Andy Shevchenko > --- > sound/soc/codecs/cs53l30.c | 1

Re: [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables

2025-05-29 Thread Charles Keepax
36_OTP_CTRL1, 0x2460}, For the cs35l56: Reviewed-by: Charles Keepax Thanks, Charles