On 07/01/14 21:39, Mike Snitzer wrote:
> (btw, Bart Van Assche also has issues with commit e8099177 due to hangs
> during cable pull testing of mpath devices -- Bart: curious to know if
> your cable pull tests pass if you just revert bcccff93).
Sorry but even with bcccff93 reverted af
On Tue, 2018-10-09 at 13:51 +, Christophe Leroy wrote:
> _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
>
> Acked-by: Geert Uytterhoeven
> Signed-off-by: Christophe Leroy
Hi Geert,
All patches that have been applied to this driver since 2005 are API refactoring
patche
On 8/14/19 9:52 AM, Abdul Haleem wrote:
> Greeting's
>
> Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on
> my powerpc power 8 lpar
>
> The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain
> if sp->done() is not...)
>
> boot logs:
>
> WARNIN
On 8/14/19 10:18 AM, Abdul Haleem wrote:
On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote:
On 8/14/19 9:52 AM, Abdul Haleem wrote:
Greeting's
Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on my
powerpc power 8 lpar
The WARN_ON_ONCE() was int
On Thu, 2018-06-07 at 12:38 +0530, vrbagal1 wrote:
> Observing Kernel oops and machine reboots while executing memory hotplug
> test case, on Power8 Baremetal machine.
>
> I see this is introduced some where between rc6 and 4.17.
Please provide the exact versions (git commit IDs) of the kernel v
On Thu, 2018-06-07 at 12:56 +0530, Venkat Rao B wrote:
> On Thursday 07 June 2018 12:46 PM, Bart Van Assche wrote:
> > On Thu, 2018-06-07 at 12:38 +0530, vrbagal1 wrote:
> > > Observing Kernel oops and machine reboots while executing memory hotplug
> > > test case,
On Mon, 2018-07-16 at 14:23 +0530, Abdul Haleem wrote:
> mpt3sas module unload triggered a warning at block/blk-core.c:781 on a
> powerpc bare-metal running mainline kernel
>
> WARN_ON_ONCE() was introduced with commit a063057 : block: Fix a race
> between request queue removal and the block cgrou
nally remove it.
>
> Signed-off-by: Wolfram Sang
> Cc: Bart Van Assche
> Cc: Jean Delvare
> ---
> Documentation/i2c/chips/pcf8575 | 69 --
> drivers/i2c/chips/Kconfig | 18
> drivers/i2c/chips/Makefile | 1 -
&g
On 8/30/19 2:13 PM, Qian Cai wrote:
https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
Once in a while, booting an IBM POWER9 PowerNV system (8335-GTH) would generate
a warning in lockdep_register_key() at,
if (WARN_ON_ONCE(static_obj(key)))
because
key = 0xc19ad1
On 11/18/23 07:50, Yury Norov wrote:
Add helpers around test_and_{set,clear}_bit() that allow to search for
clear or set bits and flip them atomically.
There is a typo in the subject: shouldn't "atomig" be changed
into "atomic"?
Thanks,
Bart.
On 11/18/23 07:50, Yury Norov wrote:
Add helpers around test_and_{set,clear}_bit() that allow to search for
clear or set bits and flip them atomically.
Has it been considered to add kunit tests for the new functions?
Thanks,
Bart.
On 4/1/24 03:03, Alexander Wetzel wrote:
commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
introduced an incorrect WARN_ON_ONCE() and missed a sequence where
sg_device_destroy() was used after scsi_device_put().
Isn't that too negative? I think that the WARN_ON_ONCE() mentioned ab
On 4/1/24 12:10 PM, Alexander Wetzel wrote:
@@ -301,11 +302,12 @@ sg_open(struct inode *inode, struct file *filp)
/* This driver's module count bumped by fops_get in */
/* Prevent the device driver from vanishing while we sleep */
- retval = scsi_device_get(sdp->device);
+
device_put() in the error handling.
Reviewed-by: Bart Van Assche
On 11/10/22 00:01, Sachin Sant wrote:
While booting 6.1.0-rc4-next-20221109 next kernel on a IBM Power9 LPAR
following warning is seen:
[ 8.808868] [ cut here ]
[ 8.808872] WARNING: CPU: 1 PID: 378 at kernel/module/main.c:852
module_put+0x48/0x100
[ 8.809024] sd 1:0:0:1:
On Thu, May 22, 2008 at 7:22 PM, Chris Friesen <[EMAIL PROTECTED]> wrote:
> I got the following warnings when building current git head for powerpc
> 64bit:
Something that should be fixed, but not something to worry about.
Similar warnings appear when building the kernel for x86_64. See also
http:
.
Additionally, the __inline__ keyword is replaced by inline, as checkpatch
expects.
Signed-off-by: Bart Van Assche <[EMAIL PROTECTED]>
diff -uprN orig/linux-2.6.25.9/include/asm-powerpc/spinlock.h
linux-2.6.25.9/include/asm-powerpc/spinlock.h
--- orig/linux-2.6.25.9/include/asm-powerpc/spinlock.h
On Sat, Jun 28, 2008 at 5:07 PM, Kumar Gala <[EMAIL PROTECTED]> wrote:
>
> On Jun 28, 2008, at 1:51 AM, Bart Van Assche wrote:
>
>> When compiling kernel modules for ppc that include , gcc
>> prints a warning message every time it encounters a function declaration
>
-7,8 +7,6 @@
> #ifndef __ASM_RC32434_RB_H
> #define __ASM_RC32434_RB_H
>
> -#include
> -
> #define REGBASE 0x1800
> #define IDT434_REG_BASE ((volatile void *) KSEG1ADDR(REGBASE))
> #define UART0BASE0x58000
Reviewed-by: Bart Van Assche
On 6/8/21 9:05 AM, Christoph Hellwig wrote:
> Fix the include guards to match the file naming.
Reviewed-by: Bart Van Assche
On 6/8/21 9:05 AM, Christoph Hellwig wrote:
> diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
> index aecc246ade26..93ca454eaca9 100644
> --- a/drivers/md/dm-writecache.c
> +++ b/drivers/md/dm-writecache.c
> @@ -1205,14 +1205,13 @@ static void memcpy_flushcache_optimized(void *
On 6/16/20 7:07 PM, Finn Thain wrote:
> On Tue, 16 Jun 2020, Bart Van Assche wrote:
>> As far as I know the sbp driver only has had one user ever and that user
>> is no longer user the sbp driver.
>
> So, you estimate the userbase at zero. Can you give a confidence level?
On 1/4/21 2:50 PM, Finn Thain wrote:
> On Mon, 4 Jan 2021, Bart Van Assche wrote:
>> Additionally, there is a good alternative available for the sbp driver.
>> Every system I know of that is equipped with a Firewire port also has an
>> Ethernet port. So users who want t
On 2020-06-16 02:42, Finn Thain wrote:
> Martin said, "I'd appreciate a patch to remove it"
>
> And Bart said, "do you want to keep this driver in the kernel tree?"
>
> AFAICT both comments are quite ambiguous. I don't see an actionable
> request, just an expression of interest from people doing
On 6/15/21 6:24 AM, Christoph Hellwig wrote:
> +/**
> + * bvec_kmap_local - map a bvec into the kernel virtual address space
> + * @bvec: bvec to map
> + *
> + * Must be called on single-page bvecs only. Call kunmap_local on the
> returned
> + * address to unmap.
> + */
> +static inline void *bve
On 6/27/21 6:30 AM, Sachin Sant wrote:
> While booting 5.13.0-rc7-next-20210625 on POWER9 LPAR following warning
> is seen [ ... ]
Please help with testing of the patch that is available at
https://lore.kernel.org/linux-block/2021062722.12720-1-bvanass...@acm.org/T/#u
Thanks,
Bart.
On 8/17/21 6:43 AM, John Garry wrote:
> Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag.
Reviewed-by: Bart Van Assche
dma_map_ops pointer. Additionally, introduce the function
set_dma_ops() that will be used by a later patch in this series.
Signed-off-by: Bart Van Assche
Cc: Greg Kroah-Hartman
Cc: Aurelien Jacquiot
Cc: Catalin Marinas
Cc: Chris Zankel
Cc: David Howells
Cc: David S. Miller
Cc: Fenghua Yu
Cc: Geert
ops->/intel_dma_ops./' arch/ia64/kernel/pci-dma.c
sed -i -e 's/static const struct dma_map_ops sn_dma_ops/static struct
dma_map_ops sn_dma_ops/' arch/ia64/sn/pci/pci_dma.c
Signed-off-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
Cc: Aurelien Jacquiot
Cc: Catalin Marinas
C
On Wed, 2017-01-11 at 07:46 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote:
> > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to
> > transfer data between memory and PCIe adapter. Because of performance
&g
On Wed, 2017-01-11 at 07:48 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote:
> > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to
> > transfer data between memory and PCIe adapter. Because of performance
&g
t the attached patches? These three patches are a
splitup of the single patch at the start of this e-mail thread.
Thanks,
Bart.From a6fe3a6db80f2bc359e049b72e13aa171fff6ffa Mon Sep 17 00:00:00 2001
From: Bart Van Assche
Date: Wed, 11 Jan 2017 13:31:42 -0800
Subject: [PATCH 1/3] treewide: Move dma_o
Now that all set_dma_ops() implementations are identical (ignoring
BUG_ON() statements), remove the architecture specific definitions
and add a definition in .
Signed-off-by: Bart Van Assche
Cc: Benjamin Herrenschmidt
Cc: Chris Metcalf
Cc: David Woodhouse
Cc: linux-a...@vger.kernel.org
Cc
Now that all set_dma_ops() implementations are identical (ignoring
BUG_ON() statements), remove the architecture specific definitions
and add a definition in .
Signed-off-by: Bart Van Assche
Cc: Benjamin Herrenschmidt
Cc: Chris Metcalf
Cc: David Woodhouse
Cc: linux-a...@vger.kernel.org
Cc
On Tue, 2018-01-09 at 14:44 +0530, Abdul Haleem wrote:
> Greeting's,
>
> Linux next kernel panics on powerpc when module qla2xxx is load/unload.
>
> Machine Type: Power 8 PowerVM LPAR
> Kernel : 4.15.0-rc2-next-20171211
> gcc : version 4.8.5
> Test type: module load/unload few times
>
> Trace m
by the following:
Subject: [PATCH] blk-mq: Make it safe to call blk_mq_start_hw_queues() from
interrupt context
blk_mq_start_hw_queues() triggers a queue run. Some functions that
get called to run a queue, e.g. dd_dispatch_request(), are not IRQ-safe.
Hence run the queue asynchronously if blk_mq_start_hw_qu
On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote:
> On 07/28/2017 12:19 AM, Michael Ellerman wrote:
> > OK, so the resolution is "fix it in IPR" ?
>
> I'll leave that to the SCSI crew. But at least one bug is in IPR, if you
> look at the call trace:
>
> - timer function triggers, runs ipr_rese
scsi/for-next'
>
> System booted fine when the below commit is reverted:
>
> commit 270065e92c317845d69095ec8e3d18616b5b39d5
> Author: Bart Van Assche
> Date: Thu Aug 3 14:40:14 2017 -0700
>
> scsi: scsi-mq: Always unprepare before requeuing a request
He
On Wed, 2017-08-16 at 23:37 +0530, Abdul Haleem wrote:
> Linux-next booted with the below warnings on powerpc
>
> [ ... ]
>
> boot warnings:
> --
> kvm: exiting hardware virtualization
> [ cut here ]
> WARNING: CPU: 15 PID: 0 at block/blk-mq.c: __blk_mq_run
On Wed, 2017-08-16 at 22:30 +0530, Abdul Haleem wrote:
> As of next-20170809, linux-next on powerpc boot hung with below trace
> message.
> [ ... ]
> System booted fine when the below commit is reverted:
Hello Abdul,
Can you check whether applying the following commit on top of next-20170809
fix
On Wed, 2017-08-16 at 15:10 -0500, Brian King wrote:
> On 08/16/2017 01:15 PM, Bart Van Assche wrote:
> > On Wed, 2017-08-16 at 23:37 +0530, Abdul Haleem wrote:
> > > Linux-next booted with the below warnings on powerpc
> > >
> > >
On Wed, 2017-08-16 at 18:18 -0500, Brian King wrote:
> On 08/16/2017 12:21 PM, Bart Van Assche wrote:
> > On Wed, 2017-08-16 at 22:30 +0530, Abdul Haleem wrote:
> > > As of next-20170809, linux-next on powerpc boot hung with below trace
> > > message.
> > >
&g
On Fri, 2017-08-18 at 16:04 -0500, Brian King wrote:
> I think I have an understanding what is going on and why Bart's patch is
> causing problems for ipr.
> I can work around the boot hang in ipr, but ultimately I think we need to
> figure out a fix
> in scsi / block. I added some tracing and co
On Fri, 2017-08-18 at 16:57 -0500, Brian King wrote:
> To add to my analysis above, #9 should not be there... It looks like
> jiffies_at_alloc would also be getting reinitialized in this case, resulting
> in
> a perpetual retry, which is what I was seeing.
Hello Brian,
Some time ago I noticed th
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
__loop_clr_fd wants to clear all settings on the device. Prepare for
moving more settings into the block limits by open coding
loop_reconfigure_limits.
If Damien's comment is addressed, feel free to add:
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
Since commit 7437bb73f087 ("block: remove support for the host aware zone
model"), only ZBC devices expose a zoned access model. sd_is_zoned is
used to check for that and thus return false for host aware devices.
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
Simplify loop_reconfigure_limits by always updating the discard limits.
This adds a little more work to loop_set_block_size, but doesn't change
the outcome as the discard flag won't change.
Reviewed-by: Bart Van Assche
-by: Bart Van Assche
Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
This prepares for moving the rotational flag into the queue_limits and
also fixes it for the case where the loop device is backed by a block
device.
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
virtblk_update_cache_mode boils down to a single call to
blk_queue_write_cache. Remove it in preparation for moving the cache
control flags into the queue_limits.
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
Move setting the cache control flags in nbd in preparation for moving
these flags into the queue_limits structure.
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
queue_attr_store updates attributes used to control generating I/O, and
can cause malformed bios if changed with I/O in flight. Freeze the queue
in common code instead of adding it to almost every attribute.
Reviewed-by: Bart Van Assche
On 6/10/24 10:19 PM, Christoph Hellwig wrote:
Fold blk_flush_policy into the only caller to prepare for pending changes
to it.
Reviewed-by: Bart Van Assche
On 6/28/22 16:09, Michael Schmitz wrote:
On 29/06/22 09:50, Arnd Bergmann wrote:
On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz
wrote:
On 28/06/22 19:03, Geert Uytterhoeven wrote:
The driver allocates bounce buffers using kmalloc if it hits an
unaligned data buffer - can such buffers still
Use the irq_get_nr_irqs() function instead of the global variable
'nr_irqs'. This patch prepares for changing 'nr_irqs' from an exported
global variable into a variable with file scope.
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Bart Van Assche
---
arch/powerpc/platf
Use the irq_get_nr_irqs() function instead of the global variable
'nr_irqs'. Prepare for changing 'nr_irqs' from an exported global
variable into a variable with file scope.
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Bart Van Assche
---
arch/powerpc/platforms/cell/
Use the number_of_interrupts() function instead of the global variable
'nr_irqs'. This patch prepares for changing 'nr_irqs' from an exported
global variable into a variable with file scope.
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Bart Van Assche
---
arch/po
58 matches
Mail list logo
