[PATCH] powerpc/82xx: Convert pci_pic_lock to raw_spinlock

2010-02-18 Thread Anton Vorontsov
Interrupt controllers' hooks are executed in the atomic context, so they are not permitted to sleep (with RT kernels non-raw spinlocks are sleepable). So, pci_pic_lock has to be a real (non-sleepable) spinlock. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/82xx/pq2ads-pci-

[PATCH] gpiolib: Cosmetic improvements for error handling in gpiochip_add()

2010-02-18 Thread Anton Vorontsov
Hopefully it makes the code look nicer and makes it easier to extend this function. Suggested-by: Grant Likely Signed-off-by: Anton Vorontsov --- On Tue, Feb 09, 2010 at 10:16:44AM -0700, Grant Likely wrote: [...] > Rather than doing an else block which will need to be reworked if/when &g

Re: PCI on 834x

2010-02-24 Thread Anton Vorontsov
e generic code doesn't assign resources for Freescale PHBs we dont have to explicitly exclude it. Signed-off-by: Kumar Gala May be the generic code started to assign the resources again? -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___

[PATCH v2] powerpc: Add hibernation support for FSL BookE processors

2010-02-24 Thread Anton Vorontsov
's confine the code to FSL BookE. (The only FSL-specific parts are 'flush_dcache_L1' and TLB invalidation code). Signed-off-by: Anton Vorontsov --- Sorry for the delayed response... On Tue, Jan 12, 2010 at 01:34:08PM +1100, Benjamin Herrenschmidt wrote: [...] > Here's a

Re: Gianfar driver failing on MPC8641D based board

2010-02-25 Thread Anton Vorontsov
turn it off? If that will fix the issue, then it'll be a good data point. Meanwhile, I'll try SMP kernel on MPC8568 (UP), and let you know the results. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _

Re: Gianfar driver failing on MPC8641D based board

2010-02-25 Thread Anton Vorontsov
On Thu, Feb 25, 2010 at 07:53:30PM -0500, Paul Gortmaker wrote: [...] > I was able to reproduce it on an 8641D and bisected it down to this: > > --- > commit a3bc1f11e9b867a4f49505ecac486a33af248b2e > Author: Anton Vorontsov > Date: Tue Nov 10 14:11:10 2009 +000

Re: Gianfar driver failing on MPC8641D based board

2010-02-26 Thread Anton Vorontsov
On Fri, Feb 26, 2010 at 12:06:15PM +, Martyn Welch wrote: > Anton Vorontsov wrote: > > On Thu, Feb 25, 2010 at 07:53:30PM -0500, Paul Gortmaker wrote: > > [...] > > > >> I was able to reproduce it on an 8641D and bisected it down to this: >

Re: Gianfar driver failing on MPC8641D based board

2010-02-26 Thread Anton Vorontsov
On Fri, Feb 26, 2010 at 03:34:07PM +, Martyn Welch wrote: [...] > Out of 10 boot attempts, 7 failed. OK, I see why. With ip=on (dhcp boot) it's much harder to trigger it. With static ip config can I see the same. ___ Linuxppc-dev mailing list Linuxpp

Re: Gianfar driver failing on MPC8641D based board

2010-02-26 Thread Anton Vorontsov
On Fri, Feb 26, 2010 at 11:27:42AM -0500, Paul Gortmaker wrote: > On 10-02-26 11:10 AM, Anton Vorontsov wrote: > > On Fri, Feb 26, 2010 at 03:34:07PM +, Martyn Welch wrote: > > [...] > >> Out of 10 boot attempts, 7 failed. > > > > OK, I see why. With i

Re: Gianfar driver failing on MPC8641D based board

2010-03-02 Thread Anton Vorontsov
;ll have to keep the spinlock anyway since it also protects from gfar_error(), which can modify regs->tstat. Thanks! -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] gianfar: Fix TX ring processing on SMP machines

2010-03-03 Thread Anton Vorontsov
n Welch Bisected-by: Paul Gortmaker Signed-off-by: Anton Vorontsov Tested-by: Paul Gortmaker Tested-by: Martyn Welch Cc: Sandeep Gopalpet Cc: Stable [2.6.33] --- drivers/net/gianfar.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-03-05 Thread Anton Vorontsov
mplicitly falling > > through to the return statement. > > This still hasn't happened. It's in your tree already :-) gpiolib-cosmetic-improvements-for-error-handling-in-gpiochip_add.patch -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks

2010-03-05 Thread Anton Vorontsov
hitectures, my preference > is to let this patch series lie fallow for one more merge cycle so > that things can settle out in the OF infrastructure code. How exactly OF rework affects these patches? And why some rework should be used as an excuse for not adding a hardware support? -- Anton V

Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks

2010-03-05 Thread Anton Vorontsov
ld be used as an excuse for not adding a hardware support? > > If this was a standalone device driver then I'd agree. However, this > is an infrastructure change. Infrastructure changes get more scrutiny > and are always harder to merge. Especially just before the merge > window

Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks

2010-03-06 Thread Anton Vorontsov
ll :-). Here are some technical arguments: 1. You can implement your new ideas on top of the current solution. Or I can happily do that for you. 2. The patches don't change any API, instead they just build a bridge between GPIOLIB and OF GPIO infrastructure. So it&

Re: [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node

2010-03-18 Thread Anton Vorontsov
id dev_archdata_set_node(struct dev_archdata *ad, > - struct device_node *np) > -{ > - ad->of_node = np; > -} > - > -static inline struct device_node * > -dev_archdata_get_node(const struct dev_archdata *ad) > -{ > - return

Re: Requesting a GPIO that hasn't been registered yet

2010-03-31 Thread Anton Vorontsov
On Tue, Mar 30, 2010 at 10:05:01PM -0500, Bill Gatliff wrote: [...] > In other words, the GPIO pin I'm using for the key is one of the bits on > my pca953x GPIO expander chip. > > The above would all be great, except that I haven't come up with a way > to make sure that my encoder_button doesn't t

Re: kexec for powerpc32

2010-03-31 Thread Anton Vorontsov
rpc32. http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg22498.html I've just asked around, and it seems that Maxim (Cc'ed) will start working on reviving ppc32 support real soon. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 __

Re: poweroff/suspend problems on PowerMac G5

2010-04-01 Thread Anton Vorontsov
kernel... Can you show us a boot log of working and not working kernels? And .config files you use. ..maybe for some reason PMU/SMU modules didn't get loaded? -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-d

Re: [PATCH v2] powerpc: Add hibernation support for FSL BookE processors

2010-04-15 Thread Anton Vorontsov
On Thu, Feb 25, 2010 at 12:38:02AM +0300, Anton Vorontsov wrote: > This is started as swsusp_32.S modifications, but the amount of #ifdefs > made the whole file horribly unreadable, so let's put the support into > its own separate file. > > The code should be relatively easy

Re: [PATCH v2] powerpc: Add hibernation support for FSL BookE processors

2010-04-15 Thread Anton Vorontsov
On Thu, Apr 15, 2010 at 02:20:23PM -0500, Kumar Gala wrote: [...] > > Kumar, > > > > According to patchwork, this is now delegated to you. Do you > > have any objections to merge this? > > Would like Scott's Ack. Cc'ing. ___ Linuxppc-dev mailing list L

[PATCH] powerpc/85xx: Add eTSEC 2.0 support for P1020RDB boards

2010-04-15 Thread Anton Vorontsov
This patch adds support for eTSEC 2.0 as found in P1020. The changes include introduction of the group nodes for the etsec nodes. Signed-off-by: Sandeep Gopalpet Signed-off-by: Anton Vorontsov --- This is based on http://www.bitshrine.org/gpp/kernel-2.6.32-rc3-P1020RDB-DTS-Support-for-eTSEC

Re: [PATCH v2] powerpc: Add hibernation support for FSL BookE processors

2010-04-15 Thread Anton Vorontsov
On Thu, Apr 15, 2010 at 03:05:08PM -0500, Scott Wood wrote: > Kumar Gala wrote: > >On Apr 15, 2010, at 1:45 PM, Anton Vorontsov wrote: > >>Kumar, > >> > >>According to patchwork, this is now delegated to you. Do you > >>have any objections to merge this

[PATCH v3] powerpc: Add hibernation support for FSL BookE processors

2010-04-16 Thread Anton Vorontsov
's confine the code to FSL BookE. (The only FSL-specific parts are 'flush_dcache_L1' and TLB invalidation code). Signed-off-by: Anton Vorontsov --- On Thu, Apr 15, 2010 at 03:18:31PM -0500, Scott Wood wrote: > Scott Wood wrote: > >Kumar Gala wrote: > >>On Apr

[PATCH v4] powerpc: Add hibernation support for FSL BookE processors

2010-04-16 Thread Anton Vorontsov
's confine the code to FSL BookE. (The only FSL-specific part so far is 'flush_dcache_L1'.) Signed-off-by: Anton Vorontsov --- On Fri, Apr 16, 2010 at 10:54:36AM -0500, Scott Wood wrote: > Anton Vorontsov wrote: > >+/* Invalidate TLB0 & TLB1 */ > >+li

Re: [PATCH v2] powerpc: Add hibernation support for FSL BookE processors

2010-04-16 Thread Anton Vorontsov
On Fri, Apr 16, 2010 at 10:48:09AM -0500, Scott Wood wrote: > Anton Vorontsov wrote: > >On Thu, Apr 15, 2010 at 03:05:08PM -0500, Scott Wood wrote: > >>Kumar Gala wrote: > >>>On Apr 15, 2010, at 1:45 PM, Anton Vorontsov wrote: > >>>>Kumar, > >>

[PATCH] powerpc/85xx/86xx: Fix build w/ CONFIG_PCI=n

2010-04-16 Thread Anton Vorontsov
sue by appending 'if PCI' condition when selecting FSL_ULI1575 Kconfig symbol. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/85xx/Kconfig |4 ++-- arch/powerpc/platforms/86xx/Kconfig |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platfor

[PATCH] powerpc/85xx: Fix P1020RDB boot hang due USB2

2010-04-22 Thread Anton Vorontsov
fsl-ehci.1: new USB bus registered, assigned bus number 2 Note that U-Boot doesn't clear 'status' property when it enables USB2, so we have to comment out the whole node. To enable USB2, one can issue 'setenv hwconfig usb2:dr_mode=' command at the U-Boot prompt. Signed

[PATCH 1/2] fsl_pq_mdio: Fix kernel oops during OF address translation

2010-04-23 Thread Anton Vorontsov
are buggy, though having a dead ethernet is better than a dead kernel, so fix the issue by using of_iomap(). Also, a somewhat similar issue exist in the probe() routine, though there the oops is only a possibility. Nonetheless, fix it too. Signed-off-by: Anton Vorontsov --- drivers/net

[PATCH 2/2] gianfar: Fix potential oops during OF address translation

2010-04-23 Thread Anton Vorontsov
gianfar driver may pass NULL pointer to the of_translate_address(), which may lead to a kernel oops. Fix this by using of_iomap(), which is also much simpler and shorter. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c |6 +- 1 files changed, 1 insertions(+), 5 deletions

[PATCH] booke_wdt: Fix build (unconstify watchdog_info)

2010-04-26 Thread Anton Vorontsov
; Fix this by removing 'const' qualifier from watchdog_info struct. Signed-off-by: Anton Vorontsov --- drivers/watchdog/booke_wdt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c index 500d383..801ead1 100644

Re: MPC8313: fsl_elbc_nand and MDR

2010-04-26 Thread Anton Vorontsov
ved to program the UPM in U-boot and > >therefore preempt this conflict? > > If you don't need to reprogram it dynamically, doing it either in > u-boot or early in platform code is probably best. > > I guess the UPM NAND code relies on U-Boot doing this? Yep, u-bo

Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks

2010-04-30 Thread Anton Vorontsov
On Fri, Mar 12, 2010 at 02:38:02PM -0700, Grant Likely wrote: [...] > How to proceed: I'd like to leave this series out for the 2.6.34 > cycle and I'll pick it into my OF tree before the 2.6.35 merge window, > but I'll probably modify it to call the OF hooks directly and leave > out the unnecessar

[PATCH] powerpc/83xx: Add MCU LEDs support for MPC837xRDB and MPC8315RDB boards

2010-05-02 Thread Anton Vorontsov
There are two front-panel LEDs on MPC837xRDB and MPC8315RDB boards: PWR and HDD. After adding appropriate nodes we can program these LEDs from kernel and user space. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8315erdb.dts | 14 ++ arch/powerpc/boot/dts

[PATCH] USB: FHCI: cq_get() should check kfifo_out()'s return value

2010-05-02 Thread Anton Vorontsov
e, but it's better to check if we really got a whole pointer. Signed-off-by: Anton Vorontsov --- drivers/usb/host/fhci.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/fhci.h b/drivers/usb/host/fhci.h index 72dae1c..a3fd0fd 100644 --- a/driver

Re: [PATCH v2 6/7] mmc: sdhci: merge two sdhci-pltfm.h into one

2011-05-05 Thread Anton Vorontsov
f-by: Shawn Guo > Reviewed-by: Grant Likely > Reviewed-by: Wolfram Sang Acked-by: Anton Vorontsov ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-05 Thread Anton Vorontsov
e two. I'd rather vote for renaming sdhci-of-esdhc to sdhci-esdhc-mpc. :-) -- Anton Vorontsov Email: cbouatmai...@gmail.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 3/7] mmc: sdhci: make sdhci-of device drivers self registered

2011-05-05 Thread Anton Vorontsov
On Thu, May 05, 2011 at 09:22:54PM +0800, Shawn Guo wrote: [...] > - * Copyright (c) 2007 Freescale Semiconductor, Inc. > - * Copyright (c) 2009 MontaVista Software, Inc. > - * > - * Authors: Xiaobo Xie > - * Anton Vorontsov [...] > -#ifdef CONFIG_MMC_SDHCI_BIG_ENDIAN_

Re: [PATCH v2 2/7] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data

2011-05-05 Thread Anton Vorontsov
On Thu, May 05, 2011 at 09:22:53PM +0800, Shawn Guo wrote: > The patch migrates the use of sdhci_of_host and sdhci_of_data to > sdhci_pltfm_host and sdhci_pltfm_data, so that the former pair can > be eliminated. > > Signed-off-by: Shawn Guo > Reviewed-by: Grant Likely Acked-b

Re: [PATCH v2 1/7] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-05-05 Thread Anton Vorontsov
s3xxx_exit); I don't think I like this duplicate code for each platform sub- driver. It's repetitive and annoying. :-/ But considering that ARM will be multiplatform soon, we don't want to have every mach-* stuff in the single sdhci-pltfm.

Re: [rtc-linux] Re: [PATCH] Add support for pt7c4338 (rtc device) in rtc-ds1307 driver

2011-05-30 Thread Anton Vorontsov
): http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg21196.html It was received coldly though: http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg22041.html http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg21273.html -- Anton Vorontsov Email: cbouatmai...@gm

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Anton Vorontsov
} #endif You won't need endless ifdefs in the board files: #ifdef CONFIG_PCI fsl_add_pci_err(); #endif Also, why not add this call to the fsl_add_bridge(), so you won't need to touch board files at all. Thanks, -- Anton Vorontsov Email: cbouatmai...@gmail.com __

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Anton Vorontsov
On Wed, Jun 01, 2011 at 06:55:35PM +0400, Dmitry Eremin-Solenikov wrote: > On 6/1/11, Anton Vorontsov wrote: > > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: > > [...] > >> --- a/arch/powerpc/sysdev/fsl_pci.h > >> +++ b/arch/powerpc/sys

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-02 Thread Anton Vorontsov
/* Only PCI, not PCI Express! */ > + if (of_device_is_compatible(np, "fsl,mpc8540-pci")) { > + struct resource r[2]; How about '= {};' initializer instead of the '= NULL's down below? > + > +

Re: [PATCH 3/3] eSDHC: fix incorrect default value of the capabilities register on P4080

2011-07-05 Thread Anton Vorontsov
> + if (of_device_is_compatible(np, "fsl,p4080-esdhc")) > + host->quirks |= SDHCI_QUIRK_QORIQ_HOSTCAPBLT_ONLY_VS33; Should really use voltage-ranges, not quirks. http://www.spinics.net/lists/linux-mmc/msg02785.html Thanks, -- Anton Vorontsov Email: cbouatmai...@gmail.com __

Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-07-22 Thread Anton Vorontsov
nsigned short)-1) { > switch (1 << power) { > +#define ESDHCI_FSL_POWER_MASK 0x40 > +#define ESDHCI_FSL_POWER_1800x00 > +#define ESDHCI_FSL_POWER_3000x40 Same here. The driver will rot quickly if everyone would start putting chip-specific qu

Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-12 Thread Anton Vorontsov
; Anton, > thanks for the comment, as we discussed, the original code use 8 bit byte > operation, > while in fact, on some powerpc platform, 32 bit operation is needed. > should it be possible fixed by adding some wrapper in IO accessors or > introduce additional sdhci op? I woul

Re: [PATCH] usb: Allocate pram dynamically.

2011-08-23 Thread Anton Vorontsov
On Tue, Aug 23, 2011 at 02:38:41PM +0200, Joakim Tjernlund wrote: > MPC832x does not have enough MURAM to do fixed MURAM allocation. > Change to dynamic allocation. > > Signed-off-by: Joakim Tjernlund Acked-by: Anton Vorontsov Thanks! p.s. You probably want to send this to G

Re: [PATCH v2 2/2] powerpc new toolchains fix (crt.S)

2010-05-13 Thread Anton Vorontsov
this thread! :-) http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg17224.html Purgatory is just a small (tiny) piece of code that runs between kernels. Whether use libgcc or not, personally, I have no strong opinion. Kexec didn't use it, so we kept it the same way. Tha

[PATCH] fsl_pq_mdio: Fix mdiobus allocation handling

2010-05-14 Thread Anton Vorontsov
The driver could return success code even if mdiobus_alloc() failed. This patch fixes the issue. Signed-off-by: Anton Vorontsov --- drivers/net/fsl_pq_mdio.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c index

[PATCH v2] USB: FHCI: cq_get() should check kfifo_out()'s return value

2010-05-14 Thread Anton Vorontsov
luded from drivers/usb/host/fhci-hcd.c:34: drivers/usb/host/fhci.h: In function 'cq_get': drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result ... This patch fixes the issue by properly checking the return value.

[PATCH] gianfar: Remove legacy PM callbacks

2010-05-14 Thread Anton Vorontsov
ff-by: Anton Vorontsov --- drivers/net/gianfar.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 5d3763f..fb23f04 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1288,21 +1288,9 @@ static s

[PATCH v5] powerpc: Add hibernation support for FSL BookE processors

2010-05-17 Thread Anton Vorontsov
's confine the code to FSL BookE. (The only FSL-specific part so far is 'flush_dcache_L1'.) Signed-off-by: Anton Vorontsov Acked-by: Scott Wood --- On Mon, May 17, 2010 at 01:12:37PM -0500, Scott Wood wrote: > On 04/16/2010 02:03 PM, Anton Vorontsov wrote: > >+/* res

Re: [PATCH v5] powerpc: Add hibernation support for FSL BookE processors

2010-05-17 Thread Anton Vorontsov
dev@lists.ozlabs.org/msg27982.html No idea why it didn't make Linus' tree. -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc: Use common cpu_die (fixes SMP+SUSPEND build)

2010-05-19 Thread Anton Vorontsov
cpu_die pointers in either smp_ops (request a given cpu die) or ppc_md (make this cpu die), for other platforms but there are generic versions in smp.c. Reported-by: Matt Sealey Reported-by: Kumar Gala Signed-off-by: Milton Miller Signed-off-by: Anton Vorontsov --- arch/powerpc/kernel/setup_

Re: [git pull] Please pull powerpc.git next branch

2010-05-21 Thread Anton Vorontsov
On Fri, May 21, 2010 at 07:11:28PM +1000, Benjamin Herrenschmidt wrote: [...] > Anton Vorontsov (3): > powerpc/85xx: Add eTSEC 2.0 support for P1020RDB boards > powerpc/85xx: Fix P1020RDB boot hang due USB2 > powerpc/83xx: Add MCU LEDs support for MPC837xRDB and MPC83

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-08 Thread Anton Vorontsov
} > + for (i = 0; i < num_irq; i++, res++) { > + rc = of_irq_to_resource(np, i, res); > + WARN_ON(rc == NO_IRQ); > + } > + } > + > if (bus_id) > dev_set_name(&dev->dev, "%s", bus_

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-08 Thread Anton Vorontsov
On Tue, Jun 08, 2010 at 10:02:49AM -0600, Grant Likely wrote: > On Tue, Jun 8, 2010 at 9:57 AM, Anton Vorontsov > wrote: > > On Tue, Jun 08, 2010 at 08:26:43AM -0600, Grant Likely wrote: > > [...] > >> +     dev = kzalloc(sizeof(*dev) + (sizeof(struct resou

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-08 Thread Anton Vorontsov
1-9_]*\[1\]' Ugh? This produces a lot of false positives. But OK, let's run it. ~/linux-2.6$ git grep '\*).*&[a-z1-9_]*\[1\]' | wc -l 164 ^^^ Now let's presume that half of it (and not just a few hits) is the ugly hacks that we&#x

[PATCH 1/3] powerpc/85xx: Fix SWIOTLB initalization for MPC85xxMDS boards

2010-06-08 Thread Anton Vorontsov
The code inside '#ifdef CONFIG_QUICC_ENGINE' makes the mpc85xx_mds_setup_arch() return early if no QE nodes present, and so SWIOTLB is never initialized. This patch fixes the issue by moving SWIOTLB code above QE. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/85xx/mpc

[PATCH 2/3] powerpc/85xx: Fix booting for P1021MDS boards

2010-06-08 Thread Anton Vorontsov
nitialized, and so the board hangs early at boot. This patch fixes the issue by marking QE as disabled and checking the state in the probing code. U-Boot should fixup the state if it initialized the QE. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/p1021mds.dts|1 + ar

[PATCH 3/3] powerpc/85xx: Cleanup QE initialization for MPC85xxMDS boards

2010-06-08 Thread Anton Vorontsov
better now, and less indented. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 272 +++-- 1 files changed, 143 insertions(+), 129 deletions(-) diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx

[PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-09 Thread Anton Vorontsov
device tree bindings and implement enabling this feature via some property. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 1830f31..46c69cd 100644 --- a/drivers/net/gi

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-10 Thread Anton Vorontsov
On Thu, Jun 10, 2010 at 08:29:08AM +0200, Richard Cochran wrote: > On Wed, Jun 09, 2010 at 11:32:19PM +0400, Anton Vorontsov wrote: > > Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add > > hardware RX timestamping support"), the driver no lon

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-10 Thread Anton Vorontsov
er, while I saw the DHCP requests on the host side. But I don't know if disabling the timestamping fixes 8568, maybe there is some additional problem with it, no idea as I don't have 8568 board in my hands any longer. I can try any proposed fixes as soon as I get it back though. -- Anton Vo

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-10 Thread Anton Vorontsov
but I think its expressive > power trumps that small surprise. Oh, come on. Both constructions are binary equivalent. So how can people seriously be with *that* code: dev->resource = (void *)&dev[1]; which, semantically, is a nonsense and asks for a fix. While de

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-10 Thread Anton Vorontsov
e. Creates? False. The same sizeof problem exists in Grant's approach. sizeof(*dev) != what_we_have_allocated. Which is isn't great, I agree. And that's exactly why I proposed a dedicated allocation in the first place. -- Anton Vorontsov email: cbouatmai...@gmail.com

Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation

2010-06-10 Thread Anton Vorontsov
? > That being said, I'm looking at refactoring to use > platform_device_alloc() instead, which is effectively option C. (which > I'd normally avoid, but it removes otherwise duplicate code from > drivers/of). Sounds great! Thanks, -- A

Re: [PATCH] gianfar: Fix setup of RX time stamping

2010-06-11 Thread Anton Vorontsov
ned-off-by: Manfred Rudigier > --- Looks OK. I tested that it doesn't break anything, but I didn't test the timestamping functionality. So Reviewed-by: Anton Vorontsov Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _

[PATCH] gianfar: Fix oversized packets handling

2010-06-11 Thread Anton Vorontsov
Note that sometimes eTSEC works correctly, i.e. in the second (last) buffer descriptor bits 'truncated' and 'crcerr' are set, and so there's no oops. Though I couldn't find any logic when it works correctly and when not. Signed-off-by: Anton Vorontsov --- drivers/net/g

Re: [PATCH 1/2] mtd: m25p80: Rework probing/JEDEC code

2010-06-18 Thread Anton Vorontsov
On Sat, Jun 12, 2010 at 02:27:12PM +0800, Barry Song wrote: > On Wed, Aug 19, 2009 at 5:46 AM, Anton Vorontsov > wrote: > > > > Previosly the driver always tried JEDEC probing, assuming that non-JEDEC > > chips will return '0'. But truly non-JEDEC chips (li

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
return -ENODEV; > + } else > + dev_info(&spi->dev, "non-JEDEC variant of %s\n", > + id->name); > } else if (jid != id) { -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov > wrote: > > On Mon, Jun 21, 2010 at 11:27:31AM +0800, Barry Song wrote: > > [...] > >> > How about we add a non_jedec flag in platform_data, if th

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 06:31:44PM +0800, Barry Song wrote: > On Mon, Jun 21, 2010 at 3:39 PM, Anton Vorontsov > wrote: > > On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: > >> On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov > >> wrote: > >&g

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 12:34:05PM -0400, Mike Frysinger wrote: > On Mon, Jun 21, 2010 at 07:20, Anton Vorontsov wrote: > > You can't easily change OF. It's like "let's change ACPI tables > > or BIOS in these PCs". Doable, but involves things like reflashing

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-22 Thread Anton Vorontsov
On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote: [...] > >                jid = jedec_probe(spi); > >                if (!jid) { > > -                       dev_info(&spi->dev, "non-JEDEC variant of %s\n", > > -                                id->name); > > +                       return

[PATCH 1/2] mtd: m25p80: Fix false-positive probing

2010-06-22 Thread Anton Vorontsov
//blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=5975 Reported-by: Mingquan Pan Reported-by: Barry Song <21cn...@gmail.com> Signed-off-by: Anton Vorontsov --- This is for 2.6.35. drivers/mtd/devices/m25p80.c | 13 +++-- 1 files cha

[PATCH 2/2] mtd: m25p80: Make jedec_probe() return proper errno values

2010-06-22 Thread Anton Vorontsov
spi_write_then_read() may return its own return codes (e.g. -EIO), so let's propagate the value down to the probe(). Also, remove jedec == 0 check, it isn't needed as nowadays we use dedicated SPI device IDs for non-JEDEC flashes. Suggested-by: Barry Song <21cn...@gmail.com> Sign

Re: [PATCH]460EX on-chip SATA driver

2010-06-29 Thread Anton Vorontsov
mand not pending" or grep "DMA NOT started" would work. This makes the code more readable (literally, because you don't have to scroll to see dev_err's arguments) without sacrificing grep'ability. -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.n

[PATCH 1/3] gianfar: Implement workaround for eTSEC74 erratum

2010-06-29 Thread Anton Vorontsov
2." This patch implements the first workaround option by setting HUGEFRAME bit, and gfar_clean_rx_ring() already checks the RxBD[Data Length]. Signed-off-by: Anton Vorontsov --- drivers/net/Kconfig | 10 ++ drivers/net/gianfar.c | 36 ++-- drivers/

[PATCH 2/3] gianfar: Implement workaround for eTSEC76 erratum

2010-06-29 Thread Anton Vorontsov
e TOE frames to 2500 bytes, and do software checksumming instead. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c | 19 +++ drivers/net/gianfar.h |1 + 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c in

[PATCH 3/3] gianfar: Implement workaround for eTSEC-A002 erratum

2010-06-29 Thread Anton Vorontsov
at offset 0xD1C. If bits 7-14 are the same as bits 23-30, the eTSEC Rx is assumed to be idle and the Rx can be safely reset. If the register fields are not equal, wait for another timeout period and check again." Signed-off-by: Anton Vorontsov --- drivers/

Re: [PATCH 1/9] Add Synopsys DesignWare HS USB OTG Controller driver.

2010-06-30 Thread Anton Vorontsov
n. Some members of the Octeon family: arch/mips/cavium-octeon Plus ECONA CNS3xxx (arch/arm/mach-cns3xxx). -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] gianfar: Implement workaround for eTSEC74 erratum

2010-06-30 Thread Anton Vorontsov
#ifdef CONFIG_PPC_FOO GFAR_ERRATA_FOO = 0x01, #else GFAR_ERRATA_FOO = 0, #endif } And then, priv->errata & GFAR_ERRATA_FOO will be optimized away by the compiler. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 __

[PATCH v2 1/3] gianfar: Implement workaround for eTSEC74 erratum

2010-06-30 Thread Anton Vorontsov
2." This patch implements the first workaround option by setting HUGEFRAME bit, and gfar_clean_rx_ring() already checks the RxBD[Data Length]. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c | 29 +++-- drivers/net/gianfar.h | 11 +++ 2 files changed,

[PATCH v2 2/3] gianfar: Implement workaround for eTSEC76 erratum

2010-06-30 Thread Anton Vorontsov
e TOE frames to 2500 bytes, and do software checksumming instead. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar.c | 19 +++ drivers/net/gianfar.h |1 + 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c in

[PATCH v2 3/3] gianfar: Implement workaround for eTSEC-A002 erratum

2010-06-30 Thread Anton Vorontsov
at offset 0xD1C. If bits 7-14 are the same as bits 23-30, the eTSEC Rx is assumed to be idle and the Rx can be safely reset. If the register fields are not equal, wait for another timeout period and check again." Signed-off-by: Anton Vorontsov --- drivers/

[PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

2010-07-02 Thread Anton Vorontsov
Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx: Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the driver became non-selectable. This patch fixes the issue by switching to PPC_85xx symbol. Signed-off-by: Anton Vorontsov --- drivers/edac/Kcon

[PATCH 2/2] edac: mpc85xx: Add support for MPC8569 EDAC controllers

2010-07-02 Thread Anton Vorontsov
Simply add a proper ID into the device table. Signed-off-by: Anton Vorontsov --- drivers/edac/mpc85xx_edac.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 52ca09b..f39b00a 100644 --- a/drivers/edac

Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

2010-07-07 Thread Anton Vorontsov
On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote: > On Fri, 2 Jul 2010 16:41:11 +0400 > Anton Vorontsov wrote: > > > Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx: > > Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymor

Re: 2.6.34: arch/powerpc/sysdev/micropatch.c not compiling

2010-07-08 Thread Anton Vorontsov
mcr1 = 0x802a; > > > Would help? While this will fix the issue, I think this is not technically correct (i.e. micropatching SPI controller via I2C pram struct, even though the structs appear to be identical). As the spi_param is needed outside of the SPI driver, we'd better re-

[PATCH 1/3] powerpc/cpm: Reintroduce global spi_pram struct (fixes build issue)

2010-07-08 Thread Anton Vorontsov
#x27;*' token micropatch.c:629: error: 'spp' undeclared (first use in this function) micropatch.c:629: error: (Each undeclared identifier is reported only once micropatch.c:629: error: for each function it appears in.) Reported-by: LEROY Christophe Reported-by: Tony Br

[PATCH 2/3] powerpc/cpm1: Fix build with various CONFIG_*_UCODE_PATCH combinations

2010-07-08 Thread Anton Vorontsov
h': arch/powerpc/sysdev/micropatch.c:629: warning: unused variable 'spp' arch/powerpc/sysdev/micropatch.c:628: warning: unused variable 'iip' make[1]: *** [arch/powerpc/sysdev/micropatch.o] Error 1 This patch fixes these issues by introducing proper #ifdefs. Cc: [ .3

[PATCH 3/3] powerpc/cpm1: Mark micropatch code/data static and __init

2010-07-08 Thread Anton Vorontsov
#x27;patch_2f00' was not declared. Should it be static? ... Signed-off-by: Anton Vorontsov --- arch/powerpc/include/asm/cpm1.h |3 ++- arch/powerpc/sysdev/micropatch.c | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/inclu

[PATCH 0/8] sdhci: Move real work out of an atomic context

2010-07-14 Thread Anton Vorontsov
(tested on MPC8569E CPU), while latencies should be greatly improved. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

[PATCH 1/8] sdhci: Turn timeout timer into delayed work

2010-07-14 Thread Anton Vorontsov
There is no need for the timeout handler to run in the atomic context, so this patch turns timeout timeout into the delayed work. Note that the timeout handler still grabs an irqsave spinlock, we'll deal with it in a separate patch. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sd

[PATCH 2/8] sdhci: Use work structs instead of tasklets

2010-07-14 Thread Anton Vorontsov
The driver can happily live without an atomic context and tasklets, so turn the tasklets into the work structs. Tasklets handlers still grab irqsave spinlocks, but we'll deal with it in a separate patch. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sdhci.c |

[PATCH 3/8] sdhci: Clear interrupt status register just once

2010-07-14 Thread Anton Vorontsov
There's no need to clear the interrupt status register bit-by-bit, we can just clear it once. This simplifies irq handler. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sdhci.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/mmc

[PATCH 4/8] sdhci: Use threaded IRQ handler

2010-07-14 Thread Anton Vorontsov
We only need atomic context to disable SDHCI interrupts, after that we can run in a kernel thread. Note that irq handler still grabs an irqsave spinlock, we'll deal with it in a subsequent patch. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sdhci.c |

[PATCH 5/8] sdhci: Turn host->lock into a mutex

2010-07-14 Thread Anton Vorontsov
Finally, we can get rid of the host->lock spinlock, and turn it into a mutex. This patch does just this. Signed-off-by: Anton Vorontsov --- drivers/mmc/host/sdhci.c | 53 +++-- drivers/mmc/host/sdhci.h |3 +- 2 files changed, 24 insertions(+),

<    1   2   3   4   5   6   7   8   9   10   >