Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type

2023-11-08 Thread Anish Moorthy
This commit breaks the arm64 selftests build btw: looks like a simple oversight? $ cd ${LINUX_ROOT}/tools/testing/selftests/kvm $ CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 make # ... aarch64/page_fault_test.c: In function ‘run_test’: aarch64/page_fault_test.c:708:28: error: incompatible type for

Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type

2023-11-08 Thread Anish Moorthy
On Wed, Nov 8, 2023 at 9:00 AM Anish Moorthy wrote: > > This commit breaks the arm64 selftests build btw: looks like a simple > oversight? Yup, fix is a one-liner. Posted below. diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kv

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-08 Thread Anish Moorthy
Applying [1] and [2] reveals that this also breaks non-x86 builds- the MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef __x86_64__, while the usages introduced here aren't. Should On Sun, Nov 5, 2023 at 8:35 AM Paolo Bonzini wrote: > > + test_invalid_memory_region_flags(); be