On Thu, Apr 4, 2024 at 8:07 AM Jiri Slaby wrote:
> On 04. 04. 24, 0:29, Andy Shevchenko wrote:
> >> Cc: Benjamin Herrenschmidt
> >> Cc: Michael Ellerman
> >> Cc: Nicholas Piggin
> >> Cc: Christophe Leroy
> >> Cc: "Aneesh Kumar K.V"
On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote:
> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
...
> > > Cc: Benjamin Herrenschmidt
> > > Cc: Michael Ellerman
> > > Cc: Nicholas Piggin
> > > Cc: Christophe Leroy
> > > Cc: "Aneesh Kum
On Fri, Apr 5, 2024 at 1:15 AM Finn Thain wrote:
> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
>
> > > > > ---
> > > > (here is a good location for Cc:)
> > >
> > > Documentation/process/submitting-patches.rst indicats that it should
> >
On Fri, Apr 5, 2024 at 6:06 AM Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote:
> >> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
> >
> >> > > Cc: Benjamin Herrenschmidt
> >> > > Cc: Micha
On Fri, Apr 05, 2024 at 10:58:55AM +1100, Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Wed, Mar 13, 2024 at 03:56:45PM +0200, Andy Shevchenko wrote:
> >> of_gpio.h is deprecated and subject to remove.
> >> The driver doesn't use it directly, replace i
s >> 8) == PCI_CLASS_BRIDGE_PCI) {
> + slotno = PCI_SLOT(PCI_DN(dn)->devfn);
> + pci_scan_slot(bus, PCI_DEVFN(slotno, 0));
> + }
> + }
> +
> + return NULL;
> +}
--
With Best Regards,
Andy Shevchenko
+ 1;
> + return (dma_get_seg_boundary(dev) >> page_shift) + 1;
Can it be better to do something like
unsigned long boundary = dev ? dma_get_seg_boundary(dev) : U32_MAX;
return (boundary >> page_shift) + 1;
?
> +}
--
With Best Regards,
Andy Shevchenko
The pci_bus_for_each_resource_p() hides the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko
---
drivers/eisa/pci_eisa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/eisa
-mika.westerb...@linux.intel.com/
Changelog v2:
- refactor to have two macros
- refactor existing pci_bus_for_each_resource() in the same way and
convert users
Andy Shevchenko (3):
PCI: Split pci_bus_for_each_resource_p() out of
pci_bus_for_each_resource()
EISA: Convert to use
The pci_bus_for_each_resource_p() hides the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko
---
drivers/pcmcia/rsrc_nonstatic.c | 9 +++--
drivers/pcmcia/yenta_socket.c | 3 +--
2 files changed, 4
Refactor pci_bus_for_each_resource() in the same way as it's done in
pci_dev_for_each_resource() case. This will allow to hide iterator
inside the loop, where it's not used otherwise.
No functional changes intended.
Signed-off-by: Andy Shevchenko
---
.clang-format
.
Suggested-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
Signed-off-by: Andy Shevchenko
---
.clang-format| 2 ++
arch/alpha/kernel/pci.c | 5 ++---
arch/arm/kernel/bios32.c | 16 +++-
arch/mips/pci/pci-legacy.c | 3 +--
arch/powerpc
On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote:
> Am Thu, Nov 03, 2022 at 06:46:44PM +0200 schrieb Andy Shevchenko:
...
> > -
> > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> > - res = s->cb_dev->bus->resource[i];
> > -
On Thu, Nov 03, 2022 at 06:25:45PM +0100, Dominik Brodowski wrote:
> Am Thu, Nov 03, 2022 at 07:12:45PM +0200 schrieb Andy Shevchenko:
> > On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote:
...
> > Considering this is done, can you issue your conditiona
with what is there already - unless I am also reading
> the current implementation wrong.
But it wouldn't be harmful either.
> That said, Dominik is the maintainer of PCMCIA driver, so his is the last
> word, so to speak. :)
>
> > Considering this is done, can you issue your conditional tag so I will
> > incorporate it in v3?
>
> No need, really. Again, unless Dominik thinks otherwise.
I think that what is wanted to have to get his tag.
Thanks for review, both of you, guys!
--
With Best Regards,
Andy Shevchenko
sidering this is done, can you issue your conditional tag so I will
> > > incorporate it in v3?
> >
> > No need, really. Again, unless Dominik thinks otherwise.
>
> Ah, thanks for the correction. Then v2 is perfectly fine.
I'm fine with either, thanks!
--
With Best Regards,
Andy Shevchenko
patch into the SoC patch tracker (s...@kernel.org)
> with a not to apply it directly, I suggest you do the same (or ask me
> to sign it off and send it).
It depends on the patch in my tree, which is in your tree as well.
I guess you need to take or wait for v6.2-rc1.
--
With Best Regards,
Andy Shevchenko
...@linux.intel.com
Changelog v3:
- rebased on top of v2 by Mika, see above
- added tag to pcmcia patch (Dominik)
Changelog v2:
- refactor to have two macros
- refactor existing pci_bus_for_each_resource() in the same way and
convert users
Andy Shevchenko (3):
PCI: Split
Refactor pci_bus_for_each_resource() in the same way as it's done in
pci_dev_for_each_resource() case. This will allow to hide iterator
inside the loop, where it's not used otherwise.
No functional changes intended.
Signed-off-by: Andy Shevchenko
---
.clang-format
The pci_bus_for_each_resource_p() hides the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko
---
drivers/eisa/pci_eisa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/eisa
.
Suggested-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
Signed-off-by: Andy Shevchenko
---
.clang-format| 2 ++
arch/alpha/kernel/pci.c | 5 ++---
arch/arm/kernel/bios32.c | 16 +++-
arch/mips/pci/pci-legacy.c | 3 +--
arch/powerpc
The pci_bus_for_each_resource_p() hides the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko
Acked-by: Dominik Brodowski
---
drivers/pcmcia/rsrc_nonstatic.c | 9 +++--
drivers/pcmcia/yenta_socket.c
So might have dropped one...
>
> You could have done:
>
> H=$(git rev-parse @)
> b4 am -P 49-190 20221118224540.619276-1-...@kleine-koenig.org
> git am ...
> git filter-branch -f --msg-filter "grep -v 'Signed-off-by: Jonathan';
> echo
t's due to no reaction on the patch [1] from Freescale maintainers (*).
Either soc subsystem can pull this [2] or your patch can go via
pin control subsystem.
*) Note, there is not Arnd's name nor soc mailing list in the MAINTAINERS
regarding those files, so I had had no idea about the correct route of
the change.
[1]:
https://lore.kernel.org/lkml/20221005152947.71696-1-andriy.shevche...@linux.intel.com/
[2]: https://lore.kernel.org/linux-gpio/y3yy%2fm0f%2frh0j...@black.fi.intel.com/
--
With Best Regards,
Andy Shevchenko
b/include/soc/fsl/qe/qe.h
> @@ -172,14 +172,15 @@ static inline int par_io_data_set(u8 port, u8 pin, u8
> val) { return -ENOSYS; }
> /*
> * Pin multiplexing functions.
> */
> +struct device;
> struct qe_pin;
> #ifdef CONFIG_QE_GPIO
> -extern struct qe_pin *qe_pin_request(struct device_node *np, int index);
> +extern struct qe_pin *qe_pin_request(struct device *dev, int index);
> extern void qe_pin_free(struct qe_pin *qe_pin);
> extern void qe_pin_set_gpio(struct qe_pin *qe_pin);
> extern void qe_pin_set_dedicated(struct qe_pin *pin);
> #else
> -static inline struct qe_pin *qe_pin_request(struct device_node *np, int
> index)
> +static inline struct qe_pin *qe_pin_request(struct device *dev, int index)
> {
> return ERR_PTR(-ENOSYS);
> }
> --
> 2.39.0.rc0.267.gcb52ba06e7-goog
>
>
> --
> Dmitry
--
With Best Regards,
Andy Shevchenko
Reviewed-by: Andy Shevchenko
> Signed-off-by: Andrzej Hajda
> ---
> include/linux/non-atomic/xchg.h | 19 +++
> 1 file changed, 19 insertions(+)
> create mode 100644 include/linux/non-atomic/xchg.h
>
> diff --git a/include/linux/non-atomic/xchg.h b/include/l
pped - it was only used for debug.
> Signed-off-by: Sam Ravnborg
> Cc: Stephen Kitt
> Cc: Greg Kroah-Hartman
> Cc: Daniel Thompson
> Cc: Andy Shevchenko
> Cc: linux-fb...@vger.kernel.org
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl
ca
set_value(par->gpio.led[0], polarity);
?
--
With Best Regards,
Andy Shevchenko
gt; + return __xchg(&p_chain->p_prod_elem,
> + (void *)(((u8 *)p_chain->p_prod_elem) +
> p_chain->elem_size));
Wondering if you still need a (void *) casting after the change. Ditto for the
rest of similar cases.
> }
...
Btw, is it done by coccinelle? If no, why not providing the script?
--
With Best Regards,
Andy Shevchenko
On Tue, Jan 10, 2023 at 01:46:37PM +0100, Andrzej Hajda wrote:
> On 10.01.2023 12:07, Andy Shevchenko wrote:
> > On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote:
...
> > > + return __xchg(&p_chain->p_prod_elem,
> > > + (v
avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/kernel/setup-common.c | 1 +
arch/x86/include/asm/desc.h | 1 +
arch/x86/kernel/cpu/mshyperv.c | 1 +
arch/x86/kernel/setup.c | 1 +
drivers/char/ipmi
On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain wrote:
>
> On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
> > new file mode 100644
> > index ..41e32483d7a7
>
On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote:
>
> On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> > kernel.h is being used as a dump for all kinds of stuff for a long time.
> > Here is the attempt to start cleaning it up by splitting out panic an
On Wed, Apr 7, 2021 at 5:30 PM Luis Chamberlain wrote:
> On Wed, Apr 07, 2021 at 10:33:44AM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain wrote:
> > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
...
> > >
On Thu, Apr 08, 2021 at 02:45:12PM +0200, Rasmus Villemoes wrote:
> On 06/04/2021 15.31, Andy Shevchenko wrote:
> > kernel.h is being used as a dump for all kinds of stuff for a long time.
> > Here is the attempt to start cleaning it up by splitting out panic and
> > o
On Thu, Apr 08, 2021 at 11:23:03PM -0700, Andrew Morton wrote:
> On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko
> wrote:
>
> > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote:
> > >
> > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
&g
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
ssing doesn't seem to make as much sense.
In my student years I have an exercise to use 9-bit addressing mode on RS232.
Obviously I forgot all of the details, but I remember that that has a practical
application.
--
With Best Regards,
Andy Shevchenko
Let GPIO library to assign of_node from the parent device.
This allows to move GPIO library and drivers to use fwnode
APIs instead of being stuck with OF-only interfaces.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 14 +-
1 file changed, 5
On Sat, Mar 26, 2022 at 7:39 PM Benjamin Stürz wrote:
>
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
Does it follow the conventions which are accepted in the ACPI CA project?
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
> On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
> wrote:
>
> > Let GPIO library to assign of_node from the parent device.
> > This allows to move GPIO library and drivers to use fwnode
> > APIs instead
On Thu, Apr 21, 2022 at 08:42:30AM +1000, Michael Ellerman wrote:
> Linus Walleij writes:
> > On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko
> > wrote:
> >> On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
> >> > On Wed, Mar 23, 2022 at 6
It seems mpc52xx_get_xtal_freq() is not used anywhere. Remove dead code.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/include/asm/mpc52xx.h | 1 -
arch/powerpc/platforms/52xx/mpc52xx_common.c | 37
2 files changed, 38 deletions(-)
diff --git a/arch/powerpc
Switch mpc5xxx_get_bus_frequency() to use fwnode in order to help
cleaning up other parts of the kernel from OF specific code.
No functional change intended.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/include/asm/mpc5xxx.h| 9 +++-
arch/powerpc/platforms/52xx/mpc52xx_gpt.c
We may convert the GPT driver to use fwnode API for the sake
of consistency of the used APIs inside the driver.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 47 +++
1 file changed, 22 insertions(+), 25 deletions(-)
diff --git a/arch/powerpc
Let GPIO library assign of_node from the parent device.
This allows to move GPIO library and drivers to use fwnode
APIs instead of being stuck with OF-only interfaces.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 18 --
1 file changed, 8
On Thu, May 05, 2022 at 09:04:46PM +1000, Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Thu, Apr 21, 2022 at 08:42:30AM +1000, Michael Ellerman wrote:
...
> > Any new on this? I haven't seen it yet in Linux Next.
>
> It's in today's next
Switch mpc5xxx_get_bus_frequency() to use fwnode in order to help
cleaning up other parts of the kernel from OF specific code.
No functional change intended.
Signed-off-by: Andy Shevchenko
Acked-by: Chris Packham # for i2c-mpc
Acked-by: Wolfram Sang # for the I2C part
Acked-by: Mark Brown
Let GPIO library assign of_node from the parent device.
This allows to move GPIO library and drivers to use fwnode
APIs instead of being stuck with OF-only interfaces.
Signed-off-by: Andy Shevchenko
---
v2: no changes
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 18 --
1 file
It seems mpc52xx_get_xtal_freq() is not used anywhere. Remove dead code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Wolfram Sang
---
v2: collected tags
arch/powerpc/include/asm/mpc52xx.h | 1 -
arch/powerpc/platforms/52xx/mpc52xx_common.c | 37
2 files changed
We may convert the GPT driver to use fwnode API for the sake
of consistency of the used APIs inside the driver.
Signed-off-by: Andy Shevchenko
---
v2: no changes
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 47 +++
1 file changed, 22 insertions(+), 25 deletions(-)
diff --git
On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote:
> Andy Shevchenko writes:
> > We may convert the GPT driver to use fwnode API for the sake
> > of consistency of the used APIs inside the driver.
>
> I'm not sure about this one.
>
> It's
On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote:
> On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote:
> > Andy Shevchenko writes:
> > > We may convert the GPT driver to use fwnode API for the sake
> > > of consistency of the used APIs insi
On Tue, May 17, 2022 at 09:38:56AM +1000, Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote:
> >> On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote:
> >> > Andy Shevchenko writes:
&
9a948c4ba1 ("powerpc/pseries/scm: Use a specific endian format for
storing uuid from the device tree")
Cc: Oliver O'Halloran
Cc: Aneesh Kumar K.V
Signed-off-by: Andy Shevchenko
---
Not tested
arch/powerpc/platforms/pseries/papr_scm.c | 13 -
1 file changed, 8 i
sure what the coverage of your test is. That's why I have an
additional question below. Is the byte ordering kept the same in BE
(32- and 64-bit) cases? Because I'm worrying that I might have missed
something.
--
With Best Regards,
Andy Shevchenko
On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote:
> On 4/15/21 7:16 PM, Andy Shevchenko wrote:
> > Parse to and export from UUID own type, before dereferencing.
> > This also fixes wrong comment (Little Endian UUID is something else)
> > and should fix
of GCC 5, which
> is 5.5 at the time
> begin, just like the user would have selected 4.9.4 when 4.9 was the minimum
> GCC version.
And we may end up in the case when gcc 5.x will be more buggy than
v4.9.y (as once proved by nice detective story where compiler bug
produces a file system corruption).
--
With Best Regards,
Andy Shevchenko
other developers used to test that
> kernel.
I understand that you are talking about embedded, but it you stuck
with a distro (esp. LTS one, like CentOS 7.x), you have gcc 4.8.5
there for everything, but they have got security updates. Seems if you
are with a distro you have to stick with its kernel with all pros and
cons of such an approach.
--
With Best Regards,
Andy Shevchenko
ta_A004447)
> + mpc_i2c_fixup_A004447(i2c);
> + else
> + mpc_i2c_fixup(i2c);
>
> return 0;
> }
> @@ -767,6 +848,9 @@ static int fsl_i2c_probe(struct platform_device *op)
> }
> dev_info(i2c->dev, "timeout %u us\n", mpc_ops.timeout * 100 /
> HZ);
>
> + if (of_property_read_bool(op->dev.of_node,
> "fsl,i2c-erratum-a004447"))
> + i2c->has_errata_A004447 = true;
> +
> i2c->adap = mpc_ops;
> scnprintf(i2c->adap.name, sizeof(i2c->adap.name),
> "MPC adapter (%s)", of_node_full_name(op->dev.of_node));
> --
> 2.31.1
>
>
--
With Best Regards,
Andy Shevchenko
void __iomem *sr = i2c->base + MPC_I2C_SR;
u8 val;
return readb_poll_timeout(sr, val, val & mask, 0, 100);
--
With Best Regards,
Andy Shevchenko
On Fri, May 7, 2021 at 5:52 PM Joakim Tjernlund
wrote:
> On Fri, 2021-05-07 at 14:46 +0300, Andy Shevchenko wrote:
> > On Fri, May 7, 2021 at 3:40 AM Chris Packham
> > wrote:
...
> > So, now you may shrink it even further, i.e.
> >
> >void __i
eported-by: kernel test robot
Signed-off-by: Andy Shevchenko
---
arch/powerpc/kernel/prom_init.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 41ed7e33d897..6845cbbc0cd4 100644
--- a/ar
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
On Mon, May 10, 2021 at 05:49:25PM +0300, Andy Shevchenko wrote:
> If by some reason any of the headers will include ctype.h
> we will have a name collision. Avoid this by moving isspace()
> to the dedicate namespace.
>
> First appearance of the code is in the commit cf68787b6
urn -EINVAL;
> + }
> +
> + rmem->ops = &rmem_swiotlb_ops;
> + pr_info("Reserved memory: created restricted DMA pool at %pa, size
> %ld MiB\n",
> + &rmem->base, (unsigned long)rmem->size / SZ_1M);
Oh là là, besides explicit casting that I believe can be avoided, %ld
!= unsigned long. Can you check the printk-formats.rst document?
> + return 0;
> +}
> +
> +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup);
> #endif /* CONFIG_DMA_RESTRICTED_POOL */
--
With Best Regards,
Andy Shevchenko
ci.h is not only for the above.
When play with headers always do two test builds: allyesconfig and allmodconfig.
--
With Best Regards,
Andy Shevchenko
gt; pci_dev_put(pcidev);
> - return result;
> + return PCI_ERS_RESULT_NONE;
> }
> pdrv = to_pci_driver(pcidev->dev.driver);
What about splitting the conditional to two with clear error message
in each and use pci_err() in the second one?
...
> default:
> dev_err(&pdev->xdev->dev,
> - "bad request in aer recovery "
> - "operation!\n");
> + "bad request in AER recovery operation!\n");
Stray change? Or is it in a separate patch in your tree?
--
With Best Regards,
Andy Shevchenko
On Wed, Oct 13, 2021 at 06:33:56AM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 12:26:42PM +0300, Andy Shevchenko wrote:
> > On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas wrote:
> > > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-König wrote:
...
> > I
On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:
...
> so compared to Uwe's v6, I restored that section to the original code.
> My goal here was to make the patch as simple and easy to review as
> poss
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko
---
include/soc/fsl/dpaa2-fd.h| 3 ++-
include/soc
&& (*nl)->priority >= n->priority) {
' != NULL' is not needed.
> + if ((*nl)->priority == n->priority && (*nl) != n) {
> + ret = false;
> + break;
> + }
> +
> + nl = &((*nl)->next);
> + }
--
With Best Regards,
Andy Shevchenko
On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
Seems
On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe
wrote:
>
>
>
> Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :
> > On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:
> >> When kernel.h is used in the headers it adds a lot into dependency hell,
>
On Saturday, October 30, 2021, Christophe Leroy
wrote:
>
> Le 29/10/2021 à 22:31, Andy Shevchenko a écrit :
>
>> On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe
>> wrote:
>>
>>>
>>>
>>>
>>> Le 29/10/2021 à 17:55, Andy Shevche
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko
---
v2: updated Cc list based on previous changes to
MAINTAINERS lacks of proper coverage for FSL headers. Fix it accordingly.
Fixes: 1b48706f027c ("MAINTAINERS: add entry for Freescale SoC drivers")
Signed-off-by: Andy Shevchenko
---
v2: new patch
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAI
MAINTAINERS lacks of proper coverage for FSL headers. Fix it accordingly.
Fixes: 7aa1aa6ecec2 ("QE: Move QE from arch/powerpc to drivers/soc")
Signed-off-by: Andy Shevchenko
---
v2: new patch
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAI
On Sat, Oct 30, 2021 at 10:28:01AM +0300, Andy Shevchenko wrote:
> On Saturday, October 30, 2021, Christophe Leroy
> wrote:
> > Le 29/10/2021 à 22:31, Andy Shevchenko a écrit :
...
> > That means that Michael considered it is not for him.
> >
> > And I think the
On Wed, Nov 10, 2021 at 12:59:52PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
On Mon, Nov 15, 2021 at 10:24:36PM +, Leo Li wrote:
> > From: Andy Shevchenko
> > Sent: Monday, November 15, 2021 5:30 AM
> > On Wed, Nov 10, 2021 at 12:59:52PM +0200, Andy Shevchenko wrote:
...
> > > v2: updated Cc list based on previous changes to MAINTAINERS
&g
smart enough to not
include my name, for example.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
h/powerpc/kernel/setup-common.c | 3 ++
> arch/riscv/kernel/setup.c | 2 +
> arch/sh/kernel/setup.c | 3 ++
> arch/xtensa/kernel/setup.c | 2 +
Isn't x86 missed? Is it on purpose?
Would be nice to have this in the commit message or fixed accordingly.
--
With Best Regards,
Andy Shevchenko
On Tue, Nov 16, 2021 at 11:38:01AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 10:24:36PM +, Leo Li wrote:
> > > From: Andy Shevchenko
> > > Sent: Monday, November 15, 2021 5:30 AM
> > > On Wed, Nov 10, 2021 at 12:59:52PM +0200, Andy Shevchenko
goto out_free_desc;
Was or wasn't 0 considered as error code previously?
> return virq;
> out_free_desc:
> irq_free_descs(virq, nr_irqs);
> return ret;
--
With Best Regards,
Andy Shevchenko
n_ratelimit() macro which is already in the
kernel for a long time.
--
With Best Regards,
Andy Shevchenko
On Mon, Dec 21, 2020 at 7:44 AM Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult
> > wrote:
> >
> >> + if (printk_ratelimit())
> >> + pr_warn("sp
On Fri, Apr 16, 2021 at 03:05:31PM +0530, Aneesh Kumar K.V wrote:
> On 4/16/21 2:39 PM, Andy Shevchenko wrote:
> > On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote:
> > > On 4/15/21 7:16 PM, Andy Shevchenko wrote:
> > > > Parse to and export from UUID
("powerpc/pseries/scm: Use a specific endian format for
storing uuid from the device tree")
Cc: Oliver O'Halloran
Cc: Aneesh Kumar K.V
Signed-off-by: Andy Shevchenko
---
v2: added missed header (Vaibhav), updated comment (Aneesh),
rewrite part of the commit message to av
On Wed, Jun 16, 2021 at 07:17:03PM +0530, Aneesh Kumar K.V wrote:
> On 6/16/21 7:13 PM, Andy Shevchenko wrote:
> > Parse to and export from UUID own type, before dereferencing.
> > This also fixes wrong comment (Little Endian UUID is something else)
> > and should eliminate th
On Wed, Jun 16, 2021 at 04:43:03PM +0300, Andy Shevchenko wrote:
> Parse to and export from UUID own type, before dereferencing.
> This also fixes wrong comment (Little Endian UUID is something else)
> and should eliminate the direct strict types assignments.
Any comments on this versio
On Tue, Jun 22, 2021 at 03:44:56PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 16, 2021 at 04:43:03PM +0300, Andy Shevchenko wrote:
> > Parse to and export from UUID own type, before dereferencing.
> > This also fixes wrong comment (Little Endian UUID is something else)
> >
ge-model.rst
> already.)
I haven't found any traces of this to be applied. What is the status of this
patch series? And what is the general state of affairs for the PPC44x?
--
With Best Regards,
Andy Shevchenko
On Sat, Jul 24, 2021 at 12:08:30AM +0200, Christian Lamparter wrote:
> On 23/07/2021 21:19, Andy Shevchenko wrote:
> > On Sun, Sep 06, 2020 at 12:06:10AM +0200, Christian Lamparter wrote:
> > > I've been holding on to these devices dts' for a while now.
> > > B
open to restructure this series if this simplifies things. E.g. the
> use of the new wrapper in drivers/pci could be squashed into the patch
> introducing the wrapper. Patch 4 could be split by maintainer tree or
> squashed into patch 3 completely.
I see only patch 4 and this cover letter...
--
With Best Regards,
Andy Shevchenko
untime suspended, who will bring it up?
Does it mean that this callback can't be implemented on the consoles that
do runtime suspend (some of 8250 currently, for example)?
--
With Best Regards,
Andy Shevchenko
TAB instead of space after #define. Not sure if
it's good to have them different.
--
With Best Regards,
Andy Shevchenko
n't remember if it's a
checkpatch who complains on this.
> + return (pdev && (pdrv = pci_driver_of_dev(pdev))) ? pdrv->name :
> "";
--
With Best Regards,
Andy Shevchenko
port->mapsize);
You may increase readability by introducing temporary variables
... mapbase = port->mapbase;
... mapsize = port->mapsize;
...
port->membase = ioremap_nocache(mapbase, mapsize);
...
--
With Best Regards,
Andy Shevchenko
return 0x100;
> - return 0x1000;
> - }
> +
> if (is_omap1_8250(pt))
> return 0x16 << pt->port.regshift;
This is good. We definitely need to get rid of custom stuff in generic
8250_port, etc.
--
With Best Regards,
Andy Shevchenko
301 - 400 of 494 matches
Mail list logo
